Commit graph

4253 commits

Author SHA1 Message Date
Kunal Mehta 404e098c3b Fix MediaWiki.Usage.InArrayUsage.Found issues
Change-Id: I1898d95d92cda279c1b9c8a452fb7d054ff263bf
2018-07-29 15:19:09 -07:00
Translation updater bot 1c124ba77a Localisation updates from https://translatewiki.net.
Change-Id: I89dbd13e0fc5a68fb87d13548f33a1f86a9530a4
2018-07-29 22:20:56 +02:00
Translation updater bot f23810d44a Localisation updates from https://translatewiki.net.
Change-Id: Id8ca108c7d02d883c7dee11aaebac4c3be07b679
2018-07-28 22:29:13 +02:00
jenkins-bot 35a9f7d209 Merge "Fix jQuery selector when editing filters" 2018-07-28 14:01:54 +00:00
Matěj Suchánek 37908c7935 Fix jQuery selector when editing filters
Bug: T200604
Change-Id: Ife88ae0f4b9dca0492c1d9dbfc22a975dd7b6b31
2018-07-28 15:23:14 +02:00
Translation updater bot 2e433238b6 Localisation updates from https://translatewiki.net.
Change-Id: I7639c54d3138505ce9bd9f6643a2c981f6fa72c7
2018-07-27 22:17:21 +02:00
tinajohnson.1234 c9003fe1fa Use HistoryPageToolLinks hook to add a log link to history pages
Add an AbuseFilter log link to the subtitle of history pages.

Bug: T28934
Co-authored-by: Matěj Suchánek
Depends-On: I2e0e9e92d3fc303135b0eb9acf06b5fd120178a5
Depends-On: I58a3039b3755648bb0c8aaf87db48ace96ce9344
Change-Id: Ib89c48f2b8f3121ead184844844acee436e2fdd6
2018-07-27 11:25:12 +00:00
jenkins-bot eee65af0ac Merge "build: Updating mediawiki/mediawiki-codesniffer to 21.0.0" 2018-07-27 01:21:01 +00:00
jenkins-bot 55d825c325 Merge "Use empty arrays instead of empty strings for diffs" 2018-07-27 00:55:40 +00:00
libraryupgrader 76c6d2caeb build: Updating mediawiki/mediawiki-codesniffer to 21.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation
* MediaWiki.Usage.InArrayUsage.Found

Change-Id: I46e414246c6597dd78b069f753d686c0d1c1c09d
2018-07-27 00:27:11 +00:00
jenkins-bot 78bd634f58 Merge "Add link to abusefilter-edit-lastmod-text" 2018-07-26 22:56:07 +00:00
jenkins-bot 03ffcb0ff9 Merge "Fix block durations dropdown" 2018-07-25 20:24:30 +00:00
Translation updater bot c785e87f6d Localisation updates from https://translatewiki.net.
Change-Id: Iee2c94ed4667239ddf33e430deda640151995198
2018-07-25 22:17:47 +02:00
Translation updater bot a68b741060 Localisation updates from https://translatewiki.net.
Change-Id: I1d0e2e6fc7c21be3d6b80f1d8041d8fcf57c7d67
2018-07-24 22:09:37 +02:00
jenkins-bot d7a5872838 Merge "Add phpunit tests for creating and editing filters" 2018-07-24 16:04:04 +00:00
Daimona Eaytoy 7992349789 Fix block durations dropdown
A month ago SpecialBlock::getSuggestedDurations has been
modified, and now it also returns an "other" key. Since we don't need it
and it would break thing up, add a parameter to avoid dealing with that.

Depends-On: Ic2dbc961f7eebad11da53724b9cce2f804ffad39
Change-Id: Ica37ba7015a04445c2cbafebcc85726368e23cb0
2018-07-24 15:41:57 +00:00
Translation updater bot 35c4590a34 Localisation updates from https://translatewiki.net.
Change-Id: I2fae6e45e7626e55163f3ad648eb148c7b354da0
2018-07-23 22:30:53 +02:00
Translation updater bot 40eea41ca6 Localisation updates from https://translatewiki.net.
Change-Id: Iabc1ef6c5120fcb7cb26e2783596b5d3b6adad47
2018-07-22 22:08:23 +02:00
IoannisKydonis 2fa95e55e6 Add link to abusefilter-edit-lastmod-text
This adds a link to the diff of the edited filter.

Co-authored-by: Matěj Suchánek
Bug: T53382
Change-Id: I57104f592fc3961bb43ecea8442ef6666ed4a69c
2018-07-22 16:13:35 +02:00
jenkins-bot 84252213c0 Merge "Improve the check for block durations equality" 2018-07-22 14:02:22 +00:00
Translation updater bot 146a607e31 Localisation updates from https://translatewiki.net.
Change-Id: Ia7a5d7b816f5b278966a94a2c27ddaf7f97dee6c
2018-07-21 22:11:22 +02:00
Translation updater bot 0030cb2560 Localisation updates from https://translatewiki.net.
Change-Id: Iddfcc92b348f64760a0ef111524e24e1ab222cfb
2018-07-19 22:30:14 +02:00
Translation updater bot 7453a4c2a6 Localisation updates from https://translatewiki.net.
Change-Id: Ib224d87ae3ac68e3c1df7bfe8e9bd0dbcf3b541c
2018-07-18 22:12:23 +02:00
Daimona Eaytoy 9440828d13 Add phpunit tests for creating and editing filters
Adding the template for unit tests and some tests. These should cover
all the validation failure cases.

Bug: T42478
Depends-On: Ib7a0335fa7fb3b8a21765438a720205656c1ea09
Change-Id: I3fd0d627295d680ed33b1cbc730435df0446277f
2018-07-18 12:30:55 +02:00
Daimona Eaytoy 76260f9211 Clarify i18n message for throttle message
The message was quite cryptic, since I basically copied it from MW docs,
where it was equally cryptic. Looking at the code, this is the actual
meaning, easier to understand and translate.

Change-Id: I73a7aecc987361ba6bb94c87ab9e3e10057111c7
2018-07-18 10:55:40 +02:00
jenkins-bot 0979e116b4 Merge "Show AF logs for a revdeled revision if the user can see the revision" 2018-07-18 02:04:16 +00:00
jenkins-bot 7b04a89668 Merge "Add tests for filter consequences" 2018-07-18 01:14:06 +00:00
jenkins-bot 9623421366 Merge "Switch editing interface to OOUI & improve NoJS usability" 2018-07-18 00:59:12 +00:00
Translation updater bot da982b0ab8 Localisation updates from https://translatewiki.net.
Change-Id: I2e11a6863233c697bcc54ce9e08760d43ad6d25c
2018-07-17 22:13:37 +02:00
Daimona Eaytoy cea1b0aec3 Compact some other comments
Remove unnecessary ones, make clear what the cryptic ones mean, and
inline them when possible.

Change-Id: I384859871a66ced8cb0d81260c06c5a5b278866f
2018-07-17 17:17:44 +02:00
Daimona Eaytoy b825e396b5 Switch editing interface to OOUI & improve NoJS usability
This settles almost everything, leaving the tags part ready to be
further improved in the follow-ups.
Also, replaced some fields with totally different ones, improved the
warn preview area and improved a bit nojs experience by hiding unusable
buttons.

Bug: T132284
Bug: T154749
Change-Id: I7a5caa862a32f9792140c6a4d9708a2d20472672
2018-07-17 14:49:50 +02:00
jenkins-bot 3e28ac176e Merge "Use isset instead of empty+strlen when checking disallow parameters" 2018-07-17 02:20:32 +00:00
jenkins-bot fed9ca759d Merge "Remove and replace an argument in AbuseFilter::addLogEntries" 2018-07-16 22:40:00 +00:00
jenkins-bot 394d0d308e Merge "Remove obsolete comment from abusefilter.tables.pg.sql" 2018-07-16 22:03:58 +00:00
jenkins-bot dc39c3b052 Merge "Simplify AbuseFilter::addLogEntries" 2018-07-16 21:59:47 +00:00
jenkins-bot 1edc6ce2e7 Merge "Fix extension doc for AbuseFilterPrivateLog" 2018-07-16 21:57:27 +00:00
Translation updater bot 187d3ca2eb Localisation updates from https://translatewiki.net.
Change-Id: If9cd108efcd5fee176f37e2fd6db5e5a298e6a5b
2018-07-16 22:19:39 +02:00
Daimona Eaytoy dd0569c00b Fix extension doc for AbuseFilterPrivateLog
This variable is actually here to determine whether accessing private
info should be logged, not if it's possible to access such info. In
fact, you can still do it if this variable is set to false.

Change-Id: Ieba191bff4ea56eb166bbbd03cb7b1a05ca42c52
2018-07-16 15:32:38 +02:00
Matěj Suchánek 78c755fb8d Remove obsolete comment from abusefilter.tables.pg.sql
Bug: T199506
Change-Id: I0fc1ef4a04133dd823ffb41d7f17e47debbde5ac
2018-07-16 11:26:37 +02:00
Matěj Suchánek 3e1a963614 Simplify AbuseFilter::addLogEntries
Change-Id: I54bcef8c69892d184ae2362282ed7477df2b4faa
2018-07-16 11:02:03 +02:00
Matěj Suchánek df346b3995 Remove and replace an argument in AbuseFilter::addLogEntries
Change-Id: Ib4613577d1b5ac5a5cc796716c95b99196259438
2018-07-16 10:59:05 +02:00
Translation updater bot 08b3debbd4 Localisation updates from https://translatewiki.net.
Change-Id: If6f7745250a05819c281f8e5328f4732c1a2efe3
2018-07-15 22:10:44 +02:00
Daimona Eaytoy 5c6007e041 Add tests for filter consequences
The last one of what I think are the must-have tests. This patch
provides the basic tests and the framework, which may be further
expanded later on. Please note that the failures are due to an actual
problem in core, for which there is I7bb0e92b2906a2511fc4290bdc76fc39ec4617fe.

Bug: T42478
Change-Id: I28eb464c63fda7faa3ec7d1f6082f36154d66962
2018-07-15 15:43:18 +00:00
jenkins-bot 29c7f0f818 Merge "Update LogPage to ManualLogEntry" 2018-07-15 15:08:47 +00:00
jenkins-bot 32218a1391 Merge "Add the user action to warn key" 2018-07-15 15:08:42 +00:00
jenkins-bot 5281a158a9 Merge "Add phpunit tests for all exception thrown in the parser" 2018-07-15 15:08:41 +00:00
jenkins-bot c4ef80638e Merge "Add the log ID as API param for query abuselog" 2018-07-15 15:08:39 +00:00
Daimona Eaytoy adc06f409d Use isset instead of empty+strlen when checking disallow parameters
This line first used to be just an "strlen". Then we merged
Iaeae672dca66ffc745054daabd6f0eae7dfbc648 to clean input and this caused
some "undefined index" notices. These were in turn fixed in Ibebedb566da705e77ffb831ebda6476adba07c93 by adding an "empty". However, this slightly changed the range of accepted parameters, for instance refusing 0 and '0'. Those should never be used, so this is just a theoretical problem, but we'd better be consistent and simplify this line.

Change-Id: I4643d0632acf5926ac8de5da9bcb3e5dc715fdc1
2018-07-15 17:01:32 +02:00
Translation updater bot 20dc4301f8 Localisation updates from https://translatewiki.net.
Change-Id: I26e90ad47cb9e691406db27092f65c0153fe2841
2018-07-14 22:20:14 +02:00
Daimona Eaytoy 6a97133310 Add the user action to warn key
Otherwise, if the user is warned for e.g. trying to move a page, and
after the warning he tries to delete it, he won't be warned again. Since
filtered action (edit, move, delete...) can be really different, we
should repeat the warning if the action changed.

Bug: T199621
Change-Id: Ia481b2bf552e16de8485c246aa5612d5bb2cd6ca
2018-07-14 16:15:52 +02:00