mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-11-25 14:56:20 +00:00
49ffef5a0f
Closing a dialog with specific data means closing it again with potentially different data, while the dialog is already closing, means someone wins and someone looses. Silently failing in this case is bad, because if the first close call was a cancel, producing no side effects, but the second close call would have produced some side effect, the side effect would never occur. The problem here really was that the save dialog needs to be closed before we can destroy the surface so we can uphold the assumption that hold and teardown processes are operating on an attached DOM. The solution is to automatically close the save dialog on teardown, rather than on save. Since save triggers teardown, this has and identical user experience. Bug: 68048 Change-Id: I669448739f168737d4eddd6496189a819ce894b1 |
||
---|---|---|
.. | ||
ve-mw | ||
ve-wmf/i18n |