mediawiki-extensions-Visual.../modules/ve-mw
Trevor Parscal 49ffef5a0f Close the save dialog on teardown only, not on save
Closing a dialog with specific data means closing it again with
potentially different data, while the dialog is already closing, means
someone wins and someone looses. Silently failing in this case is bad,
because if the first close call was a cancel, producing no side effects,
but the second close call would have produced some side effect, the side
effect would never occur.

The problem here really was that the save dialog needs to be closed
before we can destroy the surface so we can uphold the assumption that
hold and teardown processes are operating on an attached DOM.

The solution is to automatically close the save dialog on teardown,
rather than on save. Since save triggers teardown, this has and identical
user experience.

Bug: 68048
Change-Id: I669448739f168737d4eddd6496189a819ce894b1
2014-07-16 23:51:58 +00:00
..
ce Merge "ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview" 2014-07-15 22:09:10 +00:00
dm Update VE core submodule to master (ad18102) 2014-07-16 22:38:09 +00:00
i18n Merge "Make a message dialog for cancelling VE" 2014-07-16 20:45:28 +00:00
init Close the save dialog on teardown only, not on save 2014-07-16 23:51:58 +00:00
tests [BrowserTest] update switch-edit-mode test for new UI 2014-07-16 15:38:52 -07:00
ui Listen to widget changes in MediaDialog 2014-07-16 22:46:47 +00:00