James D. Forrester
ece430258b
Update VE core submodule to master (dc98cb7ec)
...
New changes:
617708fe1 Update rel attribute checks to be aware of multiple rel values
c22428f81 ve.ce.LinearSelection: Don't throw exceptions only to catch on the next line
406db2ce3 Localisation updates from https://translatewiki.net .
33f94faf7 tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior
d85bf0d68 Use documentFragments when DOM splicing
110519f1c Update documentation now describeChange can return jQuery
ff7fa5fa0 Change http://www.mediawiki.org to https://www.mediawiki.org
09faa4a3d Fix error with tabs per this:
a329edf67 Localisation updates from https://translatewiki.net .
da864cc5e demos: Separate out and fix mobile-dist
380cc90c5 VisualDiffs: Unit test for timeout behaviour
601173c02 Clarify the "Log" button label on the debug bar
c52a2e07e demos: Fix auto-save by only storing doc state if not recovered
1b8d2c457 Auto-save: Save and restore last known selection
9e279e77e Fix deprecated icon name 'alignCentre' > 'alignCenter'
Local changes:
tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior
Bug: T189687
Bug: T189939
Depends-On: I2059d8ce9140b733ee92436de395d735ab06b9df
Change-Id: I3c210112c84e2d2bd8226de3dad195bf17afb4c2
2018-03-20 16:38:54 -07:00
jenkins-bot
cf9ddabe23
Merge "Disable visual diffs on source mode section edits"
2018-03-20 23:02:33 +00:00
Ed Sanders
8bfb270168
Use single-line editor for image captions
...
Depends-On: I2be081c766fab41b152d03b43e7e936e3f636166
Change-Id: Ifcdc34826ad81e96c22fd68ceb637107cde24d4a
2018-03-20 22:51:27 +00:00
jenkins-bot
2c96d24c76
Merge "Avoid jQuery.parseHTML"
2018-03-20 21:44:37 +00:00
jenkins-bot
0ed47a025e
Merge "Only use pre-computed measurements for position loading bar"
2018-03-20 21:44:36 +00:00
Volker E
d44bb0bc1b
Remove special font-size
treatment following-up UI unified in 14px
base
...
Removing `0.8em` VE special base `font-size` for UI as we're unifying
OOUI interfaces to `14px` equals to `0.875em` at user agent default size.
Bug: T97631
Depends-on: I693d168d2ccf2babbcfe8952af3e1c262aa97773
Change-Id: I84edeec38ecfb90f5d53199f3b26fc3f83ab0611
2018-03-20 20:03:19 +00:00
Bartosz Dziewoński
d80099dad1
Update icons for new 20px grid
...
Set viewBox to "2 2 20 20" to trim 2px off each side of our
existing 24px icons, therefore aligning them to the new 20px
grid. All of them had been drawn with large margins, so none
of the graphic is lost.
Bug: T177432
Bug: T190151
Change-Id: I23a6daa5dc2d4a9afc50f275da5df370d2319277
2018-03-20 20:03:11 +00:00
jenkins-bot
9d004c4d35
Merge "Use OOUI 'markup' icon instead of local 'alienextension'"
2018-03-20 19:50:55 +00:00
Ed Sanders
0f56af016d
Use ellipsis on toolbar save/publish button
...
Bug: T189803
Depends-On: Ic29717a660de5e80ee2a37f583b2a61c11fa87c4
Change-Id: Idaf80ea7e6ae9ffa165a8638af886bf6ab21a7f0
2018-03-20 19:46:36 +00:00
jenkins-bot
cea546b502
Merge "MediaContext: Link filename to file page"
2018-03-20 18:41:09 +00:00
jenkins-bot
bb34d650c0
Merge "Improve media context item to show Image/Video/Audio instead of 'Media'"
2018-03-20 18:38:53 +00:00
Ed Sanders
10792e179f
MediaContext: Link filename to file page
...
Change-Id: Ice3fdd40cd1f7b8ba2841ac326babc7f24a2635e
2018-03-20 17:45:50 +00:00
Ed Sanders
c245dd9ca0
Improve media context item to show Image/Video/Audio instead of 'Media'
...
Change-Id: Ie3b7ec62483e725d3ce073095a2a958c1db930d5
2018-03-20 17:45:48 +00:00
Ed Sanders
78ba8bbe3c
Use OOUI 'markup' icon instead of local 'alienextension'
...
Change-Id: Id15596ab0013cb2078480bdb4dde25ef8e7ae50b
2018-03-20 17:27:54 +00:00
jenkins-bot
c20a610750
Merge "Factor out isSaveable method from updateToolbarSaveButtonState"
2018-03-20 17:26:39 +00:00
jenkins-bot
ff21c17c37
Merge "Remove unnecessary attachToolbarSaveButton override"
2018-03-20 17:25:11 +00:00
Bartosz Dziewoński
c99b4a0ad5
ve.ui.Icons: Add missing global "invert" variant
...
Bug: T190166
Change-Id: I28cc22d49881a25973b31e5e112130fb21cf4a37
2018-03-20 16:36:18 +01:00
David Lynch
a228991181
MWTransclusionNode: describe parameter changes for Visual Diffs
...
Currently limited to single-template transclusions.
Bug: T188389
Depends-On: Id03d6a9866b56c00e11a030ed60b3c6fb7ead3d1
Change-Id: I332b5f5aa789fdc00510e9f03ea96e4058a28961
2018-03-20 10:35:03 -05:00
jenkins-bot
39a8c9e14b
Merge "Restrict width of diff feedback button mobile"
2018-03-20 02:09:11 +00:00
jenkins-bot
e23dd5fb6d
Merge "Make gallery dialog work with native gallery implementation"
2018-03-19 23:39:00 +00:00
jenkins-bot
5b82bb180d
Merge "Fix title preview when not overridden"
2018-03-19 23:24:21 +00:00
Thalia
12cc56400b
Make gallery dialog work with native gallery implementation
...
Updates the model and re-renders the gallery.
Bug: T150621
Bug: T149602
Bug: T149596
Change-Id: I1e93c3af02eeeff1fcdaa5549cccc61ea755ee04
2018-03-19 23:55:17 +01:00
Ed Sanders
5e1c024d33
Parse title in show preview using hack
...
Really Parsoid should do this for us.
Bug: T189540
Change-Id: Ie3b5d458e7e6611565e5852f351d715a48be521a
2018-03-19 21:58:33 +00:00
Ed Sanders
81f3c2df38
Fix title preview when not overridden
...
Change-Id: I555b057d8f20704c0676646afd03c78ad3353f23
2018-03-19 21:56:54 +00:00
jenkins-bot
48028e84b9
Merge "Allow ve.ui.MWCategoryInputWidget to use different API"
2018-03-19 21:29:58 +00:00
jenkins-bot
98c9a395ac
Merge "Show page title in preview"
2018-03-19 17:09:53 +00:00
petarpetkovic
fe8b510232
Allow ve.ui.MWCategoryInputWidget to use different API
...
* Provide config option to specify which API
ve.ui.MWCategoryInputWidget will use.
* To be used in Iec79e687eff8c63434054282650c97cc882f348d
Change-Id: Ib8869d4facf8b3210b309200d944fad4508d7eee
2018-03-19 16:50:27 +01:00
Ed Sanders
b80075a5e4
Avoid jQuery.parseHTML
...
Change-Id: Iaf5cbe27b8883d6e4c468a3b4dae11438d264894
2018-03-16 15:43:03 +00:00
Ed Sanders
a1dffa2dd7
Only use pre-computed measurements for position loading bar
...
Change-Id: I5fc17a432de8030a6154c4e961ac10c73f391a79
2018-03-16 15:39:21 +00:00
Bartosz Dziewoński
13d77ba557
Remember 'checkboxesMessages' when storing document state
...
Bug: T188796
Change-Id: I4785fe2fb7df774735c1bd48c222540a0286dd44
2018-03-16 01:14:29 +01:00
jenkins-bot
1d227935d9
Merge "Autosave: only try to remove autosave on teardown if the surface exists"
2018-03-14 19:17:30 +00:00
jenkins-bot
79f27a5447
Merge "Clear VE autosave whenever WikiEditor is loaded"
2018-03-14 18:25:48 +00:00
jenkins-bot
3c861d7ed1
Merge "Clear auto-save when switching to fallback wikitext editor"
2018-03-14 17:55:44 +00:00
David Lynch
9762b096c8
Autosave: only try to remove autosave on teardown if the surface exists
...
It's possible for some load failure states to cause this teardown at a point
without a surface. I observed it in MobileFrontend, when restbase can't be
contacted.
Change-Id: I13489640759c73dad5730d0bbadbfb2a38cb8e53
2018-03-14 11:53:10 -05:00
Ed Sanders
d0eafd6b8d
Restrict width of diff feedback button mobile
...
Change-Id: Ia4ceb73efb76d7714102619fce9cd87cf34216f9
2018-03-14 14:32:37 +00:00
jenkins-bot
e4a8c0b61b
Merge "Attach deactivate code to namespace tab ('Main'/'Article')"
2018-03-14 09:19:16 +00:00
Ed Sanders
c6653b6a2d
Show page title in preview
...
Bug: T189540
Change-Id: Idc203f7fcafcf944108938168b492e90091e3255
2018-03-13 10:15:16 +00:00
jenkins-bot
540cb864ca
Merge "ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image"
2018-03-12 12:28:10 +00:00
Ed Sanders
e0419f8388
Autosave section title when adding new section in source mode
...
Change-Id: Idcbe2f12e3eb0bb85e2c986885bd8084b16dbe5b
2018-03-12 12:25:12 +00:00
Ed Sanders
4fc2b32b17
Disable visual diffs on source mode section edits
...
Bug: T183938
Change-Id: I0d03c47e9b4c30760b7d3bd7bf90d91e79eb8569
2018-03-10 22:54:54 +00:00
Ed Sanders
e78379a395
Attach deactivate code to namespace tab ('Main'/'Article')
...
Bug: T189380
Change-Id: I9f05722b9a1c740f9f982d9c5690d48046f19fdd
2018-03-10 19:07:11 +00:00
Ed Sanders
c3c3c60f1f
Clear VE autosave whenever WikiEditor is loaded
...
Bug: T189381
Change-Id: I21a76dc32327d6c6e72a793d9b579cb7b6a5e32e
2018-03-10 18:34:17 +00:00
Ed Sanders
ec6d9b235a
Clear auto-save when switching to fallback wikitext editor
...
Bug: T189381
Change-Id: Id89fa2a673ad8aef3826c0ef862770bf522bbdcf
2018-03-10 18:04:44 +00:00
jenkins-bot
2ae3f5f1c2
Merge "ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption"
2018-03-10 17:28:34 +00:00
Bartosz Dziewoński
3c676013f8
ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image
...
Currently this only handles the caption, but there will be more.
Change-Id: Ia8a25de89375d0ba873f4891b053c7aceab15534
2018-03-10 17:16:16 +00:00
Bartosz Dziewoński
26e7728272
ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption
...
Overriding ve.ce.BranchNode#onSplice seems pretty scary, some bug
could cause two captions to be inserted and it wouldn't even be
visible in the editor.
Instead, allow normal splice handling to happen when the caption is
added/removed, and only override the position where it is inserted
(to account for the image node this.$a).
The caption node is already removed from DM/CE if the image type is
changed to one that doesn't have captions, and even if that failed it
is also hidden in CSS, so we don't need to handle this.
Change-Id: I54f52b288118d692708311512dd674cc85d5d9e3
2018-03-10 17:16:16 +00:00
Ed Sanders
9678cdc7c8
Factor out isSaveable method from updateToolbarSaveButtonState
...
Change-Id: Ic1922ed26bae26a76e8149d48f3fb27fa9ba4330
2018-03-10 16:20:30 +00:00
Ed Sanders
8b208c80d5
Remove unnecessary attachToolbarSaveButton override
...
It's identical to the code inherited form ArticleTarget.
Change-Id: I7fe7a48b0614f2ac2665ece042bb95a6f77303ad
2018-03-10 16:20:30 +00:00
jenkins-bot
00eb598352
Merge "Update rel attribute checks to be aware of multiple rel values"
2018-03-09 21:44:53 +00:00
jenkins-bot
04e5f6f208
Merge "LinkCache: styleParsoidElements find mw:WikiLink with ~="
2018-03-09 21:44:52 +00:00
David Lynch
b6c6d10d1e
ce.MWTransclusionNode: increase invisible selector specificity
...
5f6664e2 in VE core changed the specificity for some of the rules this
expected to override.
Bug: T189267
Change-Id: I510e151cc431c321d1d45fde9030d56f059d84ab
2018-03-08 19:27:52 -06:00
David Lynch
4e10d5b975
Update rel attribute checks to be aware of multiple rel values
...
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.
Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
2018-03-08 14:34:56 -06:00
jenkins-bot
8e79d85583
Merge "Blacklist Web of Trust junk from being added to pages"
2018-03-08 00:33:48 +00:00
David Lynch
f8c5608caf
LinkCache: styleParsoidElements find mw:WikiLink with ~=
...
`noopener` being added to the rel caused issues.
Bug: T189175
Change-Id: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
2018-03-08 00:14:16 +00:00
Bartosz Dziewoński
b05ac142c6
Blacklist Web of Trust junk from being added to pages
...
Bug: T189148
Change-Id: Icc4b2d0ddf5104e26a3f563816f6f971d71e2531
2018-03-07 22:12:43 +01:00
Ed Sanders
045f3b7640
Follow-up I5357a909: Fix logic for autosave from edited state
...
Bug: T189071
Change-Id: I5439a73ffcf26795f58625720b1f1667ee3965cc
2018-03-07 18:43:28 +00:00
Jforrester
16437646fe
Merge "Update VE core submodule to master (ca771b8bc)"
2018-03-06 13:14:21 +00:00
James D. Forrester
d144599cea
Update VE core submodule to master (ca771b8bc)
...
New changes:
7551f6c66 [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore
Local changes:
Follow-through rename of IndexValueStore->HashValueStore
Bug: T188900
Change-Id: If60d0c637fe92f0e7afe916c064fafb17980d063
2018-03-06 12:55:30 +00:00
jenkins-bot
eb125877e2
Merge "Revert "For empty / whitespace-only headings, output <p> instead of <h#>""
2018-03-06 12:22:31 +00:00
Ed Sanders
a274bdb8f7
Revert "For empty / whitespace-only headings, output <p> instead of <h#>"
...
Parsoid now handles empty headings for us in
scrub_wikitext mode (which we use).
This reverts commit 884f301aa0
.
Bug: T187913
Change-Id: I8690bbced64be76622929f78f9c9e0d8f85d4be8
2018-03-05 23:27:52 +00:00
David Lynch
09237b71ef
mwExample: add test case for cross-document numberedlink paste
...
Bug: T188429
Change-Id: I722f30f07abd65dba93e9ba297b6933ef8ca79c2
2018-03-05 13:35:25 -06:00
David Lynch
795b428477
MWNumberedExternalLinkNode: set an explicit type
...
This lets copy-paste between documents retain the numbered status rather than
falling back on pasting "<a>[3]</a>".
Update the part of LinkCache which selects on mw:ExtLink, so it will handle
possible multiple values in the link rel.
Bug: T188429
Change-Id: Ia5e4c9fa45e94da9cbfcd2a42d017d0fda1c511f
2018-03-05 11:59:41 -06:00
Ed Sanders
4c759e2587
autosave: Handle switched document with no transactions
...
Always store immediately if fromEditedState is true. Also
now that we only store if there is state to recover, remove
the check for transactions before deciding to show the notification.
Change-Id: I5357a9098b91e303f5c71881ea03a080d2969fff
2018-03-04 23:40:24 +00:00
Ed Sanders
007bb6fa09
Refactor diffpage init
...
Avoid re-rendering the diff if it hasn't changed.
Change-Id: Icbc8eb58625cf7c5485d0045e26993a170016309
2018-03-04 14:45:33 +00:00
Ed Sanders
43ea4c2b51
Fix infinite recursion in positionDiffElement
...
updateSize eventually calls setDimensions, which calls
positionDiffElement, so protect against infinite recursion.
Change-Id: I07992f337394712000e6e12c637c6e1442869722
2018-03-03 18:47:08 +00:00
Ed Sanders
d5a61eb95d
Make edit notices popup wider (320 -> 450)
...
Bug: T184379
Change-Id: Id2df8f8d162db3389206666fa07ea4cc0be8cdec
2018-03-02 13:29:54 +00:00
jenkins-bot
ad6ded970f
Merge "ve.ce.MWBlockImageNode: Fix handling of borders"
2018-03-02 13:15:50 +00:00
Ed Sanders
c8d0f62095
fetchSpecialCharList: Set directionality
...
Specifically, set arabic(extended) and hebrew to 'rtl'.
Logically depends on I14abd3e0c0d23f79aa01d96c216eea913024b4c8
to set the dir attribute in UI.
Bug: T56310
Change-Id: I1c7e28d3d2f20ca84115be6d49650cd9a81d78dd
2018-03-01 23:22:45 +00:00
jenkins-bot
e7d7d5bab1
Merge "autosave: Don't store initial document state until first change"
2018-03-01 18:47:39 +00:00
jenkins-bot
fbbda2a480
Merge "ve.ce.MWBlockImageNode: Remove unnecessary #setupSlugs override"
2018-03-01 18:39:48 +00:00
Ed Sanders
11ac2736a1
autosave: Don't store initial document state until first change
...
1. It wastes valuable time during setup.
2. If a user reloads the page without making changes we
should give them the latest html from the server to
minimise the chance of an edit conflict.
Change-Id: I9a1f8cfd65ef2552fe2c3d6d2bbf975851b52003
2018-03-01 18:25:10 +00:00
Bartosz Dziewoński
d239b6ee6a
ve.ce.MWBlockImageNode: Fix handling of borders
...
After change 89aecd54ba
(2014),
there is no 'border' value for the 'type' attribute, instead
there is a 'borderImage' attribute only present when 'type'
is 'none' or 'frameless'.
Change-Id: Id87ba09b647f5f69b1c9350209e66acdea2c9d69
2018-03-01 01:08:30 +01:00
Bartosz Dziewoński
5b7c93f0d5
ve.ce.MWBlockImageNode: Remove unnecessary #setupSlugs override
...
MWBlockImageNode already can't have any slugs:
* It can't have inline slugs, because it can't directly contain
content (`this.canHaveChildrenNotContent()` is true)
* It can't have block slugs, because it can't contain paragraphs
(`this.isAllowedChildNodeType( 'paragraph' )` is false).
(The only thing it can contain is a mwImageCaption.)
Change-Id: Ice6505da2356f004ef048ed0b1a9e03d08af02d1
2018-03-01 01:08:30 +01:00
jenkins-bot
6155cd4434
Merge "Remove autoGenerated hack"
2018-02-28 18:41:29 +00:00
jenkins-bot
9840316ee9
Merge "Centralize Parsoid resource name parsing logic"
2018-02-28 15:09:20 +00:00
Ed Sanders
90b6a1b5cf
Clarify autosave comment
...
Change-Id: I0bdaf989886be8537ea45237ceea88a5cca11fc1
2018-02-28 14:36:58 +00:00
Ed Sanders
19d9e9eb98
Tag TODO comments with bug number
...
Change-Id: I965e8d4bed4fdfa24738ca5cce0ae3f51e7f2b40
2018-02-28 14:36:42 +00:00
Bartosz Dziewoński
98a1bb09c0
Centralize Parsoid resource name parsing logic
...
Let's keep the ugly regexp and the comments about why we do this in a
single place.
This is mostly without behavior changes, with three exceptions:
* ve.dm.MWImageModel#attachScalable now passes a title with spaces
instead of underscores to the Scalable (this doesn't matter because
it's normalized to use spaces later anyway).
* ve.dm.MWImageNode#getFilename now returns a title with spaces
instead of underscores. This is used in some API queries and when
rendering thumbnails for missing files, and this format is actually
more correct for both of these.
* ve.dm.MWTemplateModel now URI-decodes the template title. This
actually fixes a bug where trying to edit a template transclusion
whose title contains a '?' would throw an exception about invalid
title.
Also, clarify that the return value of ve.dm.MWImageModel#getFilename
and ve.dm.MWImageNode#getFilename is different :(
Change-Id: I8e09015cea82308017ed925ec755b7231518126e
2018-02-28 03:01:05 +01:00
jenkins-bot
8727ecd181
Merge "Do not use deprecated jquery.byteLength"
2018-02-27 22:10:23 +00:00
jenkins-bot
b5ceb1b956
Merge "ve.ui.MWSaveDialog: Allow limiting comment length by characters rather than bytes"
2018-02-27 22:06:01 +00:00
Bartosz Dziewoński
974ea82c50
Do not use deprecated jquery.byteLength
...
Change-Id: If3f921d60563bd614c269d1d26b745161f8cfc7b
2018-02-27 22:35:29 +01:00
Bartosz Dziewo??ski
dbfe6c0b5a
ve.ui.MWSaveDialog: Allow limiting comment length by characters rather than bytes
...
Bug: T185948
Change-Id: I882d69beb1cd442868c8d73988f5b3a2bbb084bc
2018-02-27 22:35:08 +01:00
jenkins-bot
12323a022e
Merge "autosave: Use upstream methods in ve.dm.Surface"
2018-02-27 21:03:52 +00:00
jenkins-bot
b3adaa5fc1
Merge "Show notification when document is recovered (or fails)"
2018-02-27 21:03:51 +00:00
Ed Sanders
c670ce76ee
autosave: Use upstream methods in ve.dm.Surface
...
Change-Id: I150b21d7767153d8457b5da658bb8b51b5464aa9
Depends-On: I859b57aef9d591597956f3d942dd2cf1b0aecee0
2018-02-27 20:54:59 +00:00
Ed Sanders
a46b30a161
Show notification when document is recovered (or fails)
...
Change-Id: Id2f6651ba7743c05043bbbe64cd9cb7bd762d74b
2018-02-27 20:54:18 +00:00
jenkins-bot
c44390e6f8
Merge "Use session storage to auto-save"
2018-02-27 20:20:31 +00:00
jenkins-bot
92470ae024
Merge "Always set sourceMode=true on dm.MWWikitextSurface"
2018-02-27 16:49:09 +00:00
Ed Sanders
76caef6b4b
Use session storage to auto-save
...
Ensure we start with the same HTML (i.e. if an edit has
been made since the crash-recovery):
* Whenever an article target is activated, stash the initial
document html, other parsoid response data, and the request
parameters (pageName, mode, section) in session storage.
* Whenever an article is fetched through the target loader,
recover from session storage if the request parameters match.
Store transactions:
* On document transaction (debounced) append the latest
changes to session storage.
* If a document state is recovered from session storage,
attempt to re-apply the stored transactions.
Clear transactions:
* Whenever the target is torn down (i.e. save, deliberately
closing the editor to go back to read mode)
Other:
* If writing to session storage fails once, disable future
attempts for that session (assume storage quota exceeded)
* Disable tempWikitextEditor when recovering. We don't have
the transaction code loaded yet to perform the recovery.
Bug: T57370
Depends-On: I3832243fc347a99641fcb7e39a887a153c9a3b22
Depends-On: I448fb566fe9f7f5b5a76e88b70ca000e3d35b415
Change-Id: Id9d877f903cf4796a52f90991c030417a9f8786f
2018-02-27 12:19:06 +00:00
Ed Sanders
366219e953
Always set sourceMode=true on dm.MWWikitextSurface
...
Change-Id: Id46d5ef9c8a585784b8fbd55418d012fff96823f
2018-02-27 12:19:06 +00:00
Ed Sanders
31f7015260
Whitelist style tags from Parsoid, e.g. TemplateStyles
...
Bug: T188143
Change-Id: I7a30d8a8c40de8b786d59c8bf0ebcb77f2baeb2a
2018-02-26 16:52:01 +00:00
jenkins-bot
72756d5a26
Merge "MWImageNode: getHashObject -> getHashObjectForRendering"
2018-02-24 13:42:15 +00:00
Ed Sanders
d17121d1f3
MWImageNode: getHashObject -> getHashObjectForRendering
...
The latter was introduced for this very purpose: defining
which attributes affect the rendering (in this case the
thumbnail URL). getHashObject should be reserved for making
full semantic comparisons.
Bonus: Don't distinguish between block/inline images
for URL caching purposes.
Change-Id: I6e6d2547a0d110f07c4d18b8179c168d8c251059
2018-02-24 12:44:53 +00:00
David Lynch
abe3d0a4a5
DiffPage.init: Enforce a valid diff mode
...
Bug: T173400
Change-Id: I48b97e10fc6c6e2ca84563b58dd0bb8f42fa251f
2018-02-22 11:48:37 -06:00
jenkins-bot
3d93d195c7
Merge "Drop IE10 support"
2018-02-22 00:55:50 +00:00
Ed Sanders
05a504887d
Drop IE10 support
...
Change-Id: Ib1cb8fb32c499ba0bdc87ec55e1e2e95d2eb39ec
Depends-On: I68c882e64fba95d5e1bf41f64658fcef7524dcf5
2018-02-22 00:47:38 +00:00
Jforrester
2e87e03a29
Merge "ve.ce.MWGalleryNode: Ensure we always have a focusable element"
2018-02-22 00:33:23 +00:00
jenkins-bot
c5cc11079b
Merge "ve.ui.MWGalleryDialog: Handle galleries with 0 items"
2018-02-22 00:31:30 +00:00
Bartosz Dziewoński
180eb91f3f
Increase selector specificity for .ve-ce-focusableNode-invisibleIcon
...
Otherwise our width/height rules are overridden by OOUI styles.
Change-Id: I2bbf81231615e6fcfd95573f5f590b5101e66bdf
2018-02-21 22:30:45 +01:00
Bartosz Dziewoński
a5e2f60d7e
ve.ce.MWGalleryNode: Ensure we always have a focusable element
...
For galleries with 0 items, this would previously return an empty
jQuery collection, which caused funny rendering issues later.
Bug: T75230
Change-Id: Ia68e4f1b74b5ec494fa3d86f0b792f69eadb02fb
2018-02-21 22:22:49 +01:00
Bartosz Dziewoński
3d422bac2a
ve.ui.MWGalleryDialog: Handle galleries with 0 items
...
We still don't allow inserting such galleries, but we can handle them
in existing content.
Bug: T75230
Change-Id: I5d7350f00871ac295b0ebc00a633b44570347d85
2018-02-21 22:11:41 +01:00
jenkins-bot
dd94837192
Merge "MWTemplateTitleInputWidget: recover gracefully if TemplateData not present"
2018-02-21 18:14:12 +00:00
David Lynch
bd64b58071
MWTemplateTitleInputWidget: recover gracefully if TemplateData not present
...
Bug: T187917
Change-Id: Ica0c853e1a7bc908651260df115d59d1939a7939
2018-02-21 11:53:56 -06:00
jenkins-bot
5de7185687
Merge "Rebaser: Generate random doc name if none provided"
2018-02-21 16:37:36 +00:00
jenkins-bot
8d3e702976
Merge "Disable tempWikitextEditor for section=new on talk pages"
2018-02-21 01:29:58 +00:00
Derk-Jan Hartman
249c52b6a4
Hide historical diff controls when UA doesn't support JS
...
Bug: T187780
Change-Id: If29974323ef21016edbbb66870914a6dc37e7bbb
2018-02-20 16:54:31 +00:00
jenkins-bot
8f33fc6225
Merge "Add clearfix to diff page's visual diff element"
2018-02-20 16:52:39 +00:00
jenkins-bot
d040645244
Merge "Avoid jQuery.parseHTML"
2018-02-20 16:50:06 +00:00
Ed Sanders
7fe496d8ef
Avoid hiding generated #toc
...
Bug: T187636
Change-Id: I713479616feddb01c48c9bb6dda2f9c4aaf182e0
2018-02-20 16:18:27 +00:00
Ed Sanders
fcf6ea9e67
Add clearfix to diff page's visual diff element
...
Bug: T187687
Change-Id: I4de925964fde7b0fffc6540ba821f9a8162cffe7
2018-02-20 15:04:25 +00:00
Ed Sanders
ee5b80aeee
Avoid jQuery.parseHTML
...
Bug: T187713
Change-Id: Ic156d6fb670fa2f79cf3c1d5fe0c6272b53b6440
2018-02-19 15:41:20 +00:00
Ed Sanders
f2e7361460
Disable tempWikitextEditor for section=new on talk pages
...
The temp editor doesn't know about the title input
widget yet, so disable for now.
Bug: T185633
Change-Id: I3e44dcc30ee8372080c7cd8c5fc27eb167e24fc6
2018-02-16 18:32:41 +00:00
Ed Sanders
1bef5a03ce
Rebaser: Generate random doc name if none provided
...
Change-Id: Ib790fa5d61df7f2318cd014d5ffa60a3ab3861d3
2018-02-16 18:09:19 +00:00
Ed Sanders
33858c6818
MWSaveDialog: Another check to see if visual diff is still visible
...
Bug: T187282
Change-Id: Ia29a335bf6b1bad0eeb55b54094475c7fcc18dfe
2018-02-16 15:21:12 +00:00
James D. Forrester
dd3dddb98c
Follow-up 0a7a845a4
: Missed one
...
Change-Id: I252cb6678df9df503e07b635384a713f052a8abe
2018-02-14 14:25:07 -08:00
jenkins-bot
0c05b46bff
Merge "Remove IE9 workaround"
2018-02-13 17:37:29 +00:00
Ed Sanders
e0b7fbe6f8
NWE preview: Avoid skin style clash
...
Bug: T187075
Change-Id: I6ac6eebca3bd89ce19fb64f6e95809c4d595bc8b
2018-02-13 16:22:56 +00:00
Ed Sanders
119e9ef0f6
Remove IE9 workaround
...
Change-Id: Ifcb1690934ece7d373c764591e00740d6f1238ee
2018-02-13 10:45:16 +00:00
James D. Forrester
b6c18b2d49
Don't try to insertMetas at 0,0, just at 0 now (lest we crash)
...
Bug: T187112
Change-Id: I56e39276637ea018c1ec742d833d115ee881a5d5
2018-02-12 19:32:23 +00:00
Fomafix
8079d081d0
Remove /* global confirm, alert */
...
The browser functions alert() and confirm() are not used.
Change-Id: I1b069937fe1548298d55a3e6616e189b72c3e8fa
2018-02-12 10:49:11 +01:00
jenkins-bot
3d0d5667bc
Merge "ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection'"
2018-02-08 23:58:24 +00:00
jenkins-bot
b2400138a5
Merge "ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable"
2018-02-08 19:44:36 +00:00
Bartosz Dziewoński
5ce321bc60
ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection'
...
Bug: T185917
Depends-On: I39bbbce20336a1286a07bf8032acdfb8a7e0cdb6
Depends-On: I05086ddce2ddd857ff88eba75cfdb6bf877bd924
Change-Id: I1e7ed33275d0a97f4b0b3c9756bbef2f3f3ad73c
2018-02-08 19:50:17 +01:00
Bartosz Dziewoński
5f36aac24c
ve.ui.MWWikitextSurface: Make 'textSelection' API chainable methods really chainable
...
Change-Id: I1292021a4a8dee70cfa203a040f176996e4a13ff
2018-02-08 19:48:33 +01:00
Ed Sanders
b14480f49b
Assume wpTextbox1 has an API registered already
...
Bug: T186743
Change-Id: I19b085dfbf6229854c3d70807ffe83685ca811fe
2018-02-07 20:12:51 +00:00
Ed Sanders
cefa0ebf7b
Add trailing linebreak to NWE's temporary wikitext editor
...
Bug: T185632
Change-Id: I8225b08484e535668e8b0bd33eb3b8b09b80ff35
2018-02-02 11:10:18 +00:00
jenkins-bot
7dd6aea2d6
Merge "NWE: Use internal paste in compatible browsers"
2018-01-30 17:41:05 +00:00
jenkins-bot
e613c8edc4
Merge "Load modules for preview"
2018-01-30 17:40:45 +00:00
jenkins-bot
8e1ec692d8
Merge "textSelection: Implement getCaretPosition"
2018-01-30 16:48:00 +00:00
jenkins-bot
5e2e0013ae
Merge "Implement simple methods from $.textSelection API"
2018-01-30 16:47:19 +00:00
Ed Sanders
9e16e1cbd4
textSelection: Implement getCaretPosition
...
Bug: T185992
Depends-On: Id60f4b8aa177564f5252508ce6cff2424eb03fc8
Change-Id: I1a1a953dfbb299a15ba9d4d3e624e6779e72d11c
2018-01-30 10:54:02 +00:00
Ed Sanders
aeb4f2f2b7
Implement simple methods from $.textSelection API
...
This should make it easier for some gadgets to work
with NWE.
Bug: T185992
Change-Id: Ic60440f345b8226fb5acaeb966e25eb003ad7866
2018-01-30 10:53:49 +00:00
Volker E
e64ede5b49
Remove unnecessary and low-contrast opacity
...
Change-Id: I4853a77679687d23059c118914df42a1d3c2785c
2018-01-29 23:51:08 -08:00
Ed Sanders
9770c80615
Load modules for preview
...
Bug: T147702
Change-Id: I94f6bdf122d4e2c9fba3103f36c438980ce8228d
2018-01-29 22:35:00 +00:00
James D. Forrester
4ce103abb9
Update VE core submodule to master (c5fddd508)
...
New changes:
21a5d55b8 [BREAKING CHANGE] Store metadata as block nodes in the main data list
2f9868aae Localisation updates from https://translatewiki.net .
7a224cf4b Remove <style> tags from pasteTarget ASAP
fb4e894b6 Workaround missing child selector in OOUI for menuLayout
fa4f35281 rebaser: Fix sequencing of server operations
931ee29f6 SurfaceSynchronizer: Also translate selections that are not mentioned in the change
d232b8f04 Disable undo/usurp within SurfaceSynchronizer
d1b7fc597 ve.dm.Change: Truncate stores as well as transactions on conflict
7606f684d rebaser: Only apply artificial delay to submitChange events
9473e8b42 Toolbars: Replace $.width with clientWidth/offsetWidth
abb8f2075 ve.ui.DesktopContext: Remove unused CSS
050414205 ve.ui.DesktopContext: Remove old unnecessary CSS
7b8cbb830 Failing test case for losing annotations
5447d33e4 CommentNode: Protect against call after teardown
bf98ca2b6 Rebaser: Use better hack for disabling history commands
90c07f46c Rebaser: uninitialize fully
2a59016e4 Move updatingName recursion guard out of debounce
Bug: T56299
Bug: T185532
Bug: T185544
Bug: T185599
Bug: T185716
Bug: T185747
Change-Id: I45251811e3fbb3323a25ca5cf364e4cb94aa1d01
2018-01-29 08:43:08 -08:00
jenkins-bot
d7d026425c
Merge "Make visual diffs the default in visual mode"
2018-01-27 00:21:24 +00:00
Ed Sanders
35311ad66d
NWE: Use internal paste in compatible browsers
...
Bug: T185730
Change-Id: I9410707e6e491fe1cbe0b367fccb94a29a1b3145
2018-01-25 17:40:26 -08:00
Ed Sanders
624f181592
MW-Rebaser: Disable history commands
...
Change-Id: I46bb5e92548fe35c3490cd3df36b2a8f1cca520a
2018-01-25 10:21:33 -08:00
jenkins-bot
97fbd5619c
Merge "Public API for the tempWikitextEditor"
2018-01-24 00:53:11 +00:00
jenkins-bot
a77eea97b3
Merge "Sync tempWikitextEditor just before building target, not on every change"
2018-01-24 00:50:41 +00:00
jenkins-bot
14e557e936
Merge "Use jQuery 3 .catch( fn ) instead of .then( null, fn )"
2018-01-24 00:06:11 +00:00
Ed Sanders
8afe6c5c6d
Public API for the tempWikitextEditor
...
Allows users to know when the widget has been constructed,
and access it (e.g. to set an initial selection)
Bug: T185279
Change-Id: I3678996bcf644cc889dd168ac3ce48b5c3633ec1
2018-01-23 15:30:51 -08:00
Bartosz Dziewoński
a0e2afef8e
Use jQuery 3 .catch( fn ) instead of .then( null, fn )
...
Change-Id: I676eec0acf25690c2b2dd0b9a414be5fee887395
2018-01-23 15:25:15 -08:00
Ed Sanders
d294006d7b
Sync tempWikitextEditor just before building target, not on every change
...
Also ensure tempWikitextEditor is always torn down, even if
target setup fails.
Change-Id: Idc30a9dc00491b8c85353d73cb9ff70afea1d51c
2018-01-23 15:13:10 -08:00
jenkins-bot
f52ee56a02
Merge "Toolbars: Replace $.height with clientHeight/offsetHeight"
2018-01-23 23:01:37 +00:00
Ed Sanders
154f49e964
Toolbars: Replace $.height with clientHeight/offsetHeight
...
Bug: T185599
Change-Id: I43fbce8f221553e9ae03f8385f39a19de01e8eb7
2018-01-23 12:32:16 -08:00
jenkins-bot
53cd2346dc
Merge "MWWikitextStringTransferHandler: Perform Parsoid cleanup on result"
2018-01-22 23:43:18 +00:00
David Lynch
d97b734352
MWWikitextStringTransferHandler: Perform Parsoid cleanup on result
...
Parsoid markup delivered as a result of a paste was being handled differently.
Bug: T183173
Change-Id: Ic563d2c5cd1f663f35860892b369fb7ba34b9c55
2018-01-22 14:43:19 -08:00
Ed Sanders
3077bbe51c
Remove Firefox support comment
...
This line isn't solely for supporting FF52, that is the order
in which it is called (move after attach, not before),
but that matches all our other widgets, so not sure
it needs commenting.
Change-Id: I6f3cc5687f1e4b995dff700d0765d14de1927d51
2018-01-22 11:27:46 -08:00
jenkins-bot
97b04fbea5
Merge "NWE: Don't attempt to set selection on unattached textarea"
2018-01-22 19:22:11 +00:00
Ed Sanders
f2568c8d7d
NWE: Don't attempt to set selection on unattached textarea
...
Prevents an exception being thrown in Firefox <= 52.
Bug: T185304
Change-Id: Ic9a43e3cf12d4cc566cebb328f8e807e464af634
2018-01-22 18:58:26 +00:00
David Chan
c7b76329ad
Use ve.dm.MetaList without explicitly requiring metadata index
...
For future compatibility with Ib5174b0dcba1c24f44d889e08140bee31a064011 .
Change-Id: I15f252ce5d36bc0c38c5f5035e5176bf5e6d96e5
2018-01-21 18:33:28 -08:00
David Lynch
a52dc16244
Update TitleInput's getTitle to getMWTitle
...
cb92c72c63274b332dc81edf473b1b3979ab4bdf in MW core changed this.
Bug: T185231
Change-Id: I9084a11bd40e46bddbcd1922ff549703bc90f60f
2018-01-18 11:39:23 -06:00
jenkins-bot
d5bf4d41de
Merge "Remember preferred diff viewer"
2018-01-18 15:37:35 +00:00
jenkins-bot
31e7006610
Merge "getSelectedItem() -> findSelectedItem()"
2018-01-17 17:29:36 +00:00
Ed Sanders
a1e2cb237c
Resize link context item after getting description
...
Descriptions can run to more than two lines.
Bug: T183650
Change-Id: I3d0a5787cab19abc4851340b08fe4a109e7aec31
2018-01-17 16:06:28 +00:00
Ed Sanders
0169701257
getSelectedItem() -> findSelectedItem()
...
Change-Id: Idf90335d06800b690063c7b2a781e822f0ee7ba9
2018-01-17 13:39:13 +00:00
Ed Sanders
e70fe7c1a1
Make visual diffs the default in visual mode
...
Bug: T178248
Change-Id: I9fe22862d4415df034a0054f934c9ebd1d731a5d
2018-01-17 13:31:07 +00:00
Ed Sanders
7661081ab9
Remember preferred diff viewer
...
Separate the preference by surface mode, so you can
use a different preference for NWE.
Bug: T178691
Change-Id: Ib8494a4562ce766a7c8ef7ec1447d06f5d0f17c5
2018-01-17 13:31:07 +00:00
jenkins-bot
140ec5f2ab
Merge "NWE: Show temporary wikitext input widget while loading"
2018-01-16 18:13:47 +00:00
Ed Sanders
b1ea5d618a
Don't pass wikitext to requestPageData if unmodified
...
Bug: T184875
Change-Id: I41a72a9c7546fafc834bf837e507d9359872ff11
2018-01-14 16:16:47 +00:00
Arlo Breault
25e3662c00
Remove autoGenerated hack
...
Reverts some of 471e40e
Depends-On: I2b5c7ff552b3322be74f79a81936c41d58fecabc
Change-Id: Ibfcd4ced6c58c1cd0d362af3bdb43ce4e6879941
2018-01-12 11:52:42 -05:00
jenkins-bot
2091b8634a
Merge "Use section fragment after-save even if the query is empty"
2018-01-10 21:41:59 +00:00
jenkins-bot
2ea64bdd27
Merge "Change save dialog accesskey to be entirely off the trigger"
2018-01-10 21:30:51 +00:00
Ed Sanders
886faf2adc
NWE: Show temporary wikitext input widget while loading
...
Bug: T184614
Change-Id: I2e4964cb6329660957815dcb9a74d2ad24d5256b
2018-01-10 21:34:53 +01:00
jenkins-bot
9768750cd3
Merge "Use findItemFromData instead getItemFromData"
2018-01-10 19:54:30 +00:00
David Lynch
64944c119a
Use mw.storage instead of localStorage
...
mw.storage catches errors, so we won't crash horribly when the user has
localStorage disabled / full.
Bug: T181822
Change-Id: I212994eb535b9a8fb5f6c09deaa10b16c3d7f10e
2018-01-10 11:44:24 -06:00
David Lynch
a89c79dc79
Change save dialog accesskey to be entirely off the trigger
...
Accesskeys in this situation are unreliable cross-browser. Firefox won't
trigger the accesskey inside the dialog. We can manually simulate it, via the
existing trigger.
Bug: T121183
Change-Id: Ib919d8b9fcd9324a517037bcc6ef93a26d1488b9
2018-01-08 11:52:06 -06:00
Ed Sanders
c41fd90a15
MWImageModel: Check selectedNode exists before asking for property
...
Bug: T180521
Change-Id: I1c10929abd6f5c4afa03a65904bc76fc82f8fcbb
2018-01-08 15:31:13 +00:00
David Lynch
874ba30ce8
Use section fragment after-save even if the query is empty
...
Bug: T181075
Change-Id: If2d1107982d3f947330c750c635ee221ab71610f
2018-01-05 11:55:38 -06:00
Bartosz Dziewoński
23158de319
Fix context menu for mobile TargetWidgets
...
Depends on Ica66325a8267d14f25fbc537b956573d1d3cc336 in VE core.
Bug: T157084
Change-Id: I9d9839d7e96eb1ef254e11554acfb955750a2915
2018-01-04 16:53:40 +00:00
jenkins-bot
683ac88fcc
Merge "doc: Bump copyright year"
2018-01-03 19:20:07 +00:00
James D. Forrester
0a7a845a42
doc: Bump copyright year
...
Change-Id: I0b299c840ede1a1b8552cecfc70c5760ab036181
2018-01-03 17:45:07 +00:00
jenkins-bot
fad1466d84
Merge "Fix editfont size in source mode"
2018-01-03 01:12:25 +00:00
jenkins-bot
75d4300ba6
Merge "ve.ui.MWSettingsPage: Fix doc comment"
2018-01-02 20:11:33 +00:00
Ed Sanders
459ce75cb2
Fix editfont size in source mode
...
Bug: T182320
Change-Id: I777a1a80cb9887bc473aecb5d7b25fd6454a3d60
2018-01-02 19:20:18 +00:00
Bartosz Dziewoński
4987c07793
Move things that are not modules out of modules/ directory
...
* Move SpecialCollabPad.php to /.
* Move screenshots for BetaFeatures to images/.
* Move localisation messages to i18n/.
Change-Id: I874ae135a3ac58118c3dea105136c8c8b6fb41bc
2018-01-02 11:05:23 +01:00
Bartosz Dziewoński
5f7e60e938
Remove unused files loading-ltr.gif, loading-rtl.gif
...
No longer in use since 6d8fbd8221
.
Change-Id: If0392c49985fdd5b07c336e17eb5360e0a71770a
2018-01-02 10:47:32 +01:00
Paladox
fc03706278
Make isListed public in SpecialCollabPad.php
...
This was causing Special:SpecialPage to fatal with:
PHP Fatal Error: Access level to SpecialCollabPad::isListed() must be public
(as in class SpecialPage) or weaker
Bug: T183883
Change-Id: Ic7cbdddd3106776898ec7faa4fbaed508a6b1c08
2018-01-02 01:00:23 +00:00
Translation updater bot
93b4371954
Localisation updates from https://translatewiki.net .
...
Change-Id: I304a6848db09772c9603b19a1dbc386f80f0d109
2018-01-01 09:21:05 +01:00
Umherirrender
df29d96c3e
build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
...
Change-Id: I515dc1003bd5ee2352c85ac49e19f54e7036bd5d
2017-12-30 23:29:40 +01:00
Bartosz Dziewoński
578c55b7c1
ve.ui.MWSettingsPage: Fix doc comment
...
Change-Id: Iff4e8854124340a30081009221cde5b2831c81f3
2017-12-30 03:26:13 +00:00
Translation updater bot
327f3c1219
Localisation updates from https://translatewiki.net .
...
Change-Id: I809d676bdb78d17f0a6866ca05f021c3e9c64bdf
2017-12-29 10:07:04 +01:00
Translation updater bot
f7c0a70b9e
Localisation updates from https://translatewiki.net .
...
Change-Id: I39cb150918eaee64b034e88a4726a31c04f29331
2017-12-28 10:00:15 +01:00
Prateek Saxena
ecd663c4a0
Use findItemFromData instead getItemFromData
...
Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630
Change-Id: I379da96a42c440c7d2d5dc2f3de2773c03546c04
2017-12-28 11:53:29 +05:30
Translation updater bot
6e46084b89
Localisation updates from https://translatewiki.net .
...
Change-Id: Ife309d8d0cce6332fee9ff23796a92c3d8c6f53b
2017-12-27 10:32:31 +01:00
Translation updater bot
035ccf0d7e
Localisation updates from https://translatewiki.net .
...
Change-Id: Ic3ef5d2e35085be6121a442740ab8c6fd188721d
2017-12-23 22:27:16 +01:00
Translation updater bot
906956aae7
Localisation updates from https://translatewiki.net .
...
Change-Id: I81e6aa591bec1ac4ca53a4ab0b4f0e3a31af20fb
2017-12-20 23:23:06 +01:00
Translation updater bot
90cdac7b46
Localisation updates from https://translatewiki.net .
...
Change-Id: I7c7ae2a3327ad676a4db0461d871dd2d276ac86d
2017-12-18 23:07:22 +01:00
jenkins-bot
5457615129
Merge "Add section id to URI fragment on save"
2017-12-18 10:55:35 +00:00
Translation updater bot
99ae04623a
Localisation updates from https://translatewiki.net .
...
Change-Id: I327e05ba73228d31ad373408c93c9b40a6bfe0b0
2017-12-17 22:26:19 +01:00
David Lynch
6f2c829bd9
Add section id to URI fragment on save
...
Bug: T181075
Change-Id: Iea63112301bfa0860c3d68efc35648a5af7e4ae6
2017-12-15 00:03:52 +00:00
jenkins-bot
e99ef1da02
Merge "ArticleTargetEvents: Track editor mode on save events"
2017-12-14 22:51:04 +00:00
David Lynch
5bbda2b8c8
ArticleTargetEvents: Track editor mode on save events
...
Bug: T182610
Change-Id: I8b58bea8e4444478cde4c1340d13ddf97aab8f01
2017-12-14 16:23:08 -06:00
Translation updater bot
dbbbdbd86d
Localisation updates from https://translatewiki.net .
...
Change-Id: Icc0b85cd1433255d8c9be2f098e0bbe861f52444
2017-12-14 23:12:35 +01:00
James D. Forrester
af8428e861
trackSubscriber: Add timing data for 'loaded' state
...
Change-Id: I771764e5f40adcfc67d181cda68f60fc283a9cb2
2017-12-13 11:20:09 -08:00
David Lynch
e66d58076f
trackSubscriber: data isn't required
...
Editor-fixing caused errors on some events which don't pass data in.
Introduced in 8f612fbe64
.
Change-Id: I5c9471e6ffe4cdda0bf5455c80ef70251690e20f
2017-12-13 11:56:35 -06:00
C. Scott Ananian
fde0c180aa
Interwiki links are a type of external link
...
Bug: T97093
Change-Id: I13325075deba127dc620adb0ad1d18ef99352ab2
2017-12-13 15:56:58 +00:00
C. Scott Ananian
d2d6d23522
Bump Parsoid HTML version to 1.6.0
...
It's a brave new world.
https://www.mediawiki.org/w/index.php?title=Parsoid/Deployments&oldid=2644817#Tuesday,_Dec._12,_2017_around_11:45_am_PT:_Y_Deployed_741fc5d
Change-Id: Ib22dc5370cd01bf5becdd639cc12d6a5ccc653a3
2017-12-13 00:10:16 +00:00
Translation updater bot
aaabd8d84b
Localisation updates from https://translatewiki.net .
...
Change-Id: I2606d7b77cec575907fe57d540326bf1069f14a1
2017-12-12 22:53:01 +01:00
C. Scott Ananian
b85caca493
Strip legacy section IDs from inside headings
...
We emit <span id="..." typeof="mw:FallbackId"></span> inside headings
when necessary to provide backward compatibility with pre-HTML5
section ids. These are mostly harmless inside VE --- they become hidden
alienated nodes, which are then safely ignored by Parsoid during html2wt
even if they manage to migrate outside of a heading --- but it's a
little safer to strip them.
Change-Id: I07d0fcf54427ab02d4930cff183d3e5579a99306
2017-12-12 12:15:05 -05:00
jenkins-bot
a5a3b0c97a
Merge "Enable spellchecking on media caption inputs"
2017-12-12 17:04:38 +00:00
Ed Sanders
8a356b19d7
Enable spellchecking on media caption inputs
...
Bug: T182393
Change-Id: I23d3f1b37225f9e5a9a9651b6e7b590d38dc99b3
2017-12-12 16:42:55 +00:00
Translation updater bot
28bc31f58a
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia5bfd03dc41406dc3ea9344c93f73d6a3309dd99
2017-12-11 23:39:09 +01:00
jenkins-bot
84e3cfaa0f
Merge "Pass editor mode (visual/source) to tracking code"
2017-12-11 17:51:15 +00:00
jenkins-bot
db142d34f8
Merge "Track action=loaded for consistency with WikiEditor"
2017-12-11 17:49:17 +00:00
Translation updater bot
db453a74fb
Localisation updates from https://translatewiki.net .
...
Change-Id: I428b0455d4f87c5bd451aac088ccbf68592e5069
2017-12-10 22:33:31 +01:00
Translation updater bot
c6476a33fd
Localisation updates from https://translatewiki.net .
...
Change-Id: Iac2cdc9cd52b46e12b166676bce5f5384a53e1ef
2017-12-08 22:37:37 +01:00
Translation updater bot
18f8cd0b1d
Localisation updates from https://translatewiki.net .
...
Change-Id: I1e4452deddf816b6a2a1007d40a64dcb668fb9a0
2017-12-07 23:08:05 +01:00
Ed Sanders
8f612fbe64
Pass editor mode (visual/source) to tracking code
...
Change-Id: Iba5d3c66ecbd2872d76ea12f795ef3bebaae9d81
2017-12-07 11:14:00 +00:00
David Lynch
7a260ad1b7
Track action=loaded for consistency with WikiEditor
...
Change-Id: I1b92996e63dd85416755377dc14a5a997aac6657
2017-12-06 11:32:01 -06:00
jenkins-bot
59a57b17a9
Merge "Use rel="noopener" on links targeted at new windows"
2017-12-06 11:18:42 +00:00
jenkins-bot
890d47868c
Merge "MWTable: Cleanup events and prevent fire after teardown"
2017-12-05 15:34:05 +00:00
Translation updater bot
3d931296df
Localisation updates from https://translatewiki.net .
...
Change-Id: I456d50609430beaa80ac687259f0807a419b3e91
2017-12-05 09:42:06 +01:00
Ed Sanders
28ed1a6b97
MWTable: Cleanup events and prevent fire after teardown
...
Bug: T181767
Change-Id: I9b86d810269f3e3e15ba4736d264dbf48c9a0fe3
2017-12-03 14:46:47 +00:00
Translation updater bot
61365625b7
Localisation updates from https://translatewiki.net .
...
Change-Id: I343fc3f0ae5fb7852bc75d8278f5d39823eec5d4
2017-12-02 22:53:00 +01:00
Translation updater bot
7883f423ac
Localisation updates from https://translatewiki.net .
...
Change-Id: I2037bd6b5a9cae019e13dbf3ceddd62086c5cbce
2017-12-01 00:01:48 +01:00
David Lynch
7777f69e7b
Use rel="noopener" on links targeted at new windows
...
Bug: T180932
Change-Id: I93bda6aaebf97727a187774cccbeba4f27fcddd5
2017-11-30 13:15:38 -06:00
jenkins-bot
5dce34ee1c
Merge "ui.MWSaveDialog: consistent handling of preview category links"
2017-11-30 15:45:35 +00:00
Translation updater bot
212200f4be
Localisation updates from https://translatewiki.net .
...
Change-Id: If104f2835eee1566891974f24f9d213969a38d32
2017-11-29 22:56:41 +01:00
David Lynch
efbfcd8b35
ui.MWSaveDialog: consistent handling of preview category links
...
Category links weren't being checked for redlink status, and weren't opening
in a new window.
Bug: T179913
Change-Id: Ic665583128bf51710178c5674cd35c273f5f207e
2017-11-29 11:24:32 -06:00
jenkins-bot
7dd9cec01e
Merge "DesktopArticleTarget: enable spellcheck on sectionTitle"
2017-11-29 00:38:47 +00:00
David Lynch
396ce6eb6b
DesktopArticleTarget: enable spellcheck on sectionTitle
...
Tell browsers we explicitly want spellchecking on the section title. If
unspecified this is browser-dependent, so it was inconsistent.
This won't actually have an effect until the next OOjs-UI release (v0.24.3),
as this was a new feature added to TextInputWidget.
Bug: T179654
Depends-On: Ifdd44ead7d782288aaef0979322f0943f7304835
Change-Id: I588874efcff91c5be03da2fc03c268f883b718e2
2017-11-29 00:06:20 +00:00
Translation updater bot
085ec49a66
Localisation updates from https://translatewiki.net .
...
Change-Id: I42b3a5b87ece5c12f42489d98a3ee25aa5c5a332
2017-11-28 22:50:36 +01:00
Ed Sanders
77773df985
Create MW tables with captions by default
...
Bug: T181173
Change-Id: Ib17331e0e8478ba67c1ecbbee4a284d9993cb552
Depends-On: Ieb668d282f7afa9332cead94c95f19f652102af1
2017-11-27 16:37:24 +00:00
jenkins-bot
65a27b48ce
Merge "Fix template rendering"
2017-11-27 15:36:02 +00:00
Ed Sanders
471e40e8bb
Fix template rendering
...
* Look inside first child for autoGenerated (as reflists can be wrapped)
* Unwrap Parsoid sections
* Discard leading and trailing whitespace
Bug: T179618
Change-Id: Ib9ead28173360f0f1d5a4dc66c33a75d70ef34b3
2017-11-27 15:02:31 +00:00
Translation updater bot
7da82260e7
Localisation updates from https://translatewiki.net .
...
Change-Id: I6e77cc8b6a0e7b7378a70632d59705594a21703e
2017-11-26 22:54:54 +01:00
Translation updater bot
8e1a60e93b
Localisation updates from https://translatewiki.net .
...
Change-Id: I73e2bf2377229edac438917df4ddc638fd01e2d2
2017-11-25 22:58:16 +01:00
Translation updater bot
3c388da5e9
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie032d167e7d9f30fff049ff3a98af2ca86ba67b0
2017-11-24 23:27:50 +01:00
Translation updater bot
643466f4c2
Localisation updates from https://translatewiki.net .
...
Change-Id: Iea540f004fe2491cf5e7e7f2f85590fe96b4ffe4
2017-11-23 23:51:47 +01:00
jenkins-bot
861c48db77
Merge "Unwrap Parsoid sections"
2017-11-23 20:02:43 +00:00
Ed Sanders
267d60f61a
Unwrap Parsoid sections
...
Section wrapping will be introduced in I0f4c19f7.
Change-Id: I43ced131d07a20318af37e830318e30db2eb451f
2017-11-23 12:19:57 +00:00
Translation updater bot
b33d86d1df
Localisation updates from https://translatewiki.net .
...
Change-Id: I44df9fd1eb29e1a4bf4b160491554e49d28e4774
2017-11-22 22:47:15 +01:00
Prateek Saxena
b7541717ff
Update colors of betafeatures icon
...
Grays: Base80, Base70, Base50
Old: https://phabricator.wikimedia.org/F10934877
Old: https://phabricator.wikimedia.org/F10934879
New: https://phabricator.wikimedia.org/F10934876
New: https://phabricator.wikimedia.org/F10934878
Bug: T180427
Change-Id: I1d40411993918e2b060094d7e1e099647d42a6af
2017-11-22 17:21:12 +05:30
Ed Sanders
38dba57e95
Follow-up I80d82ad87: Only add linebreak to non-empty documents
...
This is the same behaviour as the old editor, and
unbreaks editors that use placeholders.
Change-Id: I7b5a18f1fb0d41c5dc08d1b893c90db2bf3dbd86
2017-11-21 17:14:08 +00:00
jenkins-bot
26e78ea946
Merge "Move source mode newline hack down to ArticleTarget"
2017-11-20 22:32:20 +00:00
Translation updater bot
16ae17dd2e
Localisation updates from https://translatewiki.net .
...
Change-Id: Idcfa0a5032f801b5ce589ac960badedf294efaf7
2017-11-20 22:47:55 +01:00
Translation updater bot
f295eb7384
Localisation updates from https://translatewiki.net .
...
Change-Id: I5784a828b8aa69c84222b48a4b36f9c594f9ede2
2017-11-19 22:41:33 +01:00
Translation updater bot
c482d9ebaa
Localisation updates from https://translatewiki.net .
...
Change-Id: Id8ad8acef84dedbc9395ff5643bdef0b518d4756
2017-11-18 23:03:55 +01:00
Translation updater bot
a4bdca88c7
Localisation updates from https://translatewiki.net .
...
Change-Id: I8a5785bfd53a429dbe01e3869429fb1578edc4b6
2017-11-17 23:03:28 +01:00
Roan Kattouw
f37caa6a6f
Move source mode newline hack down to ArticleTarget
...
We need this hack when visually editing articles, but not in e.g. the
Flow integration. Move it down so that mw.Target has a clean
parseDocument method that can be used by Flow without undesirable
newlines being introduced.
Change-Id: I52bba88b3d33c3d6d16c4cf832f23f970a243abf
2017-11-17 13:15:27 -08:00
Translation updater bot
b7c747a5e9
Localisation updates from https://translatewiki.net .
...
Change-Id: I141cdcd5db751610fdd3c78e40e8e82ea0905c2a
2017-11-15 22:43:25 +01:00
Translation updater bot
42de11dd9c
Localisation updates from https://translatewiki.net .
...
Change-Id: I137712b96f6223945d6f2fb14a865c2779601095
2017-11-14 22:43:04 +01:00
Translation updater bot
6cdf04d839
Localisation updates from https://translatewiki.net .
...
Change-Id: I28709c87c0b19b28913468e67250b278c917af23
2017-11-13 22:54:26 +01:00
jenkins-bot
3998651aa2
Merge "Add mw-parser-output to preview elements"
2017-11-13 12:55:24 +00:00
Translation updater bot
9b73200150
Localisation updates from https://translatewiki.net .
...
Change-Id: I9071a96e4c6bc863a75a1c6b4fa5fc1b24e3b4ba
2017-11-12 22:50:24 +01:00
Translation updater bot
8580fed7da
Localisation updates from https://translatewiki.net .
...
Change-Id: If86bb4a8467aec2ec52823fc230ed946e79c48f2
2017-11-11 22:55:50 +01:00
Translation updater bot
74800a76da
Localisation updates from https://translatewiki.net .
...
Change-Id: I21a85d3a7546005a9464af5a9c3f9a0486abf089
2017-11-10 22:57:49 +01:00
Ed Sanders
57bf86b69e
Add mw-parser-output to preview elements
...
Bug: T180214
Change-Id: I74700061c89ab4004229e3b03353067e92031774
2017-11-10 15:34:51 +00:00
Translation updater bot
625dea5a4b
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia9ec632b3d39b8353619fda55ed5e2191f3b8770
2017-11-08 22:49:19 +01:00
Translation updater bot
b9306f6b09
Localisation updates from https://translatewiki.net .
...
Change-Id: I8144f548d7e71ae260a1abf22729f6ded8d95f83
2017-11-07 22:55:00 +01:00
jenkins-bot
908205d4ac
Merge "ce.MWWikitextSurface#onCopy: Do nothing if selection is empty"
2017-11-07 16:18:21 +00:00
Ed Sanders
1cf2bf4a67
ce.MWWikitextSurface#onCopy: Do nothing if selection is empty
...
Bug: T179920
Change-Id: I3400f8277a4de6bac216ecbc0ba0d46670e03d11
2017-11-07 16:09:33 +00:00
Translation updater bot
8209c00cbc
Localisation updates from https://translatewiki.net .
...
Change-Id: If007f038b0472c9ef12fb7e444e9128c890a8564
2017-11-06 23:13:31 +01:00
jenkins-bot
2f3dba4222
Merge "Unify SVG markup"
2017-11-06 19:01:14 +00:00
Volker E
fdf30c1793
Unify SVG markup
...
Align SVG markup across Foundation products by:
- unifying XML declaration,
- removing unnecessary `standalone="no"` attribute as it's default,
- removing all SVG editor metadata
- removing all `g` group elements except where necessary for transforms,
- putting attributes on `path`,
- removing unnecessary ids and
- unifying whitespace.
Saving up to 23% file size before gzipping.
Bug: T178867
Change-Id: If0339073a12f24df1a0f8dcc110c35e0ee2d38a7
2017-11-06 10:43:56 -08:00
jenkins-bot
e18eacf222
Merge "Fix context menu placement on galleries"
2017-11-06 16:36:39 +00:00
jenkins-bot
a6e0c8854f
Merge "Convert empty doc to empty string in convertToSource"
2017-11-06 16:36:36 +00:00
Translation updater bot
5777b2c12c
Localisation updates from https://translatewiki.net .
...
Change-Id: I177221e0f068ee12d320dfae6ac11e31568d2a0f
2017-11-05 22:44:09 +01:00
Translation updater bot
c7a9996a10
Localisation updates from https://translatewiki.net .
...
Change-Id: Id90279b9542e6842b3e6c133a6fde8dcbe1bbc6f
2017-11-04 23:00:20 +01:00
Ed Sanders
88e8a9f7a7
Convert empty doc to empty string in convertToSource
...
Change-Id: I8753169ff206b5ce23cfd4c0dc7f97ac6fd1fff0
2017-11-04 21:16:35 +00:00
Ed Sanders
b85df2fb8e
Fix context menu placement on galleries
...
Change-Id: I8d64f805ac3f1ef311bcf1e0e745263b4edbc4c7
2017-11-04 11:25:41 +00:00
Translation updater bot
3145624694
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie30d0f106a01ffa12b464075db32347343652a6c
2017-11-03 22:50:14 +01:00
jenkins-bot
0511a89c2e
Merge "Fire wikipage.content hook on edit notices"
2017-11-02 23:18:44 +00:00
Translation updater bot
d234435bd0
Localisation updates from https://translatewiki.net .
...
Change-Id: I12b82affd432e1bbcafab2f608420da4bbf044d3
2017-11-02 23:08:40 +01:00
Translation updater bot
ec3d569f24
Localisation updates from https://translatewiki.net .
...
Change-Id: I0371fe47c4be9654f1818343d1e218d6577261b2
2017-11-01 23:19:48 +01:00
Ed Sanders
50217d2a19
Rename mediawikitheme -> wikimediatheme
...
Change-Id: I48e1fcc0b71dccdb6d8e034d686a4bfe5dbe39e6
2017-11-01 15:36:34 +00:00
Translation updater bot
2f9470d9ae
Localisation updates from https://translatewiki.net .
...
Change-Id: Id293c0866c91066c12fa7789fa246f6177793467
2017-10-31 22:47:15 +01:00
jenkins-bot
2649a2123a
Merge "Fix revslider colours in visual diff mode"
2017-10-31 17:50:53 +00:00
Ed Sanders
3fff0a88d7
Fire wikipage.content hook on edit notices
...
Bug: T179315
Change-Id: Ib9a19acbb2459c5b94fc72610f86a48feb80a380
2017-10-30 22:21:50 +00:00
jenkins-bot
93c2da8e78
Merge "ArticleTarget: remember whether we preloaded, so it can affect the save button"
2017-10-30 22:07:19 +00:00
Translation updater bot
d5f02b7483
Localisation updates from https://translatewiki.net .
...
Change-Id: I0713373523eaffd0f79560c1f1e76f028697758c
2017-10-30 22:55:09 +01:00
David Lynch
001b945513
ArticleTarget: remember whether we preloaded, so it can affect the save button
...
Idea being: preload use case is often "load content, maybe with parameters,
immediately save it", so we can treat it as being already-modified for saving
purposes.
Bug: T179063
Change-Id: I35ff04bc9cb5172edf8174832624145973aa1fdb
2017-10-30 16:40:57 -05:00
Translation updater bot
37668e080e
Localisation updates from https://translatewiki.net .
...
Change-Id: If2b0276e73c0f08543636a03a1dd00d9b92cd462
2017-10-28 23:05:09 +02:00
Translation updater bot
e551f8bcf4
Localisation updates from https://translatewiki.net .
...
Change-Id: I8daa1a3a143d70db44ab9c3ce6d01a1d0e4c6357
2017-10-27 22:39:50 +02:00
Ed Sanders
236d437875
Fix revslider colours in visual diff mode
...
Change-Id: If8a631812f3947b2260d66f832849eed3a0ad238
2017-10-27 11:41:02 +01:00
jenkins-bot
740b61598f
Merge "Move Beta Features screenshots into modules"
2017-10-26 22:40:56 +00:00
Translation updater bot
d95f4175dd
Localisation updates from https://translatewiki.net .
...
Change-Id: I09f1039ad1fa7689887b867839a43c90d6311510
2017-10-26 23:38:37 +02:00
James D. Forrester
9fd8def8dd
Move Beta Features screenshots into modules
...
Change-Id: I6b46f334d226a3e061a3534fd2982397b66e2c6f
2017-10-26 14:27:52 -07:00
Ed Sanders
dc3ed6cec0
build: Update stylelint 0.4.1->0.4.2
...
Change-Id: I9d67e4224eb6298e20574a201eeee559ab3a7504
2017-10-26 21:04:07 +01:00
Translation updater bot
c6cbfd272e
Localisation updates from https://translatewiki.net .
...
Change-Id: I360932f3af6ea92eb1163d9118eb4597f73a3854
2017-10-25 23:06:53 +02:00
David Lynch
ab1e5d58d4
MWInternalLinkContextItem: increase specificity to override OOUI changes
...
OOUI 8e31b2f273 increased changed various icon CSS rules, and increased their
specificity. Increase ours to match. This restores the correct size/ratio of
the images in the link context item.
Bug: T178933
Change-Id: I4f1a6dde363cf99f7665dc83f4b0fa6b1dd3c29e
2017-10-24 16:09:38 -05:00
Translation updater bot
bc1f41d0f7
Localisation updates from https://translatewiki.net .
...
Change-Id: I868bdeaabf47eb5450be9e99d45451f2724f1833
2017-10-23 23:45:49 +02:00
Translation updater bot
8074aff678
Localisation updates from https://translatewiki.net .
...
Change-Id: I34d2195477c2b61b9a38e5b188d81d595fa85c9b
2017-10-22 22:54:59 +02:00
Translation updater bot
33462623c9
Localisation updates from https://translatewiki.net .
...
Change-Id: I1a9bf279eb217f8c7e87bdaf3c43a622b68a6ae9
2017-10-19 23:28:36 +02:00
jenkins-bot
600208453b
Merge "Use more common 250ms transition for toolbar instead of 400ms"
2017-10-19 17:40:37 +00:00
jenkins-bot
c32aeeaa36
Merge "Increase selector specificity to fix layout regression"
2017-10-19 14:29:35 +00:00
Ed Sanders
b752a0620b
Increase selector specificity to fix layout regression
...
Removes negative margin from first item in help popup.
Change-Id: I87ecca9f886dd4061a2afa781ca997ef751907ef
2017-10-19 15:21:12 +01:00
Ed Sanders
4eb8f46234
Remove duplicate position:relative in toolbar css
...
Already set upstream.
Change-Id: Icf15dc82b7d57eb3591b0873e49fa9c598b2742d
2017-10-19 14:23:05 +01:00
Translation updater bot
28349d7b82
Localisation updates from https://translatewiki.net .
...
Change-Id: I8e041de2d743ecfcaa7de6770c95a41431d2cc8e
2017-10-18 22:53:58 +02:00
Ed Sanders
6761a3619a
Use more common 250ms transition for toolbar instead of 400ms
...
Change-Id: I8ad1a20753b7bd4a17db605d31502e57149b5348
2017-10-18 19:17:05 +01:00
L10n-bot
371cff8be6
Merge "Localisation updates from https://translatewiki.net ."
2017-10-17 21:05:34 +00:00
Translation updater bot
7ffbb72ae1
Localisation updates from https://translatewiki.net .
...
Change-Id: I328365204986eb3dddd000782c348b7aabd941b2
2017-10-17 23:05:28 +02:00
jenkins-bot
1b54d6e75a
Merge "Mobile: Rewrite toolbar centring CSS"
2017-10-17 20:37:14 +00:00
Ed Sanders
afc9d2156b
Mobile: Rewrite toolbar centring CSS
...
Change-Id: I43ada52231a0c9a91c98f2a482d2702528d995a2
2017-10-17 20:23:50 +01:00
jenkins-bot
45a5121853
Merge "requestParsoidData: Support 'wikitext' param in RESTBase-less environment"
2017-10-17 19:22:55 +00:00
Ed Sanders
0306f77fde
Simplify mobile overrides using LESS
...
Change-Id: I9ffce148fede03dda6e78377a0d20355bb45e5fd
2017-10-17 19:44:03 +01:00
jenkins-bot
6d6bff49eb
Merge "ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons"
2017-10-17 18:23:26 +00:00
Bartosz Dziewoński
99cdc08f53
ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons
...
OOjs UI's styles now include 'top: 0' for icons, which messes us up here.
Bug: T178415
Change-Id: Ia3234848f69fd67d0b3e35c817de1d9847d46143
2017-10-17 17:55:53 +00:00
jenkins-bot
18e2ccdc96
Merge "init.mw.DesktopArticleTarget: properly set up section links"
2017-10-17 16:28:54 +00:00
David Lynch
80c813e08c
init.mw.DesktopArticleTarget: properly set up section links
...
We were reimplementing (incompletely) the setup from the .init version. Just
call the original, modified slightly so it doesn't over-setup on repeated
calls.
Bug: T151021
Change-Id: I65bd7c5ecf75c478d6babeb13e7fb2a76a9842c8
2017-10-17 10:14:50 -05:00
Ed Sanders
8f11796c43
Convert mobile overrides to LESS
...
Change-Id: I44754f2d6e69ad9a8a6ce941962714a6d2617b5a
2017-10-17 11:46:17 +01:00
Ed Sanders
59955251fe
Fix button alignment in MW mobile
...
Change-Id: I4b29dfef672f48bc6d2b6644b1e0da5a7ada521a
2017-10-17 11:32:58 +01:00
Translation updater bot
b67854f026
Localisation updates from https://translatewiki.net .
...
Change-Id: I07de4ef9ea4a31585c519716706e9f389c3763d7
2017-10-14 22:43:30 +02:00
jenkins-bot
82c8e64f8f
Merge "Efficiency improvement for MWLanguageVariantNode#hasRendering"
2017-10-13 21:02:55 +00:00
Translation updater bot
a0d39d3643
Localisation updates from https://translatewiki.net .
...
Change-Id: I9ac1784955db18b4696006f0f0c9b3da06723f8c
2017-10-13 22:59:21 +02:00
C. Scott Ananian
b56e7eec4d
Efficiency improvement for MWLanguageVariantNode#hasRendering
...
Override ve.ce.FocusableNode#hasRendering with a model-based test to
improve efficiency and avoid some unnecessary DOM measurements.
Change-Id: Ice7aebcc2f30dc73ef049a6ed0d4a0cffe86d8e2
2017-10-13 15:11:47 -04:00
jenkins-bot
0fbf8971c1
Merge "Remove duplication from browser whitelist"
2017-10-12 17:32:47 +00:00
Ed Sanders
013d26f0b0
MWParameterPage: Use MultilineTextInputWidget instead of config
...
Change-Id: Icccd6460452774ae0ff21ce9df36dfe428d935d2
2017-10-12 18:13:06 +01:00
Ed Sanders
169ce28c44
Remove duplication from browser whitelist
...
The whitelist isn't checked for blacklisted browsers,
so if all non-blacklisted browsers are whitelisted,
set the whitelist definition to all (null).
Change-Id: I8ee3569d9d5be2eda9153f1b087c1be385f93d9c
2017-10-12 16:54:46 +01:00
Translation updater bot
3cba7eadf2
Localisation updates from https://translatewiki.net .
...
Change-Id: I7186a8239ecaadc69dc6ca45de8895ccb7846f0a
2017-10-11 23:16:55 +02:00
Ed Sanders
58a226288b
requestParsoidData: Support 'wikitext' param in RESTBase-less environment
...
Change-Id: I6154376be090655d3249ad7e74a0e90b39208a82
2017-10-11 21:26:18 +01:00
Ed Sanders
581847acb3
Show visual diffs in wikitext mode
...
Bug: T170371
Change-Id: I8fd9ed4f804444ec486c4df72125cdeb04da0d5f
2017-10-11 20:31:39 +01:00
Ed Sanders
fc9e0d88f6
Fix WikiEditor mode switcher widget
...
Broken by upstream CSS changes in OOUI.
Change-Id: I04c51f18624c09fd0030a8b73410a731216dd99c
2017-10-11 18:16:44 +01:00
jenkins-bot
12e8f5cdbb
Merge "init.mw.Target: make getSurfaceConfig aware of modes"
2017-10-10 22:02:36 +00:00
Translation updater bot
f6d891b216
Localisation updates from https://translatewiki.net .
...
Change-Id: I7b4a7018ede70f025c9d6969b7fba07794604754
2017-10-10 23:13:47 +02:00
David Lynch
4e938e58c7
init.mw.Target: make getSurfaceConfig aware of modes
...
ve.init.Target sets up TriggerListeners based on getSurfaceConfig if there's
no Surface instantiated. As such, loading directly in source mode would have
those listeners present and assuming the document is in visual mode. So, if
there's not a Surface already, we'll assume we're going to get one created
with the defaultMode, and set things up expecting that.
Bug: T153959
Change-Id: Ia0afe32e6b63ea0d3418137ca5c8bc32c009ecfa
2017-10-10 15:14:25 -05:00
jenkins-bot
762429e99f
Merge "DesktopArticleTarget.init: Load 'mediawiki.action.view.postEdit' via loader"
2017-10-10 05:04:22 +00:00
Translation updater bot
bfe3e66c5e
Localisation updates from https://translatewiki.net .
...
Change-Id: Ib298629b582138e653c5e807c09a76339544fb8f
2017-10-09 23:11:04 +02:00
Translation updater bot
1d689c9bd2
Localisation updates from https://translatewiki.net .
...
Change-Id: Icd5cecac5b2d5c7f21b9f2bd9450f8c5f191cd11
2017-10-06 22:58:01 +02:00
James D. Forrester
bd2deb3ac4
DesktopArticleTarget.init: Load 'mediawiki.action.view.postEdit' via loader
...
Bug: T164148
Change-Id: I537144bfd52ff84499f5d086f5d05efe2ba0493b
2017-10-05 15:54:20 -07:00
Translation updater bot
ccac68067f
Localisation updates from https://translatewiki.net .
...
Change-Id: I728c4e56f6e5a91ddca133607a01cfb910e4be61
2017-10-05 22:58:55 +02:00
Ed Sanders
43763f0a75
Target teardown refactor
...
* Rename 'deactivate' to 'tryDeactivate' as it may prompts
the user to deactivate.
* Merge 'cancel' and 'teardownSurface' in to 'teardown',
extending the parent method.
* Rename elementsThatHadOurAccessKey to $saveAccessKeyElements
and move teardown to parent class where it is setup.
* Move toolbarSaveButton teardown to parent class where it is setup.
* Cleanup changeDocumentTitle
Depends-On: I9d97614695272dca6936ef6f3461178fcf0368a8
Change-Id: Ie998a04c21f6615b4415edf471310db5edca3b5a
2017-10-05 10:26:46 -07:00
jenkins-bot
65ede4fc4f
Merge "Use destroy event to teardown new section inputs"
2017-10-05 17:24:57 +00:00
jenkins-bot
5d9c66497a
Merge "Use parent #clearSurfaces method to clear surfaces"
2017-10-05 17:22:41 +00:00
jenkins-bot
e657612068
Merge "Strip RESTBase IDs from historical diffs"
2017-10-05 16:06:43 +00:00
Ed Sanders
1256b19d72
Use destroy event to teardown new section inputs
...
Change-Id: I4990a162b62b7195016efba47cc5926b9e3a0f21
2017-10-05 16:20:48 +01:00
Ed Sanders
e0f7f30bbd
Use parent #clearSurfaces method to clear surfaces
...
Move mwTocWidget teardown to a destroy event listener.
Change-Id: If96be96aa67da55d3b17dd2565f5e954786ff3ff
2017-10-05 16:03:55 +01:00
Translation updater bot
e0d047973a
Localisation updates from https://translatewiki.net .
...
Change-Id: I5762bd8184d2b88c686f8b1c27787a6c279bbd73
2017-10-04 22:59:44 +02:00
jenkins-bot
6e2589d1a6
Merge "Abort loading when 'escape' is pressed"
2017-10-04 15:40:57 +00:00
Ed Sanders
58237588ad
Abort loading when 'escape' is pressed
...
Bug: T117359
Change-Id: I2c60588f14b9f80b18a7ac8da753fee224be35a4
2017-10-04 14:09:19 +01:00
jenkins-bot
28d4ed974f
Merge "Remove reference to editfont-default"
2017-10-03 18:48:21 +00:00
Ed Sanders
ff896e0be6
Always use trackingName for tracking
...
Change-Id: Ifc7d3275277628b310f5c017c43a76f5a7c25ea7
2017-10-02 22:20:53 +01:00
James D. Forrester
09cde07c45
DesktopArticleTarget: Retain 'mwTarget' stats tracking object
...
Bug: T177250
Change-Id: I1584f452e16272886af459bac3e24c4995af2231
2017-10-02 21:03:09 +00:00
jenkins-bot
fb4bb65a74
Merge "Allow MediaWiki extensions to use self closing tags"
2017-10-02 18:04:08 +00:00
Ed Sanders
cd097bed3d
Allow MediaWiki extensions to use self closing tags
...
Parsoid now supports this by setting body to null.
Change-Id: I24d856f0cffeacb00cb2b757e34315bc02b595d0
2017-10-02 10:52:48 -07:00
jenkins-bot
21bd98df61
Merge "ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission"
2017-10-02 17:44:46 +00:00
jenkins-bot
e7ac894a94
Merge "MWExtensionWindow: Always send a string to setValueAndWhitespace"
2017-10-02 17:25:02 +00:00
jenkins-bot
2d2ed0094f
Merge "MWAlienExtensionNode: Listen to attribute changes"
2017-10-02 17:22:51 +00:00
Ed Sanders
ddc056a40a
MWExtensionWindow: Always send a string to setValueAndWhitespace
...
Bug: T177180
Change-Id: I3a32e1b22e82bc0c182d26a952e7592aafd4b5e4
2017-10-02 16:26:16 +01:00
Ed Sanders
852e1ababe
MWAlienExtensionNode: Listen to attribute changes
...
Also:
* Disconnect change event on this.input, which doesn't
get destroyed on teardown
* Add padding between attributes and this.input
* Assume the alien extensions can have a rendering when
their body is empty.
Bug: T177181
Bug: T177183
Change-Id: I2e59f8195b255f33f91901213c92ea14793635b4
2017-10-02 16:22:41 +01:00
Bartosz Dziewoński
2b3998df4b
ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission
...
Bug: T177041
Change-Id: I28a7ec0710595977e5ec889016dd280d60e93034
2017-10-02 17:09:04 +02:00
Translation updater bot
e667ebe5cb
Localisation updates from https://translatewiki.net .
...
Change-Id: Ifd08290884dbeed1cc97dd04159d2b6161b31ce5
2017-10-01 22:48:18 +02:00
Translation updater bot
4ca4ddd991
Localisation updates from https://translatewiki.net .
...
Change-Id: I2ad37bcad504d1c0a6fb94e20fa9dc16f5003f59
2017-09-30 23:02:54 +02:00
jenkins-bot
ff7c57489a
Merge "Set padded=false for link inspector"
2017-09-29 16:42:29 +00:00
jenkins-bot
8032b97fa9
Merge "Remove upstreamed link inspector page icons"
2017-09-29 16:37:12 +00:00
Ed Sanders
582a3e62fb
Remove upstreamed link inspector page icons
...
Change-Id: I997b299d9a61ec9307025a7f4d106f185283eb40
Depends-On: I297648d14b4a2540a40f3a0b7d22a7905ef7c035
2017-09-29 16:27:50 +00:00
Ed Sanders
ef46e45b43
Set padded=false for link inspector
...
Logically depends on I615b485a272.
Bug: T177080
Change-Id: Ica54238d891fa41eefb0b9216eb4f2190818a502
2017-09-29 16:14:29 +01:00
Željko Filipin
fe09c22e33
Delete Ruby Selenium tests
...
Tests are broken most of the time. Ruby framework will be deprecated next month. Selenium tests
that are needed should be implemented in Node.js.
Bug: T164479
Change-Id: I8ec1d9b19b9538936c508daf2b50249a705b3170
2017-09-29 16:55:12 +02:00
Ed Sanders
dc500697e1
Follow-up Ia08dbb44: $attachable -> $bounding
...
Change-Id: I88101426998c7f11a7dfd3b971a1274e5aad638a
2017-09-28 17:36:37 +01:00
Bartosz Dziewoński
81d567bfdc
ve.init.mw.DesktopArticleTarget: Fix the code to reorder tabs
...
This code is meant to fix up the tabs if wgVisualEditorTabPosition
was changed and we're seeing cached HTML with the tabs in wrong order.
But it seems it has never worked. `$caEdit[ 0 ].nextSibling` is a text
node and obviously not equal to `$caVeEdit[ 0 ]`, and vice versa for
the other case. The logic is actually correct, so let's fix it to skip
over text nodes.
Also, remove a stray 'eslint-enable' comment left over in
a0f934ed26
.
Bug: T50017
Change-Id: I23663a9bfcfdbf52918452c878a128e6960b1191
2017-09-28 15:54:55 +02:00
Bartosz Dziewoński
a0f934ed26
ve.init.mw.DesktopArticleTarget: Remove hack for reversed tabs in RTL in Vector
...
Vector no longer does the silly thing where the tabs are reversed in
the HTML in RTL languages, so we must remove our hack to do the same,
since otherwise it reintroduces the issue it was intended to prevent.
This essentially reverts 2efd4f0061
.
Bug: T50017
Change-Id: Ibeaa55bc34899bffab849ea8ad8b127fb5184d43
2017-09-28 07:35:18 +02:00
Volker E
4067b05832
Unify monospace font family stack
...
Bug: T176636
Change-Id: I9ad1a92cef7875371e232c8e4babc842ba711e8c
2017-09-28 00:24:53 +02:00
Translation updater bot
db59dc6776
Localisation updates from https://translatewiki.net .
...
Change-Id: Icc4ce2792ffbfb8f030c9fa162400c31f72dc8dd
2017-09-27 22:44:25 +02:00
Ed Sanders
90a9fdb6aa
Ensure mw-notification-area doesn't get disabled
...
Bug: T176874
Change-Id: I43af13a0fcb5c19fdea53cfaeb941ac100579945
2017-09-27 14:50:59 +01:00
jenkins-bot
2411e7c04e
Merge "Replace constructive with progressive UI flag"
2017-09-26 22:04:46 +00:00
Translation updater bot
db5a06afd7
Localisation updates from https://translatewiki.net .
...
Change-Id: I55bcbb4134fd269f45b77115c025aea045e3bff8
2017-09-26 22:54:54 +02:00
James D. Forrester
2c70792c4f
Replace constructive with progressive UI flag
...
Change-Id: Iae36e978978ed6642f44606a934c540cf5f8537f
2017-09-26 15:14:32 -04:00
Ed Sanders
38d716f895
Follow-up Iebd1def1: Revert MWSignatureTool case
...
The tool checks the page name before the target is initialized.
Change-Id: I02ec528a11cc01b026fb95617388d47323ad96ee
2017-09-26 19:59:56 +01:00
Ed Sanders
1b8f8d8908
Replace wg(Relevant)PageName with target#pageName
...
The default value of target#pageName is wgRelevantPageName
but other targets my override this, or change it dynamically
(e.g. ContentTranslation).
Also remove duplicate setter of pageName in mw.ArticleTarget,
already set in mw.Target.
Change-Id: Iebd1def1d4142978a673afec584a0b663644d176
2017-09-26 13:22:00 +01:00
Translation updater bot
b81a4b0fea
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia27a53fdc504ca1bb3e2bbb3b0bc6e54542344aa
2017-09-25 22:54:09 +02:00
jenkins-bot
c54a54d3f9
Merge "Api: Missing preloadparams"
2017-09-25 17:30:41 +00:00
Ed Sanders
842d0bb8ed
Set bounding element to full frame for MW images
...
Logically depends on Iea800132.
Bug: T176646
Change-Id: Ia08dbb4400400990e1e518bc47afd5d60795c736
2017-09-25 17:17:27 +00:00
David Lynch
02c6e9142b
Api: Missing preloadparams
...
* Tiny fix to 33dc60838c
for PHP variable name
* Bigger fix to properly pass preloadparams in and split them up
Change-Id: I844db115f2563cb9ee1629c30d5f49d1ce58f5bd
2017-09-25 11:42:09 -05:00
Translation updater bot
e13538a8f0
Localisation updates from https://translatewiki.net .
...
Change-Id: Ic73bdbb6f814da63a38099728cd960e805be4664
2017-09-24 23:06:22 +02:00
Translation updater bot
d9de7e3235
Localisation updates from https://translatewiki.net .
...
Change-Id: I4ce90141a03f0cc736186a8375a21ff22bab349c
2017-09-23 22:58:22 +02:00
Translation updater bot
996e39613b
Localisation updates from https://translatewiki.net .
...
Change-Id: I9496eda9f2f17527f36a8dcb356e1246d1f66b98
2017-09-22 23:29:36 +02:00
Translation updater bot
14ebd22180
Localisation updates from https://translatewiki.net .
...
Change-Id: Iee95738a77c34850701cc87b345391a73201145c
2017-09-21 22:58:48 +02:00
jenkins-bot
f17b099984
Merge "Use findFirstSelectableitem instead of getFirstSelectableItem"
2017-09-21 18:13:09 +00:00
Ed Sanders
9572bbe245
Fix font size in local overlays in monobook
...
Change-Id: I742c090d64af4e22004e921ab772550474125224
2017-09-21 15:46:26 +01:00
Translation updater bot
fa7cbf0849
Localisation updates from https://translatewiki.net .
...
Change-Id: I41c542b61bc744c201ce582267a8a992fde9c201
2017-09-20 23:09:44 +02:00
jenkins-bot
549290991e
Merge "DesktopArticleTarget.init: handle new-section tab when in visual mode"
2017-09-20 17:04:48 +00:00
jenkins-bot
e1ae0a91ec
Merge "Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label"
2017-09-20 16:20:40 +00:00
David Lynch
325de4b130
DesktopArticleTarget.init: handle new-section tab when in visual mode
...
Bug: T157755
Change-Id: Ida657edb57c4d3067f17104ff1b74965c8082131
2017-09-20 15:49:21 +00:00
jenkins-bot
c1721aabe9
Merge "Wait for tree to finish building before updating caption"
2017-09-20 15:41:33 +00:00
Ed Sanders
14f99e3757
Wait for tree to finish building before updating caption
...
Bug: T176265
Change-Id: Ib73943beedc6a0166699b33b4d1148d8ba32ad20
2017-09-20 16:00:41 +01:00
Translation updater bot
7a7e57504b
Localisation updates from https://translatewiki.net .
...
Change-Id: Iad8f83651883d387edc898646acf6a1042ca38b9
2017-09-19 23:18:24 +02:00
jenkins-bot
0357252601
Merge "Use figure-inline instead of span for inline media"
2017-09-19 16:11:58 +00:00
jenkins-bot
fbdd7c895f
Merge "Do not "resolve attributes" in toDomElements() overrides"
2017-09-18 22:27:28 +00:00
jenkins-bot
0246c2a62f
Merge "Enable preload in VisualEditor"
2017-09-18 19:59:13 +00:00
David Lynch
c440a3576f
DesktopArticleTarget: Support preloadtitle in source mode
...
Can't support it in visual mode, since there's no new-section handling at all.
Bug: T51622
Change-Id: I763d5fff156e9ef3893bd882fab1dc2d47121728
2017-09-18 10:18:37 -05:00
Translation updater bot
228af9d25d
Localisation updates from https://translatewiki.net .
...
Change-Id: I10e3b3c86449102851aec61f7166adfd9432164b
2017-09-17 22:48:16 +02:00
Translation updater bot
76771b4cd0
Localisation updates from https://translatewiki.net .
...
Change-Id: I1cbc38a425ec200a585dfacb825893c20da5b1e2
2017-09-16 23:06:04 +02:00
David Lynch
ea274c94cd
Enable preload in VisualEditor
...
This allows the use of the preload and preloadparams query parameters. They
should behave as they do in the old editor, loading substituted content in
visual and source modes.
Bug: T51622
Change-Id: I522fb5b480d17912f6d6116be6aa043ead855b52
2017-09-15 17:17:51 -05:00
C. Scott Ananian
853ec0bc9c
Inspectors for editing LanguageConverter markup
...
Basic inspectors for editing. Changing from block to inline, or
adding "hidden" or "describe" flags not supported.
The UI layout for two-way and one-way rules could certainly be improved.
Bug: T49411
Change-Id: I5ce29e4bf47abf509afde0a57f64b5d1189f5185
2017-09-15 09:24:33 -07:00
jenkins-bot
0034fb3c65
Merge "CollabTarget: Disable submit button when input is invalid"
2017-09-15 00:22:12 +00:00
Ed Sanders
35be4f4757
CollabTarget: Disable submit button when input is invalid
...
Change-Id: Id8b3c098fc2fbec778b0d4cf98fa7cc35202d95b
2017-09-15 00:16:27 +00:00
Translation updater bot
253d0b2e09
Localisation updates from https://translatewiki.net .
...
Change-Id: Idc7a04710edbde1341c8fd87ab50d74a4ea87dd2
2017-09-14 23:36:51 +02:00
C. Scott Ananian
26df4dca33
Doc update: use the full class name so JSDuck hyperlinks it correctly
...
Change-Id: I2c6f6a6c5b497767d7f7731c86cc145ed60b1deb
2017-09-14 11:07:07 -04:00
Ed Sanders
405afdce70
Strip RESTBase IDs from historical diffs
...
Change-Id: I911d529204a97003ed233464709737b018918634
2017-09-14 13:45:10 +01:00
Translation updater bot
9dfe4bbdc7
Localisation updates from https://translatewiki.net .
...
Change-Id: I2195f7cb1d274f73a32a35237f6e0b9b23e29749
2017-09-13 22:56:59 +02:00
jenkins-bot
1809344c8a
Merge "URL decode file names in gallery, as in PHP parser"
2017-09-13 18:00:56 +00:00
jenkins-bot
714f43c8c2
Merge "Fix typos in gallery attribute names"
2017-09-13 17:34:52 +00:00
jenkins-bot
779dcc2164
Merge "ArticleTarget: Make save commands triggerable from anywhere"
2017-09-13 15:40:19 +00:00
jenkins-bot
d6fb66e70c
Merge "Use lowerCamelCase for javascript var oldId"
2017-09-13 13:45:20 +00:00
jenkins-bot
cd6dfaa42b
Merge "Remove pageName/revision from ArticleTarget constructor"
2017-09-13 13:45:19 +00:00
jenkins-bot
15ba6dbc53
Merge "Change ArticleTargetLoader#requestPageData API to use options object"
2017-09-13 13:42:10 +00:00
Ed Sanders
a6ac6d0cec
Fix typos in gallery attribute names
...
The MW attributes are 'style' and 'class'. The plural
forms are used internally only to avoid JS keywords.
Change-Id: I1b7d14872aab4b6b3882d00165924fd1639e1744
2017-09-13 14:06:44 +01:00
Ed Sanders
280696ad3f
URL decode file names in gallery, as in PHP parser
...
Bug: T175816
Change-Id: I3ec9c1f6db57798cdc1b5a787dd0bd9b4d3beef1
2017-09-13 14:03:20 +01:00