Commit graph

8897 commits

Author SHA1 Message Date
ryasmeen@wikimedia.org a8807c6af4 [BrowserTest] Adding tests for checking fields under Page Settings
Change-Id: I31d8d3327bd8abe6a7c5f3c4941174253104bbac
2014-12-15 21:37:42 +00:00
Translation updater bot 8133ef4aa8 Localisation updates from https://translatewiki.net.
Change-Id: Id6a2c0136078d95c537ef63e3d5d02d2b0fe581a
2014-12-15 22:20:53 +01:00
Translation updater bot 706413c211 Localisation updates from https://translatewiki.net.
Change-Id: Iff486cf59d6adef1cc9ccc4c5ce4c8e4f85e53aa
2014-12-14 22:25:34 +01:00
Translation updater bot 44514b947e Localisation updates from https://translatewiki.net.
Change-Id: I3422f33ebcd78c2a40c93d93684768b84f5dbd5e
2014-12-13 22:39:50 +01:00
jenkins-bot ad2f16c81e Merge "Update VE core submodule to master (6103755)" 2014-12-13 00:53:01 +00:00
jenkins-bot e6997350ba Merge "Check for stopped propagation before showing close dialog" 2014-12-13 00:52:57 +00:00
James D. Forrester a5b2399008 Update VE core submodule to master (6103755)
New changes:
cd56662 Move ve.init.Target#destroy to a place where it actually ends up existing
91347cb Factor out event handler binding in ve.init.Target
489cd55 Death to isolation
4597c9a Stop propagation of events after handling trigger keys
ea35d23 Non-DOM-modifying selection
6103755 Fix demo CSS hack broken by OOUI change

Change-Id: I087f2fa6a46742f39e7f25ffe5432465ab328182
2014-12-12 16:34:36 -08:00
Ed Sanders 9459e4e240 Check for stopped propagation before showing close dialog
Various VE elements use escape to perform tasks. Particularly
difficult are OOUI dialogs which listen to the document and thus
fire after this target's listener, so defer and check if the
event was previously stopped.

Bug: T78201
Change-Id: Ie335f199766923833588202626c3af8e4cbcb9b5
2014-12-12 22:38:40 +00:00
James D. Forrester 20c53d53bf Follow-up I64f5e2f6c: Bump wfUseMW version given breaking OOjs UI dependency
Change-Id: I2fddaab73d0c10286276de994c791af2cbb27595
2014-12-12 14:12:48 -08:00
Bartosz Dziewoński 29ff7b737e Rename some things for my sanity
Change-Id: I101943fa027947e73f7f7559bd706faadad90e95
2014-12-12 20:49:00 +00:00
Bartosz Dziewoński 16e8255f69 Update VE core submodule to master (b5e2b87)
New changes:
96d0936 Mark primary buttons as progressive as well
68f184c Localisation updates from https://translatewiki.net.
b96c9dc [BREAKING CHANGE] Rename method cmpOffsetPaths to compareOffsetPaths
862f31d Convenience compareDocumentOrder method
b5e2b87 Update OOjs UI to v0.5.0

Local fixes to correct for breaking change I32608c7f in OOjs UI.

Change-Id: I64f5e2f6ccc0056bfa9eda5e65e87789b97b8ad5
2014-12-12 12:29:05 -08:00
Translation updater bot a423784963 Merge "Localisation updates from https://translatewiki.net." 2014-12-11 22:59:37 +00:00
jenkins-bot 87143d4c36 Merge "Mark primary buttons as progressive as well" 2014-12-11 22:59:04 +00:00
Translation updater bot a76f1eff93 Localisation updates from https://translatewiki.net.
Change-Id: I5061faa84a867f5ff99a871aab597280d048ab38
2014-12-11 23:57:57 +01:00
James D. Forrester 57a68d082b Mark primary buttons as progressive as well
Also make save button primary.

In anticipation of Iee91d2c6 in OOjs UI

Change-Id: I123044bfaba631866ad32a35643f23686a17a16f
2014-12-11 22:55:16 +00:00
jenkins-bot fcdae1deba Merge "Fix image alignment in media dialog search" 2014-12-11 22:25:46 +00:00
Moriel Schottlender fbb6cd92b4 Fix image alignment in media dialog search
Make the image results align to the full width of the dialog. This
fix uses dynamic values of the width of the container rather than
a hard-coded value so it should work properly on all themes.

Bug: T78050
Change-Id: I05bb0d8a8b13c246840382b12e098d0579180016
2014-12-11 17:15:25 -05:00
Ed Sanders 45518019eb Update VE core submodule to master (9ac8136)
New changes:
9929b6d [BREAKING CHANGE] Make ve.init.target an OO.ui.Element

Local changes:
* Fix target constructors now they generate this.$element

Change-Id: Ia6bf604c67305834a3f73863a10336cfbb83fa77
2014-12-11 14:00:28 -08:00
James D. Forrester 0a86323d48 build: Suppress the 'unique-headings' warning from CSSLint
Change-Id: I3421cb7438f6187ae62a5bdcea3e4a5cdf251126
2014-12-11 13:35:14 -08:00
James D. Forrester 722ecddf0b Update VE core submodule to master (17c36e7)
New changes:
17c36e7 Followup cf1e167: unbreak SurfaceWidget

Change-Id: I59ae42b2053106e2a49b67501536a74c6b4bd698
2014-12-11 13:32:56 -08:00
Ed Sanders d6067d5718 Update VE core submodule to master (cf1e167)
New changes:
776e801 Delimit text nodes in debug observations
72643bc Remove debug bar hiding now it is handled by the surface
cf1e167 [BREAKING CHANGE] Multiple surface support and demo

Local changes:
Account for detachable toolbars in core being setup in a different order.

Change-Id: I29156948711d55ba5f6dd4f6c35ca0e4cca32373
2014-12-11 12:49:29 -08:00
jenkins-bot 5a3c81db4f Merge "Surfaces should have parent document direction" 2014-12-11 19:04:13 +00:00
jenkins-bot eacb364ed1 Merge "Add timing data for the first transaction" 2014-12-11 03:06:14 +00:00
Roan Kattouw 49b26f886e Add timing data for the first transaction
This doesn't quite tell us about the user's first interaction with
VE (if they open a dialog, for instance, it could be minutes before
that results in a transaction), but it's a good start.

Bug: T76524
Change-Id: I6bac987332802d7363ed65a471b2b1ece67086d8
2014-12-11 03:02:11 +00:00
James D. Forrester 603248a9c5 Update VE core submodule to master (26f44bc)
New changes:
26f44bc Refactor out trigger listening to allow target and document triggers

Local change to register the file for TriggerListener from VE core,

Change-Id: I16316b71d67b872358a8d7b685a33ce3dc066614
2014-12-10 18:16:29 -08:00
jenkins-bot 1aa30e0864 Merge "Update VE core submodule to master (3feadb2)" 2014-12-11 00:45:48 +00:00
jenkins-bot edf1ed3dbc Merge "Bump command help dialog height again" 2014-12-11 00:45:06 +00:00
Ed Sanders 34a82928c1 Update VE core submodule to master (3feadb2)
New changes:
fc4af20 Fix filibuster expansion bug
3feadb2 [BREAKING CHANGE] Refactor for multiple surfaces

Local changes:
* Use target.getSurface now that targets can have multiple surfaces
* Remove debug bar code now surfaces manage their own
* Remove import rules code now implemented in base target

Change-Id: I18d6f9f2f36431959d31347b4c1952a1aca1350e
2014-12-10 16:39:10 -08:00
Roan Kattouw e68dd9c7c1 Bump command help dialog height again
Change-Id: I348ce317b46f040bc8a2d70e4392ce0dfe24611c
2014-12-10 16:24:14 -08:00
Cmcmahon 122099fda8 [BrowserTest] issues with Chrome at SauceLabs causes test to fail
This is one of several VE tests that do not work well with older
versions of Chrome

Change-Id: Id7afc51689557d9e86e67a07dc840a8e6ca8303e
2014-12-10 15:00:05 -07:00
Moriel Schottlender e0894b807f Surfaces should have parent document direction
Make sure all surface widgets have documents that are initialized
with the direction of the parent document, so the alignment is set up
correctly.

Bug: T71969
Change-Id: I6e5f003e18a9c5808d9a4b148eddf0d0f7e29e67
2014-12-10 16:46:16 -05:00
Translation updater bot 70e8633c05 Localisation updates from https://translatewiki.net.
Change-Id: I3c4f3b3115aa8daa8b7fb3c4c800b4907e6fd564
2014-12-10 22:11:36 +01:00
James D. Forrester 8f30eddee2 Follow-up I4e38607d8: Register <visualeditor-find-and-replace-regular-expression>
Bug: T78180
Change-Id: I50d65d2c4f9458788c3fd5a09fd65d4c2f5780fc
2014-12-10 10:51:18 -08:00
jenkins-bot f51cc6f2ea Merge "ve.ui.MWParameter*: Use the destructive flag for all four remove buttons" 2014-12-10 02:04:33 +00:00
Roan Kattouw a032ea039e Move from legacy TimingData schema to new statsd API
This API doesn't have the ability to track any other data
in addition to a name and a duration in milliseconds, so
we add the target name ('mwTarget' or 'mobile') to the
event name and discard all other data.

Change-Id: I25ae0243f8983142d7755b65b05c18d5df36a253
2014-12-10 00:25:42 +00:00
James D. Forrester 8078f61657 Update VE core submodule to master (b6423de)
New changes:
3672954 Follow-up Ifa89a85e: Use '0' not '0px'
0cc0830 Normalize split text nodes correctly
c921dab Localisation updates from https://translatewiki.net.
3d1029b Trim whitespace when annotating

Change-Id: Ia5837dfb93b4eef76c32415462222bcfcfa6df3a
2014-12-09 16:22:23 -08:00
jenkins-bot 54b938e629 Merge "Fix duplicate wikitext parse for displaytitle" 2014-12-09 22:54:37 +00:00
Tim Starling 4c50307cd5 Fix duplicate wikitext parse for displaytitle
Instead of doing a whole new parse for displaytitle, just get it from
the same API action=parse internal request that is used for returning
the content HTML.

Also escape entities as in OutputPage::setPageTitle(). The format of
OutputPage::setPageTitle()/getPageTitle() is a bit confused -- it's
mostly treated as HTML, but Article::view() sets it to the unescaped
title text -- a historical error which was unfortunately wallpapered
over.

Change-Id: I387c1ccd9a75f9c6c6a006d83235c6c1c3d1ecb5
2014-12-10 09:50:59 +11:00
jenkins-bot ed22cbffea Merge "Prefer localStorage to store ve-beta-welcome-dialog" 2014-12-09 22:39:09 +00:00
James D. Forrester eac5aabeb3 ve.ui.MWParameter*: Use the destructive flag for all four remove buttons
Previously we were only doing it for one of the four.

Bug: T78033
Change-Id: Ib0091052a5c858dfd37b8755b6e3b84406b7c745
2014-12-09 14:28:40 -08:00
Alex Monk 51b091b9cd Prefer localStorage to store ve-beta-welcome-dialog
Bug: 62884
Change-Id: I3fe45e890c29aaa8d28edfb6986dc8c7541861c7
2014-12-09 21:04:13 +00:00
Translation updater bot 2edf5a7104 Localisation updates from https://translatewiki.net.
Change-Id: Ifc36f5299dfc91692e2357cb4ba2c2909477e658
2014-12-09 21:59:30 +01:00
jenkins-bot d318c5cded Merge "Restore papaparse" 2014-12-09 19:02:06 +00:00
Roan Kattouw 29995d806b Remove IEHacks.css in favor of .ve-init-target-ie class
Move reference style hack to MWReferenceNode.css, and move
heading style hack to ve.init.mw.Target.css

Change-Id: Icbd53f8df998c9f7bcc701b7c29dc226dfc5c05f
2014-12-08 15:45:23 -08:00
Roan Kattouw 3321261e98 Split up ve.init.mw.ViewPageTarget.css
* Move styles that apply to all targets to ve.init.mw.Target.css
* Move styles for MWPopupTool subclasses to ve.ui.MWPopupTool.css

Change-Id: I34c8a6200ee337debf00c4e432948f1b86f1b60a
2014-12-08 15:42:19 -08:00
jenkins-bot d250252732 Merge "Update VE core submodule to master (805e9aa)" 2014-12-08 23:11:16 +00:00
jenkins-bot 09bfc0cb9c Merge "Followup 1c04d32d: release saveDialog reference even if closed" 2014-12-08 23:06:37 +00:00
Roan Kattouw dad06ef495 Followup 1c04d32d: release saveDialog reference even if closed
It's good that we're not trying to close the save dialog
if it's not open, but we still need to release our reference
to it in that case, otherwise trying to open the save dialog
in a new incarnation of the editor will fail.

If you opened VE, opened the save dialog, closed it,
went back to read mode, opened VE again, and tried to open the
save dialog again, it would fail because it tried to open
the cached reference to the previous editor's save dialog.

Bonus: prevent JS errors in this case by only attaching an
onClose handler if the dialog actually opened successfully.
If opening the dialog failed, the callback parameter isn't
a promise but an OO.ui.Error, and calling .always() causes
a JS error.

Change-Id: I62d6d3e7cd3df2c29a0c99e2e23bf1aac5187a12
2014-12-08 14:49:39 -08:00
James D. Forrester 889d3fb042 Update VE core submodule to master (805e9aa)
New changes:
c027917 Regular expression find and replace
50ca51f Fix the src attribute for non-debug chimeras
0f0ae08 ve.ce.TestRunner: Fix copypasta in JS documentation
c3a26f8 Localisation updates from https://translatewiki.net.
c477adf Track state properly at the end of an event loop

Change-Id: I4e38607d82b57063d05c0a275b0a15b0147bca6c
2014-12-08 14:44:36 -08:00
Translation updater bot 4c3a6e55ee Localisation updates from https://translatewiki.net.
Change-Id: I771f43da908ad0d352ff74c622dea4cbcbd2bb42
2014-12-08 23:24:37 +01:00