Commit graph

20077 commits

Author SHA1 Message Date
Translation updater bot 86dff1e6a3 Localisation updates from https://translatewiki.net.
Change-Id: I857d667e34a6d769d8ca5a9ff717a5a59cecd406
2023-03-28 08:41:22 +02:00
David Lynch 31108dda7c Add editcheck tags when VE thinks a reference is needed
Bug: T324733
Change-Id: Iddc57e07133c56000c1338e8d780fa55cc95ab89
2023-03-27 22:48:25 +00:00
Ed Sanders 6e77f963e4 Initial edit check tagging
Bug: T324730
Change-Id: I112015809e55da802e3840fdfeaf16a72e090cb3
2023-03-27 22:47:40 +00:00
jenkins-bot 5ce888cdce Merge "Centralize EditAttemptStep logging code in WikimediaEvents" 2023-03-27 15:30:45 +00:00
Ed Sanders 9d09979e9e MWSaveDialog: Center preview in Vector 2022
Bug: T328783
Change-Id: I2e18967bb41573789cc3a8554038b8ac7876d356
2023-03-27 12:29:25 +00:00
Translation updater bot a205fab646 Localisation updates from https://translatewiki.net.
Change-Id: I61f9cc887c681abe8b8e54357d3dbd71db6430e2
2023-03-27 08:42:10 +02:00
Bartosz Dziewoński 766bdedf70 Centralize EditAttemptStep logging code in WikimediaEvents
* Use the new mw.track() handlers from WikimediaEvents
* Ensure that 'integration' and 'mode' are set on init
  events, since they're not guessed in the handler any more
* Remove the setting of 'editingStatsId' tracking parameter,
  now happens in WikimediaEvents by setting an API AJAX option
* Replace ve.track with mw.track in VE-MW, so that we don't have
  to copy the events manually here and in other extensions

This must be merged together with WikimediaEvents change
Iace4d53a972396ca5b8713000570cc47c9986034 (but we can't use
Depends-On, because CI requires code here to be removed first).

Bug: T332438
Change-Id: I0ef0a96aafdf89a4ebe32131a85b18c25744bb2c
2023-03-24 21:48:45 +01:00
Bartosz Dziewoński 1cdb641116 Simplify timing tracking code
Peel off some layers, remove some unused computation,
remove code from ve.init.mw.trackSubscriber.js (which
is to be removed in T332438).

Change-Id: I4073b9a2a4b2af06f30e603a9d2a1968203f3b6d
2023-03-24 21:48:14 +01:00
Jon Robson 4604c4a79f Remove unnecessary targets
VisualEditor already checks inside onBeforePageDisplay hook for
whether it is in the mobile site. The rest of the checks rely
on OO.ui.isMobile which operates using wgMFMode which is a configuration
variable added explictly by MobileFrontend so not affected by this change.

I verified that mw.loader.getState('ext.visualEditor.desktopArticleTarget.noscript')
returns 'ready' on desktop, but 'registered' on mobile site

Bug: T328497
Bug: T236944
Change-Id: Iea1135c22c750c47f2e34c7ae1fd2e828bd92cc7
2023-03-24 10:39:32 -07:00
Translation updater bot 8de2678817 Localisation updates from https://translatewiki.net.
Change-Id: I98c7ace4d47ee2bdb5c2cec5f86b4619233a2113
2023-03-24 09:29:13 +01:00
Translation updater bot c9be2deca0 Localisation updates from https://translatewiki.net.
Change-Id: Iea1ac4bce5466af97c0156f7e4ad0c84142269c9
2023-03-23 09:27:22 +01:00
Translation updater bot cfe7466147 Localisation updates from https://translatewiki.net.
Change-Id: I4f374b8c9a2cd21253aa7350f5b8527398b717bb
2023-03-22 09:16:47 +01:00
Ed Sanders e2aaac3e49 Update VE core submodule to master (b9ccfc346)
New changes:
50dc9a8b0 Localisation updates from https://translatewiki.net.
f8a1393ad build: Updating npm dependencies
ac4ca3617 Localisation updates from https://translatewiki.net.
becd00872 Update language lists
3360e8025 Force-show invisible template markers
b9ccfc346 ve.ui.DiffElement: Respect line breaks in attribute changes

Bug: T332626
Change-Id: I5a8cd9e0bfb99efd41051c34bc070d6c6087ae2f
2023-03-20 22:20:09 +01:00
Translation updater bot d4ba6e7c07 Localisation updates from https://translatewiki.net.
Change-Id: I95aee95dc8b6f0c42c54ad0605b38cfba314bcc2
2023-03-20 09:02:58 +01:00
jenkins-bot dc9fe4344f Merge "stylelint: Auto-fix selector-pseudo-element-colon-notation" 2023-03-17 18:00:34 +00:00
Translation updater bot 98cb0d966b Localisation updates from https://translatewiki.net.
Change-Id: I9a86c2585e1019964eeae2481ea3e80af34301d5
2023-03-17 09:23:21 +01:00
Ed Sanders db5f13fc93 Show redirect meta items in visual diff
Bug: T161290
Change-Id: Icf68f6d085ab2de802350df0d29208f0653ceb66
2023-03-15 14:46:28 +00:00
Ed Sanders 860d9ae926 Render category diff
Bug: T161290
Depends-On: I118e85d7fa8202717db3a323e3e3dd9bc8a25be5
Change-Id: Iaa401b130bd81b8960f799dc9de6f172d9ba86a3
2023-03-15 13:10:23 +00:00
Ed Sanders 2e492d4de7 Follow-up Id21c122d4: Replace MetaItem#remove with SurfaceFragment#removeMeta
Also fix one typo of 'frament' -> 'fragment'.

Change-Id: I1a814847213c81ecf08af6c40586752c513f7725
2023-03-15 13:10:23 +00:00
Translation updater bot 13c412e221 Localisation updates from https://translatewiki.net.
Change-Id: I7d3346c00a5241e917103d4dac564c85cb0f5cf3
2023-03-15 08:50:57 +01:00
jenkins-bot d1e51398db Merge "Move gray highlight of template items before blue active rect" 2023-03-14 22:50:09 +00:00
jenkins-bot 7f647a5135 Merge "Avoid/simplify possibly slow regular expressions" 2023-03-14 22:50:06 +00:00
jenkins-bot 2f90e96d0b Merge "MWGalleryImageNode: Handle own children" 2023-03-14 22:48:33 +00:00
Ed Sanders 7954f5897c Update VE core submodule to master (f5142bc0d)
New changes:
1b912ce6b ve.ui.DiffElement: Don't override margin on added/removed block elements
a43720b34 [BREAKING CHANGE] Move ve.dm.MetaList to ve.dm.Document
e7d6d2317 ve.dm.VisualDiff: Include metadata in diff

Local changes:
* Use new ve.dm.MetaList API

Bug: T331925
Change-Id: Id21c122d48519013a5c3325cc4bc316cedcb63f6
2023-03-14 23:07:14 +01:00
jenkins-bot 8c6e935383 Merge "Gallery tests: Remove data-mw.body attribute" 2023-03-14 21:46:31 +00:00
jenkins-bot 0860028d4c Merge "Update gallery alt with caption when set as same" 2023-03-14 21:45:04 +00:00
jenkins-bot e12342f41e Merge "MWPreviewElement: Strip already-present TemplateStyles when building elements" 2023-03-14 21:35:03 +00:00
C. Scott Ananian 4d8345247a DirectParsoidClient: Remove backward-compatibility workaround
Depends-On: I982e0df706a633b05dcc02b5220b737c19adc401
Change-Id: I316c4f9ddd4483eacb6c88181f0c5edd785cffe5
2023-03-14 21:38:46 +01:00
Ed Sanders cc6bf882dc MWPreviewElement: Strip already-present TemplateStyles when building elements
Add unnecessary <style> tags to the page triggers slow re-renders.

Bug: T330781
Depends-on: Ia47234e90d8f2c150b5250be5497cf7c7b4c1ed2
Change-Id: I27c6167663bcb201dfff5d69e5faa6006fb9cb73
2023-03-14 18:46:30 +00:00
Bartosz Dziewoński 983293156c Update VE core submodule to master (bcb501475)
New changes:
e276b1380 Localisation updates from https://translatewiki.net.
b04fd505d PreviewElement: Add a #beforeAppend method so nodes can be modified
537aebf8c build: Upgrade stylelint-config-wikimedia from 0.13.1 to 0.14.0
7c88e4e36 CompletionAction/Widget: Factor out more methods for extensibility
bcb501475 ve.ui.TargetWidget: Fix type hint

Bug: T330781
Change-Id: I10736f4499d22af82e74fbc6c38e69d10703fcb0
2023-03-13 19:15:15 +01:00
Ed Sanders 950fc45cf0 MWGalleryImageNode: Handle own children
This means that DOM attributes are deep-restored and so
selser runs properly.

Change-Id: I2fdfc04aee5e8b3524214e25afd8443b5f6b240d
2023-03-13 16:14:06 +00:00
Ed Sanders d4db90f970 Gallery tests: Remove data-mw.body attribute
This is not output by Parsoid except in legacy mode.

Change-Id: Ide894a3c5dfbbd1b7a4c0f29bbea65245192f1ef
2023-03-13 16:13:47 +00:00
Arlo Breault 8c73feb0b3 Update gallery alt with caption when set as same
Follow up to Idf297d8a98995971c5835b0cea56c3317a3626e2

Bug: T330842
Change-Id: Ia5e180f03a8199d8347558803336617472492a23
2023-03-13 11:28:32 -04:00
jenkins-bot b9691dcd09 Merge "Set editor preference even when disableForAnons is set" 2023-03-13 14:19:33 +00:00
jenkins-bot 03083bb122 Merge "Fix incompatible skin reporting logic" 2023-03-13 13:43:24 +00:00
jenkins-bot 1156c83bd2 Merge "Fix line height in templates used dialog" 2023-03-13 12:50:00 +00:00
Ed Sanders a0b09412af Fix line height in templates used dialog
Bug: T287733
Change-Id: I5a9a9d8d397e255509966001abe069b988478a64
2023-03-13 08:49:02 +00:00
Translation updater bot 0a2f1bd5ec Localisation updates from https://translatewiki.net.
Change-Id: I3114bd1b3dc317ff8aff306b4a5c2381056ec972
2023-03-13 08:40:13 +01:00
James D. Forrester ffc2b27bf9 stylelint: Auto-fix selector-pseudo-element-colon-notation
Depends-On: I0cc0c16c5adae09090a30453431fe492f3475a69
Change-Id: Ie975f0534f32e46face9ab2ba0e0d3af11533de6
2023-03-12 22:03:06 +00:00
libraryupgrader 30c544e7e6 build: Updating npm dependencies
* grunt: 1.5.3 → 1.6.1
* stylelint-config-wikimedia: 0.13.1 → 0.14.0
  The following rules are failing and were disabled:
  * selector-pseudo-element-colon-notation

* cookiejar: 2.1.3 → 2.1.4
  * https://github.com/advisories/GHSA-h452-7996-h45h
* decode-uri-component: 0.2.0 → 0.2.2
  * https://github.com/advisories/GHSA-w573-4hg7-7wgq
* jpeg-js: 0.4.3 → 0.4.4
  * https://github.com/advisories/GHSA-xvf7-4v9q-58w6
* ua-parser-js: 1.0.2 → 1.0.34
  * https://github.com/advisories/GHSA-fhg7-m89q-25r3

Change-Id: I0b7c1d2324720a0e07f24cd79651c1166b22e406
2023-03-12 13:44:51 +00:00
DLynch 15482cba82 Merge "Update VE core submodule to master (7e95f6c58)" 2023-03-10 16:08:22 +00:00
Translation updater bot cbedd8fd8f Localisation updates from https://translatewiki.net.
Change-Id: Ic1a3318ad298f2f9aaddcb7d4ddd0433419feeab
2023-03-10 08:49:52 +01:00
Ed Sanders 0c5948b4ab Update VE core submodule to master (7e95f6c58)
New changes:
d125fdac5 Localisation updates from https://translatewiki.net.
0215f6c34 Localisation updates from https://translatewiki.net.
ff1398988 Fix logic for abandoning a completion widget
40550ada0 Follow-up I5c0ac857d: Change which clippable element we disable clipping on
c70347e1e VisualDiff: Don't descend in non-tree nodes in tree diff
035cfe1a3 Localisation updates from https://translatewiki.net.
412b30649 Collapse no-change diff context in lists

Bug: T211897
Bug: T319179
Bug: T330401
Change-Id: Ic54ad0e39d88e0e97bbbac2102e3575c8c4c1402
2023-03-09 22:35:00 +00:00
jenkins-bot 099b8f9968 Merge "Remove visualeditor-enable-experimental and ext.visualEditor.experimental" 2023-03-09 19:33:59 +00:00
jenkins-bot 15bbdae6a3 Merge "Enable VE by default for 3rd party installs" 2023-03-09 19:33:39 +00:00
jenkins-bot 022e66f963 Merge "Remove unused user option 'visualeditor-enable-language'" 2023-03-09 19:32:01 +00:00
Thiemo Kreuz e391b5b925 Move gray highlight of template items before blue active rect
Discussed in todays story time. The blue "active" color is mostly a
"reminder with which parameter I interacted last". It's more a
secondary, passive information. In contrast, the gray
highlighting/hover effect that appears when navigating the sidebar
with keyboard or mouse is an active, primary information ("this is
where you are right now"). It's really confusing when the keyboard
navigation indicator disappears behind the blue box.

This patch changes this for both top-level elements as well as
template parameters. The blue text color "shines through" the gray
highlight so we can still see both information.

Bug: T289043
Bug: T311204
Change-Id: Ief6a023d8fde4f6ca0c4b2ea2e831b66e1ea8c83
2023-03-09 10:52:00 +00:00
Translation updater bot fc1c0b2b9b Localisation updates from https://translatewiki.net.
Change-Id: Iccc9666770de0833e0d368bda4bb810807de0751
2023-03-09 09:06:37 +01:00
C. Scott Ananian 10cb01cdd1 Update DirectParsoidClient to match BCP-47 changes in core
We're trying to avoid passing raw strings around, since they can be
ambiguous specifiers of language.  This patch makes VE compatible
with I982e0df706a633b05dcc02b5220b737c19adc401, with a backward
compatibility workaround which can be removed after
I982e0df706a633b05dcc02b5220b737c19adc401 merges.

The new code also uses slightly more methods of the Language object,
which need to be mocked in a unit test.

Change-Id: I830867d58f8962d6a57be16ce3735e8384f9ac1c
2023-03-08 21:19:21 +00:00
jenkins-bot eab91853fa Merge "Template context: Link to source templates in "Generated from:" list" 2023-03-08 17:34:43 +00:00