Commit graph

20077 commits

Author SHA1 Message Date
jenkins-bot b5b4d42b3b Merge "Target#tryTeardown should succeed when target isn't active" 2023-02-07 16:41:05 +00:00
James D. Forrester f6dcd98b38 Update VE core submodule to master (109c9a606)
New changes:
597ca6403 Localisation updates from https://translatewiki.net.
a938d5338 Update OOUI to v0.46.3
109c9a606 Try to prevent selections inside ref/template nodes on Firefox

Bug: T272207
Bug: T313162
Bug: T327086
Change-Id: I9b91729271e320576ea8425a68dc540a31d23a2e
2023-02-07 09:59:28 -05:00
Bartosz Dziewoński 5736f8ead6 Target#tryTeardown should succeed when target isn't active
It makes other code easier to write when we want to make sure
that no target is active.

Change-Id: Ica75f8334ef32ffbcc59109a46624acdf271847d
2023-02-07 00:03:07 +01:00
David Lynch d8fd73d72a Avoid error if watchlist has been toggled before editing
onWatchToggle didn't cope with the case where there was already an event
in the hook-queue when it was registered during setup

Bug: T328955
Change-Id: Ic80f707e86ba3c9f88097cac8aec8c6b3cc32cee
2023-02-06 15:58:45 -06:00
Translation updater bot 8eb272c2be Localisation updates from https://translatewiki.net.
Change-Id: I36f229974a169c54f63cf58d8720cf48a8da82fe
2023-02-06 08:46:44 +01:00
Translation updater bot bc4073b76c Localisation updates from https://translatewiki.net.
Change-Id: I784845f9eeb21ac31fdd62fb1a240a14573913ce
2023-02-03 08:48:45 +01:00
Ed Sanders 722e639ccb Update VE core submodule to master (b5c670c7a)
New changes:
0cf02db3a [BREAKING CHANGE] Pass Target to UI Surface and use instead of ve.init.target

Local changes:
* Pass target to surface

Bug: T305762
Change-Id: I3412c53cc70346c8ba4b8b76976ba9c7535e945f
2023-02-02 23:19:40 +01:00
Bartosz Dziewoński 0e115d914c Update VE core submodule to master (b8cc71bdc)
New changes:
ed2db1808 Localisation updates from https://translatewiki.net.
fb7f38574 Pass surface to all dialogs, and use in CommandHelpDialog

Bug: T305762
Change-Id: If69cbdc87971b303d3e7255dca3b0c7c9ef8a2b2
2023-02-02 22:29:03 +01:00
jenkins-bot 257dc1bd20 Merge "Add language and direction to preview" 2023-02-02 21:21:20 +00:00
jenkins-bot e70bdb06bf Merge "Mark config parameter as optional where it is" 2023-02-02 17:08:55 +00:00
jenkins-bot 696b791127 Merge "Error logging for native URL errors" 2023-02-02 16:10:28 +00:00
thiemowmde c57e86d325 Mark config parameter as optional where it is
This goes along with I3f239e0 in Cite.

Change-Id: Ife88431ef810f978f5c4466ee82405fd4c791032
2023-02-02 10:47:32 +01:00
jenkins-bot be9977ad8c Merge "Re-apply "Remove references to mediawiki.Uri"" 2023-02-02 09:23:43 +00:00
jenkins-bot bd105f2fc1 Merge "Re-apply "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"" 2023-02-02 09:22:45 +00:00
Bartosz Dziewoński cc72825835 Re-apply "Remove references to mediawiki.Uri"
This reverts commit afe3b7187e.

Bug: T325249
Change-Id: Ie2ce4816cd8fb6cc9805e0fd70dadb337719c551
2023-02-01 22:46:14 +00:00
Bartosz Dziewoński 99b1220aca Re-apply "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"
This reverts commit a92dce4999.

A workaround for the previous problem was added in ContentTranslation
in I945897a27db479986855002b389034a745bf9bef.

Bug: T325249
Bug: T325566
Bug: T327779
Change-Id: I2d9c330dc4328468a65315ec6bed1d0f53ebd1f6
2023-02-01 22:45:56 +00:00
jenkins-bot a1c1366b30 Merge "Document need to remove data-mw-section-id attributes when saving" 2023-02-01 21:15:11 +00:00
jenkins-bot 34a0634e16 Merge "Set a min-height on surface in Vector 2022" 2023-02-01 21:11:49 +00:00
Translation updater bot e2e5a62727 Localisation updates from https://translatewiki.net.
Change-Id: If07a3888cd2bc4f6d0f2b3c7543d5dd7ae50c450
2023-02-01 09:19:05 +01:00
jenkins-bot e9fd00aa7f Merge "build: Remove unused 'targets' property for QUnitTestModule" 2023-01-31 21:18:02 +00:00
Ed Sanders 4155ac51f6 Document need to remove data-mw-section-id attributes when saving
Bug: T328268
Change-Id: I429d692053c3bf02135b57471b76f72519221e99
2023-01-31 15:14:16 +00:00
Brandon Fowler 988097b09a Add language and direction to preview
Bug: T328388
Change-Id: I5ea63a743d9e497133ad6f35ba64d3a754eb7f5d
2023-01-31 00:18:14 +00:00
jenkins-bot 299110c446 Merge "Doc comment: Replace nbsp with normal space" 2023-01-30 17:46:29 +00:00
jenkins-bot ab8f3ece5d Merge "Authors.txt: Remove old reference to fork" 2023-01-30 17:46:00 +00:00
Bartosz Dziewoński b5a0450567 Update VE core submodule to master (6ed9b00f1)
New changes:
37b26cd7a Minor fixes to AUTHORS.txt
24151ec02 ve.ui.CommandHelpDialog: Move populating of dialog to getSetupProcess
a099b59f5 Localisation updates from https://translatewiki.net.
b45f88fd5 Update papaparse to 5.3.2

Bug: T326946
Change-Id: I83e367d5d7fa5952f942d86e3d2965f4ebf489e8
2023-01-30 17:16:10 +01:00
jenkins-bot 2fdac8851c Merge "Revert "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"" 2023-01-30 14:13:38 +00:00
jenkins-bot e5837cd9f0 Merge "Revert "Remove references to mediawiki.Uri"" 2023-01-30 14:13:35 +00:00
Bartosz Dziewoński a92dce4999 Revert "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"
This reverts commit 461c76981f.

Bug: T328143
Change-Id: Ib59192c650736eac9d4a2db130c3e29720c30486
2023-01-30 13:52:53 +00:00
Bartosz Dziewoński afe3b7187e Revert "Remove references to mediawiki.Uri"
This reverts commit 15bbafbe8c.

Bug: T328143
Change-Id: I57e6d953ed5a1735541987a256ad39037170da5a
2023-01-30 13:52:26 +00:00
Ed Sanders 143291b9d0 Doc comment: Replace nbsp with normal space
Change-Id: I5f44f2c3fc80ad6e29eaa8a5aaab2df53614e6f4
2023-01-30 11:09:37 +00:00
Ed Sanders f0516deef4 Authors.txt: Remove old reference to fork
Change-Id: I7d6240fb97047e56687afcd8fbf3d0f5a6fa7c4f
2023-01-30 11:08:41 +00:00
Translation updater bot 04b370230d Localisation updates from https://translatewiki.net.
Change-Id: I2f503345aa44871c8f094b55916065f57a632a4f
2023-01-30 08:31:07 +01:00
Ed Sanders c5cccfc85b Set a min-height on surface in Vector 2022
We could do something more complex and compute the height of the
available space, but a fixed height is a reasonable solution with
a fraction of the complexity.

Bug: T328048
Change-Id: I0b7bfa55f23afc16be43b85270666ec6a480ca32
2023-01-28 14:07:11 +00:00
Bartosz Dziewoński e52058fad3 Error logging for native URL errors
Bug: T328094
Change-Id: I7d0e3bb403db7ddbc233d6b0a770533f02883c5a
2023-01-27 10:48:45 +01:00
Ed Sanders 420c0f6c10 ve.ui.MWLiveExtensionInspector: Account for this.selectedNode being null in debounced method
Change-Id: I74ab091d3bfbdd9290429cd50688f458118701e7
2023-01-26 17:58:00 +00:00
Translation updater bot 0b1f41a07d Localisation updates from https://translatewiki.net.
Change-Id: If6a03eac30c8c10da26063590fe9620cac08f915
2023-01-26 08:52:57 +01:00
Jan Drewniak d98e9e83e1 Fix Wikitext editor preview layout in Vector 2022
Accounts for the use of CSS Grid in Vector 2022, in
the 2017 Wikitext editor preview, by placing the heading and
content in named grid areas (`titlebar` and `content`).

Bug: T327778
Change-Id: I66a30e282e808559b4f375f5924ae0d945c058a9
2023-01-24 10:39:40 -05:00
Translation updater bot eb06818b71 Localisation updates from https://translatewiki.net.
Change-Id: I64700f04b80fb793033739582e3d526d4013ccd0
2023-01-24 08:50:00 +01:00
Bartosz Dziewoński 15bbafbe8c Remove references to mediawiki.Uri
Remove dependencies (except a single one that we actually need)
and some config that allowed it to be used in doc comments.

Bug: T325249
Change-Id: I0db6e4ab1c025ac3868d2dc886c13a09d91f8086
2023-01-23 14:59:35 +00:00
Bartosz Dziewoński 461c76981f Rewrite mw.libs.ve.getTargetDataFromHref with URL API
At first I was going for a more minimal replacement of mw.Uri with URL,
until I discovered that this code depends on a mw.Uri bug that would be
difficult to replicate:

  // Expected: Relative URLs are accepted
  new mw.Uri( '/foo' ).toString() // => 'https://localhost/foo'
  // Expected: Protocol is optional
  new mw.Uri( 'example.com/foo' ).toString() // => 'https://example.com/foo'
  // Unexpected: Treated as empty domain with no protocol rather than relative URL
  new mw.Uri( './foo' ).toString() // => 'https://./foo'

So I went for a bigger rewrite to preserve the intent rather than the
exact logic.

I had to change some test cases to use more realistic fake data. They
previously relied on bugs in our URL handling to pass despite the base
URLs being incorrect, particularly for non-short URLs (see T270219).
In my testing non-short URLs behave the same as before in practice.

Depends-On: I07a8c097dba0f5572c0aedf4febdf1434063ea6f
Bug: T325249
Change-Id: I232361266c1dda795b88018c3aaa3d9ecbe42b93
2023-01-23 14:59:23 +00:00
Bartosz Dziewoński e40b73ef57 Update VE core submodule to master (b7ff5aac0)
New changes:
2201b350c Localisation updates from https://translatewiki.net.
da74736c1 Remove unused test code
d1b016e90 Minor test tweaks
551de4f0c Specify document base URLs in more test cases

Local changes:
* Specify document base URLs in more test cases

Change-Id: I0e301bef38d97fa2234aa901c787360d9fbde8a3
2023-01-23 15:57:59 +01:00
Bartosz Dziewoński a3d0ff8449 More realistic mocked data for MWWikitextStringTransferHandler tests
The actual API responses do not have <body> tags.

Change-Id: I5f2ab7d0a4ad33497868f5488e376f9467c1256b
2023-01-23 14:40:11 +00:00
jenkins-bot ca212a94d4 Merge "Minor test tweaks" 2023-01-23 13:01:42 +00:00
jenkins-bot 5c5165e394 Merge "Remove unnecessary test file" 2023-01-23 13:01:40 +00:00
Translation updater bot 44aa186f57 Localisation updates from https://translatewiki.net.
Change-Id: I6a4eeae67cebd695e49c60eff47bf66426c6afd0
2023-01-23 08:24:29 +01:00
Bartosz Dziewoński 0689e9247f Minor test tweaks
Change-Id: Ib20f9665534873bd1d5963664399459d3f5b4234
2023-01-21 19:15:51 +01:00
Bartosz Dziewoński 8371d24c78 Remove unnecessary test file
Change-Id: Ib81f70d290374451c5164bff7adbe4e18b9e2a8f
2023-01-21 15:09:14 +01:00
Ed Sanders 24a89caf93 mw.Target: Allow passing storageExpiry to initAutosave
Change-Id: Idcf50a527e2386122d077c497477057657824646
Depends-On: I4557a8808145fd1a601fe9b3fa1b190f8dba0077
2023-01-21 09:42:26 +00:00
Ed Sanders 2df8a95ac3 Update VE core submodule to master (035756895)
New changes:
4355d697a Replace ListStorage with ConflictableStorage
978061f86 Update SafeStorage and ConflictableStorage with expiry functionality
79019ed88 ve.dm.Surface: Support storage expiry

Local changes:
* Pull through conflictable storage

Bug: T218663
Change-Id: I36e49c01e9f2ddb7d362d539b72a4beca925bcb7
2023-01-21 10:41:21 +01:00
jenkins-bot da426264ca Merge "Work around Firefox bug affecting LazyMultilineTextInputWidget" 2023-01-21 08:43:10 +00:00