wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-23 10:19:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add editcheck tags when VE thinks a reference is needed

Browse source 
Bug: T324733
Change-Id: Iddc57e07133c56000c1338e8d780fa55cc95ab89
This commit is contained in:
David Lynch 2023-03-16 11:15:42 -05:00 committed by Bartosz Dziewoński
parent 6e77f963e4
commit 31108dda7c
5 changed files with 17 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
extension.json
View file

@ -166,7 +166,8 @@
"value": false
},
"VisualEditorUseChangeTagging": {
"value": true
"value": true,
"description": "Tag edits as having used visualeditor, or VE's wikitext mode."
},
"VisualEditorEditCheckTagging": {
"value": false,

2
i18n/ve-wmf/en.json
View file

@ -16,6 +16,8 @@
"Amir E. Aharoni"
]
},
"tag-editcheck-needreference": "-",
"tag-editcheck-needreference-description": "EditCheck thinks a reference might have been needed in this edit",
"tag-visualeditor": "[[{{MediaWiki:visualeditor-descriptionpagelink}}|Visual edit]]",
"tag-visualeditor-description": "Edit made using the [[{{MediaWiki:visualeditor-descriptionpagelink}}|visual editor]]",
"tag-visualeditor-needcheck": "[[{{MediaWiki:visualeditor-descriptionpagelink}}|Visual edit: Check]]",

2
i18n/ve-wmf/qqq.json
View file

@ -25,6 +25,8 @@
"Verdy p"
]
},
"tag-editcheck-needreference": "{{ignored}}Short description of the editcheck-needreference tag.\n\nShown on lists of changes (history, recentchanges, etc.) for each edit made that EditCheck thinks might need a reference.\n\nSee also:\n* {{msg-mw|Tag-editcheck-needreference-description}}\n{{Related|tag-editcheck-needreference}}",
"tag-editcheck-needreference-description": "Long description of the editcheck-needreference tag.\n\nShown on lists of changes (history, recentchanges, etc.) for each edit made that EditCheck thinks might need a reference.\n\nSee also:\n* {{msg-mw|Tag-editcheck-needreference}}\n{{Related|tag-editcheck-needreference}}",
"tag-visualeditor": "Short description of the visualeditor tag. Do not translate the link target, but do translate the words \"Visual edit\".\n\nShown on lists of changes (history, recentchanges, etc.) for each edit made using VisualEditor.\n\nRefers to {{msg-mw|Visualeditor-descriptionpagelink}}.\n\nSee also:\n* {{msg-mw|Tag-visualeditor-needcheck}}\n{{Related|Tag-visualeditor}}\n{{Identical|VisualEditor}}",
"tag-visualeditor-description": "Long description of the visualeditor tag ({{msg-mw|Tag-visualeditor}}).\n\nShown on [[Special:Tags]].\n\nRefers to {{msg-mw|Visualeditor-descriptionpagelink}}.\n\nSee also:\n* {{msg-mw|Tag-visualeditor-needcheck-description}}\n{{Related|Tag-visualeditor}}",
"tag-visualeditor-needcheck": "\"Check\" indicates \"Check needed\".\n\nSee {{msg-mw|Tag-visualeditor-needcheck-description}}.\n\nRefers to {{msg-mw|Visualeditor-descriptionpagelink}}.\n\nSee also:\n* {{msg-mw|Tag-visualeditor|similar message}}\n{{Related|Tag-visualeditor}}",

2
includes/Hooks.php
View file

@ -53,6 +53,8 @@ class Hooks {
private const TAGS = [
'visualeditor',
'visualeditor-wikitext',
// Edit check
'editcheck-needreference',
// No longer in active use:
'visualeditor-needcheck',
'visualeditor-switched'

16
modules/ve-mw/init/targets/ve.init.mw.ArticleTarget.js
View file

@ -1516,12 +1516,12 @@ ve.init.mw.ArticleTarget.prototype.save = function ( doc, options, isRetry ) {
var config = mw.config.get( 'wgVisualEditorConfig' );
if ( config.useChangeTagging && !data.vetags ) {
if ( this.getSurface().getMode() === 'source' ) {
data.vetags = 'visualeditor-wikitext';
} else {
data.vetags = 'visualeditor';
}
var taglist = data.vetags ? data.vetags.split( ',' ) : [];
if ( config.useChangeTagging ) {
taglist.push(
this.getSurface().getMode() === 'source' ? 'visualeditor-wikitext' : 'visualeditor'
);
}
if (
@ -1529,9 +1529,11 @@ ve.init.mw.ArticleTarget.prototype.save = function ( doc, options, isRetry ) {
mw.config.get( 'wgVisualEditorConfig' ).editCheckTagging &&
mw.editcheck.doesAddedContentNeedReference( this.getSurface().getModel().getDocument() )
) {
// TODO: Add an "edit check" tag
taglist.push( 'editcheck-needreference' );
}
data.vetags = taglist.join( ',' );
var promise = this.saving = this.tryWithPreparedCacheKey( doc, data, 'save' )
.done( this.saveComplete.bind( this ) )
.fail( this.saveFail.bind( this, doc, data, !!isRetry ) )