Commit graph

12319 commits

Author SHA1 Message Date
Alex Monk 86719eb90f Prevent endless error loop if falling back to wikitext (after a load failure) fails.
Change-Id: Id48fa13a33aee9fabf857d20a75d26463c329f44
2016-11-16 18:52:26 +00:00
Ed Sanders ff4761bbd9 Fix handling of failure to load visual mode
Reject the activating deferred making handleLoadFailure
redundant.

Fix logic for switching back to OWE aware of NWE.

Change-Id: I328fc944bb6b9152752742fe35c56b95e3255b88
2016-11-15 12:44:38 +00:00
Ed Sanders b4ff55a38c Always set mode when activating the target
Otherwise if the target was already loaded the mode will
not be changed, which can cause the wrong editor to load
in multi edit tab mode.

Change-Id: I64071dfdfc8511cce51bda20b9c62d7fc126c528
2016-11-15 12:44:38 +00:00
Ed Sanders 521c3c8436 Pass isModified when switching from VE to NWE
Bug: T150707
Change-Id: I9ae525aa7a5883bb45f91262db8abc082983ee1b
2016-11-14 23:05:21 +00:00
James D. Forrester 2fbbb07c73 Update VE core submodule to master (cf1a9c8)
New changes:
bccd179 ve.ui.MergeCellsContextItem: Correct @extends documentation comment
f0c7873 ui.CommentInspector: Select placeholder comment node while editing
4747913 Add ve.init.Target#isModeAvailable

Change-Id: I2e28a4bc5ca3c81580f24419409004e05c415682
2016-11-14 14:13:38 -08:00
Translation updater bot cd681d4bf4 Localisation updates from https://translatewiki.net.
Change-Id: I26e9cc640152465d37f834bf9c83d30497c6e2b4
2016-11-14 23:02:39 +01:00
jenkins-bot 0f9286519b Merge "extension.json: Bump MW requirement to 1.29" 2016-11-14 19:15:29 +00:00
James D. Forrester e39b27d79e extension.json: Bump MW requirement to 1.29
We rely on the latest version of OOjs UI which isn't available in REL1_28
since I2b8ef74e.

Change-Id: Ia75d525622cca9ec07e945bfb9260ffdf91439ba
2016-11-14 10:25:20 -08:00
jenkins-bot 0c1eff31ef Merge "Teardown the toolbar properly" 2016-11-14 17:26:54 +00:00
James D. Forrester a438e5bd9d Update VE core submodule to master (2bc2ddf)
New changes:
408a212 Fix and improve performance of shallowCloneFromRange( undefined )
6f01d52 Return an empty document when shallowCloneFromRange is collapsed
e0fb3a3 Skip toolbar rebuild when config hasn't changed
00ffe0f Avoid annotation set clones when unused
e839b94 Add teardownToolbar to ve.init.Target
869e458 Cache this.getToolbar
e0ba022 eslint: Re-enable wrap-iife and partially enable dot-notation
15518fa Wrap attribute resolve in try-catch for IE

Change-Id: I404d3b098232be920a2f72a5281bf5c04b85aae1
2016-11-14 09:02:53 -08:00
Translation updater bot 82b8afafc7 Localisation updates from https://translatewiki.net.
Change-Id: I4471a9107521394ae38e4b0fdd06cac730c7656b
2016-11-13 22:57:35 +01:00
jenkins-bot bc2a0fcbd9 Merge "Update VE core submodule to master (c532815)" 2016-11-13 02:40:42 +00:00
jenkins-bot 6215f9a1bb Merge "eslint: Re-enable wrap-iife and partially enable dot-notation" 2016-11-12 23:43:32 +00:00
Translation updater bot 3dfe9de109 Localisation updates from https://translatewiki.net.
Change-Id: I1c9a170ee3c6e466731c4725a7ee81b064f2f9a1
2016-11-12 22:59:42 +01:00
Ed Sanders 37ccaca2ec eslint: Re-enable wrap-iife and partially enable dot-notation
Change-Id: I4420d66f528dcb18ebe2b9f63996661b2969f833
2016-11-12 14:43:43 +00:00
Ed Sanders f2e0b408b4 Teardown the toolbar properly
Depends-On: I53a86bf5e0322dc9766ae4ddf31ff0ae5568df7e
Change-Id: If9cc876a57272679584ebc653cf2ee8e17ddb821
2016-11-12 14:28:11 +00:00
jenkins-bot cf3c972a3a Merge "Move NWE URL changes into JS" 2016-11-12 00:02:50 +00:00
L10n-bot 62fc7e1b9b Merge "Localisation updates from https://translatewiki.net." 2016-11-11 22:03:58 +00:00
Translation updater bot 71b1c8af06 Localisation updates from https://translatewiki.net.
Change-Id: I55094810442134b6e688fe972c06ce42dfb15cb8
2016-11-11 23:01:14 +01:00
Ed Sanders b1b6f9836e Remove redundant narrow-threshold calculation
This is done upstream in OOUI.

Change-Id: Icc0e535f9d1113a14d2c1cc275efebbc98e3a38c
2016-11-11 18:54:30 +00:00
Alex Monk 807cb6b54e Move NWE URL changes into JS
Bug: T148077
Change-Id: Ic9b94184a48026254cf4a0a812fe6fc8455841b5
2016-11-11 18:31:22 +00:00
Ed Sanders 6f8e0d9699 Replace confirm with OO.ui.confirm
Also enable no-alert eslint rule to prevent alert/confirm/prompt
being used in the future.

Change-Id: I2851e1f58c1861f75dbb20192e5cf6c343da75db
2016-11-11 13:13:58 +00:00
James D. Forrester 25b0a94ee9 Update VE core submodule to master (c532815)
New changes:
e03fbf0 ce.Surface: Tougher check on whether cursorHolders are still in-document
708aa36 Localisation updates from https://translatewiki.net.
c532815 Fix IE hack classes to run on the correct versions

Change-Id: Ie780b0287664f89815482e4632c4aac86843a1dc
2016-11-10 17:19:13 -08:00
jenkins-bot 95a8b8a30e Merge "Use a blank temp document when selection is empty" 2016-11-11 00:29:22 +00:00
Ed Sanders 003c5ac410 Use a blank temp document when selection is empty
shallowCloneFromRange can a broken document if you pass
a collapsed range. That should be fixed upstream but for
now this fixes a major bug (and is faster).

Bug: T150492
Change-Id: I9b539c588d91ef7f22e662c7cae0b3f89b21d33a
2016-11-11 00:08:11 +00:00
Translation updater bot 0b7f19e941 Localisation updates from https://translatewiki.net.
Change-Id: I18ad56399a23642d42db319d9c274c6b687a0513
2016-11-10 23:36:34 +01:00
James D. Forrester 26e7267f02 ArticleTarget: Use an OOUI MessageDialog, not window.alert()
We should avoid using alert()s as much as possible due to their unhealthy
interaction patterns with any other open tabs or user tasks.

Change-Id: Ib6a217c988322ad17bc7e649c3281eb053b54bbc
2016-11-10 12:55:49 -08:00
jenkins-bot 5ac488ba53 Merge "Revert "Temporarily override broken toolbar border colour"" 2016-11-09 21:49:54 +00:00
Translation updater bot aa1cb54a20 Localisation updates from https://translatewiki.net.
Change-Id: I8bb4d91acd719bc94ac20fa0e02220162e880c48
2016-11-09 22:45:52 +01:00
Jforrester dc8171d100 Revert "Temporarily override broken toolbar border colour"
This reverts commit 4c8a97f9e8.

[Pending next OOUI release.]

Change-Id: I890a7081ffa7c015bd32466fa88d61e3f38af4e6
2016-11-09 20:48:58 +00:00
James D. Forrester 20b802cc85 Update VE core submodule to master (5f569e4)
New changes:
66291ea Converter: Remove internal during the main loop
99172f5 Remove unnecessary double-negation cast in if()
349f341 Refactor diff element getChangedNodeHtml
2885ec2 LinkAnnotationWidget: Don't use deprecated TextInputWidget#setRTL
c235d13 LinkAnnotation{Inspector|Widget}: Stop using deprecated TextInputWidget#isValid
5f569e4 Update OOjs UI to v0.18.0

Change-Id: Iba3908fd3aec62c8c770346dd01714c41c7a87a0
2016-11-09 12:35:17 -08:00
jenkins-bot de72f77b1b Merge "Collapse to end after inserting WT signature" 2016-11-09 20:00:05 +00:00
James D. Forrester 79befe3d67 MWExtensionWindow: Use #setDir, not the removed #setRTL
Change-Id: I4090fa0375a93e095a644538b52853fd849b8749
2016-11-09 11:13:09 -08:00
Ed Sanders 1cb4c27378 Collapse to end after inserting WT signature
Bug: T150320
Change-Id: I06a8304499d92d0155c112449678fef34dc98424
2016-11-09 15:26:44 +00:00
jenkins-bot 28787b0f3c Merge "Rename methods used for setting up multiple edit tabs" 2016-11-09 00:45:01 +00:00
Translation updater bot 98fdfb3174 Localisation updates from https://translatewiki.net.
Change-Id: I0d1b052032dda69430e083751ee83934bae616e8
2016-11-08 22:50:21 +01:00
jenkins-bot 45a75047fa Merge "Move save dialog checkbox code up from DAT into ArticleTarget" 2016-11-08 17:14:45 +00:00
jenkins-bot d972d3f4f2 Merge "Hacks to get VE loading on mobile while user has NWE enabled" 2016-11-08 17:14:44 +00:00
jenkins-bot efb4133119 Merge "Use onEditTabClick handler in SingleEditTab" 2016-11-08 17:10:06 +00:00
Ed Sanders 55fcded32e Replace non-standard whitespace in comments
This is required to pass eslint:recommended.

Change-Id: If8c4876a366e5c021c414e54328ed1913b679969
2016-11-08 14:15:12 +00:00
Ed Sanders 2fa4cfef16 Rename methods used for setting up multiple edit tabs
Change-Id: I71d6dd0848e9cc3ee8531b0b914c29219b4697bd
2016-11-08 12:47:30 +00:00
Ed Sanders f6a205d77f Use onEditTabClick handler in SingleEditTab
Gives us extra functionality like  checking for
isUnmodifiedLeftClick which makes CTRL+click on SET
not change the current page, as expected.

Change-Id: Icb37d7383374ee63798443659a2bcb2f1545c8c5
2016-11-08 12:39:15 +00:00
jenkins-bot 8336720a5f Merge "Remove 'vesection' parameter" 2016-11-08 10:26:53 +00:00
James D. Forrester 539974a80b Update VE core submodule to master (88ba26b)
New changes:
e9866f4 Replace reference to current doc with this.newDoc
fa5a575 Add test framework for diffElement
2f6969c Use shallow copy for internal list data inside shallowCloneFromRange
866b2c0 Don't bother testing data on direction key tests
88ba26b Avoid jQuery in PreviewElement and ve.resolveAttributes

Change-Id: I7adb57898fa7cecd6a412183c4ca0726ef1a00ae
2016-11-07 13:51:21 -08:00
Translation updater bot b2a60edf8a Localisation updates from https://translatewiki.net.
Change-Id: If90be9fb65286254cd6b386e931eb5093134e043
2016-11-07 22:40:27 +01:00
jenkins-bot 6f4ff421fc Merge "Clarify wording of __NOINDEX__ option in VisualEditor" 2016-11-07 18:54:10 +00:00
Deskana e4b1b9e4f1 Clarify wording of __NOINDEX__ option in VisualEditor
VisualEditor contains an option in "Advanced options" to add __NOINDEX__ to
the page, stopping external search engines from indexing the page. This does
not affect the in-site search. The current wording is correct, but a little
ambiguous since it just mentions "search engines". This patch clarifies the
wording.

Change-Id: Ide528f3c028fb79d187eee1c64187c2886635d66
2016-11-07 10:39:09 -08:00
jenkins-bot c22739cff0 Merge "Cleanup elements passed to MWImageNode mixin" 2016-11-07 16:51:20 +00:00
Translation updater bot 3efe7cc78f Localisation updates from https://translatewiki.net.
Change-Id: Icb5ee56b1dcb001ad013939335baa72b6c54f128
2016-11-06 22:42:07 +01:00
Ed Sanders 7a0eb09e32 Cleanup elements passed to MWImageNode mixin
Change-Id: Idc736bca6ec7f9cae18d065303364ff5b7828a3b
2016-11-06 15:38:48 +00:00