Commit graph

4762 commits

Author SHA1 Message Date
Ed Sanders 8e4c9dba13 Fix link blacklisting
Now that we always generate mw link types in the converter,
blacklist mwExternal links, not plain links (which won't exist).

Change-Id: I2ab9fbb9ec50c2e36e8a870d48b6aa06c7e69f8c
2016-04-26 21:20:22 +01:00
jenkins-bot a9e40b09cd Merge "Move cursor to end when switching to external" 2016-04-26 15:05:44 +00:00
Ed Sanders eb839a89a0 Move cursor to end when switching to external
Bug: T133677
Change-Id: I2694b6ddd476798b29d2aeb9d3eb4f162da49f7c
2016-04-26 14:00:48 +01:00
jenkins-bot 1ca644a98b Merge "Select the label properly when converting LinkNode to LinkAnnotation" 2016-04-26 12:40:23 +00:00
jenkins-bot 6cf2af4f5c Merge "[BrowserTest] Migration of browsertests* Jenkins jobs to selenium* jobs" 2016-04-26 10:58:02 +00:00
Željko Filipin 58049b0c2c [BrowserTest] Migration of browsertests* Jenkins jobs to selenium* jobs
selenium* jobs are a new way of running Ruby based Selenium tests. The
jobs are triggered daily.

Bug: T128190
Change-Id: I11554b23a0e347736a67766f8c0b9879d5a6bed9
2016-04-26 12:40:45 +02:00
jenkins-bot 80636c235e Merge "Add a popup after switching into VE from WTE" 2016-04-25 22:42:55 +00:00
Alex Monk 6b7551112d Use correct case to access ve.ui.MWCategoryItemWidget.prototype.sortKey property
Otherwise we just record undefined as the original sort key and never
allow blank sort keys.

Bug: T92632
Change-Id: I7f37a8a33c54186ec6f0f74e374c591d5428b119
2016-04-25 23:18:09 +01:00
Translation updater bot 0c71085d52 Localisation updates from https://translatewiki.net.
Change-Id: Ib768ec5b86b9db81ec6730948e7384f831900091
2016-04-25 22:49:44 +02:00
jenkins-bot fd5e61582e Merge "Remove IE9 from blacklist, but don't add to whitelist (yet)" 2016-04-25 19:14:34 +00:00
David Lynch 8bb1399c97 Select the label properly when converting LinkNode to LinkAnnotation
We were selecting outside the annotation, when converting a LinkNode to a
LinkAnnotation. This meant that typing would overwrite the annotation as well
as the label. Speculatively, this is probably a side-effect of recent changes
to how nails and cursor offsets interact.

Bug: T121448
Change-Id: Ib2274bc5857294c5b691b3c3567b135d68bfa596
Depends-On: I3954c7f8f8e5870b13a8f6c4f0e86fb3b20b3cd3
2016-04-25 11:56:39 -05:00
Ed Sanders 61d5ae3d5d Don't expand link selections when opening with '[[' sequence
This mimics what would happen if you were actually typing wikitext.

Bug: T133516
Change-Id: I737313e6aaa5e4517c9f7f18faa5570a31395e03
Depends-On: If8ab31a7eacb4d8fa6d9787b7ac9872be0de04e7
2016-04-25 08:48:53 -07:00
Translation updater bot 7f9ab36d6a Localisation updates from https://translatewiki.net.
Change-Id: I082b61486f45d155f10df7645c72c32089e2e2a3
2016-04-24 22:37:58 +02:00
Translation updater bot 247a96ab1f Localisation updates from https://translatewiki.net.
Change-Id: Iba208728fdee4e84e230a001e8137d7b6ace2fb0
2016-04-22 22:25:23 +02:00
jenkins-bot a825845ad5 Merge "Move monobook global overlay styles to generic DesktopTarget" 2016-04-22 16:37:55 +00:00
jenkins-bot ddb37b3921 Merge "Add method that runs after activation, for overriding" 2016-04-22 16:30:42 +00:00
Ed Sanders 6efd583ff7 Add method that runs after activation, for overriding
Change-Id: I046583e61f328baddb0c09eaff122e991c85f992
2016-04-22 17:17:56 +01:00
Ed Sanders 9898b7ea2c Move monobook global overlay styles to generic DesktopTarget
Fixes the font size in non-article desktop targets,
e.g. Flow.

Change-Id: I8f7e0af5061ef5dda2564b62e9b94e606ca77799
2016-04-22 12:42:52 +01:00
jenkins-bot faed98a7c6 Merge "Create MW targets using a factory" 2016-04-21 22:25:37 +00:00
Translation updater bot a18be53e3d Localisation updates from https://translatewiki.net.
Change-Id: Ifa769984c966bdc6bdcaa5f98168d1828fe67b97
2016-04-21 23:00:09 +02:00
Ed Sanders 7a007e2874 Create MW targets using a factory
Move the existing static property 'name' to 'trackingName'
to make way for a real registry index.

Change-Id: Iab0d5be611ece7038234551c4847b07517b4348d
2016-04-21 21:06:39 +01:00
jenkins-bot 4b4c52c334 Merge "Use Array.prototype.indexOf in support check" 2016-04-21 15:27:20 +00:00
Ed Sanders 7576810b28 Use Array.prototype.indexOf in support check
The SupportCheck method asserts that the method is available so use it
instead of the confusingly named jQuery version.

Change-Id: I2105384cc4f6f2ec1cdb24a7bf3b0f4cce7672d3
2016-04-21 12:41:13 +01:00
Alex Monk 0bbe2e38ee Add a popup after switching into VE from WTE
Bug: T131066
Change-Id: I2294da7d09dfbacb9187aba5e6e703511cec3c9f
2016-04-20 18:46:00 -07:00
Translation updater bot ad436e29ff Localisation updates from https://translatewiki.net.
Change-Id: Ib7b2fce6436cb6d4407f08724cd396e9553033de
2016-04-20 23:15:50 +02:00
Ed Sanders 4479633159 Remove IE9 from blacklist, but don't add to whitelist (yet)
This puts IE9 on the greylist, meaning it will open but with
a warning.

Bug: T133094
Depends-On: I817b286e16b7923dd4dd456467466a0128805da1
Change-Id: I55fcbd1b7c4a82e11d61d3b93b4fdb7e992fba1d
2016-04-20 00:10:26 +00:00
jenkins-bot 0f60df5d9e Merge "Defer before restoring scroll position, and allow 0" 2016-04-20 00:01:14 +00:00
Ed Sanders a6aa6daa28 Defer before restoring scroll position, and allow 0
Bug: T131791
Change-Id: Id48b913effe5313c193ce62b19faf5655278ff6d
2016-04-19 21:42:09 +01:00
Translation updater bot 411b2e5421 Localisation updates from https://translatewiki.net.
Change-Id: I76cac451fdc00f764ecf03a074436322323cf2de
2016-04-19 22:24:01 +02:00
James D. Forrester be1809c35d Update VE core submodule to master (d6c6a85)
New changes:
c48d7cc Add support for placing a toolbar dialog in the side margin
ee7e14b FindAndReplaceDialog#renderFragments: Protect against null surface
fc61463 Fix dm.Surface#getHistory to not return undone items
f1dff2f Introduce ve.Range#overlapsRange method
f608958 Introduce dm.Surface#getModifiedRanges
db114ed Move debugging data-url GIFs to a debug only file
1dd8194 Update RangeFix to 0.2.0
706ff4e Add 'Support: [browser]' to browser hack comments
4f52afc Inline slugs: Limit Firefox hack to versions <38
bf73326 Add classList polyfill for IE9
59d78aa Fix access of iframe-created document in IE9
a886ae1 Hide borders on linked images in IE9
5293974 Fix double-click to edit table cells in IE9
a49a02f Add some more Support: comments

Depends-On: I9c5cea3e8df1fae001d4d98c0782a04dec803776
Change-Id: I460368f509a213464e57bb95f2d726305ef608de
2016-04-18 18:34:20 -07:00
Translation updater bot c8359c9c5d Localisation updates from https://translatewiki.net.
Change-Id: Iee3d68d581c1392ef45cfcd2710c36d83cf95043
2016-04-18 22:23:58 +02:00
Translation updater bot ddbafee1e4 Localisation updates from https://translatewiki.net.
Change-Id: If9d3d7ff71b15c2ff3519ee9bf59154be6d99417
2016-04-17 22:20:31 +02:00
jenkins-bot d4f9a85f27 Merge "Set mw.libs.ve.EditingTabDialog.static.message instead of passing it to setup data" 2016-04-17 17:49:28 +00:00
jenkins-bot 227de9cfef Merge "Close VE SET dialog when we deactivate" 2016-04-17 17:43:01 +00:00
jenkins-bot 299027e528 Merge "Don't select edit tab when VE is opened while user has prefer-wt pref" 2016-04-17 17:39:56 +00:00
jenkins-bot 25fb8ce692 Merge "Only style originalContent when VE is active" 2016-04-17 17:31:05 +00:00
jenkins-bot e357f19f6b Merge "EducationPopup: Give pulsating blue dot an initial opacity of 0" 2016-04-17 17:28:03 +00:00
jenkins-bot 09ed9130e0 Merge "Replace transitionend event with setTimeout" 2016-04-17 17:24:30 +00:00
Translation updater bot 7c18e19eaf Localisation updates from https://translatewiki.net.
Change-Id: I379df9b3b27dfc8b007da7710faf02b71502ae04
2016-04-16 23:16:25 +02:00
Translation updater bot 3f33dd5309 Localisation updates from https://translatewiki.net.
Change-Id: I52858a699489c4fa8d2ef09963f9e57a0cce8a7f
2016-04-15 22:21:49 +02:00
Alex Monk 4ccc1ad5af Don't select edit tab when VE is opened while user has prefer-wt pref
You can still open VE with prefer-wt mode by going to veaction=edit, and
T116406 proposes making it accessible with a keyboard shortcut as well.

Change-Id: Ifc25b5147a96a200ac3a7de465d5cdf67e2e255b
2016-04-15 02:37:46 +01:00
Alex Monk 89ed0ccbf5 Only style originalContent when VE is active
Otherwise there is a white block above the resulting content after save

Change-Id: If9239556ed5b1038aa86e4ba161da2abfd9e6bf2
2016-04-15 02:26:44 +01:00
Translation updater bot 3a05797ea5 Localisation updates from https://translatewiki.net.
Change-Id: I3f0b46e53c0dd708d744452925e274a3ad024445
2016-04-14 22:38:43 +02:00
Ed Sanders 4d40a9df80 EducationPopup: Give pulsating blue dot an initial opacity of 0
This makes it degrade to a small dot instead of a huge dot in
browsers which don't support animation (IE9).

Change-Id: Ia457b3caf35ff0ffe7287b2b1e395860d5dbd7d0
2016-04-14 16:22:04 +01:00
Ed Sanders 011ff4e133 Replace transitionend event with setTimeout
transitionend events seem like a neater solution, but we should
migrate all of our code at once, and provide a polyfill for
browsers which don't support it (IE9).

Change-Id: If6ae030856f8e69cc8bb26f21bfed30d5d22775c
2016-04-14 16:21:41 +01:00
Alex Monk f3c5e2f410 Set mw.libs.ve.EditingTabDialog.static.message instead of passing it to setup data
Change-Id: I2bfb79e258253e00c9f856bbbb3c4efae55a128c
2016-04-13 22:46:14 +01:00
Alex Monk 47cfc03d72 Close VE SET dialog when we deactivate
You can trigger deactivation by browsing back.

Bug: T132494
Change-Id: I8f66e22a745d84a3ca4b144c389c3ae654974789
2016-04-13 22:41:27 +01:00
Translation updater bot a6974c0c81 Localisation updates from https://translatewiki.net.
Change-Id: Ieaf3137f26d599edcc19c42af321fded1e6d135e
2016-04-13 22:22:36 +02:00
Translation updater bot 716a7d64c8 Localisation updates from https://translatewiki.net.
Change-Id: I4409a473d8217eaf7c1fa93505422709f1172b6c
2016-04-12 22:59:48 +02:00
jenkins-bot b779743208 Merge "[BrowserTest] Fix i18n files lookup" 2016-04-12 00:50:13 +00:00
Alex Monk 71990b4c44 Check wpSection before converting textbox contents for use in VE
Bug: T132309
Change-Id: I93f7706257f1f8ea59b7447f198a34439b17194d
2016-04-11 23:35:11 +01:00
Translation updater bot 5508609124 Localisation updates from https://translatewiki.net.
Change-Id: I29d8e85f5a87b73f8ee011e35f174078dbe60259
2016-04-11 22:40:29 +02:00
jenkins-bot 5dc1257507 Merge "More minor/watch checkbox state computation server-side" 2016-04-11 14:18:56 +00:00
jenkins-bot 9b9390585d Merge "Adjust DOM and CSS so UI surface runs from top to bottom of page" 2016-04-11 14:03:29 +00:00
jenkins-bot c2bb40285b Merge "Add ?redirect=false to VE's RB /page/html/ requests" 2016-04-11 13:44:21 +00:00
Ed Sanders f342dc01c3 Adjust DOM and CSS so UI surface runs from top to bottom of page
Place things like the page title and redirect link inside a new
container $originalContent, which is appended to the surface
when ready. Replace margins with padding in various places.

This will allow us to surface-height-matching sidebar for dialogs.

Change-Id: I60d80fb303bdaf93e9d121f62d534ee3a3056e59
2016-04-11 13:18:36 +01:00
Translation updater bot b8f387afa7 Localisation updates from https://translatewiki.net.
Change-Id: Idece17af3a2cff864e7085f34b1b91b03a1d424e
2016-04-10 20:10:39 +02:00
Alex Monk 149dab8fc5 Add ?redirect=false to VE's RB /page/html/ requests
Untested.

Bug: T130757
Change-Id: I27570d3212bd41bf7da93608302dae04c364783f
2016-04-09 03:34:34 +01:00
Roan Kattouw 12eb41acff More minor/watch checkbox state computation server-side
Following through on my threat from 72b0d2a19c (November 2013).

Change-Id: I0daeef2a0373bbdb06627053e9d726d6fc20a3f6
2016-04-08 18:02:01 -07:00
jenkins-bot c253bfbd5a Merge "Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields" 2016-04-08 16:39:50 +00:00
Translation updater bot a7b2938f0e Localisation updates from https://translatewiki.net.
Change-Id: I67966efc3392f3d2133c0442aad699406bba0c00
2016-04-07 23:05:28 +02:00
Translation updater bot f9487af27a Localisation updates from https://translatewiki.net.
Change-Id: Iaded10f066d638b38240ff8572e4abb326d42302
2016-04-06 23:16:05 +02:00
Alex Monk 978224f2ec Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields
* Use TitleInputWidget for wiki-page-name and wiki-template-name parameters
* Use UserInputWidget for wiki-user-name parameters
* Use a custom hacky CheckboxInputWidget child class for boolean parameters
* Borrow some ve.ui.MWExternalLinkAnnotationWidget.prototype.createInputWidget code for url parameters
* Use a TextInputWidget with multiline disabled for line parameters

Not dealt with in this commit, so fallback to existing behaviour:
* string
* number
* unknown
* content
* unbalanced-wikitext
* date
* wiki-file-name

Bug: T55613
Bug: T124734
Bug: T124736
Change-Id: If04944d64303d959e8dd605e75a175895932b788
Depends-On: I87699a93ca1b34c6d248456fcc060f584623d158
Depends-On: I5e97604f0fc24176d5e89899bf0505dc442a1a7e
2016-04-06 22:07:19 +01:00
Translation updater bot 5f58ba4bf5 Localisation updates from https://translatewiki.net.
Change-Id: I21bc9c165d900adb4223887846c898e702ac40df
2016-04-05 23:01:17 +02:00
jenkins-bot 597a095a64 Merge "Ensure veswitched is not set when we set wteswitched in the URI" 2016-04-05 15:51:33 +00:00
jenkins-bot f9c95cd820 Merge "Fix up mw.libs.ve.EditingTabDialog.prototype.getActionProcess" 2016-04-05 15:41:28 +00:00
Alex Monk 373a19f1cc Ensure veswitched is not set when we set wteswitched in the URI
veswitched and wteswitched together cannot result in any sane behaviour.

To reproduce:
* Open VE (while having multi-tab pref?), switch into WTE
* Make a change
* Switch into VE

Change-Id: I90e19169e3fab60ab876c8e4d349801309db262f
2016-04-05 01:27:37 +01:00
Alex Monk f67b578c3f Fix up mw.libs.ve.EditingTabDialog.prototype.getActionProcess
How did this ever work?

Ensure action is passed through and not just undefined, wait for change to go
through before refreshing.

Bug: T131818
Change-Id: I83b5695906044299d338e62e6c980c596d291765
2016-04-04 23:57:46 +01:00
Translation updater bot 2ff6fd5b9b Localisation updates from https://translatewiki.net.
Change-Id: I39ddf914192ccdd0d41708303eb9fb153329c1ba
2016-04-04 22:13:20 +02:00
Antoine Musso 4a97e9585f [BrowserTest] Fix i18n files lookup
The visual_editor_page used relative paths expecting the current
directory to be modules/ve-mw/tests/browser. Use absolute paths instead.

Change-Id: I8b1c4eddc2085ee80380f288bceb14c6feee0a60
2016-04-04 11:52:36 +02:00
Translation updater bot 286f489a6d Localisation updates from https://translatewiki.net.
Change-Id: Iaef135e32858ff9562fba4a1fe56558fc13ba893
2016-04-03 23:25:01 +02:00
jenkins-bot 12aefcc213 Merge "After saving and setting HTML, set single-editor edit section handlers again" 2016-04-02 18:32:46 +00:00
Roan Kattouw 8e69dfa3b8 ArticleTarget: Correct comment explaining where setAssumeExistence( false ); is called
Change-Id: Ib883ea1fe57fe6cb3e182965a18eb3fb50246178
2016-04-02 20:28:44 +03:00
jenkins-bot 65ee77da50 Merge "MWExternalLinkAnnotation: Only match plain external <a>s with hrefs" 2016-04-02 16:05:36 +00:00
Ed Sanders 6fad9ecdee MWExternalLinkAnnotation: Only match plain external <a>s with hrefs
We now accept non-Parsoid generated external links from paste,
so make sure they have href attributes otherwise they aren't
really external links and will throw exceptions later on.

Bug: T131430
Change-Id: Ifb565b1ce30cfe80ae72b17f6a9551ea40b36453
2016-04-02 18:51:56 +03:00
jenkins-bot aa5f992159 Merge "MWExtensionNode#generateContents: Fix renderEmpty logic" 2016-04-02 09:31:07 +00:00
Tpt 8ccbb58ca6 MWExtensionNode#generateContents: Fix renderEmpty logic
This static attribute is not used anywhere so it should be safe

Change-Id: I633c521859b59614835344a4644560ac933c6028
2016-04-02 07:58:33 +00:00
Alex Monk 7788aece55 After saving and setting HTML, set single-editor edit section handlers again
Change-Id: I6e0962271e7e1460abbe82864b47fddc5bd7f235
2016-04-02 09:53:25 +03:00
Translation updater bot 6b4dcefcf2 Localisation updates from https://translatewiki.net.
Change-Id: I520bd24cc795d85ab66e2d623d77b7141d0188ab
2016-04-01 22:30:49 +02:00
Roan Kattouw f6ba399137 Fix asynchronous loading of MWAlienExtensionNode renderings
ve.dm.MWExtensionNode#toDataElement calls storeGeneratedContents()
which prepopulates the cache, but because it was being called with
the wrong context, this.name was null and so the key we were storing
it under was different from the key we'd later be looking for.

Fixed by ensuring ve.dm.MWAlienExtensionNode#toDataElement preserves
context when calling its parent. Our static context hacks are tricky.

Change-Id: If859d861453067d7656a33a1767f6efc7bd9d323
2016-04-01 12:50:13 +03:00
Translation updater bot 1ad77ddf91 Localisation updates from https://translatewiki.net.
Change-Id: Ic552bb2a2a87252033cc9f6ab57ff9545f6686b5
2016-03-31 22:47:29 +02:00
jenkins-bot 2449ce203d Merge "Use veaction=edit in URL instead of action=edit when we're using multiple tabs" 2016-03-31 15:42:40 +00:00
Translation updater bot db5741d061 Localisation updates from https://translatewiki.net.
Change-Id: Ib60a84f5f2dd85ed5b2f9dd89b8eb64402e8a2d6
2016-03-30 22:43:22 +02:00
Alex Monk 4210c4bee0 Use veaction=edit in URL instead of action=edit when we're using multiple tabs
TODO: What about prefer-wt users switching from WTE?

Bug: T131064
Change-Id: I9aa701cbda3964decb8b1ee853c0a281567a0ccb
2016-03-30 02:54:01 +01:00
jenkins-bot 4dadaa677c Merge "MWWikitextStringTransferHandler: Add test for autoGenerated=true" 2016-03-29 22:01:39 +00:00
jenkins-bot f5f97adbe4 Merge "MWWikitextStringTransferHandler: Factor out body tag from response" 2016-03-29 21:42:09 +00:00
jenkins-bot b44cee5557 Merge "MWWikitextStringTransferHandler: Remove data-parsoid from tests" 2016-03-29 21:39:07 +00:00
Translation updater bot f753a46fa1 Localisation updates from https://translatewiki.net.
Change-Id: I840ba9e9d5c3eaed4837cabbd5fbf35c1079150e
2016-03-29 22:40:33 +02:00
Ed Sanders 18df6c3d47 MWWikitextStringTransferHandler: Add test for autoGenerated=true
Bug: T131153
Change-Id: I4922abe7978e1f04eb2276214c761622b44149c7
2016-03-29 19:57:45 +00:00
Ed Sanders b51b512555 MWWikitextStringTransferHandler: Factor out body tag from response
Change-Id: Ic694d1099538d2c60900d490667f2175f7f3afb3
2016-03-29 19:57:36 +00:00
Ed Sanders 818931dd9e MWWikitextStringTransferHandler: Remove data-parsoid from tests
It is ignored by VE, and isn't present in restbase responses.

Change-Id: Iaa2a6a66ba76ca0d63b4d6791ab8589191bce0f2
2016-03-29 19:57:26 +00:00
jenkins-bot 0242dedff9 Merge "Filter out auto-generated reference lists" 2016-03-29 19:37:35 +00:00
jenkins-bot 18533b47fa Merge "Toolbar: Add tooltips to structure and insert groups" 2016-03-29 17:15:51 +00:00
jenkins-bot 29af9b54b6 Merge "MWPopupTool: Don't pass $1 to visualeditor-beta-warning any more" 2016-03-29 16:52:31 +00:00
jenkins-bot 190c64ed69 Merge "Select tool when it's been closed by education tool popup button" 2016-03-29 16:42:38 +00:00
jenkins-bot b9643881d9 Merge "Remove icon properties from windows" 2016-03-29 16:37:22 +00:00
Alex Monk 0760cd6974 Select tool when it's been closed by education tool popup button
Bug: T117273
Change-Id: I54b704b6663f7d862557e6524713259dee8765cc
2016-03-29 15:54:22 +01:00
Ed Sanders 9a347220bc Target loading: Only parse oldid if it is non-null
This un-breaks MobileFrontend.

Change-Id: Ib1bce6b80abb004ff4ca26920759ef98f3cd1143
2016-03-29 12:57:00 +01:00
Ed Sanders c516d897d2 Remove icon properties from windows
Windows stopped supporting icons a while ago.

Change-Id: I8a63152282a5968dcd17675330e31bd1ebe4b68b
2016-03-29 12:33:42 +01:00
Ed Sanders 1d8d1c2a64 Toolbar: Add tooltips to structure and insert groups
Bug: T131133
Change-Id: I927bf6f0d1de74b4ac8d16c3b5ce27720db322d4
2016-03-29 12:08:22 +01:00