Reuse the back button confirmation dialog for the close button. The
condition is slightly different: need confirmation if there are any
manually-entered values for any parameter AND the user has edited
the template in this session.
The "reset" action was synthetic, only used internally and not
connected to buttons or menus. Canonically, action='' is the close
action for OOUI.
Bug: T297792
Change-Id: I4ff644c7ab24ed9ba1a4c27d762563c5d6771cfc
* Find the first section below the top of the viewport
(usually visible) and measure its offset.
* After loading the editor, ensure this heading is still
at the same position on the page.
Bug: T296910
Change-Id: I9a05ea74ba3c19a4a91ddc1bc0afe311851c53e6
Without changing behavior, consolidate the logic for detecting
whether the editor has made changes to the template. This is
responsible for enabling and disabling the "Apply changes" button.
Change-Id: Ic4755b13f30fb738a7cb1eebaddef0435ea61d34
Currently, the insert template dialog includes a back button in the
upper corner. Confirmation of abandoning unsaved changes was
accomplished in an overlay panel. This patch rewrites as a dialog
and updates the on-screen text.
Bug: T297792
Change-Id: Ifa2ff97c9284609ee2a784f455789c56a762ba50
New changes:
22f6db516 Fix getViewportRange when section editing
7d948731c Toolbar: Remove unnecessary unfloat() in detach()
2d14351b9 Toolbar: Set toolbar height from $bar when floating, and updating size when switching surface
f18dab62f Improve getViewportRange behaviour around text wrapping
6eb23a10f Try to select a visible offset when focusing a null-selection surface
Bug: T296910
Change-Id: I1265be30bb11076576a32feea7299303f74b197c
* Use this.getElementWindow
* Use this.surface.padding to avoid race condition
when the toolbar hasn't fully rendered yet.
Change-Id: I055b1d9458d73e435ede6096941a3e72c9c1ce74
New changes:
04bd5c1da Localisation updates from https://translatewiki.net.
4147426da DiffElement: Manually number ordered lists with value attribute
ef3536361 DiffElement refactor: Pass diff objects to renderDiff instead of using state properties
593fe9026 DiffElement refactor: De-duplicate logic inside getNodeElements & wrapNodeData
a7b5eed5f DiffElement refactor: Create an iterateDiff method and unify function signatures
2db326345 Diff some nodes as if they are documents, e.g. <div>s
Bug: T188170
Bug: T298410
Change-Id: I28a048a02c62fb9bb96f29e472767d46c3b45804
New changes:
46501f84a Localisation updates from https://translatewiki.net.
2b3f0c029 Update RangeFix to 0.2.10
254a8f359 Tests: Show warning when input to ve.createDocumentFromHtml is unbalanced
Change-Id: I015c6fd980fee754bf907fc6f87f403ca0fa952a
This prevents your preference being changed if you just
followed a link with a diffmode parameter.
Change-Id: I755563bde285e95c0367119d49a40e1dd3c5e178
This is guaranteed via ve.init.mw.Target.getContentApi(). But the
ContentTranslation extension replaces this, and does not set a
formatversion. See e.g. SectionTranslationTarget.getContentApi().
Bug: T298599
Change-Id: I8768cae3153e9cbc29a8796ec21ef249f80471ed
In case the save is triggered without the save dialog (for example, when a null edit is made during suggested edits task in GrowthExperiments)
Bug: T298552
Change-Id: Id49b967cfa52d33848e9c911086000fa4501fa7f
New changes:
6f114fe8c Localisation updates from https://translatewiki.net.
b2dd88142 Localisation updates from https://translatewiki.net.
08d33f872 Localisation updates from https://translatewiki.net.
fb15ab599 DiffElement: Remove unused jlen from loops
5ca7924d5 DiffElement: Remove unused 'doc' argument from compareNodeAttributes
e776c9011 DiffElement tests: Remove wrapper paragraphs from list test input
Change-Id: Ida46a53c566b4b4df085c7e581dc937f2ee2ff75
The global function wfReadOnly() has been deprecated in favor of the
new ReadOnlyMode service. Its usages should be replaced.
Bug: T283978
Change-Id: I26a878f19be5c90dab04e28ce395cb8f6dddebef
New changes:
26ba8a561 Store internal list counter in new document storage and persist
75661d69f Drop support for fallback createDocumentFromHtml methods
2143a90a7 ve.dm.Document: Remove rebuildNodes
Bug: T294918
Bug: T298106
Change-Id: I1da12be2ba952912071d2f7fbde1d0854f82fb6d
It's not a getter, but a generator. I found the name confusing.
Getters typically don't return something different every time you
call them.
Change-Id: I6eeab8b6a8644e430003f6e1ad77ab4b28e0d8c9
