wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Use new wikipage.watchlistChange hook"

Browse source
This commit is contained in:
jenkins-bot 2022-01-10 22:42:17 +00:00 committed by Gerrit Code Review
parent ccb74dc828 3800daf354
commit b92f414e23
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
View file

@ -354,10 +354,11 @@ ve.init.mw.DesktopArticleTarget.prototype.loadSuccess = function () {
/**
* Handle the watch button being toggled on/off.
*
* @param {jQuery.Event} e Event object which triggered the event
* @param {string} actionPerformed 'watch' or 'unwatch'
* @param {boolean} isWatched
* @param {string} expiry
* @param {string} expirySelected
*/
ve.init.mw.DesktopArticleTarget.prototype.onWatchToggle = function ( e, actionPerformed ) {
ve.init.mw.DesktopArticleTarget.prototype.onWatchToggle = function ( isWatched ) {
if ( !this.active && !this.activating ) {
return;
}
@ -365,7 +366,7 @@ ve.init.mw.DesktopArticleTarget.prototype.onWatchToggle = function ( e, actionPe
this.checkboxesByName.wpWatchthis.setSelected(
!!mw.user.options.get( 'watchdefault' ) ||
( !!mw.user.options.get( 'watchcreations' ) && !this.pageExists ) ||
actionPerformed === 'watch'
isWatched
);
}
};
@ -376,7 +377,7 @@ ve.init.mw.DesktopArticleTarget.prototype.onWatchToggle = function ( e, actionPe
ve.init.mw.DesktopArticleTarget.prototype.bindHandlers = function () {
ve.init.mw.DesktopArticleTarget.super.prototype.bindHandlers.call( this );
if ( this.onWatchToggleHandler ) {
$( '#ca-watch, #ca-unwatch' ).on( 'watchpage.mw', this.onWatchToggleHandler );
mw.hook( 'wikipage.watchlistChange' ).add( this.onWatchToggleHandler );
}
};
@ -386,7 +387,7 @@ ve.init.mw.DesktopArticleTarget.prototype.bindHandlers = function () {
ve.init.mw.DesktopArticleTarget.prototype.unbindHandlers = function () {
ve.init.mw.DesktopArticleTarget.super.prototype.unbindHandlers.call( this );
if ( this.onWatchToggleHandler ) {
$( '#ca-watch, #ca-unwatch' ).off( 'watchpage.mw', this.onWatchToggleHandler );
mw.hook( 'wikipage.watchlistChange' ).remove( this.onWatchToggleHandler );
}
};
@ -924,9 +925,7 @@ ve.init.mw.DesktopArticleTarget.prototype.saveComplete = function ( data ) {
var watch = require( 'mediawiki.page.watch.ajax' );
watch.updateWatchLink(
$( '#ca-watch a, #ca-unwatch a' ),
data.watched ? 'unwatch' : 'watch',
'idle',
data.watched,
data.watchlistexpiry
);
}