wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Reuse touched-content logic"

Browse source
This commit is contained in:
jenkins-bot 2022-01-12 08:34:09 +00:00 committed by Gerrit Code Review
parent 328763526e 28e706b3dd
commit 1dbfad3503
1 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
View file

@ -81,11 +81,11 @@ ve.ui.MWTemplateDialog.prototype.getReadyProcess = function ( data ) {
};
/**
* Called when the transclusion model changes. E.g. parts changes, parameter values changes.
* Update dialog actions whenever the content changes.
*
* @private
*/
ve.ui.MWTemplateDialog.prototype.onTransclusionModelChange = function () {
ve.ui.MWTemplateDialog.prototype.touch = function () {
if ( this.loaded ) {
this.altered = true;
this.setApplicableStatus();
@ -171,13 +171,11 @@ ve.ui.MWTemplateDialog.prototype.onReplacePart = function ( removed, added ) {
if ( reselect ) {
this.focusPart( reselect );
}
if ( added || removed ) {
this.altered = true;
}
}
this.setApplicableStatus();
if ( added || removed ) {
this.touch();
}
this.updateTitle();
};
@ -230,8 +228,7 @@ ve.ui.MWTemplateDialog.prototype.onAddParameter = function ( param ) {
page.scrollElementIntoView();
}
this.altered = true;
this.setApplicableStatus();
this.touch();
if ( page instanceof ve.ui.MWParameterPage ) {
page.updateSize();
@ -258,10 +255,7 @@ ve.ui.MWTemplateDialog.prototype.onRemoveParameter = function ( param ) {
this.bookletLayout.stackLayout.unsetCurrentItem();
this.bookletLayout.removePages( [ page ] );
if ( this.loaded ) {
this.altered = true;
this.setApplicableStatus();
}
this.touch();
};
/**
@ -483,7 +477,7 @@ ve.ui.MWTemplateDialog.prototype.getSetupProcess = function ( data ) {
// Events
this.transclusionModel.connect( this, {
replace: 'onReplacePart',
change: 'onTransclusionModelChange'
change: 'touch'
} );
// Detach the form while building for performance