Wikia has done some work on the template user experience, including
automatically showing all available parameters without the use of
TemplateData. In order to make our changes, we had to make some changes
to VE-MW.
ve.dm.MWTransclusionModel.js
* this.specCache is created so subclasses can reference it.
* Promise handlers in the fetch() method have been broken out as class
methods so they can be overridden in subclasses.
ve.ui.MWTemplateDialog.js
* addPromptedParameters() has been moved to the
initializeNewTemplateParameters() class method so subclasses can
overwrite. In Wikia's implementation, we have a method of getting
all parameters and a dialog that shows all of the parameters, so the
request to addPromptedParameters is overwritten.
* Added a done() handler to the transclusionModel promise for Wikia
extensibility.
Change-Id: I073c5850420e7719e82957f879423c2717af674a
Looks like VisualEditor does not allow saving the page, if the changes
to the page were made while the browser did not have focus.
Change-Id: I959bcb4cc2f72237d2ea75249a56e140d4f7c867
Paired-With: Amir Aharoni
Hack to try to kill a class of bugs caused by misbehaving browser plugins.
Unable to test whether this fixes them or not.
Bug: 68900
Bug: 51423
Bug: 51521
Bug: 52791
Bug: 52884
Bug: 53252
Bug: 61776
Bug: 63121
Bug: 63229
Change-Id: I8af9f7ba4be45b42f6e2e382ff1a3e1f452058ba
Now that we use staging in the meta dialog, the following
sequence is possible:
* Add Category:Foo in UI (adds to DM and adds a widget)
* Remove Category:Foo in UI (removes from DM, removes widget)
* Click Cancel to leave meta dialog
** popStaging()
*** Undo removal of Foo (adds to DM, does not add a widget)
*** Undo addition of Foo (removes from DM, tries to remove nonexistent widget)
Add a check so trying to remove an already-removed widget
doesn't cause a JS error.
Bug: 71471
Change-Id: I34690364ce302b858e2a4429dbb97b57d39aae5f
New changes:
28ebb29 ve.ui.CommentInspector.css: Fix documentation
b3b3b11 Followup a618491: fix JS errors when slugging near annotated inline nodes
b987d63 Record and show observation times in ve.Filibuster
60ac437 ve.ui.FragmentInspector: Remove #setDimensions
9f4a067 ve.ui.CommentInspector.js: Fix documentation
0677c3b Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's
Change-Id: I1f3c9d3e81eea9d380b2e2aa5deb9fdbf0ca9c93
Just hide them when opening the editor and show again afterwards. Will
need Parsoid for proper support.
Corresponding patch in core: I2389ff9a5332a2b1d033eb75f0946e5241cfaaf4.
Bug: 23796
Change-Id: I3ce5e7869be50dcd189ca24e2b3d7ebc62de4fc4
New changes:
b9bd135 Fix getUsedStoreValues and allow a range to be passed
33f4026 Update OOjs UI to v0.1.0-pre (98e770ce46)
c78efc5 DesktopContext: Ensure that inspectors/menus are fully visible when created
1dff977 ve.ui.DesktopContext: Fix comment typo
3aafc81 Localisation updates from https://translatewiki.net.
Change-Id: Icba3f7bb3916be19832387e3ef541613a78bdda8
New changes:
4ad56e9 Be more cautious about placing the cursor
b39c9e2 Fix some getSelectionRects edge cases
cbb4197 Don't perform focus node native selection trick while dragging
817ef5f Follow-up I99acd6c6: More files' header comment fixes
d28aacb Localisation updates from https://translatewiki.net.
Change-Id: I42ba31b3428d98695c5a51d194cf972d649fef48
* Add type hints
* Use $skin->msg instead of wfMessage where available
* Minor doc fixes
* Use Title::inNamespace()
Change-Id: I406a0a40e785947fbdc09707597ccf9c50d6f9be
Fixes Icb62b9b2. I have no idea how I managed to screw this up.
Was also causing an error in console when one of the categories was a redirect
Change-Id: I0321c8be1386cb010c3babb33e08fae0fcaf75ce
This doesn't happen in real life (as resource is always set) but
it allows us to contruct these nodes from the factory with no data.
Change-Id: Iea146f5dc128ad9d0f36a79b6fe67d622767d46c
