Commit graph

18507 commits

Author SHA1 Message Date
jenkins-bot 1dbfad3503 Merge "Reuse touched-content logic" 2022-01-12 08:34:09 +00:00
Translation updater bot 328763526e Localisation updates from https://translatewiki.net.
Change-Id: Idf59385ca3e56b7144b3314d7ecfee927a9cc12b
2022-01-12 08:25:52 +01:00
Ed Sanders c0f3fc3a78 Pass visibleSection & visibleSectionOffset to target
* Find the first section below the top of the viewport
  (usually visible) and measure its offset.
* After loading the editor, ensure this heading is still
  at the same position on the page.

Bug: T296910
Change-Id: I9a05ea74ba3c19a4a91ddc1bc0afe311851c53e6
2022-01-11 20:39:27 +00:00
jenkins-bot e1b9e6a98e Merge "Watchlist API update: Call correct method" 2022-01-11 18:41:49 +00:00
Ed Sanders aea22d546e Watchlist API update: Call correct method
We changed the arguments, but not the function name.

Change-Id: Ic7b36f666ead57bc62aa6e40e148821ea267ee80
2022-01-11 18:21:12 +00:00
jenkins-bot 11ff2c8452 Merge "Update VE core submodule to master (f06e0ff04)" 2022-01-11 18:15:53 +00:00
jenkins-bot 9b659687c7 Merge "Introduce ArticleTarget#afterSurfaceReady" 2022-01-11 18:11:50 +00:00
jenkins-bot 4f9f14f383 Merge "Replace confirmation overlay with a popup dialog" 2022-01-11 17:59:48 +00:00
Bartosz Dziewoński 37a2a77cc4 Update VE core submodule to master (f06e0ff04)
New changes:
f06e0ff04 Initialise toolbar height to 0

Change-Id: I97b936f9a42bd3b2f8b3b1e2ea52c0cda43f6ecb
2022-01-11 18:42:37 +01:00
Adam Wight 28e706b3dd Reuse touched-content logic
Without changing behavior, consolidate the logic for detecting
whether the editor has made changes to the template.  This is
responsible for enabling and disabling the "Apply changes" button.

Change-Id: Ic4755b13f30fb738a7cb1eebaddef0435ea61d34
2022-01-11 17:39:22 +00:00
Adam Wight cbe2fd634f Replace confirmation overlay with a popup dialog
Currently, the insert template dialog includes a back button in the
upper corner.  Confirmation of abandoning unsaved changes was
accomplished in an overlay panel.  This patch rewrites as a dialog
and updates the on-screen text.

Bug: T297792
Change-Id: Ifa2ff97c9284609ee2a784f455789c56a762ba50
2022-01-11 18:37:29 +01:00
jenkins-bot 83d1211ef6 Merge "Give getUniquePartId method a better name" 2022-01-11 13:31:10 +00:00
Bartosz Dziewoński 67b7b90847 Update VE core submodule to master (6eb23a10f)
New changes:
22f6db516 Fix getViewportRange when section editing
7d948731c Toolbar: Remove unnecessary unfloat() in detach()
2d14351b9 Toolbar: Set toolbar height from $bar when floating, and updating size when switching surface
f18dab62f Improve getViewportRange behaviour around text wrapping
6eb23a10f Try to select a visible offset when focusing a null-selection surface

Bug: T296910
Change-Id: I1265be30bb11076576a32feea7299303f74b197c
2022-01-11 05:07:12 +01:00
Ed Sanders 6c471c5b1e Introduce ArticleTarget#afterSurfaceReady
This method should be called once the surface is visible
and ready to be focused.

Change-Id: I43a1d9cabd59181d2beab8f4a29700d031903c22
2022-01-11 03:33:04 +00:00
Ed Sanders 93df71af77 ArticleTarget#scrollToHeading fixes
* Use this.getElementWindow
* Use this.surface.padding to avoid race condition
  when the toolbar hasn't fully rendered yet.

Change-Id: I055b1d9458d73e435ede6096941a3e72c9c1ce74
2022-01-11 03:32:52 +00:00
Bartosz Dziewoński c5d987b3fc Update VE core submodule to master (2db326345)
New changes:
04bd5c1da Localisation updates from https://translatewiki.net.
4147426da DiffElement: Manually number ordered lists with value attribute
ef3536361 DiffElement refactor: Pass diff objects to renderDiff instead of using state properties
593fe9026 DiffElement refactor: De-duplicate logic inside getNodeElements & wrapNodeData
a7b5eed5f DiffElement refactor: Create an iterateDiff method and unify function signatures
2db326345 Diff some nodes as if they are documents, e.g. <div>s

Bug: T188170
Bug: T298410
Change-Id: I28a048a02c62fb9bb96f29e472767d46c3b45804
2022-01-11 00:28:42 +01:00
jenkins-bot ed77e22e98 Merge "Update skinStyles with new vector skin key." 2022-01-10 23:11:27 +00:00
jenkins-bot b92f414e23 Merge "Use new wikipage.watchlistChange hook" 2022-01-10 22:42:17 +00:00
Clare Ming 1e1638145b Update skinStyles with new vector skin key.
Bug: T292599
Change-Id: I6a2db3012b37e4164e03f3701dc11fa36f2dbf92
2022-01-10 15:38:48 -07:00
Ed Sanders 3800daf354 Use new wikipage.watchlistChange hook
Bug: T294254
Depends-On: I88af8585e8fc75f77ebef867d267199aeb2c6592
Change-Id: I60400124976093060b3b5478c6d7d9e6844cc217
2022-01-10 23:16:41 +01:00
jenkins-bot ccb74dc828 Merge "Enforce formatversion=2 in template search" 2022-01-10 12:57:05 +00:00
Translation updater bot f9bf7d36fa Localisation updates from https://translatewiki.net.
Change-Id: Iec7d3662ebff654a024c55f8cbc4806068c70dd6
2022-01-10 08:11:59 +01:00
jenkins-bot 8886773548 Merge "DiffPage: Only set user pref on 'choose' event" 2022-01-08 01:33:31 +00:00
jenkins-bot 67aad36acb Merge "DiffPage.init: Move and rename some vars" 2022-01-08 01:33:29 +00:00
Bartosz Dziewoński 12cd0fd396 Update VE core submodule to master (bafd926a8)
New changes:
46501f84a Localisation updates from https://translatewiki.net.
2b3f0c029 Update RangeFix to 0.2.10
254a8f359 Tests: Show warning when input to ve.createDocumentFromHtml is unbalanced

Change-Id: I015c6fd980fee754bf907fc6f87f403ca0fa952a
2022-01-08 02:06:39 +01:00
jenkins-bot 451555ac64 Merge "Tests: Fix unbalanced HTML" 2022-01-08 00:26:53 +00:00
Translation updater bot a422bc28a4 Localisation updates from https://translatewiki.net.
Change-Id: I1e0bd111f2038088c893314f1e9af1bf53832f4b
2022-01-07 08:25:40 +01:00
Ed Sanders 40a50cac4a DiffPage: Only set user pref on 'choose' event
This prevents your preference being changed if you just
followed a link with a diffmode parameter.

Change-Id: I755563bde285e95c0367119d49a40e1dd3c5e178
2022-01-06 16:48:02 +00:00
Ed Sanders 302303de46 DiffPage.init: Move and rename some vars
Change-Id: Ibcef23650e6c77d9142055e9e7357ce095ba3b49
2022-01-06 16:47:35 +00:00
Translation updater bot 0521c5e540 Localisation updates from https://translatewiki.net.
Change-Id: I69bb987b0aa7ddb2677f93eb75b22e36c81ce7a3
2022-01-06 08:32:20 +01:00
jenkins-bot 4ceca46c8e Merge "Check for saveDialog in ve.init.mw.DesktopArticleTarget.saveComplete" 2022-01-05 17:23:33 +00:00
Thiemo Kreuz 579cdaa145 Enforce formatversion=2 in template search
This is guaranteed via ve.init.mw.Target.getContentApi(). But the
ContentTranslation extension replaces this, and does not set a
formatversion. See e.g. SectionTranslationTarget.getContentApi().

Bug: T298599
Change-Id: I8768cae3153e9cbc29a8796ec21ef249f80471ed
2022-01-05 12:49:44 +01:00
Translation updater bot 77e6242d85 Localisation updates from https://translatewiki.net.
Change-Id: I7091f85c6babfd867d1d94c2fb4278bd2e652296
2022-01-05 08:16:37 +01:00
mewoph 93d54c701b Check for saveDialog in ve.init.mw.DesktopArticleTarget.saveComplete
In case the save is triggered without the save dialog (for example, when a null edit is made during suggested edits task in GrowthExperiments)

Bug: T298552
Change-Id: Id49b967cfa52d33848e9c911086000fa4501fa7f
2022-01-04 13:35:21 -08:00
Ed Sanders 9e4915d7c3 Tests: Fix unbalanced HTML
Change-Id: I997c68ce33263004b8ae9b686aae7295eec12ea7
2022-01-04 02:01:38 +00:00
Bartosz Dziewoński 3c02dbcc7f Update VE core submodule to master (5b987b34a)
New changes:
6f114fe8c Localisation updates from https://translatewiki.net.
b2dd88142 Localisation updates from https://translatewiki.net.
08d33f872 Localisation updates from https://translatewiki.net.
fb15ab599 DiffElement: Remove unused jlen from loops
5ca7924d5 DiffElement: Remove unused 'doc' argument from compareNodeAttributes
e776c9011 DiffElement tests: Remove wrapper paragraphs from list test input

Change-Id: Ida46a53c566b4b4df085c7e581dc937f2ee2ff75
2022-01-03 19:12:17 +01:00
Translation updater bot 1139a77734 Localisation updates from https://translatewiki.net.
Change-Id: I4d2420846da93f2a8923b9dc5bd3914c71df3bd5
2022-01-03 08:11:54 +01:00
Translation updater bot e2373154d3 Localisation updates from https://translatewiki.net.
Change-Id: I83f3d9c3d4fd3f1395448854c1eeca1914679e43
2021-12-31 09:42:29 +01:00
Translation updater bot 053b3a2b70 Localisation updates from https://translatewiki.net.
Change-Id: I6f8f1f0d1fa9d9fbf5dbb71d8002a1577b43d8df
2021-12-30 09:38:19 +01:00
jenkins-bot a886a5e1b9 Merge "Replace usage of deprecated global function wfReadOnly()" 2021-12-27 13:13:58 +00:00
Translation updater bot 1bf508e2ca Localisation updates from https://translatewiki.net.
Change-Id: Iab9a565ab972b74d2f06fa3c9da1f51e82c679de
2021-12-27 09:31:19 +01:00
Alexander Vorwerk 61e0094574 Replace usage of deprecated global function wfReadOnly()
The global function wfReadOnly() has been deprecated in favor of the
new ReadOnlyMode service. Its usages should be replaced.

Bug: T283978
Change-Id: I26a878f19be5c90dab04e28ce395cb8f6dddebef
2021-12-26 14:23:42 +01:00
Translation updater bot 63dfd2492a Localisation updates from https://translatewiki.net.
Change-Id: Ic393105b2217dda422df819c1c4f276c5225e2fb
2021-12-23 08:38:43 +01:00
Bartosz Dziewoński ea4808552d Update VE core submodule to master (2143a90a7)
New changes:
26ba8a561 Store internal list counter in new document storage and persist
75661d69f Drop support for fallback createDocumentFromHtml methods
2143a90a7 ve.dm.Document: Remove rebuildNodes

Bug: T294918
Bug: T298106
Change-Id: I1da12be2ba952912071d2f7fbde1d0854f82fb6d
2021-12-22 23:51:56 +01:00
Thiemo Kreuz 454dc53126 Give getUniquePartId method a better name
It's not a getter, but a generator. I found the name confusing.
Getters typically don't return something different every time you
call them.

Change-Id: I6eeab8b6a8644e430003f6e1ad77ab4b28e0d8c9
2021-12-22 13:03:01 +01:00
Translation updater bot 435d3727dc Localisation updates from https://translatewiki.net.
Change-Id: I524c34f4a3df5ccfd8bfdece8684caabfa12adc5
2021-12-22 08:34:41 +01:00
Bartosz Dziewoński 8cf9039b9f Update VE core submodule to master (4b2339f6e)
New changes:
8859b6a7c List diff: Improve handling of complex changes
fba7ecd4a List diff: Add descriptions for list item indent/outdent
4b2339f6e List diff: Fix display of list node attribute change (e.g. bullet->numbered)

Local changes:
* Add new localisation messages

Bug: T298002
Bug: T298012
Change-Id: I0a7614b48ebc970233ae72a5404751f07b0e03b0
2021-12-21 20:24:26 +01:00
Bartosz Dziewoński c9d8c6f90b Update VE core submodule to master (9df59571b)
New changes:
abd4e7423 ve.ce.Surface.test: Move var declarations inline
d4e08cb5c Increase specificity of source mode paragraph margin rule
7ca52e3f7 Converter: Cache whitespace regexes
7f7fbc555 Follow-up I0f5a01e3d: Update unicodeJS readme and headers
6567612db Tests: Move var declarations inline

Bug: T287733
Change-Id: I3dabc5db58da23af9fda3a44bebfe669765d19b1
2021-12-20 22:29:07 +00:00
Bartosz Dziewoński 011277f757 ApiVisualEditorEdit: Fix Phan build failure
Caused by cbfcf9e8a8b2d5aaef78d8900c2e373d350eba02 in MediaWiki core.

Change-Id: I251f44faa46376ecde49c87ccff65025f56ab7e8
2021-12-20 23:26:44 +01:00
Ed Sanders 1c6dbf433f Remove more DOM garbage introduced by 'Web of Trust' extension
Bug: T297862
Change-Id: Ib6efe0c4ea68a1b17efd37839cec428dc9ebf6b7
2021-12-20 17:54:20 +00:00