Commit graph

2154 commits

Author SHA1 Message Date
Aaron Schulz 2a0e98e9a9 Reduce CAS errors in ApiEchoMarkSeen
* These tend to log errors many times in a row for the same few
  users in any given time period. There is probably some usage
  pattern issue in JS on top of the abuse of preferences for
  such tracking state. In any case, this should help.

Bug: T95839
Change-Id: I4d57b1db43a63300a412a5de220b66081da754f1
2015-08-11 19:18:45 +00:00
Kunal Mehta 92da0124d0 Only require event type to construct a formatter
Push the $wgEchoNotifications dependency to
NotificationFormatter::factory(), and only catch exceptions we're
actually expecting (NotificationFormatter::format()).

And clean up the logging to use structured logging while we're at it.

Change-Id: I7e18c318c5c81b6a38e55f27ef8f604654f10858
2015-08-10 11:27:52 -07:00
Translation updater bot 4082868601 Localisation updates from https://translatewiki.net.
Change-Id: I8dad2531b3a253395afa43a47b4df91360486bfa
2015-08-09 20:46:24 +02:00
Translation updater bot d6b03824f0 Localisation updates from https://translatewiki.net.
Change-Id: I46499a39ef0e0299048618cc89e11acde8616f13
2015-08-08 21:12:47 +02:00
addshore a9be7abfbe Remove use of deprecated TestUser->user
Change-Id: I9b3e048f01551cffb6848410fa9515201cbb2d1f
2015-08-07 17:04:59 +01:00
Kunal Mehta d072a9a47b Add some type-hinting and doc fixes
And remove some useless code as well.

Change-Id: I97a2ca08a1d4ef0b59535c1c002840f108defe4a
2015-08-06 15:36:05 -07:00
Translation updater bot a1b482af33 Localisation updates from https://translatewiki.net.
Change-Id: I300adc0e166058c1f5de486089581791e0f2de8e
2015-08-06 21:36:19 +02:00
jenkins-bot 1fcc45920c Merge "Refactor and unify icon URL logic" 2015-08-06 04:22:24 +00:00
Kunal Mehta 5e2da7627b Refactor and unify icon URL logic
The logic to get the URL for an icon was duplicated in the
EmailFormatter and BasicFormatter. It is now in the abstract
NotificationFormatter, which EmailFormatter and BasicFormatter now
use.

Changes in logic:
* Throw an exception if an invalid notification type is provided instead
of a PHP notice
* icons using 'url' may have different ltr/rtl icons
* Throw exception if icon is supposed to have different icons for
ltr/rtl, but doesn't, instead of debug logging

The new function is static so it can be used in EmailFormatter as it
does not inherit from NotificationFormatter.

Bug: T60726
Change-Id: Ia3c01c35f58eed8cc2c039249ab1ec1a80a8abbb
2015-08-06 04:17:14 +00:00
Translation updater bot c25709432f Localisation updates from https://translatewiki.net.
Change-Id: Ie0ce67ca2822f27b97a29d574af08bb79186619f
2015-08-05 22:34:26 +02:00
Translation updater bot b284d25ab3 Localisation updates from https://translatewiki.net.
Change-Id: I7d3ba255c318a8091d56c6b383127ac1f9cb6fc8
2015-08-03 22:03:47 +02:00
Translation updater bot 84fdb93c92 Localisation updates from https://translatewiki.net.
Change-Id: I068050c2036ef8ddc23b6c601eb7a0ad434ec9a1
2015-08-02 21:51:51 +02:00
Translation updater bot 2181c4743d Localisation updates from https://translatewiki.net.
Change-Id: Ia15e46461ce2b74361075f88aec828659dec01d3
2015-08-01 21:46:49 +02:00
jenkins-bot 8fda0c0568 Merge "Fix more "the job queue can run against different wikis"" 2015-07-31 23:38:43 +00:00
Translation updater bot 29485b3985 Merge "Localisation updates from https://translatewiki.net." 2015-07-31 19:58:16 +00:00
jenkins-bot 3bed04ee7f Merge "Remove useless and misleading comment" 2015-07-31 19:54:19 +00:00
Translation updater bot c58e934ce6 Localisation updates from https://translatewiki.net.
Change-Id: Icb3c4b2584e45a84b31d36b1ad7b818cf6abe078
2015-07-31 21:47:11 +02:00
Stephane Bisson f6bef9d159 Remove useless and misleading comment
Change-Id: Id4d2f908f3fdf4a37f3e5a1ddc6b205db745802e
2015-07-31 15:46:53 -04:00
Stephane Bisson 8ea150809b Fix usage of UserMailer::Send to use new signature
Change-Id: I41aba8a2d5381df9845eb31c0d1d63ee9834acec
2015-07-31 15:45:57 -04:00
Kunal Mehta 410271897c Fix more "the job queue can run against different wikis"
It doesn't.

Change-Id: Ia3f7b459ddcbabf525bde2e1489dc9379a0a7ef5
2015-07-31 12:19:53 -07:00
Translation updater bot 48bb0ffedb Localisation updates from https://translatewiki.net.
Change-Id: I31b602f6ec2a66002d8d7054a7d08a9b6ad7bc4a
2015-07-30 21:10:39 +02:00
Translation updater bot 73e4e075b3 Localisation updates from https://translatewiki.net.
Change-Id: Ice0f437d00331a26d29e87f6840aedb0db34a3df
2015-07-29 21:48:54 +02:00
Matthew Flaschen 261009fe62 More detailed Echo description
This shows up at e.g. Special:Version.

Bug: T106211
Change-Id: I438b2cc30ba926daef871edff98da9ce549253f3
2015-07-29 01:58:15 -04:00
Translation updater bot e731874360 Localisation updates from https://translatewiki.net.
Change-Id: I5843e52c8d91d2dc5798292f7705a43fe563c113
2015-07-28 21:48:28 +02:00
Translation updater bot a49a6f383f Localisation updates from https://translatewiki.net.
Change-Id: I8e3d5c3e93be9b6687b8511cbee7c24eacad8bf1
2015-07-27 21:34:44 +02:00
Translation updater bot de0fe5b624 Localisation updates from https://translatewiki.net.
Change-Id: Ide9d2700ce7433dc3178355a17f94a659f4a57f0
2015-07-26 21:39:02 +02:00
Translation updater bot b7a246a92f Localisation updates from https://translatewiki.net.
Change-Id: Id31e3d19c3f91376fa279812011333fa89888165
2015-07-24 21:06:37 +02:00
jenkins-bot 04468b5dc1 Merge "Avoid an extra memcached lookup in MWEchoNotifUser::getNotificationCount()" 2015-07-21 22:05:33 +00:00
jenkins-bot c13811ee94 Merge "ApiEchoMarkRead: Remove unused variable" 2015-07-21 22:05:29 +00:00
Kunal Mehta 6515e1fd65 Avoid an extra memcached lookup in MWEchoNotifUser::getNotificationCount()
Change-Id: I32eb79beb494710c35b175f2dc15af42bdad61d7
2015-07-21 14:19:12 -07:00
Kunal Mehta e4d3b7e9fa ApiEchoMarkRead: Remove unused variable
Skips two(!) useless memcached lookups.

Change-Id: I6961e736a7ddf72478bdc6e684f5ebb9824560de
2015-07-21 14:16:06 -07:00
Translation updater bot d905966422 Localisation updates from https://translatewiki.net.
Change-Id: Ic95ee34bf2eea1e10b8916e05a0599e8240f5543
2015-07-21 21:43:54 +02:00
Translation updater bot fa8d725e49 Localisation updates from https://translatewiki.net.
Change-Id: Ic59ca078ad2342e8913986ac847aecb4bc779eb8
2015-07-20 21:54:08 +02:00
Translation updater bot 992e6d33e4 Localisation updates from https://translatewiki.net.
Change-Id: I383c72c9f2ddb2ce41aa062e27c8f854b41d9e13
2015-07-17 22:18:18 +02:00
Translation updater bot f9cd68d9dd Localisation updates from https://translatewiki.net.
Change-Id: If81fac87e23ba5e7aa3366274d951d6729f2a2da
2015-07-16 21:11:38 +02:00
Translation updater bot bccc995692 Localisation updates from https://translatewiki.net.
Change-Id: I7f3a56710473c902476c59130576c8d3137612f8
2015-07-15 21:39:11 +02:00
Translation updater bot 9470229ea6 Localisation updates from https://translatewiki.net.
Change-Id: I0356898c5a28494ef67a7809dbfbce4824fadef3
2015-07-14 22:00:29 +02:00
Translation updater bot 4bf19c8287 Localisation updates from https://translatewiki.net.
Change-Id: I544466d0aa921b9716a0a34ab3c864d389a6989a
2015-07-13 21:34:27 +02:00
Translation updater bot 80c6a7d5ba Localisation updates from https://translatewiki.net.
Change-Id: I18582de30e37c13192ddc400eb5af71374f60602
2015-07-12 21:46:12 +02:00
Translation updater bot b77ca32b65 Localisation updates from https://translatewiki.net.
Change-Id: I1ebb6f311cd90fba3b6f4dd052b273c1b21d52a4
2015-07-11 22:05:10 +02:00
Translation updater bot f73d5af3e1 Localisation updates from https://translatewiki.net.
Change-Id: I645d26cdc3164713cf1d81857ba04b9b393dafe8
2015-07-10 21:13:44 +02:00
jenkins-bot 47021a9080 Merge "Load only the EchoInteraction schema client-side" 2015-07-09 06:31:31 +00:00
Kunal Mehta 064c1f1514 Load only the EchoInteraction schema client-side
The other schemas are not used client-side, just server-side.

Bug: T105220
Change-Id: I5e5e7b01998cee38693c9f5e22da6e86a5e13e96
2015-07-08 13:17:35 -07:00
Translation updater bot 4dc4cc059e Localisation updates from https://translatewiki.net.
Change-Id: I90f4a70b266e5be6eec2da94e96cfe26d2ee9d78
2015-07-08 21:53:59 +02:00
jenkins-bot aab214bc6a Merge "Userlogin is canonical name, not UserLogin" 2015-07-08 09:31:34 +00:00
Niklas Laxström 81f8df2249 Userlogin is canonical name, not UserLogin
Fixes: PHP Notice:  Found alias defined for Userlogin when
searching for special page aliases for UserLogin.

Change-Id: Ib64d4c76d3915ae752a9c56eb9635653e0da5623
2015-07-08 11:26:27 +02:00
Kunal Mehta 4d8b977ff9 Get rid of disabled 'echo-notify-show-link' preference
This preference has been disabled since bug 47562, and doesn't make
sense to keep around given that the flyout is the main interaction most
users have with Echo.

Change-Id: I7e8ddf96dbde9a95ac01a0cc83bad396151d01bd
2015-07-07 17:10:49 -07:00
Translation updater bot 09643dc7b4 Localisation updates from https://translatewiki.net.
Change-Id: If90b5c8639a20caf8312f2890f2b2fa5bfa2a5f6
2015-07-07 22:07:56 +02:00
jenkins-bot 95a6f459c5 Merge "Add test case to demonstrate T68512 is fixed" 2015-07-07 19:18:43 +00:00
Kunal Mehta bce9dbab18 Link to localized Special:Notifications in overlay footer
Re-use the localized link from the badge.

Bug: T59350
Change-Id: I4b859a07b253894ac776519971cc130548350321
2015-07-06 17:57:59 -07:00