wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-25 00:05:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
6069 commits 164 branches 0 tags 74 MiB
Commit graph

6069 commits

This branch
This branch
All branches
Author SHA1 Message Date
Matěj Suchánek e30b466d9c Fix variable choice in NotificationController::notify 
I believe this is a bug. Individual user's option ($userNotifyTypes)
should not influence the options for all users ($notifyTypes).

This piece of code was first introduced in
I51600bbb26594323831d22bc35d34587ff146d47.

Change-Id: I32d56891ac68e82734813280505b4a57d5427f8c
 2021-07-28 13:13:00 +02:00
jenkins-bot 9e9303221e Merge "SpecialDisplayNotificationsConfiguration: Fix default values of core prefs" 2021-07-27 18:32:19 +00:00
jenkins-bot 0364d96af3 Merge "SpecialDisplayNotificationsConfiguration: Use OOUI checkboxes" 2021-07-27 18:32:18 +00:00
Bartosz Dziewoński 0341634e45 SpecialDisplayNotificationsConfiguration: Fix default values of core prefs 
Some of Echo's subscription user preferences are mapped to existing
user preferences defined in core MediaWiki. However, this special page
was checking the Echo preference names, returning incorrect values.

This affected the edit-user-talk preference and watchlist preferences
(not available with the default configuration).

Change-Id: I2de7553f82434505c000c30a71b9f90c4490482b
 2021-07-27 19:53:58 +02:00
Bartosz Dziewoński b826dd263c SpecialDisplayNotificationsConfiguration: Use OOUI checkboxes 
On some systems, when they are disabled, checked and unchecked
checkboxes are not that easy to distinguish. They're really bad
for me on Windows (apparently a bit less bad on macOS).
https://phabricator.wikimedia.org/F34567120

OOUI checkboxes are clearer (since they're bigger and the
check icon has higher contrast against the background).
https://phabricator.wikimedia.org/F34567121

Change-Id: I124c7e1874d50d5f3883ffcc5264da46ae012e0a
 2021-07-27 19:33:30 +02:00
Translation updater bot 2ed45e91c2 Localisation updates from https://translatewiki.net. 
Change-Id: I70a23d2b7c8d2f7d39e912fb1f35d6124167f614
 2021-07-27 08:13:21 +02:00
DannyS712 4cc8233ee5 DiscussionParser: fetch UserNameUtils service outside of loop 
Change-Id: I6c523dcc2ca1e06136f2f5ad18c0ac371c7f9494
 2021-07-26 09:40:49 +00:00
Translation updater bot a0636f75a7 Localisation updates from https://translatewiki.net. 
Change-Id: I1e1c731baee92a8b3e83599df70cc941db91e843
 2021-07-26 08:12:07 +02:00
DannyS712 f13dd018c7 Enable and fix ReturnTypeDeclaration sniff 
Libup decided to disable the sniff, fix the issues instead

Change-Id: Ibac1c3f32af19edff3f428928efe578d97061b07
 2021-07-24 04:36:30 +00:00
libraryupgrader 17a644263a build: Updating dependencies 
composer:
* mediawiki/mediawiki-codesniffer: 36.0.0 → 37.0.0
  The following sniffs are failing and were disabled:
  * PSR12.Functions.ReturnTypeDeclaration.SpaceBeforeReturnType

npm:
* svgo: 2.3.0 → 2.3.1
  * https://npmjs.com/advisories/1754 (CVE-2021-33587)
* postcss: 7.0.35 → 7.0.36
  * https://npmjs.com/advisories/1693 (CVE-2021-23368)
* trim-newlines: 3.0.0 → 3.0.1
  * https://npmjs.com/advisories/1753 (CVE-2021-33623)

Change-Id: Id866782d39ac02a329bd79539f2d52392fffd296
 2021-07-24 01:48:06 +00:00
bwang a64b97a620 Override opacity styles for all read badges for vector user links 
- Addresses this issue https://phabricator.wikimedia.org/T285259#7231489

Bug: T285259
Change-Id: I58345c84efa129aae56c5ae1be3bcf5117589647
 2021-07-23 14:47:14 +00:00
jdlrobson b4ec1eda88 Fix display of user messages orange bar 
The icon in Vector is copied across when Vector is loaded before
Echo in LocalSettings.php

Change-Id: Ida8c78e5c723f9628928f0293f43b2d67616888f
 2021-07-22 13:21:53 -07:00
jenkins-bot e8430bd44a Merge "Update vector badge styles" 2021-07-22 17:59:38 +00:00
bwang b0aaa2e4ec Update vector badge styles 
- Override echo icon styles for modern vector
- Reverts https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/704862

Bug: T285259
Change-Id: Id71d3e248dc6d0ee24278e0ecfbcf8691e1da24b
 2021-07-22 11:53:36 -05:00
Petr Pchelko a10b0b07c8 Use CentralIdLookupFactory and pass UserIdentity 
Change-Id: I44144df7cf244eb867c1b261c10cc29b020f8409
 2021-07-21 19:23:42 -07:00
Bartosz Dziewoński 8823aa15cd Fix Phan failure in backfillUnreadWikis 
Phan says:
maintenance/backfillUnreadWikis.php:51 PhanTypeMismatchArgumentNullable Argument 1 ($userIdentity) is $lookup->localUserFromCentralId($row->euw_user, CentralIdLookup::AUDIENCE_RAW) of type ?\MediaWiki\DAO\WikiAwareEntity|?\MediaWiki\User\UserIdentity but \MediaWiki\User\UserFactory::newFromUserIdentity() takes \MediaWiki\User\UserIdentity defined at ../../includes/user/UserFactory.php:166 (expected type to be non-nullable)

Follow-up to 64531785a6.

Change-Id: I261e87d16bc23e9f1b5d3385553c5899632c9127
 2021-07-21 21:04:47 +02:00
Translation updater bot 961293c192 Localisation updates from https://translatewiki.net. 
Change-Id: I58f10c9296fa402ce346df15da1e22813b122fa9
 2021-07-20 08:20:30 +02:00
jenkins-bot d38cacd581 Merge "Prepare for CentralIdLookup returning UserIdentity" 2021-07-19 15:28:44 +00:00
Translation updater bot 847ca35eb6 Localisation updates from https://translatewiki.net. 
Change-Id: I35fb94ac99332d9c3a8860a511d0f1bb758dc3b2
 2021-07-19 08:15:39 +02:00
Matěj Suchánek 3f05f8a71b Drop unused property and inject a service to SpecialDisplayNotificationsConfiguration 
Change-Id: I0f238b863638245eef381e540da7d610d01bd25b
 2021-07-17 10:40:45 +00:00
jenkins-bot a6dbadb006 Merge "Avoid using User::setOption()" 2021-07-17 10:29:45 +00:00
ZabeMath 3befbe0a69 Avoid using User::setOption() 
User::setOption() is deprecated and should be replaced with UserOptionsManager::setOption()

Bug: T277818
Change-Id: I001301fb95635c421a0bbb921fd909c5312dc896
 2021-07-17 09:52:53 +00:00
jenkins-bot 31b5c6a526 Merge "Add icon property to echo link data for modern Vector" 2021-07-16 19:15:46 +00:00
bwang fbde7bd61b Add icon property to echo link data for modern Vector 
Bug: T285259
Change-Id: I995f877a6e8574a519aedece31e7889b9735366a
 2021-07-16 15:05:29 +00:00
Translation updater bot 8cb1c60547 Localisation updates from https://translatewiki.net. 
Change-Id: I090eea8fc6b8edd2ee8663e2f791f32fb1ffa5d1
 2021-07-16 08:43:26 +02:00
jenkins-bot cadd47489a Merge "Remove use of global $wgUser" 2021-07-15 04:06:56 +00:00
Translation updater bot 2523b82598 Localisation updates from https://translatewiki.net. 
Change-Id: I753f5f45b69b276bcb7324ec5dc1757779d28056
 2021-07-14 08:02:48 +02:00
DannyS712 3269afae8e Remove use of global $wgUser 
This partially reverts commit 83a181ce9c
and fully reverts 82896eff62

To avoid regressing to the errors from T139665, check if the user
retrieved from RequestContext::getMain()->getUser() is safe to load
instead of $wgUser, still in addition to the other checks that
EchoForeignWikiRequest::$user is safe to load.

Bug: T243732
Change-Id: I22c4918fc7e8b3d1364a95de3958c055059971b8
 2021-07-14 04:57:34 +00:00
jenkins-bot 9cf347019b Merge "Add DS_Store to gitignore" 2021-07-13 21:44:19 +00:00
jenkins-bot fa8331294b Merge "Hardcode talk alert id to be pt-talk-alert" 2021-07-13 19:42:47 +00:00
bwang eefea58979 Add DS_Store to gitignore 
Change-Id: Ied30753510ae46a4710d319e4f7815ce85829e39
 2021-07-13 13:58:44 -05:00
bwang 2bf4047410 Hardcode talk alert id to be pt-talk-alert 
Bug: T285442
Change-Id: I3b46a494682b3b5055f525c0c1219a1710655ce5
 2021-07-13 13:58:06 -05:00
jenkins-bot bfcbfff6f6 Merge "Drop DB patches from pre MW 1.26" 2021-07-13 13:52:27 +00:00
Translation updater bot 57def66cd5 Localisation updates from https://translatewiki.net. 
Change-Id: I7b0ec7c3a740d0c894a1a32f65b1c665e91dccb4
 2021-07-13 08:11:39 +02:00
jenkins-bot 7cb32579c7 Merge "Simplify code for detecting rollbacks" 2021-07-12 23:04:20 +00:00
jenkins-bot 98d7428837 Merge "Avoid using ContentHandler::getContentText()" 2021-07-12 14:22:05 +00:00
Translation updater bot fb853419ec Localisation updates from https://translatewiki.net. 
Change-Id: I54a1df4355a405a019f7c1c8fb941ebb4db17e23
 2021-07-12 08:06:23 +02:00
Translation updater bot 742da14e75 Localisation updates from https://translatewiki.net. 
Change-Id: Ic0578bab45c5d63eb258d2906d9d818a7ee7c7de
 2021-07-07 08:07:52 +02:00
Translation updater bot c456d8e80f Localisation updates from https://translatewiki.net. 
Change-Id: I8b99ccb3e47aa4adcb3f22f387b787ba5f789d39
 2021-07-06 08:38:24 +02:00
Translation updater bot e2fd0ddf62 Localisation updates from https://translatewiki.net. 
Change-Id: I8d6aa0eb1b6a23484968b9223ed8a306da8f7967
 2021-07-05 08:06:48 +02:00
Petr Pchelko 64531785a6 Prepare for CentralIdLookup returning UserIdentity 
Needed-By: I67bf4f2442269b8aa1002868ede9a71a5ca43a84
Change-Id: I4c2170a25ea8b1cf5410a4648ebec66a3ab253f3
 2021-07-02 09:12:20 -07:00
Translation updater bot 590a7d502e Localisation updates from https://translatewiki.net. 
Change-Id: I1c5027009d820331adc83d8574d094119a51b990
 2021-07-02 08:31:08 +02:00
mbsantos 2f21c2649e push: document description of topic parameter 
Bug: T285573
Change-Id: I875681ca3bdfe006d68b15f3cffc0089c9677ef1
 2021-07-01 16:10:00 +02:00
Translation updater bot 3ec28cda42 Localisation updates from https://translatewiki.net. 
Change-Id: I4d9790170a4947f6e59a1a782a7f6a418a427730
 2021-06-30 08:26:03 +02:00
jenkins-bot 31d115e9f3 Merge "Remove probably outdated error suppression" 2021-06-29 17:49:35 +00:00
Matěj Suchánek 4b4954ac40 Remove probably outdated error suppression 
https://bugs.php.net/bug.php?id=50688 was closed as fixed
in 2017 when PHP 7.0 was only supported upstream.
We already require PHP 7.2.

Change-Id: Ie9801e38915da634e31c91ebdcb61226e0ae5712
 2021-06-29 17:29:23 +02:00
DannyS712 0099c45e54 AttributeManager: accept UserIdentity objects 
Inject a UserOptionsLookup to replace deprecated
User::getOption()

Change-Id: I177f6d3486f987073e5d745077f0abfe9ae85aca
 2021-06-29 06:41:47 +00:00
DannyS712 66a290500c EventLogging: accept UserIdentity objects 
Replace User::getEditCount with UserEditTracker service

Change-Id: Idcf98dc6b1e88f9301b731b1d8296f613464a364
 2021-06-29 06:12:59 +00:00
DannyS712 2e1757eaaf NotificationMapper: accept UserIdentity objects 
No need for a full User, only the user's id is retrieved

Change-Id: Ibf4005c83d66d846b7e1ab711cd135c9ae08964a
 2021-06-29 05:53:41 +00:00
jenkins-bot 39afffb297 Merge "Use WikiPage::doUserEditContent() instead of ::doEditContent()" 2021-06-28 14:06:34 +00:00