wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-12 09:26:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop unused property and inject a service to SpecialDisplayNotificationsConfiguration

Browse source 
Change-Id: I0f238b863638245eef381e540da7d610d01bd25b
This commit is contained in:
Matěj Suchánek 2021-06-29 15:43:25 +02:00
parent a6dbadb006
commit 3f05f8a71b
2 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
extension.json
View file

@ -49,6 +49,7 @@
"DisplayNotificationsConfiguration": {
"class": "SpecialDisplayNotificationsConfiguration",
"services": [
"EchoAttributeManager",
"UserOptionsManager"
]
},

16
includes/special/SpecialDisplayNotificationsConfiguration.php
View file

@ -10,13 +10,6 @@ class SpecialDisplayNotificationsConfiguration extends UnlistedSpecialPage {
*/
protected $attributeManager;
/**
* Notification controller
*
* @var EchoNotificationController
*/
protected $notificationController;
/**
* Category names, mapping internal name to HTML-formatted name
*
@ -61,13 +54,16 @@ class SpecialDisplayNotificationsConfiguration extends UnlistedSpecialPage {
private $userOptionsManager;
/**
* @param EchoAttributeManager $attributeManager
* @param UserOptionsManager $userOptionsManager
*/
public function __construct( UserOptionsManager $userOptionsManager ) {
public function __construct(
EchoAttributeManager $attributeManager,
UserOptionsManager $userOptionsManager
) {
parent::__construct( 'DisplayNotificationsConfiguration' );
$this->attributeManager = EchoServices::getInstance()->getAttributeManager();
$this->notificationController = new EchoNotificationController();
$this->attributeManager = $attributeManager;
$this->userOptionsManager = $userOptionsManager;
}