Commit graph

5319 commits

Author SHA1 Message Date
jenkins-bot 1c3cb04618 Merge "NotificationBadgeWidget: Don't double-convert numbers" 2019-06-25 21:24:14 +00:00
Roan Kattouw d95b4bfaac NotificationBadgeWidget: Don't double-convert numbers
We shouldn't run numbers through convertNumber() twice.

Change-Id: If0ab0cad48761eaa1753f65e9d1557d84ec31961
2019-06-25 14:11:26 -07:00
Roan Kattouw ea856105f2 Fix badge icons in Monobook
In c86a1a5cf, the structure of the badge was changed, and the hack for
hiding the screenreader text in the badge was updated accordingly.
However, the Monobook styles were not updated, and this caused the badge
icons to be positioned off-screen.

Update the Monobook styles for the new badge structure, and use a
different hack for hiding the screenreader text because the one used for
other skins doesn't work in Monobook.

Bug: T226503
Change-Id: I190d2719addfbe50a7108193848bf23eef54bccf
2019-06-25 13:41:58 -07:00
Translation updater bot 506aa9d425 Localisation updates from https://translatewiki.net.
Change-Id: I4b5cd9e558def3547aad28169fd832cb6bcdf68b
2019-06-24 08:38:15 +02:00
jenkins-bot c2669ba0b3 Merge "Selenium: Test that checks for user mention alerts" 2019-06-19 10:42:06 +00:00
ephemeralwaves dd4539b522 Selenium: Test that checks for user mention alerts
Check that a user gets an alert when their username is mentioned by another user.

Bug: T224894
Change-Id: I303e10a40d1092e4b9f81deef0f1ac2af6f7a435
2019-06-19 10:23:22 +00:00
jenkins-bot a32d18d73e Merge "Make Notification count update without page reload" 2019-06-18 23:39:41 +00:00
shivanshbindal9 43bff91c68 Make Notification count update without page reload
* MVC is used to change the count of notifications on header icons.
* The Widgets are loaded after 60secs or icon click, whichever occurs first.

Bug: T219222
Change-Id: I2d034a76d5c3abe55894dd1dd10e28713344c5bb
2019-06-18 04:49:59 +05:30
Translation updater bot 6204787c6f Localisation updates from https://translatewiki.net.
Change-Id: Ia81fc65f5a49653f2379e7b7dfcd2f23eb8e0602
2019-06-17 22:33:45 +02:00
Translation updater bot 698cf06e63 Localisation updates from https://translatewiki.net.
Change-Id: I3651155f13400c433ec273f8b55481ad7ade5768
2019-06-16 22:35:46 +02:00
Derick Alangi f402ecd31f Echo: Fix case mismatch for function/method calls
PHP doesn't care much about the name (in terms of case sensitivity)
but I think we should make sure the names of the method should be as
they're in their definition.

Change-Id: I6e38d8be64efaec4200471f2d3007275d7ddecec
2019-06-11 22:46:24 +01:00
jenkins-bot a334ab5d34 Merge "tests: Remove local override for editPage()" 2019-06-11 00:09:13 +00:00
jenkins-bot 92d4d578a1 Merge "Localisation updates from https://translatewiki.net." 2019-06-10 20:58:39 +00:00
Translation updater bot 3c067d044e Localisation updates from https://translatewiki.net.
Change-Id: Iab8c0fde92f482f05ed09301f2bf3a0f008e7840
2019-06-10 22:54:32 +02:00
jenkins-bot 912923b742 Merge "Provide visual focus feedback for notification badges" 2019-06-10 20:52:43 +00:00
Max Semenik 538be81712 tests: Remove local override for editPage()
As far as I can see, it doesn't do anything different from the
parent class.

Bug: T225327
Change-Id: Id52ebd2faa179de39111221e55435e2e6e13aa05
2019-06-10 13:17:09 -07:00
manoj 0db743477d Provide visual focus feedback for notification badges
Provide visual feedback when focus is set on notification badges.
Also removing outdated `-moz-outline-style` property, which is applied
only in Firefox <= 3.6.

Bug: T186553
Change-Id: Ia523be0f74beb8fc52f8f04a9a7f59d88c7d2082
2019-06-10 12:31:45 -07:00
libraryupgrader 9572ab4c6a build: Updating mediawiki/mediawiki-phan-config to 0.6.1
Change-Id: Ibeb795b33383c04fe51040d29284ffa5ef4d10bf
2019-06-10 07:04:22 +00:00
libraryupgrader 9a030c4bfe build: Updating npm dependencies for security issues
* Updated grunt to 1.0.4, addressing:
  * https://npmjs.com/advisories/788
  * https://npmjs.com/advisories/813
* Updated stylelint-config-wikimedia to 0.6.0, addressing:
  * https://npmjs.com/advisories/786

Committed package-lock.json (T179229) too.

Change-Id: I9a58f8acade9bd129474785831e8c8174896982c
2019-06-08 05:43:44 +00:00
Translation updater bot 70a56e2814 Localisation updates from https://translatewiki.net.
Change-Id: I991c1141ec1c7cccfbf3c46b42687425ba98eaa4
2019-06-06 22:48:23 +02:00
jenkins-bot 21354c66a2 Merge "Remove badgeicon module, use OOUI icon instead." 2019-06-05 19:08:33 +00:00
shivanshbindal9 c86a1a5cf3 Remove badgeicon module, use OOUI icon instead.
Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module.

Bug: T139779
Change-Id: I8218530ed2cdd2d81c1fc24509f36ea2b6742bd9
2019-06-05 12:29:17 +05:30
James D. Forrester f7da14ec49 build: Upgrade wdio-mocha-framework to be node10 compatible
Change-Id: I5acbc6b161d8d856777f2bd6c80168f411549983
2019-06-03 14:46:36 -07:00
Translation updater bot 6410100d69 Localisation updates from https://translatewiki.net.
Change-Id: I413e3724bb3bd44071e72797956d7824721c7091
2019-06-02 22:29:38 +02:00
Translation updater bot 5f472fafd3 Localisation updates from https://translatewiki.net.
Change-Id: I345cdd016e1e69c33d9b1796a06611a2218a3316
2019-05-26 22:22:49 +02:00
Translation updater bot 2e0a436405 Localisation updates from https://translatewiki.net.
Change-Id: Ie786d2b098853b20dad2999bbdc6133dc278e72d
2019-05-23 23:06:19 +02:00
Stephane Bisson 1ebb8e3daa Don't add CommentStoreComment as plaintext params
Follow-up Icfc8516 and I3d997f9 (migrating from deprecated Revision
to RevisionRecord)

When generating 'edit-user-talk' events, if we don't have the section-text,
we use the edit summary instead.

Revision->getComment() returns a string but RevisionRecord->getComment()
returns a CommentStoreComment. As a result of the migration, an instance
of CommentStoreComment was put into the event 'extra_data' and later
added as a plain text params during notification presentation.

This patch proposes to
1) Make sure to add the comment's TEXT to the event
2) Test that the 'section-text' is a string before using it
   as a message parameter. This will cause faulty notifications to
   render without a body instead of erroring out. We could write a
   maintenance script to fix those notifications but I don't
   think it's worth it.

Bug: T223741
Change-Id: Ie3a1c59a43b0981ec42fc77e7ebb0e8bd132dbe2
2019-05-21 11:44:54 -04:00
Hashar e3ae1a62d0 Revert "Make phan ignore JsonSerializable redefinition"
This reverts commit 13956265c1.

The Wikimedia CI jobs running phan were installing mediawiki development
dependencies which might overlap with the dependencies from the
extension. Ultimately phan failed with:

includes/RemoteSchema.php:9
PhanRedefinedInheritedInterface
\RemoteSchema inherits abstract Interface \JsonSerializable declared at
internal:0 which is also declared at
../../vendor/jakub-onderka/php-parallel-lint/src/JsonSerializable.php:4.
This may lead to confusing errors.

If7171a6d46473b0bb05e3adaeb40229e7881c2b6 adjusts the CI configuration
to no more install MediaWiki core development dependencies and solely
relies on mediawiki/vendor.git. That prevents the duplicate interface
definition.

Bug: T223397
Depends-On: If7171a6d46473b0bb05e3adaeb40229e7881c2b6
Change-Id: I794fbffe59104f138802bc6ded1a9d9a58ba9437
2019-05-21 10:34:28 +02:00
Translation updater bot 34612122e3 Localisation updates from https://translatewiki.net.
Change-Id: I5e4f32645d00315edc54f77436dfadda76dccdef
2019-05-20 22:29:26 +02:00
James D. Forrester 980e67d338 build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0 and make pass
Change-Id: Ifc83427ccdcfc34d33a667ffde5e0cec98a0a609
2019-05-19 13:33:12 +02:00
Roan Kattouw b31119ea19 Remove unused method EchoEvent::isDismissable()
Change-Id: Ibea0c85cf9dd13cc2b6f22d27e8e3e0b927256c0
2019-05-18 17:37:54 +02:00
Translation updater bot c7691f85c4 Localisation updates from https://translatewiki.net.
Change-Id: I5666ec7f159082327bf6758ea2fb31212d79ab6c
2019-05-16 09:09:59 +02:00
Translation updater bot f04ba06819 Localisation updates from https://translatewiki.net.
Change-Id: I2d5526d3f38c071efa3b6f00e6f62638a5c782dd
2019-05-15 09:12:49 +02:00
Paladox e446f8aad0 Fix removeInvalidNotification script
Change-Id: I16c26e259841ff2c69b24afa3427bf74f6d17fb2
2019-05-14 16:49:05 +00:00
Translation updater bot f0a3a6e131 Localisation updates from https://translatewiki.net.
Change-Id: If4b64730368f140f79795fab49e9fd0e9b6bb409
2019-05-13 23:21:51 +02:00
James D. Forrester b45ba9cda9 build: Upgrade wdio-mediawiki from 0.1.7 to 0.3.0
Bug: T223150
Change-Id: Ie29be986c2a50004802658b26f312ea5db08583f
2019-05-13 19:09:14 +01:00
Translation updater bot afcc70bc7c Localisation updates from https://translatewiki.net.
Change-Id: I7dbbf1516631677e664307a44875ace155e8c5b9
2019-05-12 22:33:27 +02:00
Translation updater bot 52ee21983a Localisation updates from https://translatewiki.net.
Change-Id: I314c2470d5a9fa3ea7ad500a2cdd5524e9ecec02
2019-05-10 09:19:17 +02:00
Roan Kattouw 05499e0446 Fix fatal "Object of class CommentStoreComment could not be converted to string"
Bug: T221163
Follows-Up: Icfc85167a636bef95daab236ab80113c1a3cf41b
Change-Id: I92811ae9e383f431ef939b004c7d10126e051bbf
2019-05-09 21:35:03 +00:00
jenkins-bot 74f7784cdf Merge "Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord" 2019-05-09 21:24:10 +00:00
jenkins-bot c5ed6315cc Merge "Remove usage of deprecated Revision class in Echo" 2019-05-09 20:56:17 +00:00
Derick Alangi 76544df40a Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord
Follow up on Icfc85167a636bef95daab2.

Bug: T221163
Depends-On: I31d819f4453032da8deb117254b954fba058e0a3
Change-Id: I3d997f9e8d4bd1566ec6fd8fe2d33be5161458b3
2019-05-09 20:36:05 +00:00
jenkins-bot 703aac8e75 Merge "Test that checks for welcome notification" 2019-05-09 17:41:57 +00:00
Thiemo Kreuz be5919f623 Make use of the PHP 7 ?? operator where it makes sense
To my knowledge in all the places I'm touching in this patch the new
code is functionally identical to the old one.

Change-Id: I0ffa96d2f9cb9bf932f68b689244051c96c17ad9
2019-05-09 15:57:16 +00:00
Derick Alangi 8e5aa13a73 Remove usage of deprecated Revision class in Echo
Class Revision is deprecated and in this patch, replaces
usage with appropriate classes; RevisionRecord, RevisionStore,
etc.

Bug: T221163
Change-Id: Icfc85167a636bef95daab236ab80113c1a3cf41b
2019-05-08 19:50:58 +01:00
Stephane Bisson f5f59a503b Use wikiId both server and client side
When creating the various notification sources,
the server was indexing them with wfWikiID() but
the client was using wgDBname to find which one
is local and which are remote. On some wikis,
like TWN, wfWikiID() includes a db suffix so
the JS app on Special:Notifications is failing to
find the local source and errors.

Bug: T167336
Change-Id: Id60f723b615fb7db54a6f17b1c1be20dfe98e36c
2019-05-08 09:03:28 -04:00
jenkins-bot 77126f0c47 Merge "build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint" 2019-05-07 22:32:45 +00:00
Derick Alangi c4890ca86f Remove usage of deprecated database access code from Echo
Bug: T221164
Change-Id: Ib7cfe384f4104dbaeed5ba6659e81555eb810f97
2019-05-07 20:46:07 +00:00
James D. Forrester 94658a80c2 build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
Bug: T220036
Change-Id: Iedc0e92345eeaa7400c87a2d29f67bff5ba38f4a
2019-05-07 20:44:20 +00:00
Stephane Bisson 13956265c1 Make phan ignore JsonSerializable redefinition
Change-Id: I1cffc88a3f4ea4290892c0624a6f32e852cde1dd
2019-05-07 16:21:22 -04:00