mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-11-24 07:54:13 +00:00
1ebb8e3daa
Follow-up Icfc8516 and I3d997f9 (migrating from deprecated Revision to RevisionRecord) When generating 'edit-user-talk' events, if we don't have the section-text, we use the edit summary instead. Revision->getComment() returns a string but RevisionRecord->getComment() returns a CommentStoreComment. As a result of the migration, an instance of CommentStoreComment was put into the event 'extra_data' and later added as a plain text params during notification presentation. This patch proposes to 1) Make sure to add the comment's TEXT to the event 2) Test that the 'section-text' is a string before using it as a message parameter. This will cause faulty notifications to render without a body instead of erroring out. We could write a maintenance script to fix those notifications but I don't think it's worth it. Bug: T223741 Change-Id: Ie3a1c59a43b0981ec42fc77e7ebb0e8bd132dbe2 |
||
|---|---|---|
| .phan | ||
| db_patches | ||
| i18n | ||
| images | ||
| includes | ||
| maintenance | ||
| modules | ||
| scripts | ||
| tests | ||
| .eslintrc.json | ||
| .gitignore | ||
| .gitreview | ||
| .mailmap | ||
| .phpcs.xml | ||
| .stylelintrc.json | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| Echo.alias.php | ||
| echo.sql | ||
| extension.json | ||
| Gruntfile.js | ||
| jsduck.external.js | ||
| jsduck.json | ||
| jsduck_custom_tags.rb | ||
| Makefile | ||
| package.json | ||
| RELEASE_NOTES | ||