Kunal Mehta
89898043b1
Throw InvalidArgumentException in NotificationFormatter
...
Change-Id: I1417771c70ed644303ae22c43923cf9674835a7b
2015-06-15 19:28:48 -07:00
Kunal Mehta
a2566e45a9
Don't silently accept invalid class names
...
Change-Id: I7888cd3356fcf7433a52455e1cf64522b7e17eb5
2015-06-15 19:26:31 -07:00
Kunal Mehta
cac31dd843
Fix doc comment in EchoNotificationController
...
Change-Id: I3b82206f93099959ed3c12aed7853762cc3da8e4
2015-06-15 19:02:05 -07:00
Kunal Mehta
da894d8a43
Fix docs on EchoNotificationDeleteJob and set explicit visibility on functions
...
Change-Id: I7bfa6b9a7c2a78135005d05024d77a3319c7eed0
2015-06-15 17:58:00 -07:00
Kunal Mehta
06d9385fbb
Don't use $dir
...
Change-Id: I2e376c15cd6fdddcf037985eb20702c2aaa8c177
2015-06-15 17:45:03 -07:00
Kunal Mehta
1298f2bb74
Don't hook into ourselves: EchoGetNotificationTypes (part 2)
...
Change-Id: I51600bbb26594323831d22bc35d34587ff146d47
2015-06-15 17:43:54 -07:00
Kunal Mehta
df452abbb6
Don't hook into ourselves: EchoCreateNotificationComplete (part 1)
...
Change-Id: I5f0f3929a3b0396c98e0f3e74b69ddcee744a0e8
2015-06-15 17:41:10 -07:00
Kunal Mehta
c1c91a0c1d
Update tests/phpunit for new directory structure
...
Change-Id: Ic2d5659bb1db89cb62d3703ce59f3e58ba909886
2015-06-15 11:36:02 -07:00
jenkins-bot
fb6150fb36
Merge "Separate logic for extracting usernames from picking the right one"
2015-06-15 17:49:18 +00:00
Translation updater bot
f42d9abcb5
Localisation updates from https://translatewiki.net .
...
Change-Id: Id6dd9f48cc66102116ef3fc9512908193ddbc8bf
2015-06-14 21:06:12 +02:00
Translation updater bot
d74ea607ae
Localisation updates from https://translatewiki.net .
...
Change-Id: Iafa235501231f6f250f770166cda8924a8ead94c
2015-06-13 22:28:10 +02:00
Matthew Flaschen
3c37aefdb1
Separate logic for extracting usernames from picking the right one
...
Pull out the logic that extracts usernames from links. This allows
it to be reused by the LQT->Flow import code.
Bug: T101979
Change-Id: Ib16a09cf1f388f56944cd1bb564384535728156e
2015-06-12 21:16:59 -04:00
Translation updater bot
569c30304b
Localisation updates from https://translatewiki.net .
...
Change-Id: I9d69bdefdd15d99f55c75ea1af211128c5ccbaa1
2015-06-12 21:53:18 +02:00
jenkins-bot
054cd1a5cb
Merge "build: Adding configuration for jsonlint"
2015-06-12 15:57:24 +00:00
Kunal Mehta
2c71920c5c
build: Adding configuration for jsonlint
...
Change-Id: I3c0d0c353a75bcc9da5dd3706d6c5dc6d34570fd
2015-06-11 21:32:18 -07:00
Matthew Flaschen
a6412a6d27
Fix typo in scenario name
...
Change-Id: I90cf03197c715dc7c786479056f95137245ef939
2015-06-11 23:02:12 -04:00
Matthias Mullie
4a9ebfc9a1
Guarantee a correct known status for Linker::link
...
Bug: T96162
Change-Id: I4b0962c5ca6bd09b34a8fa031e80b2274033ccc0
2015-06-11 11:15:33 -07:00
jenkins-bot
c4b00cfda7
Merge "Remove unused EchoDiscussionParser::getNotifiedUsersForComment()"
2015-06-10 03:41:46 +00:00
Kunal Mehta
add1eb8266
Remove unused EchoDiscussionParser::getNotifiedUsersForComment()
...
Change-Id: I63c51835f54735c04f8356cf8ce161210895c378
2015-06-09 23:38:16 -04:00
Translation updater bot
d341b4e325
Localisation updates from https://translatewiki.net .
...
Change-Id: Ibeab97e3fe899c2e7df9edbecfda31ea7e27c5c1
2015-06-09 22:45:49 +02:00
jenkins-bot
46c8abdfd2
Merge "Merge MWDbEchoEmailBundler into MWEchoEmailBundler, remove abstraction layer"
2015-06-08 21:53:43 +00:00
jenkins-bot
51789ccf5f
Merge "Use intval() to make string concatenation in DB query less scary"
2015-06-08 21:50:25 +00:00
jenkins-bot
1b2af79634
Merge "Merge MWDbEchoEmailBatch into MWEchoEmailBatch, remove abstraction layer"
2015-06-08 21:50:09 +00:00
Kunal Mehta
58b7cc7cfd
Use intval() to make string concatenation in DB query less scary
...
Change-Id: I51d7744b8c7f967e47777b5f3a6e491f4e65f5c8
2015-06-08 14:36:08 -07:00
Translation updater bot
6cf6e77d82
Localisation updates from https://translatewiki.net .
...
Change-Id: I504d60a80231f6f2fcec1a48f84943868b09673c
2015-06-08 21:54:52 +02:00
Kunal Mehta
07da9c2e41
Merge MWDbEchoEmailBundler into MWEchoEmailBundler, remove abstraction layer
...
Change-Id: Ifc05f1d03d1dde79d5c788ee7417ed0cec43155f
2015-06-08 11:58:06 -07:00
Kunal Mehta
24cd62e322
Merge MWDbEchoEmailBatch into MWEchoEmailBatch, remove abstraction layer
...
Change-Id: Ib1ae17326443d2143346bcd2e4204defa2dab4c3
2015-06-08 11:54:25 -07:00
Kunal Mehta
9d08c96fad
Move all PHP code into includes/
...
Mainly because I was annoyed at m<tab>o<tab>d<tab>u<tab> to reach
modules/.
Change-Id: Ib149cb2e2612ccddd0503f9d0c5d05b554860a00
2015-06-07 18:54:14 -07:00
Kunal Mehta
78dc653c80
Remove dead dismiss code
...
mw.echo.setUpDismissability was removed in 08fc83b6de
, and will
never be called since the class is never set.
Change-Id: I1e13bbabaeb7df21c161d4cf4205a1564e1d81d9
2015-06-07 18:30:49 -07:00
Kunal Mehta
70d95fbad0
Use mw.Api.postWithToken to automatically re-try badtoken errors
...
Bug: T101664
Change-Id: I93188099e24102b47384c08113e8dbd26dac8df1
2015-06-07 18:11:48 -07:00
Kunal Mehta
7a196ce358
Remove pre-MW 1.22 compatability code
...
Change-Id: Ia59464f4a9a5589d84e5028cdabb33aa95df4209
2015-06-07 17:34:26 -07:00
Kunal Mehta
0919b01e75
Pass uselang=user to the API instead of figuring it out client side
...
Change-Id: I09add693567af577c14c646d2b6b943716e0522e
2015-06-07 17:30:00 -07:00
Kunal Mehta
10cd92a326
ext.echo.special depends upon mediawiki.api
...
Change-Id: Iabcfd263ae8cb857d767ea9b6af0480d67bf3d2d
2015-06-07 17:27:32 -07:00
Translation updater bot
a0cf14cad8
Localisation updates from https://translatewiki.net .
...
Change-Id: I8553c9d44c71c5ac3de595b1c43fdff333afb900
2015-06-07 22:27:28 +02:00
Translation updater bot
1564aa95a0
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia7660ab18517dfb12c45b7e539d27301dc85d302
2015-06-06 22:16:40 +02:00
Kunal Mehta
e2eee93c4d
build: Updating development dependencies
...
* grunt-contrib-csslint: 0.2.0 → 0.4.0
* grunt-contrib-jshint: 0.10.0 → 0.11.2
* grunt-banana-checker: 0.2.0 → 0.2.2
* jshint: ~2.5.0 → 2.8.0
Change-Id: Ibb94cf3d1d4cc71d9342165fd9b6c4ad18d58f07
2015-06-05 17:14:09 -07:00
Translation updater bot
838cd1ed73
Localisation updates from https://translatewiki.net .
...
Change-Id: I69201c362e5cc46d419c4b95668fabeedfb92c3f
2015-06-05 21:01:45 +02:00
Translation updater bot
49f4e715e1
Localisation updates from https://translatewiki.net .
...
Change-Id: Iac4d2ba00cc8ae88ba6198d85e14862538469910
2015-06-03 22:10:12 +02:00
Stephane Bisson
5b72b9f026
Fix new talk page message notification
...
* Do not default section to footer. If the section
is not found, it is left empty and the notification
message is simpler.
* Change notification-edit-talk-page-email-batch-body2
Replace : at the end with . so it does not look
incomplete.
Bug: T99989
Change-Id: Ic982a81eada388d750760787245dea8f72368147
2015-06-03 13:17:57 -04:00
Kunal Mehta
9fd265d54b
The job queue does not run against multiple wikis at once
...
...because that would be crazy.
Also fix return documentation.
Change-Id: I38c06767f4e53bafff19b4f0819158939ef264c0
2015-06-01 19:26:06 -07:00
jenkins-bot
64b66712c5
Merge "Make processEchoEmailBatch check that Echo is actually enabled before doing anything"
2015-06-02 01:16:16 +00:00
jenkins-bot
14f663e847
Merge "Don't depend on global grunt install"
2015-06-02 01:07:31 +00:00
Kunal Mehta
cd1885e3b7
Don't depend on global grunt install
...
Change-Id: Iadc396247410688b58281bfe43df1888e0a16f83
2015-06-01 18:04:14 -07:00
jenkins-bot
e6ffb55eaf
Merge "Use "elseif", not "else if" in PHP"
2015-06-02 01:01:54 +00:00
Kunal Mehta
4d52bc2534
Use "elseif", not "else if" in PHP
...
Change-Id: I3a84f1c3ec9d4522f5f7f461a680561c8aeda29e
2015-06-01 17:59:05 -07:00
Kunal Mehta
70761a124c
Cleanup LoadExtensionSchemaUpdates hook
...
* Use standard "on{hook}" naming pattern
* Skip hook if using an external database server ($wgEchoCluster)
* Don't return true, it's not necessary anymore
Change-Id: I488e4636f9499c468b870966614b0762c2ade8ea
2015-06-02 00:55:54 +00:00
Kunal Mehta
0e6976f536
Require Resources.php in entry point
...
Extension loading should fatal and stop if Resources.php cannot be loaded.
Change-Id: I62f3095438e3702e0a41e1a4ad6721ec31f432fc
2015-06-02 00:55:50 +00:00
Kunal Mehta
d9e2695c7b
Don't pollute $GLOBALS in Resources.php
...
Get rid of $mobileReadyTemplate, it's only used once now, and unset
$echoResourceTemplate after usage.
Change-Id: Ie371a6c1545383b8be1c0b99730228da6e381650
2015-06-02 00:55:44 +00:00
Kunal Mehta
c78e5202e8
The OBOD is orange
...
c.f. https://meta.wikimedia.org/wiki/OBOD
Change-Id: Ib3efe9ea59d1b955be86e56cfa8841c2c4daedb6
2015-06-02 00:55:36 +00:00
Kunal Mehta
c2258dd7ce
Kill $wgEchoCohortInterval
...
The Echo cohort study was finished in July 2013 and hasn't been used
since. The code was also checking in reverse order, for example it
checked registration before checking whether the survey was still
active.
EchoHooks::isEchoDisabled() was removed, and all callers were checked to
make sure they were also checking for anonymity.
EchoNotificationController::doNotification() will throw an exception if
the user is anonymous, since it shouldn't be possible to get an
anonymous user into that code path.
Bug: T101047
Change-Id: Iada2f6d2066c0f6bba5cc58aeb03d687632ac5a4
2015-06-01 17:53:29 -07:00