wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 09:40:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't silently accept invalid class names

Browse source 
Change-Id: I7888cd3356fcf7433a52455e1cf64522b7e17eb5
This commit is contained in:
Kunal Mehta 2015-06-15 19:21:01 -07:00
parent cac31dd843
commit a2566e45a9
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
includes/formatters/NotificationFormatter.php
View file

@ -95,20 +95,20 @@ abstract class EchoNotificationFormatter {
/**
* Create an EchoNotificationFormatter from the supplied parameters.
* @param $parameters array Associative array.
* Select the class of formatter to use with the 'class' field.
* Select the class of formatter to use with the 'formatter-class' field.
* For other parameters, see the appropriate class' constructor.
* @throws MWException
* @throws RuntimeException
* @return EchoNotificationFormatter object.
*/
public static function factory( $parameters ) {
$class = null;
if ( isset( $parameters['formatter-class'] ) ) {
$class = $parameters['formatter-class'];
} else {
$class = 'EchoBasicFormatter';
}
// Default to basic formatter
if ( !$class || !class_exists( $class ) ) {
$class = 'EchoBasicFormatter';
if ( !class_exists( $class ) ) {
throw new RuntimeException( "Class $class does not exist" );
}
return new $class( $parameters );