Commit graph

2841 commits

Author SHA1 Message Date
jenkins-bot 5a5ad9f8df Merge "Always scroll "Loading..." text into view" 2022-09-27 19:16:23 +00:00
jenkins-bot 5d92f638f3 Merge "Move "Return to comment" below sticky header when present" 2022-09-27 19:16:20 +00:00
jenkins-bot adc3344f5f Merge "Fix TODO about ParsoidClient::getPageHtml() params" 2022-09-27 10:43:00 +00:00
Translation updater bot 7654f86129 Localisation updates from https://translatewiki.net.
Change-Id: I248cc9f89609664219874c56728a6b4a4a4631ba
2022-09-27 08:32:04 +02:00
Bartosz Dziewoński 0a5cded42c Fix TODO about ParsoidClient::getPageHtml() params
Depends-On: Id9a450dc8b8eb3e82cf87718b96975e5a3c6180c
Change-Id: I35ce516187fb8dcde24bc35278378496f471e211
2022-09-26 22:50:07 +02:00
Translation updater bot 9ca9bd1355 Localisation updates from https://translatewiki.net.
Change-Id: I75fff58586f1dbb28faa22b57d2c0454a458def7
2022-09-26 08:15:04 +02:00
Ed Sanders f6df39c11a Always scroll "Loading..." text into view
If the widget has just been opened, it should already be in view,
but when we are recovering from auto-save it might not be.

Scrolling it into view lets the user know sooner that a draft is
about to be recovered.

Change-Id: I2b8232edc20e71b04a3f106107c0c7bc6333f66a
2022-09-25 13:28:14 +01:00
Ed Sanders 688cdc24ae Move "Return to comment" below sticky header when present
Also ensure that when we click the button, we scroll the widget fully
into view below the sticky header.

Bug: T318474
Change-Id: I394f02912cd6ab2773552a7364691ef89a17369c
2022-09-25 13:28:12 +01:00
jenkins-bot fb7a25ce91 Merge "PreferenceHooks: Avoid referring to the field of disabled feature" 2022-09-24 23:30:44 +00:00
jenkins-bot 63acbf4dfc Merge "Add Korean special page aliases" 2022-09-24 23:26:00 +00:00
Translation updater bot 5f94a9bf00 Localisation updates from https://translatewiki.net.
Change-Id: I1667584f86a919a1f7a25e8c9e6a95983cd12466
2022-09-23 08:29:00 +02:00
jenkins-bot 43f95c18c3 Merge "Tweak topic container margins on desktop" 2022-09-22 15:32:34 +00:00
Translation updater bot 74305d71ed Localisation updates from https://translatewiki.net.
Change-Id: Iacfcb8b6929589488f40d6c136f86f648314375b
2022-09-22 08:45:57 +02:00
Ed Sanders a9488a9ead Suppress top border when section follows <h1>
Bug: T318198
Change-Id: I550dd240fe629d0159448ea49d49195de0166a25
2022-09-21 21:39:40 +01:00
Translation updater bot f22e68ff86 Localisation updates from https://translatewiki.net.
Change-Id: If151368b3b904ffde201c2545bb2919dd10f346b
2022-09-21 08:28:42 +02:00
jenkins-bot 169b4c74ad Merge "ThreadItemSet.newFromAnnotatedNodes needs to wait to compute names" 2022-09-20 16:46:51 +00:00
na1307 1c1d7b3c5d
Add Korean special page aliases
Change-Id: I87c827d6f113b7d8d46eb60a6cd65ad6c679587c
2022-09-20 17:01:54 +09:00
Translation updater bot 855eef1c2a Localisation updates from https://translatewiki.net.
Change-Id: I23ddaa79e5f7982a6008bea4d234730841a7504f
2022-09-20 08:33:56 +02:00
David Lynch 9ee2301f1e ThreadItemSet.newFromAnnotatedNodes needs to wait to compute names
Computing the name, for headings, requires determining the oldest
comment. This must not be done before all the replies are added to the
thread.

Follow-up to e24550fae9. It was
already *technically* incorrect before then because it was generating
the name based on the first comment in the thread, but that was only
not the oldest in very unusual cases so it was fine. That commit caused
the thread summary to be cached when first requested, however, which
made future requests for oldest/newest comment and authors to be
incorrect.

Bug: T318057
Change-Id: If0bd6caf88e72cd3f91e7f0633c40b445f5e2246
2022-09-19 14:13:51 -05:00
jenkins-bot 82f107af7e Merge "Add @covers CommentUtils to tests that use it" 2022-09-19 16:57:18 +00:00
jenkins-bot b594a99a12 Merge "Use margin to position comment marker to avoid Chrome bug" 2022-09-19 16:57:16 +00:00
jenkins-bot 77514eb01f Merge "Replace VisualEditor ParsoidHelper with ParsoidClient" 2022-09-19 16:33:13 +00:00
Bartosz Dziewoński 2679fa3b04 Replace VisualEditor ParsoidHelper with ParsoidClient
Depends-On: I21c4a8cd86f8d085e75a601ed6d2509dedd75d42
Change-Id: I9533d7c05047c2d873c8c6ee5944df965e3b379d
2022-09-19 18:00:14 +02:00
Translation updater bot 3695b13fd7 Localisation updates from https://translatewiki.net.
Change-Id: I37764caac2b80d143fbb93a79c6f96d8603758f1
2022-09-19 08:24:20 +02:00
Ed Sanders 0265d401c2 Add @covers CommentUtils to tests that use it
Change-Id: I35d2d0d75bfdbe17fe186eb5cfb47a850a9d6f6a
2022-09-16 13:22:43 +02:00
Ed Sanders fcdabc5fcc Only filter code coverage at the class level
Many methods are covered indirectly, and using method-level
@covers filters means these are reported as not being covered.

Change-Id: I94eb3e8c48209ff0b6bfc09e18c93555bb167e8f
2022-09-15 14:08:30 +02:00
Translation updater bot 80590f1457 Localisation updates from https://translatewiki.net.
Change-Id: I9e536b12107bbae4940c0b6bcf4498db047fbfe2
2022-09-15 09:54:53 +02:00
Translation updater bot 35fa4a5dd9 Localisation updates from https://translatewiki.net.
Change-Id: I664e5e348cc171c62d3ddcb92abd8cd264fe1e2f
2022-09-14 10:31:29 +02:00
Ed Sanders 39502b4f9a Use margin to position comment marker to avoid Chrome bug
Bug: T317135
Change-Id: I627d92fabaa9d9e477279041d3c40a7c6bfe37c8
2022-09-14 10:01:53 +02:00
Ed Sanders 516ea4a970 Tweak topic container margins on desktop
Bug: T314449
Change-Id: I021dbd33f211fcdc5ef2fea1d99212df772053b4
2022-09-14 09:59:39 +02:00
David Lynch 968250bb02 Add mw.track call when comment setup fails
Bug: T310390
Change-Id: I6df98032469931276ea096a008fdf8f63893dff5
2022-09-14 01:23:07 -05:00
Func 8820940dfd PreferenceHooks: Avoid referring to the field of disabled feature
The GlobalPreferences extension would remove disabled fields from
the form, avoid referring to it in the disable-if param.

Bug: T317526
Change-Id: I6ec177a1f20855c90eb4ea17bb6625c75e5b9617
2022-09-13 09:32:09 +00:00
Translation updater bot 93713ffab4 Localisation updates from https://translatewiki.net.
Change-Id: Ica2690ef08200f5df41df3d900d33029688f4d3a
2022-09-13 09:25:54 +02:00
Translation updater bot 840a796c26 Localisation updates from https://translatewiki.net.
Change-Id: I4328c68d619d6ad0bd1f6b36e4c4bcb8e4d0a81d
2022-09-12 08:11:25 +00:00
jenkins-bot f152ca001d Merge "Reduce size of topic headings to 18px on mobile" 2022-09-10 11:53:39 +00:00
jenkins-bot 639ad57914 Merge "Suppress top border of first section on mobile" 2022-09-10 11:53:37 +00:00
Ed Sanders 9af812720c Reduce size of topic headings to 18px on mobile
Also reduce spacing around headings and meta bar.

Bug: T311612
Change-Id: I40e01caea22c6b89122a29f87282e4147961f6a7
2022-09-10 12:46:34 +01:00
Ed Sanders 7a579fd67b Suppress top border of first section on mobile
The :first-child that would usually do this doesn't work
due to the hidden .mf-section-0.

Change-Id: I772414f563543f6a39ec61e87a9c46cb3ef6690d
2022-09-10 12:44:32 +01:00
jenkins-bot 183fba9171 Merge "Update mw:tocplace CSS hack" 2022-09-09 21:12:43 +00:00
Translation updater bot 6fb0d36946 Localisation updates from https://translatewiki.net.
Change-Id: I640502c4b71f8903cbbb6656ae376d21dcb35c6e
2022-09-09 10:10:02 +02:00
Translation updater bot 4ef027ce2e Localisation updates from https://translatewiki.net.
Change-Id: I6f1637b3baf50c35ec4067a249f47b966d821912
2022-09-08 09:59:07 +02:00
Translation updater bot 88f8e534eb Localisation updates from https://translatewiki.net.
Change-Id: Ibfbc00a012fa42346c80de99e440ceb55ba42b1b
2022-09-07 09:54:37 +02:00
jenkins-bot 936883572c Merge "CommentFormatter: Fix TOC info being repeated for subsections" 2022-09-06 22:23:51 +00:00
jenkins-bot 0632bfc92e Merge "Refactor thread summary getters" 2022-09-06 22:17:26 +00:00
jenkins-bot 014ff9f8da Merge "Hooks: Inject VisualEditorParsoidClientFactory to ParsoidHelper" 2022-09-06 21:28:24 +00:00
Bartosz Dziewoński d7b6100c28 CommentFormatter: Fix TOC info being repeated for subsections
(And don't display it for empty top-level sections)

Bug: T309463
Change-Id: Icc69a248bca0be4945e07051e667b87af28927f7
2022-09-06 23:19:13 +02:00
Ed Sanders e24550fae9 Refactor thread summary getters
Replace getThreadSummary with individual getters that call
calculateThreadSummary once.

Change-Id: Ie8a8b4d7cb5121847b78dbc20bca2c8d48c7d857
2022-09-06 23:19:13 +02:00
Derick Alangi 5168005373 Hooks: Inject VisualEditorParsoidClientFactory to ParsoidHelper
Since it will be made a required field in VE, just inject it.

Change-Id: If682af406c0fc7a9eca106eb3ebd95e6c14baddd
2022-09-06 21:15:13 +01:00
Ed Sanders 09d9b179f7 Content*Item: Use more specific Content*Item classes within functions
We can't use these is class method function signatures, but we
can use within the functions themselves.

Change-Id: Ic24e47d6647226172a3bfacd81398d26143d98e4
2022-09-06 20:00:55 +00:00
jenkins-bot 23a5647ff4 Merge "Hooks: Remove injecting MainConfig to ParsoidHelper" 2022-09-06 17:53:11 +00:00