Commit graph

2341 commits

Author SHA1 Message Date
jenkins-bot a78cacc618 Merge "Mobile topic containers: Fix right alignment of ellipsis button" 2022-06-29 14:27:32 +00:00
jenkins-bot 45e7c01b62 Merge "New topic hint: Cleanup CSS" 2022-06-29 14:23:37 +00:00
jenkins-bot c44da3739d Merge "New topic hint: Add clear:both" 2022-06-29 14:22:49 +00:00
Ed Sanders 26cdf6789d Mobile topic containers: Fix right alignment of ellipsis button
The icon element should be aligned with the right side
of the content area, like the expand/collapse button, and
the edit pencil in the main namespace.

Change-Id: I191a5984bafc6a478674dd5dccff0594a743ff18
2022-06-29 12:22:53 +01:00
Ed Sanders ff97a06522 New topic hint: Cleanup CSS
* Use sibling selector instead of negative margin to reduce
  space between hint and reply widget.
* Remove upstreamed right-padding for close button.

Change-Id: Ie51cd2208c2bebcbfeff08c249389085523193f0
2022-06-29 11:58:51 +01:00
Ed Sanders 90b2222341 New topic hint: Add clear:both
Bug: T311597
Change-Id: Id7e545b0c18fdd407cb096e3cc3d51415be9839c
2022-06-29 11:58:44 +01:00
Translation updater bot cab67f96fd Localisation updates from https://translatewiki.net.
Change-Id: I83ae7a4491b6614a80239b947641b32c33cca9cd
2022-06-29 08:35:02 +02:00
jenkins-bot 826fcc2229 Merge "ApiDiscussionToolsPageInfo: Fix fake headings with null name/id" 2022-06-29 03:17:32 +00:00
Bartosz Dziewoński af6e4a29eb ApiDiscussionToolsPageInfo: Fix fake headings with null name/id
name and id are supposed to never be null. Calling getName() or
getId() on this object would cause an exception.

Change-Id: I5f95b7d9e4ce4550b550ee758fc86f032b676731
2022-06-29 02:52:31 +02:00
Ed Sanders 56989d18a3 Fix hiding of topic container top-border when mw:tocplace present
Change-Id: I382cfeb10c7f8407b559526b0ca06e0dcddd2191
2022-06-28 15:18:13 +01:00
Translation updater bot dac8380021 Localisation updates from https://translatewiki.net.
Change-Id: Idcbc286414115946eb8d5325326baeb2476bd071
2022-06-28 08:39:26 +02:00
jenkins-bot cd86854235 Merge "Pass useskin/mobileformat when previewing/refreshing page contents" 2022-06-27 21:57:02 +00:00
jenkins-bot db36c87210 Merge "Api: Make type/title required args of previewMessage" 2022-06-27 21:56:59 +00:00
Ed Sanders d00fa80ff4 Use $.html to refresh page after save
As per If549a0e647ce8.

Change-Id: I6afdc4a80615617678d2d31c2c9e5830b07a6ef0
2022-06-27 17:34:32 +01:00
Ed Sanders 639fabf647 Pass useskin/mobileformat when previewing/refreshing page contents
These are required to render content correctly on mobile.

Change-Id: I421e1f172e208c4bf9d50eee68f1b0220a78dfbe
2022-06-27 17:15:28 +01:00
Ed Sanders 904f1c2f25 Api: Make type/title required args of previewMessage
Change-Id: I0a0d9bfe3510d9bd6076408ba3819c82cd44ec0c
2022-06-27 12:50:10 +01:00
Translation updater bot 2435a0859d Localisation updates from https://translatewiki.net.
Change-Id: I709e27e8e28866e5e888cd5738b02fc456230a11
2022-06-27 08:17:54 +02:00
jenkins-bot 1650d05b0c Merge "Update wording of visual enhancements preferences" 2022-06-26 12:28:11 +00:00
Ed Sanders 7fc5a0c29d Topic containers: Design iterations
Bug: T310914
Change-Id: I9000f9902d612c58c6b3bc8b762232ca6dd9724f
2022-06-25 12:54:39 +00:00
Ed Sanders 63acc121fc Thread containers: Link latest comment timestamp to corresponding comment
Bug: T309751
Change-Id: Id969bd7a76544d6024b8714c45cdfe5c59b71a0b
2022-06-24 21:44:21 +00:00
Ed Sanders b1be63469b Only enable visual enhancements in specific namespaces
Change-Id: I91643d3f07a9ee6f03a18f8e2787ab9cb61bc41d
2022-06-24 16:15:07 +01:00
jenkins-bot bb04010ab0 Merge "Truncate timestamps in comment IDs / names" 2022-06-24 08:33:22 +00:00
Translation updater bot 1c05db4609 Localisation updates from https://translatewiki.net.
Change-Id: If78136f44b9347caecfec0a6f366c992a8139e6a
2022-06-24 09:30:33 +02:00
Bartosz Dziewoński 109a50cb34 Truncate timestamps in comment IDs / names
For comments posted on or after 2022-07-12 (configurable), use a
shorter format, identical to the timestamps MediaWiki uses in URLs.

Changing the format for already existing comments would involve
difficult migrations, therefore we elect not to do it.

Bug: T304595
Change-Id: I387051a6a3a1d84cfae45c3e1516db870cc8b977
2022-06-24 00:49:58 +02:00
Bartosz Dziewoński 17b8892d78 Update wording of visual enhancements preferences
Bug: T270316
Bug: T272198
Change-Id: I07e86b5837ef606b7ab74876e5aa07debe56292c
2022-06-23 23:34:14 +02:00
jenkins-bot 1a7011dde2 Merge "Show thread metadata in section headers" 2022-06-23 20:19:37 +00:00
Ed Sanders da64c43ccc Show thread metadata in section headers
Bug: T269950
Change-Id: Ifa47ddcbccf288be0bbecd5961eab7c5122aab7b
2022-06-23 17:17:09 +01:00
Translation updater bot d4c8044bed Localisation updates from https://translatewiki.net.
Change-Id: I590400762095875895cd0412a49c30d03f081807
2022-06-23 09:02:47 +02:00
Translation updater bot be62bd895b Localisation updates from https://translatewiki.net.
Change-Id: Ieb37e856acecd5556d61b6f2bb0e7ec9285b7fcc
2022-06-22 08:13:16 +02:00
jenkins-bot 54d5f7a898 Merge "Fix race condition causing highlights to not be cleared" 2022-06-21 15:41:53 +00:00
jenkins-bot 257565a5dd Merge "Tweak positioning of highlights to make them prettier" 2022-06-21 15:41:51 +00:00
jenkins-bot 58a9deb531 Merge "Set rootNode for items from in ThreadItemSet#newFromAnnotatedNodes" 2022-06-21 15:41:49 +00:00
jenkins-bot 151a140c75 Merge "topicsubscription: Reduce code duplication" 2022-06-21 15:40:58 +00:00
Translation updater bot 3c247c73ab Localisation updates from https://translatewiki.net.
Change-Id: I0571343aa3e1a7e64988a2246417f88dc50a1214
2022-06-21 08:30:32 +02:00
jenkins-bot d5d896a0dc Merge "CommentFormatter: Escape user input in generated comment" 2022-06-20 23:54:07 +00:00
Bartosz Dziewoński 1ec97b18d9 Fix race condition causing highlights to not be cleared
We cleared the highlight outside the setTimeout(), then set a new one
inside the setTimeout(). If this method was called twice quickly, two
highlights would be created, and the first one of them would become
impossible to clear.

Move the setTimeout() outside of the method to avoid this.

Bug: T311021
Change-Id: Ic8b2cf2a782a429c4ea073871efd215f4b300ed8
2022-06-20 22:51:39 +02:00
Bartosz Dziewoński d73ce24059 Tweak positioning of highlights to make them prettier
* Fix math and styling for RTL
* Make highlights for headings and framed comments cover them fully
* Align the far edges of wide comments

Bug: T309444
Change-Id: Iadbf83e02801fd9bd6336c84015994ee2819ce51
2022-06-20 19:03:50 +02:00
Bartosz Dziewoński a0750129e7 Set rootNode for items from in ThreadItemSet#newFromAnnotatedNodes
It's needed for the fix for T303396 to work correctly (in the case
where there's exactly 1 thread item on the page), and for the
highlight improvements in Iadbf83e02801fd9bd6336c84015994ee2819ce51.

Change-Id: I2b2f5535ebbf792910133622a271ac1491c74de6
2022-06-20 19:03:09 +02:00
Bartosz Dziewoński df22a66e42 topicsubscription: Reduce code duplication
Rather than making our own ThreadItem objects from scratch,
reuse those used by the rest of the code.

Change-Id: I67f5ea3ad26baffe51b66d0c75467ac00185dd0a
2022-06-20 19:02:46 +02:00
Ed Sanders d59d5e14f9 CommentFormatter: Escape user input in generated comment
Currently the only user input in a headingItem name is the username
which can't contain a '>', so the regex can't break, but this is
fragile, and we should always do our own escaping.

Change-Id: I14e5ae2dc1e9ad7639e61b5471aa9ce270137960
2022-06-20 12:09:02 +01:00
Translation updater bot c757398293 Localisation updates from https://translatewiki.net.
Change-Id: Ie3e7699ae7e84abc0b8dddf4c1228f5703164ce4
2022-06-20 08:16:44 +02:00
jenkins-bot 9058467403 Merge "ReplyWidgetVisual: Pass in memory-wrapped store to VE" 2022-06-17 22:26:06 +00:00
jenkins-bot 6c3f056904 Merge "Translate special page alias into Polish" 2022-06-17 13:31:30 +00:00
jenkins-bot 39401c4b6b Merge "ReplyWidgetVisual: Handle VE surface 'cancel' event" 2022-06-17 13:24:13 +00:00
Ed Sanders af5b9a9b46 ReplyWidgetVisual: Pass in memory-wrapped store to VE
We switched to our memory-wrapped store everywhere outside the
VE surface, but not in the VE surface itself.

Change the way we construct MemoryStorage objects so that they can
be constructed from a specific mw.SafeStorage instance.

Ensure MemoryStorage's cache is populated with initial storage object
data, and that the cache is copied over when we create derivative
objectes.

Bug: T310438
Change-Id: I652428f114dc5169195887cb8ca719ae196bb76f
2022-06-17 14:05:54 +01:00
Msz2001 64cd38c053 Translate special page alias into Polish
Change-Id: Ieac259d5cf48f786cd24f54fc40683fa254828b6
2022-06-16 10:07:17 +00:00
Translation updater bot 20c151db49 Localisation updates from https://translatewiki.net.
Change-Id: I4ea5220f0b847cf6982b5c99169569862e701c0c
2022-06-16 09:24:24 +02:00
Ed Sanders 7befd4a8fc Use new function signature for Target#initAutosave
Depends-On: I6ab00c089c9ae1a8bb05ce9405f1f1f2fd0915ca
Change-Id: I23eb131082260540d2cf5e2cad92c9514333862d
2022-06-15 23:49:49 +00:00
jenkins-bot 80173ed010 Merge "Convert more self:: to static::" 2022-06-15 19:42:57 +00:00
Bartosz Dziewoński 9eb200024e ReplyWidgetVisual: Handle VE surface 'cancel' event
Since change I29f6af4cc7c71a63a6d1bafc53d16b9abd1b60ec, VisualEditor
handles the Escape key to emit a 'cancel' event. We need to listen to
this event to allow Escape to close our editor when the surface is
focussed, in addition to the existing handling for the Escape key.

Change-Id: I8c0f2678d104a76d6a223aca9b57123b9f587ac7
2022-06-15 21:09:06 +02:00