wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-22 04:46:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
3522 commits 13 branches 4 tags 131 MiB
Commit graph

3522 commits

This branch
This branch
All branches
Author SHA1 Message Date
David Lynch 6ec1f39147 Change generation of logging session ID 
Same pattern as is now used in VisualEditor. Generate an initial session
ID when the file loads, so if any VisualEditorFeatureUse events trigger
before the init there'll be a session ID for them to use.

Bug: T275051
Change-Id: I4f25e9e1e195c11129044868eb67fcc2f4494ffd
 2021-02-23 15:37:22 -06:00
Ed Sanders da72fb15c2 Only show reply links when body class in present 
Bug: T273072
Bug: T274311
Change-Id: Ibe08c0eba0b80a5143845dcd1792d616ad8ffc61
 2021-02-23 19:36:21 +00:00
Ed Sanders 6c023da581 Sort message keys (and enforce sorting) 
Change-Id: I72236c23323dc3292bf8a060c4270685c6decb9a
 2021-02-23 16:33:11 +00:00
Ed Sanders 0856617636 Remove useless escaping from en/qqq.json 
Change-Id: Ic3879f53e375113efa16062b4729663f0bbdd05d
 2021-02-23 14:58:37 +00:00
Translation updater bot 2cfa72df99 Localisation updates from https://translatewiki.net. 
Change-Id: Ie951aa5e8dbce650cbfd5081573b6db18fb18a64
 2021-02-23 08:48:06 +01:00
Ed Sanders fa484e0c4a Don't allow CommentItem author to be null 
Change-Id: Idb12bfa62e42bff521e872ab358b5ba9a8d24089
 2021-02-22 20:55:35 +00:00
Ed Sanders bb8d2b691e Define sub-features in arrays and use where possible 
* HookUtils:FEATURES lists all features
* CommentFormatter::USE_WITH_FEATURES are all features
  which require the comment formatter

Change-Id: Idbbe8bdd910b9c7b23c7fee76af7bb7ee13c2759
 2021-02-22 20:55:35 +00:00
Translation updater bot c7753b464c Localisation updates from https://translatewiki.net. 
Change-Id: I0cae3753e3a1b01c5c1903775c6597561b916646
 2021-02-22 08:51:43 +01:00
Translation updater bot 59a3eda011 Localisation updates from https://translatewiki.net. 
Change-Id: I1d60e6ba86b241fc7a4ff690345be7014dfc1fca
 2021-02-19 08:31:46 +01:00
jenkins-bot f6cb81ce21 Merge "Show wikitext warnings for sequences not in reply tools" 2021-02-19 00:27:12 +00:00
Ed Sanders 6afb92d940 Show wikitext warnings for sequences not in reply tools 
Bug: T274923
Change-Id: I56adc6524398805d3d6d582572e7524af8ba86a7
 2021-02-18 22:52:35 +00:00
Ed Sanders 33c6181e79 Rename indent replacement methods 
Change-Id: I8cb1b58dad068be7cfa62cab9e932463a23c6b12
 2021-02-17 23:42:57 +00:00
jenkins-bot c417d3279a Merge "Make new topic autosave specific to page title" 2021-02-17 23:26:36 +00:00
jenkins-bot 872867c422 Merge "Fix highlight when new topic is posted without a title" 2021-02-17 23:26:34 +00:00
Bartosz Dziewoński 717955a513 Make new topic autosave specific to page title 
Bug: T274949
Change-Id: I7e1bbcd6c606c7443f55fe3b1780021b07b28c5e
 2021-02-17 20:09:13 +00:00
Bartosz Dziewoński b7917f5fa4 Fix highlight when new topic is posted without a title 
Bug: T272666
Change-Id: I9bf87d6e6e004001fa387e94623751eea694a14f
 2021-02-17 21:08:54 +01:00
Bartosz Dziewoński 9ae59e6ddb Disable VE indentation commands to allow tabbing out of the widget 
Bug: T172694
Change-Id: I458271a82a2aba475007d94901bd14f405bccb24
 2021-02-17 19:30:23 +00:00
Translation updater bot a2be5d32cc Localisation updates from https://translatewiki.net. 
Change-Id: Ia999e551b315b3c03d473dc754246b0f1f4c734e
 2021-02-17 08:42:29 +01:00
Translation updater bot 57f90ef72e Localisation updates from https://translatewiki.net. 
Change-Id: I6be4cdc1b213e158c1435633b8df2e0039fc3a3d
 2021-02-16 08:29:54 +01:00
Translation updater bot 3fe36e7f04 Localisation updates from https://translatewiki.net. 
Change-Id: Iddca426c39bfc80bd282934e511280548adafbf9
 2021-02-15 10:04:55 +01:00
jenkins-bot a0d97212cd Merge "Improve API parameter documentation" 2021-02-13 22:15:16 +00:00
jenkins-bot 5a9a4dc525 Merge "computeId() can't return null" 2021-02-13 22:14:02 +00:00
Bartosz Dziewoński 6659bb3f00 CommentFormatter: Fix problems with editsection and quotes 
Bug: T274709
Change-Id: I918fdd97064186381b65ab1567d02abf6f944b8f
 2021-02-13 20:01:58 +01:00
Bartosz Dziewoński 03f22c538e Improve API parameter documentation 
These messages are used on Special:ApiSandbox.

Change-Id: I07809d3f9402d30c5d2d364e0634bd020f86f64f
 2021-02-13 00:08:31 +01:00
Bartosz Dziewoński 1998c983f1 computeId() can't return null 
It used to return null for headings, but now it doesn't. Simplify some
code checking for that.

Change-Id: I28131c4aee89b901879b4c49953d6b15ed91b5e7
 2021-02-13 00:08:15 +01:00
Translation updater bot 0ac7cc7f33 Localisation updates from https://translatewiki.net. 
Change-Id: I0e36e25db72a2099bf1e0263df88b3e2ae504b7d
 2021-02-12 08:51:26 +01:00
Translation updater bot 859d68f56b Localisation updates from https://translatewiki.net. 
Change-Id: I7e01a7ce5736080facac70c89babba0d15f1b87c
 2021-02-11 08:38:32 +01:00
jenkins-bot f393fa5f03 Merge "Remove a TODO note about wrappers" 2021-02-11 00:09:50 +00:00
jenkins-bot d5b2389ffa Merge "Fix replying outside wrappers for partially indented comments" 2021-02-11 00:09:48 +00:00
Ed Sanders 361fd4c4a4 Add body class to enable reply links 
Going forward this will allow us to remove the parser
cache split, and toggle features just using CSS.

The CSS will be modified in a later commit to give the
anon caches time to clear.

Bug: T273072
Change-Id: I83c84b8bc63e1881e07b49acd8499b811adfccd4
 2021-02-10 15:40:34 +00:00
jenkins-bot 80b6896b8a Merge "Show relevant user in local suggestions on user talk pages" 2021-02-10 15:08:51 +00:00
Translation updater bot a78f328b33 Localisation updates from https://translatewiki.net. 
Change-Id: Ib569e247b68a6a2f517044fe0ea1772a67573859
 2021-02-10 08:38:21 +01:00
Ed Sanders b581883e7c Show relevant user in local suggestions on user talk pages 
Bug: T273324
Change-Id: I60e550efbea3d9e250dcaf13080407094a23aad3
 2021-02-09 21:51:28 +00:00
jenkins-bot 89dd44bb35 Merge "More test cases for comment wrappers (multiple siblings)" 2021-02-09 18:07:14 +00:00
Thiemo Kreuz 1e0d2d93b3 Add missing out-of-index guard to CommentUtils 
I found this error in our logstash. I was not able to find an
existing Phabricator ticket.

Note how line #348 extracts the last element from the
$siblings array. It uses the function end() there, which
returns false in case the array is empty. $siblings[0] can't
do this but yields an error.

An alternative is to use reset(), which can return false as
well. But that's not really better. Especially not better
readable, I would argue.

Change-Id: Ic90cd2392ede15078ba0d5b4d67b8dc5d05f9bf7
 2021-02-09 12:27:41 +01:00
Translation updater bot 7a93aeca7a Localisation updates from https://translatewiki.net. 
Change-Id: I3dea088ec6c16b9590c1ac78c1a14bb52432a87e
 2021-02-09 08:39:57 +01:00
Bartosz Dziewoński 3a1b8e09ea Remove a TODO note about wrappers 
Yes, this is still needed, removing it causes failures in tests
(and the old outputs look better).

Change-Id: I5bcedb0295a1f0ac4f6e51eaa9a9e072d8236f3c
 2021-02-08 22:23:54 +01:00
Bartosz Dziewoński 9d2b35828d Fix replying outside wrappers for partially indented comments 
Top-level comments that start or end with a list (inconsistent
indentation) would not have triggered the logic for detecting
wrappers.

Bug: T273692
Change-Id: Idcb4eed73e391f5f86eca2eb05cb3cea0d86f30a
 2021-02-08 22:18:37 +01:00
jenkins-bot 3da91953da Merge "Adjust new comment highlight timings" 2021-02-08 18:51:06 +00:00
Bartosz Dziewoński 3c7c9c6e3a Adjust new comment highlight timings 
The new timing exactly matches MediaWiki's post-edit notification.

Bug: T268994
Change-Id: I8233f56ad6e0d95285fee7f514fce914e7897905
 2021-02-08 16:49:50 +01:00
jenkins-bot c0d4bd007a Merge "Truncate user generated part of IDs to 80 characters" 2021-02-08 14:47:38 +00:00
Translation updater bot fe6d1d0485 Localisation updates from https://translatewiki.net. 
Change-Id: I30b78a0b4076357253fd3bbc9d8a3a8e7803e2cf
 2021-02-08 08:40:25 +01:00
Bartosz Dziewoński 5a4ca05981 Adjust the edit summary interface message 
Bug: T273944
Change-Id: Ibd23dc985e6fef7ab60d15bfb545c87b29af258c
 2021-02-05 13:30:13 +01:00
Translation updater bot 02883977fe Localisation updates from https://translatewiki.net. 
Change-Id: Iab4883e6e03abe1d3c5dcd9880d758993bca46e0
 2021-02-05 08:46:50 +01:00
Translation updater bot 3bfc0b2a2a Localisation updates from https://translatewiki.net. 
Change-Id: I2927d31711152829f61fa0e164b41fb3b106af5f
 2021-02-04 08:39:18 +01:00
Ed Sanders d05109b24d Truncate user generated part of IDs to 80 characters 
This ensures that IDs fit in a 255 character database field.

Bug: T273658
Change-Id: I3cfe4fce6a865b4343f0f01121cd696aa5f98b22
 2021-02-03 15:04:58 +00:00
Translation updater bot 6124c1acf7 Localisation updates from https://translatewiki.net. 
Change-Id: Ifb50676b19de745a0730915849d422c00a1ea245
 2021-02-03 08:39:04 +01:00
Bartosz Dziewoński 0f4db60e72 More test cases for comment wrappers (multiple siblings) 
For a moment I doubted if we handle this case correctly, but in fact
I didn't botch that code *this* badly.

Change-Id: I5a9d142e4bd97ac40aa388bb43b65ab1286e3f18
 2021-02-03 00:26:52 +01:00
Bartosz Dziewoński 1c3fada1fb Make CommentUtilsTest a proper unit test 
Documentation:
https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_for_extensions#Two_types_of_tests

We can do this because the tested methods do not depend on any globals
or on MediaWiki being installed.

In addition to being the new hotness, MediaWikiUnitTestCase allows the
test classes that use it instead of MediaWikiTestCase to start up much
faster. In my testing, running this test case individually now takes
0.35s, compared to 1.1s before.

Try:
* With new code:
  time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/unit/CommentUtilsTest.php
* With old code:
  time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/CommentUtilsTest.php

Change-Id: I771b1f3d101a394ee869e42547d9ae7839397752
 2021-02-02 15:37:17 +01:00
jenkins-bot 3a33cf81a8 Merge "Update localisation messages and their documentation for new discussion tool" 2021-02-02 12:12:45 +00:00