Go to file
Thiemo Kreuz 1e0d2d93b3 Add missing out-of-index guard to CommentUtils
I found this error in our logstash. I was not able to find an
existing Phabricator ticket.

Note how line #348 extracts the last element from the
$siblings array. It uses the function end() there, which
returns false in case the array is empty. $siblings[0] can't
do this but yields an error.

An alternative is to use reset(), which can return false as
well. But that's not really better. Especially not better
readable, I would argue.

Change-Id: Ic90cd2392ede15078ba0d5b4d67b8dc5d05f9bf7
2021-02-09 12:27:41 +01:00
.phan build: Add mediawiki/mediawiki-phan-config 2020-06-10 22:21:07 +02:00
i18n Localisation updates from https://translatewiki.net. 2021-02-09 08:39:57 +01:00
images Add beta feature preference 2020-02-21 15:20:48 +00:00
includes Add missing out-of-index guard to CommentUtils 2021-02-09 12:27:41 +01:00
maintenance Defensive use of dynamic paths in maintenance script 2020-02-20 19:51:07 +01:00
modules Merge "Adjust new comment highlight timings" 2021-02-08 18:51:06 +00:00
tests Merge "Truncate user generated part of IDs to 80 characters" 2021-02-08 14:47:38 +00:00
.eslintrc.json build: Update devDependencies 2020-06-09 19:42:05 +01:00
.gitignore Remove extra blank line from .gitignore file 2020-08-31 15:24:56 +01:00
.gitreview Add .gitreview 2019-10-09 21:18:34 +00:00
.phpcs.xml build: Updating mediawiki/mediawiki-codesniffer to 32.0.0 2020-10-29 10:53:01 +00:00
.stylelintrc.json Stylelint: Enforce class prefixes 2020-12-23 16:47:55 +00:00
CODE_OF_CONDUCT.md build: Updating npm dependencies 2020-01-09 06:43:15 +00:00
composer.json build: Updating dependencies 2021-01-29 09:54:58 +00:00
COPYING Add required files for an extension 2019-10-10 19:42:56 +01:00
extension.json Make CommentUtilsTest a proper unit test 2021-02-02 15:37:17 +01:00
Gruntfile.js build: Update devDependencies 2020-06-09 19:42:05 +01:00
package-lock.json build: Updating dependencies 2021-01-29 09:54:58 +00:00
package.json build: Updating dependencies 2021-01-29 09:54:58 +00:00