Commit graph

3514 commits

Author SHA1 Message Date
Bartosz Dziewoński 085ea2e8d1 Remove client-side timeout when saving pages (again)
Previously: e3e36e11ac (April 2020),
regressed: 3b31aa669d (October 2020).

Bug: T290514
Change-Id: Ifb09d62145e0b62c5b59708552a3a63b920e5b2f
2021-09-09 23:46:44 +02:00
Translation updater bot f2de0a465d Localisation updates from https://translatewiki.net.
Change-Id: I61adce5f1023fe9d79b61cf59bba8b18e4a6d422
2021-09-09 08:17:27 +02:00
libraryupgrader 26b69d2c70 build: Updating composer dependencies
* mediawiki/mediawiki-phan-config: 0.10.6 → 0.11.0
* php-parallel-lint/php-parallel-lint: 1.3.0 → 1.3.1

Change-Id: I76996ed939d706739d2094077c64eeca6f51126a
2021-09-08 23:14:53 +00:00
Translation updater bot 93079c7eab Localisation updates from https://translatewiki.net.
Change-Id: I74077147422a8549d4d5624c9582db1d6f5ea371
2021-09-08 08:10:15 +02:00
Bartosz Dziewoński e634701460 Always apply DiscussionTools page transformations
Bug: T273072
Bug: T280599
Change-Id: I0b39ef2f9ede15905951a54c043dd228bd5ace9f
2021-09-08 00:16:30 +02:00
Bartosz Dziewoński 0ae97ef550 Deduplicate logic for subscribable headings
Change-Id: I1cd96cf0bcce2101455702f1350d8a4336c60790
2021-09-07 21:38:35 +00:00
Bartosz Dziewoński 8bb36bd782 Add API to get the status of topic subscriptions on a page
(Split off from Ic0fabda0de4ebbc5e424f49641e6b03ebb4b7e6a)

Bug: T290185
Change-Id: Iacc0f92bedfcb49e8a05d98af4d8170d08b1c8de
2021-09-07 21:38:09 +00:00
Bartosz Dziewoński ce899aaadd Inject services in hook handlers where possible
Change-Id: Ie5c36cabd90412d2299b00d2b0c3c3bdf9ffc6d6
2021-09-07 22:51:35 +02:00
Bartosz Dziewoński c70a203111 Inject ConfigFactory in API modules
…plus minor tweaks.

Change-Id: I80ded8bac836f4a49d61c51c4d17b48687628986
2021-09-07 18:36:12 +02:00
Bartosz Dziewoński 9819df3288 CommentParser: Remove outdated legacy ID algorithm
Last changed in March (4a0802065c),
was only needed for about 2 weeks for compatibility with cached data.

Change-Id: I510238cb86a7b4d7ae5e8636716d1e9ca2d0e402
2021-09-07 17:41:30 +02:00
Translation updater bot e953a9c262 Localisation updates from https://translatewiki.net.
Change-Id: I97056dfc7e67b240232551e43083fa00fff8eb76
2021-09-06 08:20:39 +02:00
libraryupgrader d41ea5ed3c build: Updating stylelint-config-wikimedia to 0.11.1
Change-Id: I5e956c73e99afdaf467e067566dbdc3ca2efc30c
2021-09-04 19:36:49 +00:00
jenkins-bot 3287ea3f1d Merge "HookUtils: Remove unused variable" 2021-09-03 20:38:28 +00:00
jenkins-bot 54d5d06e27 Merge "ThreadItem: Remove redundant check" 2021-09-03 20:37:52 +00:00
Bartosz Dziewoński 23d2255111 HookUtils: Remove unused variable
Change-Id: I3f8aec349a5845b3ea4d08d3257937467497f2a2
2021-09-03 19:13:34 +00:00
Bartosz Dziewoński 317c608eda ThreadItem: Remove redundant check
CommentItem::getAuthor() used to return null in the past.

Change-Id: I66f4e83b51b6efef7441d4b963f6db09571d9393
2021-09-03 19:13:21 +00:00
Translation updater bot eacaadde91 Localisation updates from https://translatewiki.net.
Change-Id: I0746742ea81f7873475ad7141cedee47ab130659
2021-09-03 08:14:53 +02:00
jenkins-bot 22bb9d9b42 Merge "New topic tool: Show empty title warning only when focussing the description" 2021-09-02 19:45:58 +00:00
Bartosz Dziewoński 89aebfee07 New topic tool: Show empty title warning only when focussing the description
Currently the message appears too often when the user is not really
intending to interact with the widget.

Bug: T287901
Bug: T288316
Change-Id: I38b4c0b8817b9a9238fb6adc91ab2d1231650eff
2021-09-02 19:27:30 +00:00
Translation updater bot 6fb08ddd54 Localisation updates from https://translatewiki.net.
Change-Id: If7b53439398de6ded7e9850421b2c20c2fae626d
2021-09-02 08:26:13 +02:00
Translation updater bot 49aacb31e6 Localisation updates from https://translatewiki.net.
Change-Id: I167b63b421c87a31dd78b4a410e1790d66d04c6d
2021-09-01 08:16:10 +02:00
Bartosz Dziewoński 9273611a08 Remove unused 'use' definitions
I guess that at some point this class was meant to convert some
timestamps, but it does not (it returns them as strings in the
database format).

Change-Id: I33ee5e8807ee686b77819ef16f43509326c60762
2021-08-31 22:03:51 +02:00
Translation updater bot 20ce7f1815 Localisation updates from https://translatewiki.net.
Change-Id: I62eb99bed2b2a63e36547ebae67dccb5589d1be6
2021-08-31 08:15:40 +02:00
jenkins-bot 82cd8f6578 Merge "Fix finding topmost comment when there are 3+ highlighted" 2021-08-30 16:03:35 +00:00
Bartosz Dziewoński 6bec44a236 Fix finding topmost comment when there are 3+ highlighted
This code made no sense.

Follow-up to db28a3d3a7.

Bug: T286620
Bug: T290006
Change-Id: I08712e31824315da231d15098073e3ec5be273e4
2021-08-30 15:59:20 +02:00
Translation updater bot 61d5b624ae Localisation updates from https://translatewiki.net.
Change-Id: Ia92bf13ab44a2ec8d55b1df4f059a0da8ab254da
2021-08-30 08:20:05 +02:00
David Lynch 90bbcb904d Hide top-level error when new discussion widget is open as well
This will hide the user-not-registered warning, stopping it appearing
duplicated in the notices.

Change-Id: I508b5fc4161cb7e109f9a5a83f6188675c8be83a
2021-08-27 10:12:51 -05:00
Translation updater bot b2ba8b7b31 Localisation updates from https://translatewiki.net.
Change-Id: I7470c967dba7479a2a78385baf93f922c30254fa
2021-08-27 08:43:42 +02:00
jenkins-bot c68d0aeec1 Merge "Empty states for anon/IP user talk pages" 2021-08-26 20:20:20 +00:00
jenkins-bot 1f9a0c45d2 Merge "Empty state copy changes" 2021-08-26 20:20:18 +00:00
David Lynch 21600231d9 Empty states for anon/IP user talk pages
Bug: T287779
Bug: T288556
Change-Id: I9d01d1ac04c0cc443c4cbfe94d301db16f5b1ef6
2021-08-26 22:11:13 +02:00
jenkins-bot 35b3859ce9 Merge "Hide the top-level warningbox when the new discussion widget is open" 2021-08-26 19:30:10 +00:00
David Lynch dcd3d23d31 Hide the top-level warningbox when the new discussion widget is open
Bug: T289354
Change-Id: I251bed09764a0d6389dbb62403ebacbf1abd41c3
2021-08-26 13:19:14 -05:00
David Lynch e85795446b Empty state copy changes
Bug: T288741
Change-Id: Ie8b8fc69d853bce21765926f36e2d1f730abbb5e
2021-08-26 12:03:50 -05:00
Translation updater bot fd6455f774 Localisation updates from https://translatewiki.net.
Change-Id: I813ea54544d4650b431f55947f6be3b3c81a9af6
2021-08-26 08:35:58 +02:00
Bartosz Dziewoński 4bbbdc9703 EventDispatcher: Try really, really hard to read from master
Follow-up to 37d6825c14.

Bug: T289717
Depends-On: I2a614915c7d9ffbc4f466204b2684478fb52f30e
Change-Id: Id2e040a19e457a2a8f4121b04ebd43bf6ea64181
2021-08-25 21:38:10 +02:00
Translation updater bot c960f41652 Localisation updates from https://translatewiki.net.
Change-Id: Ie0a9733577deffa4b0ee703bee5f955e1c6c1113
2021-08-24 12:38:41 +02:00
Translation updater bot c907cf4a43 Localisation updates from https://translatewiki.net.
Change-Id: If6420654e66fa1fc2131d26587e97b3fb503936f
2021-08-24 10:20:59 +02:00
Bartosz Dziewoński a6a547f2b2 Add some tests covering ThreadItem::getHTML() and related methods
* ThreadItem::getText
* CommentItem::getBodyText (used when generating notifications)
* ThreadItem::getHTML (may soon be used in API)
* CommentItem::getBodyHTML (may soon be used in API)
* ImmutableRange::cloneContents (the common implementation for all
  of the above)

The outputs are only lightly reviewed. This is mostly meant to
document the current behavior rather than the expected behavior,
to avoid making unintentional changes while refactoring.

Change-Id: I14471ee4969aa3d0b5577d9de2a6d4462fab4d09
2021-08-24 07:54:09 +02:00
jenkins-bot b1eb884966 Merge "Improve discussiontoolssubscribe API documentation" 2021-08-24 02:42:17 +00:00
jenkins-bot 5d9d28b280 Merge "ApiDiscussionToolsSubscribe: Remove redundant checks" 2021-08-24 02:41:26 +00:00
Bartosz Dziewoński 90d84a0504 Fix localisation files for 781576fd
Doing this manually, because otherwise the next WMF branch would have
broken translations, and it's a pain to backport localisation changes.

Find:           :{{ARTICLESPACE}}:{{PAGENAME}}
Replace with:   :{{SUBJECTPAGENAME}}

Find:           {{ARTICLESPACE}}:{{PAGENAME}}
Replace with:   :{{SUBJECTPAGENAME}}

Change-Id: Ie64e57f705721be463750a0d876b92a06ae2e37b
2021-08-24 00:50:30 +02:00
jenkins-bot 2086851d44 Merge "Load styles in ParserOutput too" 2021-08-23 20:50:20 +00:00
Bartosz Dziewoński 6dd90eda4a Improve discussiontoolssubscribe API documentation
Bug: T280314
Change-Id: I0987faac2cd8c5276a37869212fa968f0d642c09
2021-08-23 18:40:00 +00:00
Bartosz Dziewoński bb5054435f ApiDiscussionToolsSubscribe: Remove redundant checks
$user is guaranteed to be a User object.

Also, while we're here:
* Remove an unnecessary TODO. There's no need for a more specific
  error message, this one is just fine, other extensions use it too.
* Replace isAnon() with !isRegistered(). It'll probably be deprecated
  soon, because the new UserIdentity interface doesn't include it.

Change-Id: Ifbe98f4eccef79deee6bdb54c1bccf49807a9563
2021-08-23 20:39:18 +02:00
Bartosz Dziewoński 781576fd7c Fix broken link in empty state on article talk pages
`[[:{{ARTICLESPACE}}:{{PAGENAME}}]]` results in `[[::Foo]]`, which
is not a valid link.

Luckily, there's a magic word `{{SUBJECTPAGENAME}}`, which is the same
as `{{ARTICLESPACE}}:{{PAGENAME}}`, but without pesky leading colons.

Follow-up to bb0b65dc0c.

Change-Id: I992bdb8807c665561cad58997017aab5a6c1d8e8
2021-08-23 17:36:13 +00:00
Translation updater bot 9018cc9997 Localisation updates from https://translatewiki.net.
Change-Id: Iaa5643ff5e3e46abf6aa821acea285ce26c6f037
2021-08-23 09:03:52 +02:00
Raymond bb0b65dc0c Add colon to avoid loading the file on file talk pages
example: https://commons.wikimedia.org/w/index.php?title=File_talk:Vorstellung_Projekt_MuLI,_KVB-Haltestelle_Bocklem%C3%BCnd-3380.jpg&action=edit&redlink=1
Change-Id: I9067390a7861cfb328fedfe6f5e56384ac141aeb
2021-08-20 22:49:03 +02:00
David Lynch 503d2f1f76 Enforce no text-indent on our reply button
Change-Id: Ie26d7632ec4845cc9048c0261b51ff2a1b6b51e2
2021-08-20 13:46:23 -05:00
Bartosz Dziewoński 3e19fce67a Load styles in ParserOutput too
We load them in OutputPage, because we need that to handle the
query parameter 'dtenable=1', but do it here as well just in case
the pages are somehow shown without involving OutputPage.

Per code review:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/713681/1/includes/Hooks/ParserHooks.php#90

Change-Id: I3f287a9e146de7fd4d37c47dfa47eeb03eeb8cf1
2021-08-20 18:49:04 +02:00