Commit graph

3514 commits

Author SHA1 Message Date
Bartosz Dziewoński 98bba62e5d Add [reply] link brackets during postprocessing after parser cache
This should avoid them showing up in unexpected contexts where parser
output is used (e.g. API T292345, search T294168, action=render).

Also rename some variables to be directionality-neutral.

Bug: T292345
Bug: T294168
Change-Id: Ibcac44ee10f0842e205d9dd9a7f3a935ce0c690b
2021-10-26 19:55:09 +00:00
Bartosz Dziewoński 884d1f6ec6 Move body classes code to BeforePageDisplay hook
Seems like a better place and it avoids duplication.

Change-Id: I26643c42cb7aa19cf0dfae449347f2fec2f8bc61
2021-10-26 17:42:39 +02:00
Translation updater bot 7ee34804ac Localisation updates from https://translatewiki.net.
Change-Id: I1c265dce272bac7dd92e625ff763c416a6a25586
2021-10-26 08:17:12 +02:00
Ed Sanders f0149541b0 Update watchlist checkbox when main watchstar is changed
Bug: T294122
Change-Id: If50d5596fd86ed273658a275c9b3be31f39eaad7
2021-10-25 15:27:04 +01:00
Translation updater bot c805edb7f0 Localisation updates from https://translatewiki.net.
Change-Id: If4c239af117de94c36a8fd594b6671f50f77dcb8
2021-10-25 08:51:19 +02:00
libraryupgrader 8bac47f4fb build: Updating mediawiki/mediawiki-codesniffer to 38.0.0
Change-Id: I2a4206a563fe6ab548243b05c000035032b233f5
2021-10-24 02:15:38 +00:00
jenkins-bot 0b3a0c1367 Merge "Rephrase 'apierror-discussiontools-commentname-ambiguous'" 2021-10-23 19:33:29 +00:00
jenkins-bot e5822fa037 Merge "Fix phrasing of 'tag-discussiontools-edit' message (unused)" 2021-10-23 13:17:12 +00:00
Bartosz Dziewoński 6fb376a11a Rephrase 'apierror-discussiontools-commentname-ambiguous'
I think API error messages should be impersonal. Also clarify which
parameter must be provided.

Change-Id: I43ab66fddbd0c7f9948a6e2859d621a45d3f34ba
2021-10-22 17:18:54 +02:00
Bartosz Dziewoński c4e08d7736 Fix phrasing of 'tag-discussiontools-edit' message (unused)
A tag described as "Edit comment" doesn't make sense grammatically.
It should be in past tense, "Edited comment". (Another option could
be a noun, "Comment edit", but that seems less clear.)

Change-Id: I32cf6e533b4b98b5206dd3c74abdf5168f1f2e37
2021-10-22 17:16:07 +02:00
Bartosz Dziewoński 8c626a18ed Replace "Learn more" links with descriptive links in talk page empty states
Also, add a link to 'discussiontools-emptystate-desc-self-anon'.

Bug: T288741
Change-Id: Ibc4b5c46f146502d2eab6dc36eddef7dc22e5b5d
2021-10-21 23:17:59 +00:00
Bartosz Dziewoński 588a8825b2 Add {{GENDER:}} hint to empty state messages for user talk pages
The markup has no effect in English, but it helps reassure translators
that it will work if they need to provide multiple grammatical forms
in their language (or remind them that they do).

It also lets us test this functionality even when testing in English.

Bug: T292636
Change-Id: I093e9a1e0e8e3e9a1808220ab12831fdf8dbc108
2021-10-21 23:17:48 +00:00
jenkins-bot 109f0df289 Merge "ImmutableRange: Port over changes from upstream" 2021-10-21 13:59:17 +00:00
Ed Sanders ff46f37b56 ImmutableRange: Port over changes from upstream
* Explode boundary point tuples passed to computePosition
* Note that we won't use previousSibling instead of array_reverse
* Simplify logic using xor

Change-Id: I927256e31b5e441aade91b4fd0d83d8f0d89afbe
2021-10-21 12:42:27 +01:00
Translation updater bot e19c19fcbe Localisation updates from https://translatewiki.net.
Change-Id: Ic464863942b73b9f0ceb13015249b87263542ad5
2021-10-21 08:21:37 +02:00
Translation updater bot eaa2fb5c5c Localisation updates from https://translatewiki.net.
Change-Id: I7192db6b21ba983357c3738cb271e554fef6cce6
2021-10-20 08:36:44 +02:00
jenkins-bot 4d633e42ca Merge "Remove unused non-parser-cache mode" 2021-10-19 15:57:08 +00:00
jenkins-bot 344fe433ca Merge "Remove parser cache splitting ('dtreply' option)" 2021-10-19 15:57:06 +00:00
jenkins-bot fbcb6d50a5 Merge "Define documentable types in eslintrc instead of inline" 2021-10-18 21:31:02 +00:00
Translation updater bot cdc4954fe2 Localisation updates from https://translatewiki.net.
Change-Id: I8e7b9700691394c145c8feb867925ed1dc9873c2
2021-10-18 15:19:56 +02:00
Ed Sanders f4c12e120a Define documentable types in eslintrc instead of inline
These types can be passed a parameters to any file without
creating a dependency, so it makes more sense to allow
the globally.

Change-Id: I5504465fd997b46547642e7046993b370b85586e
2021-10-17 14:38:39 +01:00
jenkins-bot aa8ed1d469 Merge "Remove redundant checks" 2021-10-14 16:02:32 +00:00
Bartosz Dziewoński d83816f508 Remove redundant checks
The info in wgDiscussionToolsFeaturesEnabled already includes a check
for user options.

Change-Id: I01377e647b1dd5d06b67d1e0c7ee6940f1617066
2021-10-13 21:59:47 +02:00
jenkins-bot 3df2f3c623 Merge "modifier: Handle empty nodes in appendSignature()" 2021-10-13 17:26:56 +00:00
jenkins-bot e5f8b1fe47 Merge "Replace marker comment with limit report data" 2021-10-12 15:20:13 +00:00
jenkins-bot a56d1a0a98 Merge "Re-enable wikitext paste conversion in source mode" 2021-10-12 15:19:45 +00:00
jenkins-bot 906cbe2d75 Merge "Compatibility with Microsoft Edge's translation feature" 2021-10-12 13:52:22 +00:00
Ed Sanders 7f16b7a4c2 TopicSubscriptions: Rename 'actions' column and unframe button
Bug: T273342
Change-Id: Ifd18551e0d89e5c0d4cebd022afebb9a31e2619b
2021-10-12 14:06:57 +01:00
Ed Sanders 7550bb4395 TopicSubscriptions: Hide broken "Topic" sort
This doesn't sort by the topic name, but the hidden
sub_id field, leading to a confusing order.

Bug: T273342
Change-Id: I6146abf05544d40c9ef0d2e8c58d020e5a5fa8a2
2021-10-12 14:04:59 +01:00
Alexander Vorwerk 0935bb1271 MediaWikiTestCase -> MediaWikiIntegrationTestCase
MediaWikiTestCase has been renamed to MediaWikiIntegrationTestCase in 1.34.

Bug: T293043
Change-Id: I485c5c5f0376ab60cdec49e934c6e7eea8c9feb5
2021-10-12 00:40:27 +02:00
Bartosz Dziewoński 8c6928aacf modifier: Handle empty nodes in appendSignature()
Bug: T292664
Change-Id: I0003528076e3981d639d337affcccbf394f59224
2021-10-11 22:17:46 +02:00
libraryupgrader b0c8621973 build: Updating ansi-regex to 5.0.1
* https://npmjs.com/advisories/1002401 (CVE-2021-3807)

Additional changes:
* eslint: Added `wikimedia/mediawiki` profile (T262222).
* composer.json: Updated phpcs command in composer test (T280592).
* composer.json: Added phpcs command to scripts (T280592).

Change-Id: I39276efa5a6991f6216992840c497ae9d3b5fd7d
2021-10-09 07:08:30 +00:00
Bartosz Dziewoński 384fc2aa8d Re-enable wikitext paste conversion in source mode
The current experience (implemented in T282789) is unobtrusive and
maybe even helpful.

This reverts commit 35e97c24fe.

Bug: T281009
Change-Id: I0514e8f8960600edf12b51fff6de305e46cf8c34
2021-10-09 03:38:11 +02:00
Translation updater bot 0dd0fc0013 Localisation updates from https://translatewiki.net.
Change-Id: I7c1b1d49bca753a6a99c361cb42f1f0bc124403d
2021-10-08 09:20:45 +02:00
Ed Sanders 605e7322b8 eslint: Lint root folder with server rules
Change-Id: I372eef293983bff0c79ad8aa0da1c7e5d07b1e44
2021-10-07 17:37:52 +01:00
Ed Sanders 02642e48dd Fix linting on i18n key order
Change-Id: Id30b228f2aaa710f75086b6b64ffda5726d59a8e
2021-10-07 17:37:51 +01:00
Bartosz Dziewoński 695a966a41 Remove unused non-parser-cache mode
Change-Id: Ief9f4153898b09a1ce15ccfdc8656dfad4642269
2021-10-07 17:59:10 +02:00
Bartosz Dziewoński dbb8b00ec7 Remove parser cache splitting ('dtreply' option)
Bug: T280599
Change-Id: I08b52874d575619308b5b83a39acfb6353c5b7b5
2021-10-07 17:59:10 +02:00
Bartosz Dziewoński e3af0bc65b Replace marker comment with limit report data
We always do our processing in the parser now, so we don't need the
marker comment to detect whether we've already processed the page.

Bonus: include the time taken by our processing in the limit report.

Bug: T291831
Change-Id: Ife7ddffbad1b1495b004739212002a98fdebe6c0
2021-10-07 17:59:10 +02:00
jenkins-bot f8bd39adbf Merge "Add Special:TopicSubscriptions" 2021-10-07 14:53:59 +00:00
Translation updater bot 52b3ba2ef7 Localisation updates from https://translatewiki.net.
Change-Id: Ie1271d0521feb36a397089f9ecd123406b6a7b63
2021-10-07 09:02:46 +02:00
Bartosz Dziewoński 59cba79c85 Compatibility with Microsoft Edge's translation feature
Bug: T292675
Change-Id: I7bc4dded7fdd522167d473dce4843d666c6e88fd
2021-10-06 21:01:10 +00:00
Bartosz Dziewoński a0dc12ab56 Add Special:TopicSubscriptions
Bug: T273342
Change-Id: If96a0df1efbf5cadfb6bf2bf8f7ad5c9c90ea142
2021-10-06 20:06:01 +00:00
Translation updater bot b0ce65736e Localisation updates from https://translatewiki.net.
Change-Id: Ic9c6f2aec7b1a75c160dc701a6b11cd65f2069f6
2021-10-06 09:28:17 +02:00
jenkins-bot c7d82f4ddc Merge "Remove uppercase of first character of auprefix" 2021-10-05 20:57:58 +00:00
jenkins-bot c4f94d0202 Merge ""Reply ... in one click" -> "Reply ... with one click"" 2021-10-05 19:22:43 +00:00
Bartosz Dziewoński 11566e4b27 Allow more flexible overrides for the terms-of-use messages
Bug: T284097
Change-Id: Ibacd9397a40ffcc8a8127ec543cb2f7300ce5464
2021-10-05 17:58:37 +02:00
jenkins-bot 1a67ab6d74 Merge "Make reply links more robust so Google Translate won't break us" 2021-10-05 13:53:03 +00:00
Translation updater bot bbf98c00a4 Localisation updates from https://translatewiki.net.
Change-Id: I9a0584c3b7e17e6d7dc078cd57951824b34317da
2021-10-05 08:29:31 +02:00
David Lynch 4211494ed7 Make reply links more robust so Google Translate won't break us
Normal link: `<a>reply</a>`

Google Translate: `<a><font><font>reply</font></font></a>`

Using jQuery's `closest` method to make sure we go up if the event
target isn't the data-mw-comment element should avoid problems.

Bug: T245563

Change-Id: I19ffb9a5b91617b98b0f00e4d185c01bcde093b0
2021-10-05 01:07:36 -05:00