wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-24 10:58:20 +00:00
Code Issues Packages Projects Releases Wiki Activity
1955 commits 138 branches 0 tags 114 MiB
Commit graph

1955 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 6572e108f9 Remove empty lines in visual mode in some more cases 
After switching from source mode to visual mode, there will be some
Parsoid-generated white space between block nodes, which remains when
the reply is posted in visual mode.

Follow-up to e064f43499.

Bug: T300439
Change-Id: Ia5d2c06f0a4125e9f148eddd3235f95138c9d37f
 2022-01-29 22:42:41 +00:00
Bartosz Dziewoński bacf6a8fc6 Remove unused code in JS modifier 
I don't think we're going to need this in the client again.

Change-Id: Id38405c14edfd7ac45afad8f32cad64594ae7bc0
 2022-01-29 21:39:45 +00:00
Translation updater bot 03344f2f5c Localisation updates from https://translatewiki.net. 
Change-Id: I45832232e047fba9c238ab8e1931959e6c55f0a7
 2022-01-25 08:32:35 +01:00
jenkins-bot 0b52563b53 Merge "One more tweak for comparing comment ranges to transclusion/DOM ranges" 2022-01-24 23:37:07 +00:00
jenkins-bot 4679dd27b3 Merge "Use class list everywhere for adding/checking CSS classes" 2022-01-24 23:37:05 +00:00
jenkins-bot 51e4fdea9f Merge "Don't try to parse section titles as wikitext in subscription notifs" 2022-01-24 23:23:34 +00:00
jenkins-bot 9892008135 Merge "Simplify handling of sections in bundled notification links" 2022-01-24 23:21:54 +00:00
Bartosz Dziewoński 110a59200f One more tweak for comparing comment ranges to transclusion/DOM ranges 
When we encounter a node that doesn't represent comment contents, e.g.:
* a [reply] link we inserted (T297034#7641334)
* an {{outdent}} template (see changed test case)

…we should ignore it together with its descendants (like in
Parser#nextInterestingLeafNode), instead of processing descendants
and possibly detecting comment contents in them.

Follow-up to 8de940b587,
72b9c2c6f5.

Bug: T297034
Change-Id: Ib2fa40c5fa389572b0e88ef558728fa06e3621b0
 2022-01-24 17:42:18 +00:00
Bartosz Dziewoński f15693eefa Use class list everywhere for adding/checking CSS classes 
In PHP, use DOMCompat::getClassList(), provided by Parsoid.
In JS, use `.classList`, available in all supported browsers.

This may fix some bugs where we were incorrectly checking for exactly
one class. The change in isOurGeneratedNode() is needed for
Ib2fa40c5fa389572b0e88ef558728fa06e3621b0.

Change-Id: Ia28d31678fd3d617b69280c4b7857755300fa515
 2022-01-24 18:40:00 +01:00
Translation updater bot ea54d68f2d Localisation updates from https://translatewiki.net. 
Change-Id: I4f0fd50eb877b4d2caa90b5f8607458ff7f8c223
 2022-01-24 08:27:03 +01:00
jenkins-bot 5fa81c4123 Merge "Restore scrolling to comments when clicking a bundled notification" 2022-01-22 17:24:32 +00:00
Bartosz Dziewoński 35d6a0d853 Restore scrolling to comments when clicking a bundled notification 
Follow-up to ebd37369ce.

Bug: T299813
Change-Id: Idd95f21921a89633f5d85aa993ba07aaab59ff20
 2022-01-22 03:48:37 +01:00
jenkins-bot 3a4a6bff16 Merge "Add another test case for transclusions overlapping comments" 2022-01-21 22:25:46 +00:00
Translation updater bot 636b646e45 Localisation updates from https://translatewiki.net. 
Change-Id: Id98e357f77f901ec7788b8b1db201070c69e058e
 2022-01-21 08:13:52 +01:00
jenkins-bot 4a0db2ae45 Merge "Add an optional suffix message to mentions" 2022-01-21 00:36:15 +00:00
jenkins-bot 0e8c9b9536 Merge "Update DiscussionTools phan configuration to match new Parsoid DOM alias config" 2022-01-20 23:34:25 +00:00
Bartosz Dziewoński 5919e4e371 Don't try to parse section titles as wikitext in subscription notifs 
Bug: T299572
Depends-On: Idb3a87fd18330f90a8cdc1276994d54288e17b28
Change-Id: I3b58f337bb2ea1f5255fc0a41dbd7a5ad8c433db
 2022-01-21 00:12:58 +01:00
Bartosz Dziewoński d2405cc11c Simplify handling of sections in bundled notification links 
This code previously ensured that the fragment identifier linking
to a section was only included if all events had the same section.
It doesn't actually seem worth the effort, since we handle scrolling
to the highlighted comments client-side anyway.

And the links were not quite correct, because we didn't parse and
strip the section title as expected by built-in Echo events. Just
use Echo's code for this.

Depends-On: Idb3a87fd18330f90a8cdc1276994d54288e17b28
Change-Id: Icae0d3654dd02109337ff8737b16f55bbd514f43
 2022-01-21 00:06:36 +01:00
C. Scott Ananian c643669dbd Update DiscussionTools phan configuration to match new Parsoid DOM alias config 
Bug: T240775
Followup-To: I99e1768c4dcbe84d73d13ddd34a181d68e9fcb5e
Depends-On: I68228213a2af937923751dcc2c121551396c6498
Change-Id: I9c5d1fc4c59469f0af9da81f94aac0ccd779d4df
 2022-01-20 17:16:35 -05:00
Bartosz Dziewoński 8f937eb9da Prevent assertion failure caused by empty headings 
Follow-up to 8de940b587.
See also 8b426c7e5c.

Bug: T299583
Change-Id: Ibd2c459330cfc7664bd36d7840209779450d72d4
 2022-01-20 18:56:32 +00:00
Translation updater bot 4b138f128f Localisation updates from https://translatewiki.net. 
Change-Id: I2842ad13ded091c3ed7c1c88763304937f3272cc
 2022-01-20 09:17:31 +01:00
jenkins-bot 7843aab8af Merge "When using bullet syntax, hide the marker next to the reply tool" 2022-01-20 01:40:27 +00:00
Bartosz Dziewoński b019196e7a When using bullet syntax, hide the marker next to the reply tool 
Bug: T259864
Change-Id: I47097c2b06f9deade7c234f08ebacb83d16a1d6d
 2022-01-19 23:05:05 +01:00
jenkins-bot 70a701dd13 Merge "Include namespace when referring to page title in empty state messages" 2022-01-19 18:40:41 +00:00
David Lynch dccaa5bf65 Add an optional suffix message to mentions 
Wikis like jawiki will then be able to customize the message to include
honorifics as they think appropriate.

Bug: T268588
Change-Id: I213fb9fd0a9ed6592ce3548a5b2c3b11a55c1abc
 2022-01-19 10:29:10 -06:00
Translation updater bot 7694243a9f Localisation updates from https://translatewiki.net. 
Change-Id: Ic2cc7510e7bf664b4266f3804926bcabd335dd57
 2022-01-19 08:23:59 +01:00
Translation updater bot 10acc0ea8f Localisation updates from https://translatewiki.net. 
Change-Id: I1ccc84bee60d1d89b33b8981c995dcb3b0455cad
 2022-01-18 08:10:49 +01:00
Bartosz Dziewoński 4e4e9f1c80 Add another test case for transclusions overlapping comments 
Prior to 8de940b5, the comments on this page would not be marked as
partially transcluded.

Bug: T298408
Change-Id: Ib7eb8b4113151048c0e778b3530600d98dd8f705
 2022-01-17 23:52:02 +01:00
Translation updater bot d354e3fff6 Localisation updates from https://translatewiki.net. 
Change-Id: I092f62e4b92ba5b108c961e740622d033f3d9339
 2022-01-17 08:12:00 +01:00
jenkins-bot ed8560569e Merge "Add tests for bullet indentation" 2022-01-15 02:38:31 +00:00
jenkins-bot 610ca856b2 Merge "Work around Karma test runner timeouts caused by large tests" 2022-01-14 21:52:35 +00:00
Translation updater bot f2219191d2 Localisation updates from https://translatewiki.net. 
Change-Id: I4ed8640cafdcf5b981bc52033338c7bc18ed3e18
 2022-01-14 08:16:18 +01:00
Bartosz Dziewoński 0369b11efc Include namespace when referring to page title in empty state messages 
Bug: T298454
Change-Id: I5a2d53f08887df3750dd131269757a9f35179478
 2022-01-14 01:50:19 +01:00
Bartosz Dziewoński b7cbd714ca Add tests for bullet indentation 
Bug: T259864
Change-Id: If38016564b67ee7217fe7328b40973aa244ff467
 2022-01-14 00:27:04 +00:00
Bartosz Dziewoński 1ce3d7ab7e Work around Karma test runner timeouts caused by large tests 
Change-Id: I8c7d32dac073e1f0510e57f26ba81ff22f005f0a
 2022-01-14 00:26:37 +00:00
Translation updater bot 428de4a658 Localisation updates from https://translatewiki.net. 
Change-Id: I8cbca1c669d4fc19820e2abaa5a85019ac9d3aa7
 2022-01-13 08:26:55 +01:00
jenkins-bot 39249d6e69 Merge "Ensure the marker appears in a reasonable place when replying with a bullet" 2022-01-13 00:57:53 +00:00
jenkins-bot 5181d099ab Merge "PreferenceHooks: Don't call saveSettings in LocalUserCreated" 2022-01-12 21:58:04 +00:00
Bartosz Dziewoński faf6da62cc Ensure the marker appears in a reasonable place when replying with a bullet 
Bug: T259864
Change-Id: I782460797ea78ab689cbab19c631f651315d2c8f
 2022-01-12 22:57:48 +01:00
jenkins-bot 3699158e81 Merge "Handle selflinks by returning the current page's title" 2022-01-12 21:46:35 +00:00
jenkins-bot 7f329ca9a2 Merge "Enable wikis to customize the syntax used for replies" 2022-01-12 21:32:49 +00:00
Ed Sanders f80ff74fc6 Handle selflinks by returning the current page's title 
Bug: T287818
Change-Id: I67f10ac9976581279d1e6a477e90d55875ebab20
 2022-01-12 21:18:04 +00:00
Ed Sanders 34011b7a07 Parser: Pass in title of page being parsed 
Will be used to parse selflinks in the future.

Change-Id: I2bc29d1c5c69cb6309f582f162f9af7d96ce8913
 2022-01-12 21:17:59 +00:00
Ed Sanders 1fed7115f4 Tests: Add original titles to test cases 
These are not used for anything yet, but soon the parser will
want to know the title of the page it is parsing.

Change-Id: I02fa5d63fae78f3e92032d93bc27ac5c744faecb
 2022-01-12 22:16:03 +01:00
Bartosz Dziewoński 7b1053300a Enable wikis to customize the syntax used for replies 
The following values for configuration variables are supported:
$wgDiscussionToolsReplyIndentation = 'invisible'; (default)
$wgDiscussionToolsReplyIndentation = 'bullet';

Bug: T259864
Change-Id: Icefad79630adc6ed35687498614e6a03ede1451b
 2022-01-12 20:54:04 +00:00
jenkins-bot 20378e7be3 Merge "Ignore the watch star when replying to a transcluded comment" 2022-01-12 18:26:25 +00:00
Kosta Harlan f9f1884ac3 PreferenceHooks: Don't call saveSettings in LocalUserCreated 
$user->saveSettings() happens in AuthManager after the LocalUserCreated
hook finishes running.

Bug: T199393
Change-Id: Ic661dbe1ffaa3a5438373a33c10ad3053662d932
 2022-01-12 19:21:17 +01:00
jenkins-bot f189c985da Merge "Fix placeholder headings causing exceptions in getTranscludedFrom()" 2022-01-12 17:18:55 +00:00
jenkins-bot 6c5461d858 Merge "Treat user talk subpages like normal talk pages in empty state text" 2022-01-12 17:04:21 +00:00
jenkins-bot ed9fca9e5c Merge "Ensure [subscribe] buttons don't float too far away" 2022-01-12 15:06:11 +00:00