wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 00:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure the marker appears in a reasonable place when replying with a bullet

Browse source 
Bug: T259864
Change-Id: I782460797ea78ab689cbab19c631f651315d2c8f
This commit is contained in:
Bartosz Dziewoński 2022-01-11 23:21:28 +01:00
parent 3699158e81
commit faf6da62cc
2 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
modules/CommentController.js
View file

@ -171,6 +171,22 @@ CommentController.prototype.setup = function ( mode, hideErrors ) {
}
$( commentController.newListItem ).empty().append( replyWidget.$element );
if ( commentController.newListItem.tagName.toLowerCase() === 'li' ) {
// When using bullet syntax, add some normal-looking text to the list item, so that the list
// marker will be shown in a reasonable place. If there's no obvious text, browsers go crazy.
// (IE 11 adds some empty space at the top of the list item, and aligns the marker with it;
// Firefox and Chrome place it somewhere in the middle of our reply widget, in different
// places in visual and source mode.)
//
// The spec itself describes its rules for placing the marker as "handwavey nonsense".
// https://www.w3.org/TR/css-lists-3/#list-style-position-property
$( commentController.newListItem ).prepend(
$( '<div>' )
.addClass( 'ext-discussiontools-ui-markerPlaceholder' )
.text( '\u00a0' )
);
}
commentController.setupReplyWidget( replyWidget );
commentController.showAndFocus();

4
modules/dt.ui.ReplyWidget.less
View file

@ -318,3 +318,7 @@
// while the tool is open, as we need negative margins on the widget.
overflow: visible;
}
.ext-discussiontools-ui-markerPlaceholder {
height: 0;
}