wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-24 22:04:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
3547 commits 13 branches 4 tags 132 MiB
Commit graph

3547 commits

This branch
This branch
All branches
Author SHA1 Message Date
Translation updater bot 09d872e0a5 Localisation updates from https://translatewiki.net. 
Change-Id: I91b8e0cb320ef8376b13eb0cd78f9844950bae8e
 2021-07-30 08:27:37 +02:00
Translation updater bot 69f86f7555 Localisation updates from https://translatewiki.net. 
Change-Id: Iea7d53db93514a37b93c1986cdc70b9ba9fc1608
 2021-07-29 08:44:52 +02:00
jenkins-bot a51132998c Merge "Fix notifications when new comment is under subheading" 2021-07-28 16:59:10 +00:00
jenkins-bot 405497594b Merge "Add PHPUnit integration tests for EventDispatcher" 2021-07-28 16:59:07 +00:00
jenkins-bot e9ff4695ad Merge "Change updating page content after saving to avoid losing footers" 2021-07-28 16:59:05 +00:00
Translation updater bot 3ccfa56d8f Localisation updates from https://translatewiki.net. 
Change-Id: I07a3e6d2260ee25a08d0d5433e1a726a15624194
 2021-07-26 08:12:04 +02:00
Bartosz Dziewoński d0e4aeaecb Fix notifications when new comment is under subheading 
The user interface only allows you to subscribe to level 2 headings.
But we would generate events for whatever heading was the closest,
If it was e.g. level 3, no one would receive that notification.

Now we generate events for the closest level 2 heading, or we don't
generate the event at all if there isn't one (if the only headings are
of level 3 and below, or level 1, or if the comment is added before
the first heading on the page).

Bug: T286736
Change-Id: Iae99853070e353ab81c9cc29ef1d53c877adfc66
 2021-07-24 05:28:10 +02:00
Bartosz Dziewoński 801b57b0f4 Add PHPUnit integration tests for EventDispatcher 
Bug: T286608
Change-Id: I711483be80d455f4439e96d37844ee4552619a92
 2021-07-24 05:28:04 +02:00
Bartosz Dziewoński 4ebf05d802 Recognize links to add a new topic that use Special:NewSection 
Bug: T277371
Change-Id: I40a13d8bf87bcd3ecea1427b444b6b7b621213c4
 2021-07-22 22:25:11 +02:00
Bartosz Dziewoński 4e8e1bda67 Change updating page content after saving to avoid losing footers 
This is the same method as used by VisualEditor
(ve.init.mw.DesktopArticleTarget.prototype.replacePageContent).

Bug: T275698
Change-Id: Idcf7c79b8d5565b0ae36c6e9d42b66662c1acc8d
 2021-07-22 21:43:10 +02:00
libraryupgrader b0884b177c build: Updating dependencies 
composer:
* mediawiki/mediawiki-codesniffer: 36.0.0 → 37.0.0

npm:
* postcss: 7.0.35 → 7.0.36
  * https://npmjs.com/advisories/1693 (CVE-2021-23368)
* glob-parent: 5.1.1 → 5.1.2
  * https://npmjs.com/advisories/1751 (CVE-2020-28469)
* trim-newlines: 3.0.0 → 3.0.1
  * https://npmjs.com/advisories/1753 (CVE-2021-33623)

Change-Id: I7a71e23da561599da417db3b3077b78d91173bbc
 2021-07-22 16:29:04 +00:00
Translation updater bot aa19431689 Localisation updates from https://translatewiki.net. 
Change-Id: Id49ff976340c4fddfb19be18a6500a88c72b2548
 2021-07-22 08:13:08 +02:00
Bartosz Dziewoński 709a7e5c4a Do not teardown newtopictool interface if it was not setup 
Bug: T287035
Change-Id: Ib7c6c564ff197e0c8c8cf79680513f9415d108f9
 2021-07-20 22:32:25 +02:00
Translation updater bot fb066eda46 Localisation updates from https://translatewiki.net. 
Change-Id: I2db2ddf62a091255ae019d35ea3e42b98e4ea7e6
 2021-07-20 08:20:29 +02:00
Translation updater bot 6e9e08bb31 Localisation updates from https://translatewiki.net. 
Change-Id: I9096cce0f728a4ba1434987d85aeae0bc908e5d2
 2021-07-19 08:15:37 +02:00
Translation updater bot c83f98c972 Localisation updates from https://translatewiki.net. 
Change-Id: I579cfcac4c6b1320701fbe0cb890050658cb7bc0
 2021-07-15 08:12:10 +02:00
Translation updater bot f9dd078ded Localisation updates from https://translatewiki.net. 
Change-Id: If319cf5a434ecc8ca6c1d69305650fb95991108f
 2021-07-14 08:02:47 +02:00
jenkins-bot 52ffc8ce98 Merge "Remove comment highlight after user clicks anywhere on the page" 2021-07-13 17:26:39 +00:00
jenkins-bot 64f40718e2 Merge "Avoid exception when trying to highlight hidden comment" 2021-07-13 17:26:37 +00:00
jenkins-bot 062416771f Merge "Only show [subscribe] links on sections that contain at least one comment" 2021-07-13 16:25:31 +00:00
Translation updater bot 31e3e1f8a7 Localisation updates from https://translatewiki.net. 
Change-Id: Id228cf0a64adefd1557dc8266ad333743127a7df
 2021-07-13 08:11:37 +02:00
Bartosz Dziewoński b3a2941575 Remove comment highlight after user clicks anywhere on the page 
Bug: T285430
Change-Id: I32fc04a440c807211c5e4f121e58757466ee55bf
 2021-07-13 02:38:40 +02:00
Bartosz Dziewoński 4ebe4b29bb Only show [subscribe] links on sections that contain at least one comment 
Bug: T285796
Change-Id: I48264d55464fa6bce56b47fc1075f5d348101676
 2021-07-13 02:35:15 +02:00
Bartosz Dziewoński 650c7dd1d3 Avoid exception when trying to highlight hidden comment 
(e.g. if the comment is inside a node with 'display: none')

Change-Id: I23a38fd877b1f9f1554962f7f08f7e2732d8f560
 2021-07-13 00:00:30 +02:00
Translation updater bot ad0b879473 Localisation updates from https://translatewiki.net. 
Change-Id: I9ae758b23834e6bef292b6e394b80e8a9264233d
 2021-07-12 08:06:22 +02:00
Translation updater bot b8384190f1 Localisation updates from https://translatewiki.net. 
Change-Id: I335fe805673a261c6bfe240fb3f0a45f0e453db7
 2021-07-06 08:38:23 +02:00
Translation updater bot df4653f4df Localisation updates from https://translatewiki.net. 
Change-Id: Id0db12580df7053bc6fd873388382a16e55c6e6b
 2021-07-05 08:06:47 +02:00
Translation updater bot ac06fb4d6f Localisation updates from https://translatewiki.net. 
Change-Id: I1d90959d9809e2c5194cc99f7e647447ef0f16e0
 2021-07-02 08:31:06 +02:00
jenkins-bot 164e1328b9 Merge "Take over extra links to add a new topic added by gadgets/templates" 2021-07-01 17:21:16 +00:00
jenkins-bot 5663796725 Merge "Improve how new topic tool avoids conflicts with NWE new section" 2021-07-01 17:21:14 +00:00
jenkins-bot 16f6715fe7 Merge "Move reply link handling out of CommentController" 2021-07-01 17:21:13 +00:00
jenkins-bot 1f9d96d81a Merge "Show edit notices in the new discussion tool" 2021-07-01 17:18:59 +00:00
jenkins-bot 3676f3881d Merge "Introduce CommentDetails to group up and document stuff we pass around" 2021-07-01 17:18:58 +00:00
jenkins-bot cced58b5cc Merge "EventDispatcher: Ensure we fetch page content from the primary database" 2021-07-01 16:29:41 +00:00
Bartosz Dziewoński 37d6825c14 EventDispatcher: Ensure we fetch page content from the primary database 
We used an internal API requests to fetch page content because it was
easy, but there's no way to guarantee that it returns data from the
primary database.

Use ParserOutputAccess::getParserOutput() to fetch from cache if
available. Also, use canonical output instead of user-specific,
not that it should matter.

Bug: T285895
Change-Id: I7dcd9659be77746dc2a0c4eeae2319887936b555
 2021-07-01 14:52:13 +00:00
Translation updater bot 7327d6158d Localisation updates from https://translatewiki.net. 
Change-Id: I788108f901cc2fe3a5a3860fb86f9679a30208af
 2021-07-01 08:09:21 +02:00
Bartosz Dziewoński f35bf487ef Take over extra links to add a new topic added by gadgets/templates 
* Move getTitleFromUrl() from parser to utils. It's a generic method,
  the PHP equivalent is already in utils.

Bug: T277371
Change-Id: Id960e5f60af02bdeb0a3a68f43b7a695eb035139
 2021-06-30 18:06:39 +02:00
Bartosz Dziewoński dce09e61b7 Improve how new topic tool avoids conflicts with NWE new section 
I noticed that the NWE new section editor would open sometimes even
though we attempt to prevent it. This way seems to work more reliably.

Change-Id: I0ce1640b8c1dd098bf3f0d41dc4fdc276a0c5fd5
 2021-06-30 18:00:34 +02:00
Bartosz Dziewoński a2c662d3b2 Move reply link handling out of CommentController 
Problems with the current setup:

* Each CommentController must have exactly one link.
  For T277371 we want multiple, and for T282205 we might want zero.

* CommentController objects must be constructed immediately.
  They are implemented to make this pretty fast, but it's still
  unnecessary work to do on page load.

* Only one link may be activated at a time, and activating one affects
  the styling of others, so CommentController has to use global state
  to check if it can set up and to update them.

Instead introduce ReplyLinksController, which knows about all reply
links and which one is active, and emits events that allow
CommentControllers to be constructed on demand.

Change-Id: Iabdeded2e71e598ae78703a6ff9410d0cfba397c
 2021-06-30 17:05:55 +02:00
Translation updater bot 12f5a5365e Localisation updates from https://translatewiki.net. 
Change-Id: If9caf7c26c68eb2baee42c64262c55c283466a92
 2021-06-30 08:26:01 +02:00
jenkins-bot f8f776d4e7 Merge "CommentFormatter: Remove old cached compatibility code" 2021-06-29 22:32:54 +00:00
David Lynch ae0aeff3a3 Allow dtenable=0 to disable DiscussionTools 
Bug: T285578
Change-Id: Ic722285d51ea1a51593ab63fac516b4f992eb1c8
 2021-06-29 21:20:35 +00:00
jenkins-bot b6b60bbe0b Merge "Config option to enable topic subscriptions backend and dtenable=1 URL parameter" 2021-06-29 15:21:09 +00:00
Translation updater bot f3ff33faae Localisation updates from https://translatewiki.net. 
Change-Id: Iaca38bd40a8156eded74d69fbcb0bc540cc015ce
 2021-06-29 08:13:37 +02:00
Translation updater bot f72a4bff37 Localisation updates from https://translatewiki.net. 
Change-Id: I34895056962eb3c4ea9d7177743a667f7be6e3bd
 2021-06-28 09:22:59 +02:00
Bartosz Dziewoński a38eb4fe18 CommentFormatter: Remove old cached compatibility code 
Added in 4bbfe6cb5d.

Change-Id: I4a6b265897beb60abc2a7c1e6bfc4acc646fda56
 2021-06-24 15:38:02 +02:00
Translation updater bot d71b3e51e7 Localisation updates from https://translatewiki.net. 
Change-Id: I17e05787fd12b74036b5c05f3c8ef2c20ab67651
 2021-06-24 08:26:55 +02:00
Bartosz Dziewoński a36d6ad5c6 Show edit notices in the new discussion tool 
Considerations:
* Using the same edit notices as VisualEditor, except 'anoneditwarning'
* No extra frame/styling is added (on Wikimedia wikis, the notices
  often already have them)
* 'talkpagetext' message is not shown (on Wikimedia wikis, they are
  mostly about signing your posts with tildes, which is not necessary)

Bug: T269033
Change-Id: Idc5ff29f093c75a14c3a3479888295d5bf630f6d
 2021-06-22 21:40:51 +02:00
jenkins-bot 3a17858421 Merge "Silence JQMIGRATE warnings when running tests" 2021-06-21 21:34:02 +00:00
jenkins-bot 01d8f79e46 Merge "Remove unused RL module" 2021-06-21 21:25:34 +00:00