Commit graph

3512 commits

Author SHA1 Message Date
Translation updater bot 7327d6158d Localisation updates from https://translatewiki.net.
Change-Id: I788108f901cc2fe3a5a3860fb86f9679a30208af
2021-07-01 08:09:21 +02:00
Bartosz Dziewoński f35bf487ef Take over extra links to add a new topic added by gadgets/templates
* Move getTitleFromUrl() from parser to utils. It's a generic method,
  the PHP equivalent is already in utils.

Bug: T277371
Change-Id: Id960e5f60af02bdeb0a3a68f43b7a695eb035139
2021-06-30 18:06:39 +02:00
Bartosz Dziewoński dce09e61b7 Improve how new topic tool avoids conflicts with NWE new section
I noticed that the NWE new section editor would open sometimes even
though we attempt to prevent it. This way seems to work more reliably.

Change-Id: I0ce1640b8c1dd098bf3f0d41dc4fdc276a0c5fd5
2021-06-30 18:00:34 +02:00
Bartosz Dziewoński a2c662d3b2 Move reply link handling out of CommentController
Problems with the current setup:

* Each CommentController must have exactly one link.
  For T277371 we want multiple, and for T282205 we might want zero.

* CommentController objects must be constructed immediately.
  They are implemented to make this pretty fast, but it's still
  unnecessary work to do on page load.

* Only one link may be activated at a time, and activating one affects
  the styling of others, so CommentController has to use global state
  to check if it can set up and to update them.

Instead introduce ReplyLinksController, which knows about all reply
links and which one is active, and emits events that allow
CommentControllers to be constructed on demand.

Change-Id: Iabdeded2e71e598ae78703a6ff9410d0cfba397c
2021-06-30 17:05:55 +02:00
Translation updater bot 12f5a5365e Localisation updates from https://translatewiki.net.
Change-Id: If9caf7c26c68eb2baee42c64262c55c283466a92
2021-06-30 08:26:01 +02:00
jenkins-bot f8f776d4e7 Merge "CommentFormatter: Remove old cached compatibility code" 2021-06-29 22:32:54 +00:00
David Lynch ae0aeff3a3 Allow dtenable=0 to disable DiscussionTools
Bug: T285578
Change-Id: Ic722285d51ea1a51593ab63fac516b4f992eb1c8
2021-06-29 21:20:35 +00:00
jenkins-bot b6b60bbe0b Merge "Config option to enable topic subscriptions backend and dtenable=1 URL parameter" 2021-06-29 15:21:09 +00:00
Translation updater bot f3ff33faae Localisation updates from https://translatewiki.net.
Change-Id: Iaca38bd40a8156eded74d69fbcb0bc540cc015ce
2021-06-29 08:13:37 +02:00
Translation updater bot f72a4bff37 Localisation updates from https://translatewiki.net.
Change-Id: I34895056962eb3c4ea9d7177743a667f7be6e3bd
2021-06-28 09:22:59 +02:00
Bartosz Dziewoński a38eb4fe18 CommentFormatter: Remove old cached compatibility code
Added in 4bbfe6cb5d.

Change-Id: I4a6b265897beb60abc2a7c1e6bfc4acc646fda56
2021-06-24 15:38:02 +02:00
Translation updater bot d71b3e51e7 Localisation updates from https://translatewiki.net.
Change-Id: I17e05787fd12b74036b5c05f3c8ef2c20ab67651
2021-06-24 08:26:55 +02:00
Bartosz Dziewoński a36d6ad5c6 Show edit notices in the new discussion tool
Considerations:
* Using the same edit notices as VisualEditor, except 'anoneditwarning'
* No extra frame/styling is added (on Wikimedia wikis, the notices
  often already have them)
* 'talkpagetext' message is not shown (on Wikimedia wikis, they are
  mostly about signing your posts with tildes, which is not necessary)

Bug: T269033
Change-Id: Idc5ff29f093c75a14c3a3479888295d5bf630f6d
2021-06-22 21:40:51 +02:00
jenkins-bot 3a17858421 Merge "Silence JQMIGRATE warnings when running tests" 2021-06-21 21:34:02 +00:00
jenkins-bot 01d8f79e46 Merge "Remove unused RL module" 2021-06-21 21:25:34 +00:00
Bartosz Dziewoński ea68e1a8f0 Introduce CommentDetails to group up and document stuff we pass around
Change-Id: I809524ea8d89130548964ba9e5a73f00f6089ff4
2021-06-21 22:12:18 +02:00
Bartosz Dziewoński f075e37303 Silence JQMIGRATE warnings when running tests
Disable the legacy htmlPrefilter from jquery.migrate.js, which is
causing noisy warnings when running tests because we use HTML
templates with wacky content in the test module. They look like this:
"JQMIGRATE: HTML tags must be properly nested and closed: <200 KB of HTML>"

Change-Id: Ic9bbd56e24b5769988a52f28d26d8b6d5922b1b4
2021-06-21 21:17:36 +02:00
Translation updater bot c3844de173 Localisation updates from https://translatewiki.net.
Change-Id: I0f524961c628d63696cd310cd2c84363365f0970
2021-06-21 14:11:37 +02:00
jenkins-bot cccce3886e Merge "Disallow horizontal rule (----) in reply tool" 2021-06-19 14:01:16 +00:00
jenkins-bot c694f9c6cc Merge "Unregister sequence help for unavailable commands" 2021-06-19 14:01:03 +00:00
Translation updater bot 8ac66fd95e Localisation updates from https://translatewiki.net.
Change-Id: I8145c8dcb4ea673ef0dee0009c8e08758541e9d5
2021-06-18 08:20:45 +02:00
Ed Sanders a76539e19b Disallow horizontal rule (----) in reply tool
These also don't work when indented.

Change-Id: Id2f1b14f434f8527f1391ebf056aeb80c7023feb
2021-06-17 21:30:48 +01:00
Ed Sanders 54f2dcf030 Unregister sequence help for unavailable commands
Bug: T284758
Change-Id: I85fe9332ec723e44b5cb508f9b53a59c9e9b61d9
2021-06-17 21:30:40 +01:00
Bartosz Dziewoński 1517e2e094 Remove unused RL module
Unused since 6a24ceaeca.

Change-Id: I96c8a7d7f7527e86ed728e72eb7232406aeb6942
2021-06-15 12:34:18 +02:00
Bartosz Dziewoński 26822864a9 Add missing dependency
Bug: T284969
Change-Id: I32b10c68991344ef4a2cedc7fb0fdd94b1f787a6
2021-06-15 12:34:18 +02:00
Bartosz Dziewoński 067f0c36de Config option to enable topic subscriptions backend and dtenable=1 URL parameter
…without making the topic subscriptions feature available in user preferences.

Follow-up to these commits, which added these checks in ad-hoc ways:
* 9420f22e9d
* f3422f40a6
* 23a490deca
* a555db7892

Bug: T284491
Change-Id: If2e3fb1e06d1cc489fbca14796ed77c83bb52991
2021-06-14 16:18:18 +02:00
Translation updater bot 6f0c5f26c0 Localisation updates from https://translatewiki.net.
Change-Id: I4f0fa84fae77142e5aa712a5c085f9ee9bd1a992
2021-06-14 08:36:42 +02:00
jenkins-bot 9ea5d8375c Merge "Reply tool: Disable preformatted command" 2021-06-10 20:21:33 +00:00
Translation updater bot fdadd19ce4 Localisation updates from https://translatewiki.net.
Change-Id: I2daffe12505362a78551da7078bd05f9351738ee
2021-06-10 08:34:19 +02:00
Ed Sanders c41dab81c4 Reply tool: Disable preformatted command
Preformatted text can't be rendered in wikitext when indented.

Change-Id: I2269471dd76630661cdb459322df591c6b3e6a50
2021-06-08 23:02:59 +01:00
jenkins-bot d1576ad40b Merge "Update surface styles for VE changes" 2021-06-08 16:35:00 +00:00
Bartosz Dziewoński c51638e940 Update surface styles for VE changes
The .ve-init-mw-target-surface class is no longer added since
Ic5320f6747907542285674d386c7a59c9e857f0a.

Also apply changes similar to I8d20a830dc48f6a098b0f9e9a7c7c1656de0fe56
to avoid potential styling issues with nested surfaces.

Bug: T284567
Change-Id: I58a49f0137e8804fbd73de20048eb2ffdbbfbe77
2021-06-08 18:04:21 +02:00
Translation updater bot 3bf067bb8d Localisation updates from https://translatewiki.net.
Change-Id: Iadf0ce9509da5c7012c76faebbe3181118d3fe19
2021-06-08 08:35:55 +02:00
Translation updater bot d18315f850 Localisation updates from https://translatewiki.net.
Change-Id: I0495ec5fc32d59ff54b49b412c60a5426126a8f0
2021-06-07 08:41:52 +02:00
Translation updater bot 441079b6d0 Localisation updates from https://translatewiki.net.
Change-Id: I5536cc1216dd2cb0a7dd0c472a106ff91af2ee4d
2021-06-04 08:36:18 +02:00
jenkins-bot c5c4c86185 Merge "Change how highlights are positioned to work better with unaware tools" 2021-06-03 12:11:25 +00:00
Bartosz Dziewoński bd27a46deb Fix revealing content of deleted revisions in notifications
If the revision from which we generated the notification has been
deleted, we shouldn't include the content snippet, nor the direct link
to the comment (because the fragment ID is generated from the content).

This matches how Echo handles mention notifications.

Change-Id: Ica939f3a4efd39d0c295511d58280d3f9d584129
2021-06-03 02:45:15 +02:00
Bartosz Dziewoński 0dfb34eb50 Avoid parsing the comment snippet in notifications as wikitext
As it happens, most of Echo does not actually parse this message,
but it is for some reason parsed in HTML email notifications.

Change-Id: I414cd242d9bcc4d8b5a1c2a2a71be9e5f00ea8be
2021-06-03 02:43:56 +02:00
Bartosz Dziewoński fd080b7043 Ensure you can't get duplicate notifs for edits to your user talk page
We don't display [subscribe] buttons on your user talk page,
but the API still allows those subscriptions.

Use the same approach as for mentions to ensure this doesn't cause
duplicate notifications.

Remove some code in SubscribedNewCommentPresentationModel,
now guaranteed to be unused.

Change-Id: I99a276a48d8562552ed2c54cc0323e8e428845fd
2021-06-03 02:10:33 +02:00
Bartosz Dziewoński 4353b68646 EventDispatcher: Read revision IDs to compare from master
Bug: T284175
Change-Id: Iec99ea0afc659969108104cf5b2627856711544d
2021-06-02 19:47:35 +00:00
Bartosz Dziewoński 9c8d709b8a Use placeholder localisation messages in CommentFormatter tests
Otherwise they will fail whenever translations are updated
(and they are failing right now).

Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 21:46:36 +02:00
Translation updater bot cf1af27f32 Localisation updates from https://translatewiki.net.
Change-Id: I5c867270835bb40ff825f508d0e16c8d6eea8e93
2021-06-02 14:35:05 +02:00
Ed Sanders 5a166cfab5 Notification unsubcribe button
Bug: T279150
Change-Id: Ib0bfe3c0dced2108bddbc837a7ddd7bea814e129
2021-06-01 23:29:53 +02:00
jenkins-bot ea98787f41 Merge "Apply transformations in ParserCache for all CommentFormatter features" 2021-06-01 19:24:04 +00:00
Ed Sanders 6a24ceaeca Subscribe/unsubscribe with plain text links
Bug: T279149
Bug: T279151
Change-Id: Ie7d46ea2e8d458fcdad4f91bb89ba038969f6b62
2021-06-01 20:37:47 +02:00
Translation updater bot f6af99c3e0 Localisation updates from https://translatewiki.net.
Change-Id: Ie737b72809d598a19693d399b4cee34747cdca62
2021-06-01 08:35:05 +02:00
Bartosz Dziewoński 9c58c0a203 Change how highlights are positioned to work better with unaware tools
Previously, our highlights were placed in a node at the end of
the page, and positioned absolutely in relation to the whole
page. Now we insert the highlight in the DOM near the comment,
and position it in relation to that.

This way it remains positioned correctly when the page shifts
(e.g. collapsing the table of contents), and disappears when
the page content is hidden (e.g. opening visual editor).

Bug: T281471
Change-Id: I60afc4b94b2e23376105638542563e595a1811d9
2021-05-31 23:07:02 +02:00
Translation updater bot 9bbbf967ac Localisation updates from https://translatewiki.net.
Change-Id: I850f95e4d1819a34b5b3aec85847c4486d3215ea
2021-05-31 08:30:52 +02:00
jenkins-bot 3759ffdd2a Merge "Swap DOM order of summary and watch checkbox" 2021-05-30 12:42:35 +00:00
jenkins-bot e5e1d9e86c Merge "Follow-up: Adjust comment ranges to exclude the start marker *only*" 2021-05-30 12:41:36 +00:00