Commit graph

5095 commits

Author SHA1 Message Date
jenkins-bot 94d78fa268 Merge "Try to always limit our document references to the current fragment" 2024-09-16 15:00:38 +00:00
Translation updater bot 189aa8f9ab
Localisation updates from https://translatewiki.net.
Change-Id: I132aa602e48eb175d39d0c3f0694af16ad91c033
2024-09-16 09:25:29 +02:00
Translation updater bot bbaf397f3e
Localisation updates from https://translatewiki.net.
Change-Id: I7ec9d0672919ecfd52a9fb6ac34aa2f8c4f9ea6c
2024-09-13 09:17:46 +02:00
Translation updater bot 1310475a0e
Localisation updates from https://translatewiki.net.
Change-Id: I25c988a76ffd1c6c7500311f8132a5ab062863a8
2024-09-12 09:17:39 +02:00
Adam Wight 6ea3a8c696 Try to always limit our document references to the current fragment
Reverses the previous logic which traversed up from a fragment to get
the full document's refs.  Much other code in VE isn't ready for this
behavior, for example we can see list-defined refs but not inline refs
defined outside of the fragment.

This patch will ensure that we're only looking at refs accessible from
the current fragment, and prevents caching on fragments because the
cache uses `persistentStorage`, which is shared between fragments and
their parent document.

Bug: T374068
Change-Id: Ia38098f8b3e5a9d24c2206e11edab37d60209225
2024-09-10 12:26:32 +02:00
jenkins-bot e26e726cb0 Merge "[refactor] Rewrite context as service" 2024-09-10 08:27:05 +00:00
Translation updater bot 5efd7bcaa3
Localisation updates from https://translatewiki.net.
Change-Id: I3cd229480ee45f8e122b3f96e76c580b9199952d
2024-09-10 09:28:45 +02:00
jenkins-bot 334087ee39 Merge "Ignore cypress generated PHP files" 2024-09-10 05:21:49 +00:00
jenkins-bot 6203ab3d13 Merge "VE include subref count in warning message" 2024-09-09 12:09:26 +00:00
jenkins-bot 25b71720a4 Merge "[refactor] Renaming some fields in SearchWidget for clarity" 2024-09-09 07:26:57 +00:00
Translation updater bot d91bf9251a
Localisation updates from https://translatewiki.net.
Change-Id: Ie569a85559b233f8ba4da913df914fd65dc48273
2024-09-09 09:22:11 +02:00
mareikeheuer bdcbcc08f8 VE include subref count in warning message
Include subref count in warning messages in VE editPanel dialog and contextItem

Bug: T373023
Change-Id: Ie7d162c4a2291db441846ec338159e8955c206c2
2024-09-09 09:21:06 +02:00
WMDE-Fisch b5a41a62de [refactor] Renaming some fields in SearchWidget for clarity
Should be a no-op. I checked CodeSearch for other usages but seems
safe so far.

Bug: T370875
Change-Id: I4969e93308735f06be3e344616341c1284157c19
2024-09-09 09:03:11 +02:00
Adam Wight 8e4c83bfc6 [refactor] Rewrite context as service
Puts the ReferencePreviewsContext behind a service to improve
testability.

Bug: T363162
Change-Id: I63aa4144081a2625da1b89f4d56adb612741c8fc
2024-09-06 16:26:20 +02:00
Adam Wight 79be7f0f08 Ignore cypress generated PHP files
Change-Id: I53a673ec969da7feae00b38f67d9de53f18dfa7e
2024-09-06 14:28:29 +02:00
thiemowmde 878a29b727 Add extra safe-guard to ve.ui.MWCitationDialogTool
Note this doesn't fully solve T374068. The issue is probably that the
reuse tab shouldn't be visible in the first place. Still I think this
is a useful safe-guard that cannot hurt. We are doing the same in
almost all other places already.

Bug: T374068
Change-Id: I9b91374dbda74af75d8c36e24ffe5b9448da1aa7
2024-09-05 17:54:50 +02:00
jenkins-bot 2890772a9f Merge "Adding some QUnit tests for MWGroupReferences" 2024-09-04 11:46:11 +00:00
Translation updater bot 1a68933678
Localisation updates from https://translatewiki.net.
Change-Id: Ib0f3a420e937d0b52281b8b691cbfd2493350fb5
2024-09-04 09:16:11 +02:00
WMDE-Fisch f133ad3ead Adding some QUnit tests for MWGroupReferences
Bug: T373854
Change-Id: Ie1ea1016e6e67429b109989bc7995b6dd532f314
2024-09-03 17:00:01 +02:00
jenkins-bot 70277f746d Merge "[refactor] Stash calculated group refs" 2024-09-03 13:48:13 +00:00
jenkins-bot 52dc522cca Merge "Streamlining the MWReferenceEditPanel QUnit test" 2024-09-03 13:19:54 +00:00
jenkins-bot 0f72ad8b05 Merge "[refactor] Finish decoupling search widget from InternalList" 2024-09-03 12:52:26 +00:00
jenkins-bot 45e9e7a328 Merge "Finish safety fallback for missing groups" 2024-09-03 12:52:24 +00:00
WMDE-Fisch 1507354f93 Streamlining the MWReferenceEditPanel QUnit test
I could add some simplifications to reduce the complexity of the
tests a bit. I also fixed the test for the change handler. Seems
it did not work that way before.

Also some minor random doc fixes.

Change-Id: If1530a815ea126c38c3a55f3d52e3ca482059840
2024-09-03 14:50:51 +02:00
jenkins-bot 30b5fca6ee Merge "[refactor] InternalList isn't state" 2024-09-03 12:47:12 +00:00
Adam Wight 5f888c98fa Finish safety fallback for missing groups
In a document without references, the default group doesn't exist.
Make sure that we don't assume any group's existence.

Bug: T373661
Change-Id: I1bfd41b0b61938f32219d61142cd576c8ca97ace
2024-09-03 13:37:31 +02:00
Adam Wight aa9af6346a [refactor] Stash calculated group refs
Motivation is to simplify calling code.

Citoid subclass usage is safe across this change.

Change-Id: I24d9cbd58a0e34f6ce659e9a655547a46d5d057d
2024-09-03 12:47:25 +02:00
Adam Wight 65a02eb97b Fixup types
Change-Id: I609f6b4dfb4ebc357b6190571b8779a167a66f4f
2024-09-03 12:46:47 +02:00
Adam Wight ab0f2ea000 [refactor] Finish decoupling search widget from InternalList
Bug: T370875
Change-Id: I6ed43ea3a5b25c2ef5afc373b5a2523a730fd11e
2024-09-03 12:12:01 +02:00
Adam Wight e3398577c1 [refactor] InternalList isn't state
We've almost finished decoupling, and the last remaining usages of
InternalList can be inlined.

Change-Id: I0809df9d3c24fdd5fe4c628420d0406e012a3259
2024-09-03 11:34:47 +02:00
Translation updater bot 4d8cb0d18a
Localisation updates from https://translatewiki.net.
Change-Id: I9281e0592c09eb78ea1d4fc31ec0216271b06b3d
2024-09-03 09:31:51 +02:00
jenkins-bot 1116cfb9a9 Merge "Allow disabling the alternative backlink labels message" 2024-09-02 19:34:57 +00:00
jenkins-bot 4b92287348 Merge "Fix null reference error in 2017 source editor" 2024-09-02 09:23:12 +00:00
Translation updater bot 4141cb91b9
Localisation updates from https://translatewiki.net.
Change-Id: Ic4cbb937827d897220d8b1720af1e2baef1497f7
2024-09-02 09:20:23 +02:00
thiemowmde 581d987b88 Fix null reference error in 2017 source editor
Looking for other references can (as of now) never work in source
mode. There are never other references or reference lists.

Bug: T373661
Change-Id: Icaad4e71a1538c5fad6a0f016b342a7cb7b9db2f
2024-08-30 17:41:17 +02:00
jenkins-bot 617ca08892 Merge "Drop unused, duplicate "this is an extension" message" 2024-08-30 11:20:00 +00:00
jenkins-bot d68f601b25 Merge "Drop unused "Re-use by this name" message" 2024-08-30 11:17:29 +00:00
jenkins-bot e28b4c0d04 Merge "[refactor] Replace InternalList with DocumentReferences in ReferenceEditPanel" 2024-08-30 08:21:32 +00:00
Translation updater bot 210912c199
Localisation updates from https://translatewiki.net.
Change-Id: Id0e6ab2c0668a8ab2aae344e0b0cf3e13a709826
2024-08-30 09:19:51 +02:00
WMDE-Fisch 31dcf2528e [refactor] Replace InternalList with DocumentReferences in ReferenceEditPanel
Change-Id: Icdb7b80f5ca4284fe77c4905b7a9c98659f9c2b4
2024-08-29 23:43:03 +02:00
Raimond Spekking 1882c463f2 Merge "Localisation updates from https://translatewiki.net." 2024-08-29 16:31:16 +00:00
thiemowmde 24915de7d7 Drop unused, duplicate "this is an extension" message
Patch I83434afaf1b76425bddb575dd724f462a247c83d was meant to be a
revert of I3749683d8a18e502bf16e5bd5f2fe385581625be, but left this
unused message behind.

While an unused message is harmless, it's of no use either. Even if
we are going to re-implement something like this again in the future,
we will certainly not be able to use this exact message (mostly
because of T373307). Starting with a new message is much easier then.

Bug: T373564
Change-Id: I241d44639ca7112e8398d095e7aa59cf8e275da1
2024-08-29 16:21:04 +02:00
thiemowmde b5522b705c Drop unused "Re-use by this name" message
This message was added via Icf9ea348cd97bdb09ddf18769f53c01ea5a8b7ef,
merged 2013-06-15.

The code of the ReferenceDialog class was later largely rewritten
and split into two separate "Edit" and "Insert" dialogs.
See Ib244ff6ad9b4cee1decfd9b9e1d3d4e9cdcfb78c, merged 2013-06-28.
Since then the message is unused. The commit message mentions the
related change. The patch just forgot to remove the message.

Note: The two separate dialog classes have been merged back into
the original ReferenceDialog class.
See I8265febf4fd8f64d2ac40470ff033bac68b24d99, merged 2013-07-18.
The message is already unused at this point. This just makes the
Git history extra confusing.

Bug: T373564
Change-Id: Ifb71a243fbdac43d2199ad40d84da14333d42599
2024-08-29 15:57:43 +02:00
jenkins-bot 1bae4d71c9 Merge "[refactor] Update some usages to new refs interface" 2024-08-29 12:23:14 +00:00
Adam Wight 633969300b [refactor] Update some usages to new refs interface
Change-Id: Idfffbe92ad1385e85b078bc4794a529c5f770eae
2024-08-29 13:21:48 +02:00
jenkins-bot 72056c5fd0 Merge "Make use of createNoOpMock in ReferenceListFormatterTest" 2024-08-29 10:21:44 +00:00
Translation updater bot 568cbfdd12
Localisation updates from https://translatewiki.net.
Change-Id: I2f148433c357c0f7a6804d703768fc5b48c70a7f
2024-08-29 09:17:33 +02:00
jenkins-bot 43274e9716 Merge "Reword the missing main ref hint in editing and context menu" 2024-08-28 13:47:18 +00:00
jenkins-bot 179e12f4ec Merge "[refactor] groupInput takes narrower parameters" 2024-08-28 08:09:55 +00:00
jenkins-bot 99d2cce694 Merge "[refactor] New interface in MWReferenceContextItem" 2024-08-28 08:06:54 +00:00