wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-23 22:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[refactor] Stash calculated group refs

Browse source 
Motivation is to simplify calling code.

Citoid subclass usage is safe across this change.

Change-Id: I24d9cbd58a0e34f6ce659e9a655547a46d5d057d
This commit is contained in:
Adam Wight 2024-09-03 12:44:28 +02:00
parent 4d8cb0d18a
commit aa9af6346a
1 changed files with 16 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
modules/ve-cite/ve.ui.MWReferenceContextItem.js
View file

@ -20,6 +20,8 @@ ve.ui.MWReferenceContextItem = function VeUiMWReferenceContextItem() {
// Parent constructor
ve.ui.MWReferenceContextItem.super.apply( this, arguments );
this.view = null;
/** @member {ve.dm.MWGroupReferences} */
this.groupRefs = null;
// Initialization
this.$element.addClass( 've-ui-mwReferenceContextItem' );
};
@ -72,10 +74,7 @@ ve.ui.MWReferenceContextItem.prototype.getRendering = function () {
* @return {jQuery|undefined}
*/
ve.ui.MWReferenceContextItem.prototype.getReuseWarning = function () {
const usageCount = ve.dm.MWDocumentReferences.static.refsForDoc( this.getFragment().getDocument() )
.getGroupRefs( this.model.getAttribute( 'listGroup' ) )
.getRefUsages( this.model.getAttribute( 'listKey' ) )
.length;
const usageCount = this.groupRefs.getRefUsages( this.model.getAttribute( 'listKey' ) ).length;
if ( usageCount > 1 ) {
return $( '<div>' )
.addClass( 've-ui-mwReferenceContextItem-muted' )
@ -107,9 +106,7 @@ ve.ui.MWReferenceContextItem.prototype.getReferenceNode = function () {
return null;
}
if ( !this.referenceNode ) {
this.referenceNode = ve.dm.MWDocumentReferences.static.refsForDoc( this.getFragment().getDocument() )
.getGroupRefs( this.model.getAttribute( 'listGroup' ) )
.getInternalModelNode( this.model.getAttribute( 'listKey' ) );
this.referenceNode = this.groupRefs.getInternalModelNode( this.model.getAttribute( 'listKey' ) );
}
return this.referenceNode;
};
@ -132,15 +129,24 @@ ve.ui.MWReferenceContextItem.prototype.getParentRef = function () {
if ( !extendsRef ) {
return null;
}
const parentNode = ve.dm.MWDocumentReferences.static.refsForDoc( this.getFragment().getDocument() )
.getGroupRefs( this.model.getAttribute( 'listGroup' ) )
.getInternalModelNode( extendsRef );
const parentNode = this.groupRefs.getInternalModelNode( extendsRef );
return parentNode ? new ve.ui.MWPreviewElement( parentNode, { useView: true } ).$element :
$( '<div>' )
.addClass( 've-ui-mwReferenceContextItem-muted' )
.text( ve.msg( 'cite-ve-dialog-reference-missing-parent-ref' ) );
};
/**
* @override
*/
ve.ui.MWReferenceContextItem.prototype.setup = function () {
this.groupRefs = ve.dm.MWDocumentReferences.static.refsForDoc( this.getFragment().getDocument() )
.getGroupRefs( this.model.getAttribute( 'listGroup' ) );
// Parent method
return ve.ui.MWReferenceContextItem.super.prototype.setup.apply( this, arguments );
};
/**
* @override
*/