Commit graph

765 commits

Author SHA1 Message Date
Translation updater bot e3e502e935 Localisation updates from https://translatewiki.net.
Change-Id: I47c46b7c78ed84b9246ed5e2f473473b1705a897
2019-07-07 22:38:08 +02:00
jenkins-bot dbf08269a6 Merge "Dialogs: Use close flag for close actions" 2019-07-02 19:01:35 +00:00
jenkins-bot 028a1828e0 Merge "Remove citefromid alias support" 2019-06-28 18:52:41 +00:00
Translation updater bot afcaf6fef9 Localisation updates from https://translatewiki.net.
Change-Id: Ia9579d616be7b871e76832dde09115bac8b7775a
2019-06-24 08:37:42 +02:00
Ed Sanders 6af3bc1fe4 Remove citefromid alias support
Change-Id: I20aa82a3fdc16897abcb36874c17be31d41fda43
2019-06-20 16:08:58 +01:00
Translation updater bot 5a1e6da148 Localisation updates from https://translatewiki.net.
Change-Id: Idcc0a16486605ab590e884012025265e1c26440f
2019-06-17 22:33:36 +02:00
Translation updater bot 8c150438ee Localisation updates from https://translatewiki.net.
Change-Id: I58d680d672d535c56c50282ffd4e01f3cf6c3e14
2019-06-16 22:35:29 +02:00
Translation updater bot 8517cb060c Localisation updates from https://translatewiki.net.
Change-Id: I10b9debec1a9d78660b7e75de0e47852c70b0971
2019-06-13 22:38:36 +02:00
Translation updater bot ced3252ea5 Localisation updates from https://translatewiki.net.
Change-Id: I4d3a616b4bd545cce10b060a116a1dc7a70a02b7
2019-06-10 22:53:57 +02:00
Ed Sanders d92e930bb6 Dialogs: Use close flag for close actions
Bug: T225021
Change-Id: I7915656896b502d6f2e19e38aae09d09d2bb8c49
Depends-On: I67b8474b0662f8dbc23c1b5ff883e3d4093bdbd4
2019-06-10 16:00:38 +01:00
Translation updater bot 44f1d91e2f Localisation updates from https://translatewiki.net.
Change-Id: I5758a4a40329d591ce6c5e788233659ac023d39a
2019-06-02 22:29:05 +02:00
Translation updater bot 5cf69a42ee Localisation updates from https://translatewiki.net.
Change-Id: I11ce3442806fc356ea339cc6c5b1d82490d1cd69
2019-05-30 22:52:57 +02:00
jenkins-bot 6c2ba09132 Merge "Remove dead extra comparison from VE JavaScript code" 2019-05-28 23:18:17 +00:00
Translation updater bot 66470a318e Localisation updates from https://translatewiki.net.
Change-Id: Ia66a31164fd94fd3db1a4d9bb8b9bc4d9eeba885
2019-05-23 23:06:16 +02:00
Translation updater bot c92f5cf602 Localisation updates from https://translatewiki.net.
Change-Id: Ib2456fd28329d1fc654fb2ad45d2eebfba7a9db4
2019-05-22 22:30:12 +02:00
Translation updater bot 23276790ae Localisation updates from https://translatewiki.net.
Change-Id: I259607c53cbe2d093de3c60100bc95fd109306b3
2019-05-20 22:28:31 +02:00
Thiemo Kreuz d622356a73 Remove dead extra comparison from VE JavaScript code
The first code snippet in this while already covers this case. The loop
will end the moment it can't find another parent any more.

This was found via
https://sonarcloud.io/project/issues?id=mediawiki-extensions-Cite&types=BUG
as a potential bug. After looking at the code I'm sure it's not one.

Change-Id: Id914252c88b27420dfa47dcc918fc58d9ee2a65d
2019-05-17 13:48:37 +00:00
Translation updater bot e834fbe25e Localisation updates from https://translatewiki.net.
Change-Id: Ic8de74a3c17cc3056a5a8d1e563b97b62ebfada2
2019-05-16 09:09:40 +02:00
Translation updater bot d32f5e0fcf Localisation updates from https://translatewiki.net.
Change-Id: Icae5f51f8f30b5fb857f7e2b64809556cc4f9450
2019-05-15 09:12:12 +02:00
Translation updater bot 0b423bbf7d Localisation updates from https://translatewiki.net.
Change-Id: Ife455e4cf5038cebb30702cca3ee5a54d414fe4f
2019-05-12 22:33:03 +02:00
Translation updater bot ccc25d094b Localisation updates from https://translatewiki.net.
Change-Id: Id6d87011739efc1e4742f68d1e8ebd74fa1bf894
2019-05-10 09:18:38 +02:00
Translation updater bot 7c8b492030 Localisation updates from https://translatewiki.net.
Change-Id: I05157c46b13124f87cc1b159057bb8d4cdce65a9
2019-05-06 09:03:29 +02:00
Translation updater bot becce25ed4 Localisation updates from https://translatewiki.net.
Change-Id: I794ccaac2d8c91b02a5e1ab23242963b8dd7908c
2019-04-30 22:17:32 +02:00
Translation updater bot 8e6ede04c6 Localisation updates from https://translatewiki.net.
Change-Id: I3c32b72f46babbc390badeda90d09c1cdb10f733
2019-04-29 22:15:25 +02:00
jenkins-bot 78f9e45e72 Merge "Render placeholder citation as […] to show it isn't finished" 2019-04-24 21:27:23 +00:00
Translation updater bot c663a136df Localisation updates from https://translatewiki.net.
Change-Id: Ia61301fec1d9bd01d3994b6203dfd8487fa94b8c
2019-04-24 22:20:39 +02:00
Ed Sanders 2f3fc5594d Render placeholder citation as […] to show it isn't finished
Bug: T220502
Change-Id: I11f2aea22d9b9c83d7a642e86e0c2f4c2fb3a430
2019-04-23 14:34:43 +00:00
Translation updater bot 916e50a58e Localisation updates from https://translatewiki.net.
Change-Id: I5e25ad7ff2d9e8bcd4c144d7a6b1d9534732e2d8
2019-04-15 22:52:51 +02:00
Translation updater bot 7c5eb38bb7 Localisation updates from https://translatewiki.net.
Change-Id: Ibc67d96401e21934acad66f9e616236b482ca2ce
2019-04-14 22:29:19 +02:00
Ed Sanders 625047f513 Define default icons for core citation types
Duplicating these icon names across every wiki
makes it harder to change the icons when changes
are made to the OOUI icon set.

Bug: T217132
Change-Id: Iba19f92cdadc64865b9c4d9d2c2c74e0e2a66348
2019-04-12 15:01:35 +01:00
Ed Sanders 367e7a2803 Use upstream OOUI icons
Provide a mapping from the old icons to the new defaults
as the names are defined on-wiki.

Bug: T217132
Change-Id: I7fd22078789f4a06c5ed165a0c979fb543801af2
2019-04-12 14:11:47 +01:00
jenkins-bot 64234cb793 Merge "Rename 'citefromid' to 'citoid'" 2019-04-11 11:00:58 +00:00
Ed Sanders 01ef641a66 VE: Use new object format for importRules
Add in missing mwTable types.

Change-Id: I4b2e81f8cd78c61d208a3ef6fdab43d0cc720cb5
Depends-On: I366a091ff4def66cc25200b3d1b2c23ba6b716f7
2019-04-09 19:03:49 +01:00
Translation updater bot 12c586c410 Localisation updates from https://translatewiki.net.
Change-Id: I7f891f48c845599fd1d5547d5e817394c67d0e2f
2019-04-04 14:52:32 +02:00
Bartosz Dziewoński fd11b87c5d Remove "hrefPrefix" from tests
Bug: T206357
Change-Id: I8728f63084902c76d1c61193be4367939b069f1a
2019-04-03 20:09:59 +00:00
Ed Sanders e7a7f2107b Rename 'citefromid' to 'citoid'
Backwards compatible change can be merged ahead of change
in Citoid repo.

Bug: T219512
Change-Id: If4b920ba743030341e9cf6987c3d2ddc490992c9
2019-04-03 13:20:36 +01:00
Translation updater bot 1a96874463 Localisation updates from https://translatewiki.net.
Change-Id: Ibd92dd862050b6255cfc894e240e6507ecd8cda7
2019-03-31 22:16:10 +02:00
jenkins-bot 4f751b39c5 Merge "Expose the list of citation tools" 2019-03-28 20:03:50 +00:00
Ed Sanders e534585b18 RefList: Avoid changing 'responsive' value if meaning hasn't changed
Bug: T212340
Change-Id: I57ebe0fbf374c1ee7a7538a938d7b9fd904e80db
2019-03-28 16:40:39 +00:00
Ed Sanders a6c8d9b8bc Expose the list of citation tools
Bug: T219510
Change-Id: If848a7fbebf050cd1ba376e45c9be95a9ad98290
2019-03-28 15:47:46 +00:00
Translation updater bot 738519277a Localisation updates from https://translatewiki.net.
Change-Id: I73ac407bd459b6ee973ad75fddaadb9545a9b1a3
2019-03-27 22:28:53 +01:00
Translation updater bot 0b74051d16 Localisation updates from https://translatewiki.net.
Change-Id: I6df4754ac6fc1402700f26828c9309a5eaec7964
2019-03-26 08:44:22 +01:00
jenkins-bot 116b98a75e Merge "ve.ui.MWCitationDialog: If the selected ref is not using the template, clear it" 2019-03-23 12:10:26 +00:00
Translation updater bot 53e0f3ba02 Localisation updates from https://translatewiki.net.
Change-Id: I2300cf5689231d4e815ddd27e6ec8bdf319d3346
2019-03-20 22:26:52 +01:00
Translation updater bot 427f8c6a3b Localisation updates from https://translatewiki.net.
Change-Id: I82e7d1e21f99cb2b9507717dda5eb62293c08140
2019-03-18 23:07:07 +01:00
Translation updater bot d0cbe02212 Localisation updates from https://translatewiki.net.
Change-Id: I6e1066a8dc7db9cada0ad32cf874b1da9b48e1ef
2019-03-14 22:51:43 +01:00
Translation updater bot 393f17cf77 Localisation updates from https://translatewiki.net.
Change-Id: I488188960313b030cdccdfaafccefaafa6c31012
2019-03-07 22:40:36 +01:00
Translation updater bot 9af2d84a83 Localisation updates from https://translatewiki.net.
Change-Id: I149a04f3b5388a3e5754d3173c2c7a606f3a555c
2019-03-02 22:42:23 +01:00
Translation updater bot 37d6d15413 Localisation updates from https://translatewiki.net.
Change-Id: Ie16e10760b094323cb8c8b94c2da5a7494e1955a
2019-02-28 22:24:38 +01:00
Bartosz Dziewoński a3ef5fdab5 ve.ui.MWCitationDialog: If the selected ref is not using the template, clear it
Bug: T208981
Change-Id: I344331f1b2a5a8456d064039086623f67d9c0ea9
2019-02-26 00:30:56 +01:00
Bartosz Dziewoński 17555dd934 ve.ui.MWReferenceDialog: Remove 'Use an existing reference' button
The same functionality is available using the 'Cite → Re-use' tool
on the toolbar (T214991).

We want to use the same location for a new 'Replace reference' button,
to be implemented in the Citoid extension (T208981).

Bug: T208981
Bug: T214991
Change-Id: I511e3c27a7d2175bdc2b6bdb648f04ac96cd1e0b
2019-02-26 00:30:56 +01:00
Translation updater bot 12076d6937 Localisation updates from https://translatewiki.net.
Change-Id: Iaa63b15963234a6fbd6af72eb0f5a67dea96f6f7
2019-02-25 22:57:35 +01:00
jenkins-bot 467a17f651 Merge "Add support for read-only mode" 2019-02-22 19:45:57 +00:00
jenkins-bot 7c5906bcdf Merge "Use new upstream defaults for actions" 2019-02-22 14:53:52 +00:00
Ed Sanders 03711dfea8 Add support for read-only mode
Depends-On: Iedd1bd9ce17750ad8528c1a053293c4a7321c5de
Change-Id: I83bec9ea5b71aca0b4ef23237fad84aa6ea8a508
2019-02-22 14:13:57 +00:00
Ed Sanders e4efddbd0d Use new upstream defaults for actions
Allows us to remove action lists identical to the parent,
and also the default this.actions.setMode call.

Rename #canApply to #isModified for consistency.

Change-Id: I026feb291cd64474557d1f9df30604a7bbbb0bd2
2019-02-22 14:12:52 +00:00
Translation updater bot 80abb0f400 Localisation updates from https://translatewiki.net.
Change-Id: Ifd9c65e956524a2acd24d7ccbe40dd6a7cdfad71
2019-02-21 22:20:39 +01:00
Thiemo Kreuz 85ad4513ba Fix highlighting code destroying backlinks on unnamed <ref>s
There are multiple formats for these IDs:

cite_ref-1, cite_ref-2, and so on for anonymous <ref>s without a name.

cite_ref-name_1-0 for named references, where "name" is the custom name,
and "_1" is the sequential number for the reference (same number as above).
The final "-0" is counting the usages. If a named <ref> is only used once,
there is no cite_ref-name_1-1 anywhere on the page.

The later was already checked by the code. But we forgot about unnamed
references! As a consequence IDs like the cite_ref-1 above got misdetected
as reused references.

This patch tries hard to extract code into named functions, so it becomes
much more clear what they do, and why.

Bug: T215317
Change-Id: Iedb5b0c3dffae19bad7df9a43ed2d4512b3921ec
2019-02-20 15:40:46 +00:00
Thiemo Kreuz e71dcc355d Add missing jQuery selector escaping
As far as I can tell the effect of this is almost zero, because in both
cases the unescaped ID ends in double quotes. Within these double quotes
not many characters must be escaped, essentially only double quotes and
backslashes. Neither can appear in an ID (more precisely: neither should).

Proper escaping is "the right thing to do" anyway.

Change-Id: I21934f7cb54e2d68013a994150a92c76ef1b61d7
2019-02-20 16:22:20 +01:00
jenkins-bot 92c5ba2ca6 Merge "Remove generated cite-dialogs stubs" 2019-02-20 01:41:54 +00:00
Translation updater bot adae685cbe Localisation updates from https://translatewiki.net.
Change-Id: I3f65ae836527ec61287faef23aeff07e43ea3fcc
2019-02-17 22:14:03 +01:00
Ed Sanders 89dd1faa11 Remove generated cite-dialogs stubs
We generate stub MWCitationDialog sub-classes for each citation
type, e.g. cite-web, cite-news. The only override these sub-classes
provide is for the dialog title, providing "Website" instead of
"Cite web", however because of code in MWTemplateDialog, this override
isn't even used.

1. Make the 'citation' dialog (now 'cite') concrete by registering
   it, and allow a 'title' argument to be passed it.
2. Actually override the title, using the passed in argument.
3. Remove the stub generated citation dialogs.

This will also fix our tracking data. Current we are getting
window-open actions with the argument being a localised citation
type name, e.g. cite-Literatur, cite-אתר.

These will now all be tracked as 'cite' as we use the parent dialog.

Bug: T216248
Depends-On: I355e7fe4c2ea965f2ca91f0ab0430cfb95e56e0a
Change-Id: I661707b5f9d3d810e9391ad63bef546d4fcb29e4
2019-02-15 22:44:17 +00:00
Translation updater bot 9d476d73a7 Localisation updates from https://translatewiki.net.
Change-Id: I5efb1661329708a8602b2f76125d89596048c2ea
2019-02-14 22:28:57 +01:00
Translation updater bot fd89012b96 Localisation updates from https://translatewiki.net.
Change-Id: Ie11733aa2fcb7ef6b1de74b23ddda0c4ec90da58
2019-02-03 22:38:08 +01:00
Translation updater bot a778b6496f Localisation updates from https://translatewiki.net.
Change-Id: I0fd47d21150a54a5a55b99a411c2baf7783e82a6
2019-01-30 22:13:45 +01:00
Translation updater bot b56ca815bf Localisation updates from https://translatewiki.net.
Change-Id: I1217c6951dd149bf9fcae1cf4c516c145baa7274
2019-01-28 22:26:39 +01:00
Translation updater bot cc02b3122e Localisation updates from https://translatewiki.net.
Change-Id: I3475370bce39958a30ab7a79ffc6c1d0a304ed97
2019-01-25 22:28:46 +01:00
Translation updater bot 4b36c2b18a Localisation updates from https://translatewiki.net.
Change-Id: If2dcae129f62230eb5159785612be2937117a770
2019-01-22 22:17:08 +01:00
Translation updater bot 56fb029d72 Localisation updates from https://translatewiki.net.
Change-Id: I814a41ae72c6fce86aa465a42f8bb20a83509693
2019-01-19 22:15:56 +01:00
Translation updater bot 1fbff19c91 Localisation updates from https://translatewiki.net.
Change-Id: I1975c4deb3fa6f6a4f97ca906cb1b76bf7af14fd
2019-01-18 22:18:47 +01:00
Translation updater bot 8702b61b60 Localisation updates from https://translatewiki.net.
Change-Id: Ie5269d976f6cc4f7f32699fe06524e3de175cd29
2019-01-17 09:12:19 +01:00
Translation updater bot 2526765ecd Localisation updates from https://translatewiki.net.
Change-Id: Iab8e9dcd4348605b61be0e0d5af7f9733078bec5
2019-01-13 22:12:45 +01:00
Translation updater bot 23c29ed403 Localisation updates from https://translatewiki.net.
Change-Id: I3ab972919da543b1ac67aa776fdf6411c75e00c9
2019-01-12 22:39:38 +01:00
Translation updater bot 32b9b2207d Localisation updates from https://translatewiki.net.
Change-Id: Ibe4c662abf8932bf252eff6f75baebb7f50991c0
2019-01-10 22:49:01 +01:00
Bartosz Dziewoński 2286e5fde1 Improve warning that reference is reused
* Show the warning in the context menu (on desktop only) in addition
  to the reference dialog.
* Add more details to the warning in reference dialog, and adjust
  spacing around it to make it more noticeable.

Bug: T208981
Bug: T212609
Depends-On: I6ca605ddd580d6259952c8799ecdca08da07474a
Change-Id: I23cc02f651c15b3276613d32a0c2537032f731c2
2019-01-10 02:01:09 +01:00
Ed Sanders 0c0dcbdcd8 build: Update eslint-config-wikimedia to 0.10.0
Change-Id: Iba24172bd492750b268d0afbeeaf84b12cca3e0b
2019-01-08 23:06:43 +00:00
Translation updater bot 686006e44f Localisation updates from https://translatewiki.net.
Change-Id: I05fd70901a5783c8bf3bef7f0f319128cdbd0a1d
2019-01-05 22:33:37 +01:00
jenkins-bot 6a51ea98b3 Merge "ve.ui.MWCitationDialog: Unbreak the logic to enable/disable actions" 2019-01-03 18:41:09 +00:00
Translation updater bot 7750d59dc0 Localisation updates from https://translatewiki.net.
Change-Id: If1bd77d24bfe7d26949cf88b173b82387900a40f
2019-01-01 22:20:21 +01:00
Translation updater bot 9b59a7d155 Localisation updates from https://translatewiki.net.
Change-Id: I231f1d6af08194f58aefa8f36206c431ca2cbf91
2018-12-27 09:50:54 +01:00
Translation updater bot 22acd9a29c Localisation updates from https://translatewiki.net.
Change-Id: Icc162281f1ddec0369b8447b3c10f0cd84df4205
2018-12-18 22:48:09 +01:00
Kunal Mehta 0395035789 build: Set "root": true, in .eslintrc.json
This ensures that each repository's "npm test" command is fully
independent of wherever it might be in the filesystem.

Bug: T206485
Change-Id: I54d052bed4ceed175a938896154fd6ad5c89f964
2018-12-18 10:47:31 +00:00
Translation updater bot cfb8412e11 Localisation updates from https://translatewiki.net.
Change-Id: I3f4d7fd126b48e103bce03b104db51edcccbd569
2018-12-15 22:23:48 +01:00
Translation updater bot 87c2b3ded4 Localisation updates from https://translatewiki.net.
Change-Id: Ia71b6012942934a135547e787ad9c74ae37f7563
2018-12-14 22:21:37 +01:00
jenkins-bot 4eef765808 Merge "Restructure highlighting code for improved readability" 2018-12-13 00:04:21 +00:00
Translation updater bot 0dca8d7428 Localisation updates from https://translatewiki.net.
Change-Id: Ieea1e84f17cf47832f8c83dcd802b94293ace8ee
2018-12-12 22:18:26 +01:00
Translation updater bot 075d391ace Localisation updates from https://translatewiki.net.
Change-Id: I84b3d49b0e3c7cb7edeb62096427e6c3bc13cedb
2018-12-11 22:39:36 +01:00
jenkins-bot 1ee256aa76 Merge "Add "twice" instead of "2 times" in an English message" 2018-12-11 17:32:45 +00:00
Thiemo Kreuz e32a76061c Restructure highlighting code for improved readability
This gives the code a little more structure without changing anything
it does. A section is extracted as a named function, and some lines
are moved and bundled where it made sense.

Change-Id: I51909517021bee9dc618efe5fbe40adfc29dc6af
2018-12-11 15:19:17 +01:00
Volker E b9ee8433f4 build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Change-Id: I05e257b3213dd4039455d7e55efeb72b58da67fb
2018-12-10 02:59:11 -08:00
Amir Aharoni af28eed881 Add "twice" instead of "2 times" in an English message
Change-Id: I53de963d71015dfd26692241b2a0ea5630be080c
2018-12-10 08:52:36 +02:00
Translation updater bot 626d8a75df Localisation updates from https://translatewiki.net.
Change-Id: I5a8df261ae60ded18ca4709af624aa4fa4bc4a72
2018-12-09 22:38:53 +01:00
Translation updater bot ad5fd43df9 Localisation updates from https://translatewiki.net.
Change-Id: Iafe3fa40062305c4dd0d8353bbe05896cb2f15e5
2018-12-03 22:35:12 +01:00
Translation updater bot 7a969c2dbc Localisation updates from https://translatewiki.net.
Change-Id: Ibe63f4543e5bacb89808be7f04d76ce2f76bcb06
2018-12-02 22:14:54 +01:00
jenkins-bot 7ac91bef82 Merge "ve.ui.MWCitationDialog: Remove unneeded code re-setting insert label" 2018-11-30 22:42:44 +00:00
Translation updater bot 519157719b Localisation updates from https://translatewiki.net.
Change-Id: Iad5a14d487e2561133c7f9d0684de1955c247ee9
2018-11-30 22:49:44 +01:00
jenkins-bot e7b3167b31 Merge "Split overly long highlighting code into functions" 2018-11-30 15:00:09 +00:00
jenkins-bot 8ae3b13d1a Merge "Get rid of one nesting level in highlighting code" 2018-11-30 14:58:49 +00:00
jenkins-bot e353d36f3a Merge "Make backlink highlighting robust when "mw-cite-backlink" is missing" 2018-11-30 14:58:46 +00:00
Thiemo Kreuz 4d03f8f17f Split overly long highlighting code into functions
Change-Id: I055c21ee2202afea4751dd74fa389c55fdd30acf
2018-11-30 15:03:02 +01:00
Thiemo Kreuz 9ce4b959bc Get rid of one nesting level in highlighting code
The code before was not wrong, just deeply nested. The worst case was
that the final $upArrowLink.attr( … ) might have been called on zero
elements. jQuery is fine with this.

Change-Id: I62e7286c7fe906544fe148e1122c60cc8db070f3
2018-11-30 14:49:27 +01:00
Bartosz Dziewoński adc64b3002 ve.ui.MWCitationDialog: Unbreak the logic to enable/disable actions
This code was written in 2014 and it seems that some change to
ve.ui.MWTemplateDialog since then made it not work. No idea why or
when it broke. But we can implement the functionality much more easily
now by overriding #setApplicableStatus, which works correctly.

Bug: T210796
Change-Id: I6e87ca979a96785fc74f1a57f7d80ba4b43705f2
2018-11-29 22:39:55 +00:00
Bartosz Dziewoński b7bdcaeccc ve.ui.MWCitationDialog: Remove unneeded code re-setting insert label
This sets the label to be the same as the default value inherited from
ve.ui.MWTemplateDialog. Looks like it's no longer needed since change
Ia8fb88d3501ffa2c26add4419da5463a926f45d1 in VE-MW (2014).

Change-Id: Icd64d22aef29a3791352e1839993ea8462a147f3
2018-11-29 23:09:23 +01:00
Translation updater bot c31c93f619 Localisation updates from https://translatewiki.net.
Change-Id: I58dfd99dd04e0d78298df7ad51286ba252019142
2018-11-29 22:26:44 +01:00
Bartosz Dziewoński 7f6ae77b3c ve.ui.MWCitationDialog: Fix condition for enabling insert/apply action
The method #hasUsefulParameter has been accidentally made to always
return false in fdde5b71af.

Bug: T210686
Change-Id: I215924c2f693842abd8026404d17c725192272c3
2018-11-29 04:02:44 +00:00
Thiemo Kreuz 4152c6cdf4 Make backlink highlighting robust when "mw-cite-backlink" is missing
The class="mw-cite-backlink" is part of a message. It should be
considered code and not be customized, but can be. Frwiki for example
localized it.

The new code still hopes to find the class, and still hopes the first
child is the text node containing the plain text up arrow. (See the
message "cite_references_link_many" which contains all this.) This code
path is kept because it is more performant.

If the class is not found, the upwards traversal done via .closest()
stops at the <li>. It then traverses down into the firstChild nodes,
hoping to find the plain text up arrow this way.

This patch makes the code work with the customizations found in frwiki.

Bug: T205270
Bug: T210508
Change-Id: I32552ebe820ee12aea1a75aa17af11298dc7536a
2018-11-28 12:35:05 +01:00
jenkins-bot c88275c8d5 Merge "Make backlink highlighting robust for community customized HTML" 2018-11-28 11:34:32 +00:00
Thiemo Kreuz d7c1943b04 Make backlink highlighting robust for community customized HTML
This change makes the code much, much more robust. See, almost all HTML
relevant for this feature is encoded in messages. This allows unexpected
customizations that add additional HTML elements, change the order of DOM
elements, even remove class names and elements.

The <ol class="references"> is the only HTML snippet generated via code,
guaranteed to be there, and used as an entry point because of this.

Instead of the selector utilizing a "*" to detect references with "one"
vs. "many" backlinks, we check if a second backlink exists.

The .first() copies the browsers behavior to only respect the first anchor
in case an id="…" appears multiple times on a page.

The additional .length check further down is a missing sanity check,
currently relevant on frwiki where the expected class="mw-cite-backlink"
got localized.

Bug: T205270
Bug: T210520
Change-Id: Iba9aebfd01508b283933964cfb986d7239d4cf38
2018-11-28 11:56:27 +01:00
Ed Sanders fdde5b71af Update eslint-config-wikimedia to 0.9.0
Change-Id: I7883af1f56c7f2f3eeff1f7a51b640a303bcab78
2018-11-27 22:23:57 +00:00
WMDE-Fisch 6dda36a1e7 Improve a11y support on backlinks
This changes the a11y support on the main backlinks by introducing the usage
of title and aria-labels. The support for these elements increased a lot since
the topic was first tackled and seems the appropriate way to go.

A new message was introduced for the link that will be set when directly
coming from a clicked refrence to emphasize that the can jump back to where
he came from.

Bug: T206323
Change-Id: Ifa56d41bcdb8100e19f29619796b62bb3c886d2f
2018-11-26 11:36:26 +01:00
jenkins-bot fd956ab507 Merge "ve.ui.MWReferencesListDialog: Disable 'Apply' button until changes are made" 2018-11-20 15:54:57 +00:00
jenkins-bot 222b9ca593 Merge "Make arrows/carets links whenever we know where the user came from" 2018-11-20 12:42:21 +00:00
jenkins-bot 18a53d7666 Merge "Localisation updates from https://translatewiki.net." 2018-11-19 22:23:55 +00:00
Translation updater bot 2cf53b996b Localisation updates from https://translatewiki.net.
Change-Id: If314a6b7ad16b2470688cc32ced4a5560b773cbc
2018-11-19 22:11:05 +01:00
Thiemo Kreuz (WMDE) 2b3a62c26b Make arrows/carets links whenever we know where the user came from
I tried to arrange the new code in a way that it is compact, but still
readable. I think it's possible to arrange it even better, but browser
tests should be added first, in my opinion.

Bug: T205271
Change-Id: I1d579ef9d2787fc43c0a8bbf61c583f602dca5d4
2018-11-19 16:27:59 +00:00
jenkins-bot 8b97f74dc9 Merge "Highlight backreference jump marks by making them bold" 2018-11-19 16:24:24 +00:00
Thiemo Kreuz ee8da566e3 Highlight backreference jump marks by making them bold
The separate "ext.cite.a11y" module is kept for (temporary)
compatibility with cached HTML, and should be removed in about
a month.

Browser tests will be added in a separate patch.

Bug: T205270
Change-Id: I26fe41c328157233cc5b06d38d2ba0f7b036a853
2018-11-19 16:46:08 +01:00
Translation updater bot 7ecdec713d Localisation updates from https://translatewiki.net.
Change-Id: I9cf5306d453310e154c2f49df23f1be6348200de
2018-11-18 22:48:21 +01:00
Bartosz Dziewoński fd19cd76c1 ve.ui.MWReferencesListDialog: Disable 'Apply' button until changes are made
Bug: T209660
Change-Id: I2c998cce812b63d1f5656ba38470a77ac5a0fd45
2018-11-16 00:49:08 +01:00
Ed Sanders e0781b0c58 Fix typo in documentation
Change-Id: I25407db3025dace825afd0ca083eba4fc600955d
2018-11-13 23:42:35 +00:00
jenkins-bot 82c75661ee Merge "Remove obsolete aliases from closures" 2018-11-13 22:59:20 +00:00
Ed Sanders a589dbe636 Remove obsolete aliases from closures
Bug: T208951
Change-Id: Idd6bc36b116af81827b4440b4c8ec3da94e1486f
2018-11-13 14:43:45 -08:00
Translation updater bot 664b178c3d Localisation updates from https://translatewiki.net.
Change-Id: I6aae842e9a5d4a8a036ed6107222e9bc84ac57b9
2018-11-12 22:12:39 +01:00
Translation updater bot e61ab2c8f6 Localisation updates from https://translatewiki.net.
Change-Id: Iade9e083c123e608dfac57f8e27f4fbbf65e9932
2018-11-11 22:33:37 +01:00
Translation updater bot a9ae168208 Localisation updates from https://translatewiki.net.
Change-Id: Ib3be93269095ae9b86e407aab89d353b5530b56b
2018-11-10 22:28:03 +01:00
Translation updater bot 86bf110048 Localisation updates from https://translatewiki.net.
Change-Id: I0d4260c2bd9121a41ad9598f57edb6001748e186
2018-11-07 22:21:58 +01:00
Bartosz Dziewoński ec55fa3ce8 Use changed ve.dm.Selection interface
Bug: T208228
Bug: T208913
Change-Id: Ifb1a77a5f07b9e257c6e0477e23316f80c7a4791
2018-11-07 16:51:51 +01:00
Translation updater bot 774e301300 Localisation updates from https://translatewiki.net.
Change-Id: Ia5f2da9fb4166a5c53f681705ece9591b99f4b9c
2018-11-04 22:42:03 +01:00
Translation updater bot 5e9add6454 Localisation updates from https://translatewiki.net.
Change-Id: Ic2dc4045f2baa1467329bd4619f59e846a5118c4
2018-11-03 11:02:43 +01:00
Ed Sanders 4df9bf5f69 Fix wikitext paste test
Bug: T204007
Depends-On: I97a92512d7b114ed46bc48d3d416eebc86df13f7
Change-Id: I06177cb4428798f62b78f5dc48f545a6cb6884fc
2018-10-29 21:39:40 +00:00
Translation updater bot 9ee0d799a7 Localisation updates from https://translatewiki.net.
Change-Id: Ib0be56800d53b316fb4f473c8ab2940b5cac1dd7
2018-10-28 22:21:44 +01:00
Translation updater bot 09964ca80d Localisation updates from https://translatewiki.net.
Change-Id: I1a74c35bbb16714cbe0777e6eb2305585644ccf7
2018-10-26 22:24:05 +02:00
Translation updater bot a08297ee92 Localisation updates from https://translatewiki.net.
Change-Id: I88ed6da413e9396b283e5ff6cd59b2c6990848a0
2018-10-14 22:25:09 +02:00
Translation updater bot 3e3c7fc2b1 Localisation updates from https://translatewiki.net.
Change-Id: Icb7f2e358b56be2430e5ffd95653ff59660aad87
2018-10-13 10:19:13 +02:00
Translation updater bot 05e4d5bcfb Localisation updates from https://translatewiki.net.
Change-Id: Ic3deaa69b49671465650d2bb23ba108d79e68e1a
2018-10-11 22:37:14 +02:00
Translation updater bot 1daa5234b4 Localisation updates from https://translatewiki.net.
Change-Id: Icb276a9e5e4d7d8a4e7bcdf4f71efaf3b73212ac
2018-10-07 22:30:03 +02:00
Translation updater bot 4af353f400 Localisation updates from https://translatewiki.net.
Change-Id: I0f933da5e746bc62403e714efa23ff3dedc16464
2018-10-06 22:35:16 +02:00
jenkins-bot ecb9c147f9 Merge "Avoid jQuery in ve.dm.Model.static.describeChange(s)" 2018-09-28 16:19:26 +00:00
Ed Sanders 817bfbfa54 Avoid jQuery in ve.dm.Model.static.describeChange(s)
Change-Id: If30d12289eff66470044931ea5b38d2b81d04075
2018-09-28 10:55:45 +01:00
Translation updater bot 796f09f815 Localisation updates from https://translatewiki.net.
Change-Id: Ie55265921331083b1f93423ddae0e36e72e9adae
2018-09-24 09:17:47 +02:00
Translation updater bot dc0d9647f3 Localisation updates from https://translatewiki.net.
Change-Id: I00ebfa62d02062d3e363aae70615a6896ad3b4b6
2018-09-22 10:03:17 +02:00
Translation updater bot 37421a7868 Localisation updates from https://translatewiki.net.
Change-Id: I169af1fde9b4a756a0047f546872b72533ab4fc9
2018-09-20 09:58:54 +02:00
jenkins-bot 557e311ab4 Merge "Template reflist: Re-render when converting for preview (e.g. visual diff)" 2018-09-19 23:49:12 +00:00
Translation updater bot f1cf01f878 Localisation updates from https://translatewiki.net.
Change-Id: Ic2bf30d4758f1dd51c2cfe9e57058ed9e54f5a7c
2018-09-18 09:52:00 +02:00
jenkins-bot 216d85adaf Merge "build: Update linters" 2018-09-13 22:47:59 +00:00
Ed Sanders eb7bed046b Template reflist: Re-render when converting for preview (e.g. visual diff)
Bug: T202324
Change-Id: I33dfb26a8f033f5ee5a89b2c1ad9aa081d3a55d1
2018-09-13 21:04:47 +01:00
James D. Forrester d95dda3f16 Unbreak visual diff results for checking node type change
Bug: T201721
Change-Id: I59fa13324083bfd8c77862d0d88b9b3cea1cfeb8
2018-09-13 11:08:46 -07:00
Translation updater bot 1401e9cf0b Localisation updates from https://translatewiki.net.
Change-Id: Idfc7ce1fcc94970e550ed1ca6cdf8bfc4d8c3f36
2018-09-13 10:15:21 +02:00
Ed Sanders 3a2b025e07 Convert bugzilla numbers to phab task numbers
Change-Id: I30e8c8d9eaff47185a61a093787cdfd25b3889d8
2018-09-12 16:48:17 +00:00
Jforrester 82c93513ac Merge "Replace deprecated 'advanced' by renamed to 'settings' icon" 2018-09-12 16:47:56 +00:00
Ed Sanders 0d866f13c7 build: Update linters
Change-Id: Ia558b35eab54b33e2faac1ae3324a17da18fcb49
2018-09-11 23:54:19 +01:00
Translation updater bot de58933995 Localisation updates from https://translatewiki.net.
Change-Id: Icf18dddbccb13a0e40d72c132ec38a2d139922e7
2018-09-09 10:35:52 +02:00
Volker E a30925d229 Replace deprecated 'advanced' by renamed to 'settings' icon
Bug: T190581
Change-Id: I2151c9d6b1b3f7306ed4e049a6bd2efb59787100
2018-09-07 19:59:40 -07:00
Translation updater bot 93e2858322 Localisation updates from https://translatewiki.net.
Change-Id: I8904d205c34135b3975c8dc111448d1190cf5ca9
2018-09-04 22:19:24 +02:00
Translation updater bot fadce2ecf4 Localisation updates from https://translatewiki.net.
Change-Id: Ie80f3c35493c863d84de4949e4772ed75d1079c6
2018-08-22 22:35:35 +02:00
Translation updater bot 4763e3dfd2 Localisation updates from https://translatewiki.net.
Change-Id: I65652c293084b1b43d53350b53f0c43d9a86aec9
2018-08-16 22:28:30 +02:00
Translation updater bot 627a674b99 Localisation updates from https://translatewiki.net.
Change-Id: I54d1f21c7d40edde19dbb76d21a22f88d45cc313
2018-08-10 22:18:08 +02:00
Translation updater bot 295d0f550b Localisation updates from https://translatewiki.net.
Change-Id: Id2059835f60d164e0ba24b50d1c5d14c5441b3fe
2018-08-09 22:23:30 +02:00
Translation updater bot 0b2f373c88 Localisation updates from https://translatewiki.net.
Change-Id: I49f20ed6cc83cd6e16d1d572acf680c19dad799a
2018-08-08 22:13:25 +02:00
Translation updater bot d4bad226c3 Localisation updates from https://translatewiki.net.
Change-Id: Ia58b72de17f26786121c6f0b5395aa1752f2ca47
2018-08-06 22:21:23 +02:00
Derk-Jan Hartman a603ef420f Make references not inherit bold or italic styling.
There is almost never a situation where this is desirable, yet it
happens quite a lot due to table headers etc having bold styling.
It confuses editors and tends to be less readable.

These style rules have been in en.wp:MediaWiki:Common.css for over 10
years or so, so probably a keeper.

Change-Id: If3d12383853a83d8ef14f1ec54c8c381b6c8f6a2
2018-08-01 14:57:37 +02:00
Translation updater bot 49285be063 Localisation updates from https://translatewiki.net.
Change-Id: I223a49833927444b4153b25bb521060fefc7a5bb
2018-07-31 22:32:50 +02:00
jenkins-bot d6dd82d782 Merge "Get document data using updated interface" 2018-07-29 00:32:45 +00:00
Thalia 2c77a9d66a Get document data using updated interface
Depends-On: Iea426be573f07c976b0c142357d5ed83e51db013
Depends-On: I36dad61ed614f007b16d7e9f47fcbfd02347f239
Change-Id: I9d9615f69d40822a72f31f0d86d7997dd0812523
2018-07-29 00:07:28 +00:00
Translation updater bot 6485e4ec2c Localisation updates from https://translatewiki.net.
Change-Id: Ifbb38f66c68561cb2423717199e731691c298a46
2018-07-28 22:29:33 +02:00
Translation updater bot 0be3b3f652 Localisation updates from https://translatewiki.net.
Change-Id: I8145d76cc0c4bc5beeb9bb9442b8920b71f8a972
2018-07-27 22:17:34 +02:00
Translation updater bot 580a008af7 Localisation updates from https://translatewiki.net.
Change-Id: I5600138f4129aa90d751119b729f0bd358d9fb90
2018-07-23 22:31:02 +02:00
Translation updater bot eebab2324c Localisation updates from https://translatewiki.net.
Change-Id: Iad2da337807804cfc72b9e2409dfe9b1f7098092
2018-07-22 22:08:40 +02:00
Translation updater bot 8b8d2ef640 Localisation updates from https://translatewiki.net.
Change-Id: I6c49d27a991b58b220463c583793c8158abb85c7
2018-07-21 22:11:37 +02:00
Translation updater bot d07660a410 Localisation updates from https://translatewiki.net.
Change-Id: Ic23ea75fe75a3e64a113a7fd1007865d92ef77d6
2018-07-19 22:30:23 +02:00
Translation updater bot 1851e261ea Localisation updates from https://translatewiki.net.
Change-Id: I46dc02571083f2abb636635ba019a8328920295f
2018-07-18 22:12:25 +02:00
Translation updater bot e4902524b2 Localisation updates from https://translatewiki.net.
Change-Id: Ia0cc70db00cffa075aeec1d8e0a686c7110af1b5
2018-07-11 22:39:30 +02:00
Translation updater bot c1b77b092e Localisation updates from https://translatewiki.net.
Change-Id: I3f00282a3860cee11e976aa4171ff3562fbfe7db
2018-07-07 22:52:28 +02:00
Translation updater bot bd02bf9557 Localisation updates from https://translatewiki.net.
Change-Id: I4d7c0a80e98b2bf5a37632035c695fb6d8eb65b5
2018-07-05 22:43:39 +02:00
Translation updater bot a59f8a085d Localisation updates from https://translatewiki.net.
Change-Id: I3e04c8cceae727e5470d4ae4fdb2404639f9bfb8
2018-06-30 22:30:17 +02:00
Translation updater bot 270b1b56ba Localisation updates from https://translatewiki.net.
Change-Id: I3cbf13202bc9fa6053325d3c69600fdbc40f1741
2018-06-29 22:25:43 +02:00
Translation updater bot d0073f4060 Localisation updates from https://translatewiki.net.
Change-Id: I1d70595d17590a80d48f20b878a34f57c7e6e49b
2018-06-28 22:20:58 +02:00
Translation updater bot 3ba755bdd2 Localisation updates from https://translatewiki.net.
Change-Id: I01e328cba818b428b7705df1e896f25f50e60c9c
2018-06-27 22:18:23 +02:00
Translation updater bot 6904eae490 Localisation updates from https://translatewiki.net.
Change-Id: Idd9310f79493db305959bb42439abff880e42731
2018-06-24 22:25:28 +02:00
Ed Sanders 3b53f6906b Use getHtmlMessage for DiffElement
Bug: T195243
Depends-On: Ib4ad16858e4241d33d018830dbcfded63ff703af
Depends-On: Ib5fa39e4f2f529948354b03a141542e23d169fe0
Change-Id: I4b01904d48a9520c8bb1451e0978aaa404ca858c
2018-06-20 15:31:46 +00:00
Translation updater bot 73ca14bb7d Localisation updates from https://translatewiki.net.
Change-Id: I17d832a454d3f64f1bbeeab8df666bd322bc830a
2018-06-15 22:35:36 +02:00
Translation updater bot 0a0dae10d6 Localisation updates from https://translatewiki.net.
Change-Id: Iaae6fc6de3940e7f1e0d79cded597125500a625d
2018-06-14 22:44:29 +02:00
Translation updater bot 72572ba8a0 Localisation updates from https://translatewiki.net.
Change-Id: I65609ee5a741c0356659b48098d602efe1cf5bcc
2018-06-11 22:33:37 +02:00
Translation updater bot 3c6aeebccf Localisation updates from https://translatewiki.net.
Change-Id: I2c2e27f177f3091d909a1fcadc9d8e5840510e85
2018-06-03 22:36:06 +02:00
Ed Sanders 6c38c009d7 Add preview mode converter tests
Change-Id: I2e9dc615a82b725d4061b39e6bdc56350e5d3d1d
Depends-On: I3f1a4772cbf67091b5fd52bab610390ebd9b16ef
2018-05-31 16:27:14 +01:00
Translation updater bot c3363cadae Localisation updates from https://translatewiki.net.
Change-Id: I4070d78d1e7e5ef425ac86294be6e81f9d8583d5
2018-05-29 22:24:43 +02:00
Translation updater bot 7ba27bb832 Localisation updates from https://translatewiki.net.
Change-Id: Ibc4dad7b91176083fc8fb721f960eaaee6f593a8
2018-05-28 22:41:56 +02:00
Translation updater bot 18a2b83694 Localisation updates from https://translatewiki.net.
Change-Id: Id04df14cbc15cda40051955fea054f2842a92d87
2018-05-25 22:14:06 +02:00
Translation updater bot fda8af39b3 Localisation updates from https://translatewiki.net.
Change-Id: Ib69d038dd60ede84108f48c7f1fcacc8a3f8b160
2018-05-24 22:24:44 +02:00
Translation updater bot e6506cdd08 Localisation updates from https://translatewiki.net.
Change-Id: I9f3f34ac163664fcbffe7b1d20d58813bd9c25f4
2018-05-23 22:20:08 +02:00
Translation updater bot 5b5824dabe Localisation updates from https://translatewiki.net.
Change-Id: I35ab3e7ab5ee261eb361da2cd0d3fe1ffaa3a196
2018-05-22 22:20:38 +02:00
Translation updater bot 3640f87085 Localisation updates from https://translatewiki.net.
Change-Id: I9056184ec924f3fa96031ba318041de48470fc3a
2018-05-20 22:44:17 +02:00
Translation updater bot ddcd9e644a Localisation updates from https://translatewiki.net.
Change-Id: I6c0ddba62a4ec75192123b9c9a685ce21be1632b
2018-05-15 22:24:26 +02:00
Translation updater bot 440d3678e8 Localisation updates from https://translatewiki.net.
Change-Id: Ibf12746b038b4424107565fa2d423cc55bc61638
2018-05-14 22:44:11 +02:00
Ed Sanders 475d825918 Use MWPreviewElement in view mode, instead of building a view node
Also "unwrap" paragraphs using CSS instead of DOM manipulation.

Change-Id: I5565c2c43580d5d47bc65ee06d9d14fccace90c6
Depends-On: Ibbf989dcebf2d21fd2ac481f17062f366ff29e41
Depends-On: I284bcd5dd25cdbb883427ebacb41af1bbf50b60f
2018-05-13 20:01:19 +01:00
Ed Sanders a08febb0af Simplify toolbar registration
VE-MW toolbars now define a placeholder for reference toolbars.

Depends-On: I0bace5e5fe05f9c214d57a74c478b48a7dcaec3b
Change-Id: I7cb0f1f1affbfd7a4013f396b1423b6f84da52ab
2018-05-12 16:42:08 +01:00
jenkins-bot fc0fd39389 Merge "Use ve.ce.nodeFactory.createFromModel" 2018-05-11 19:32:59 +00:00
Ed Sanders 2ae4cfe0ab Use ve.ce.nodeFactory.createFromModel
Also use ve.dm.nodeFactory.createFromElement

Depends-On: I259face33154b795143c8820abdfb6b4a495f141
Depends-On: I7fc539f75a1c9d672efc139b7884ecdfdff5f301
Change-Id: I032182616c409e65138b16fe7b238e7f7b3a8710
2018-05-11 17:08:12 +00:00
Translation updater bot a852fee21b Localisation updates from https://translatewiki.net.
Change-Id: I534fdcb01f79036b4bb29e400ebe1bb2b23a81e8
2018-05-10 22:20:22 +02:00
jenkins-bot cfd18814be Merge "Support directionality for reference" 2018-05-02 15:59:33 +00:00