wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-28 00:40:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove dead extra comparison from VE JavaScript code

Browse source 
The first code snippet in this while already covers this case. The loop
will end the moment it can't find another parent any more.

This was found via
https://sonarcloud.io/project/issues?id=mediawiki-extensions-Cite&types=BUG
as a potential bug. After looking at the code I'm sure it's not one.

Change-Id: Id914252c88b27420dfa47dcc918fc58d9ee2a65d
This commit is contained in:
Thiemo Kreuz 2019-05-17 15:24:26 +02:00 committed by Thiemo Kreuz (WMDE)
parent e834fbe25e
commit d622356a73
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/ve-cite/ve.ce.MWReferencesListNode.js
View file

@ -212,11 +212,12 @@ ve.ce.MWReferencesListNode.prototype.update = function () {
return false;
}
// Exclude references defined inside the references list node
while ( ( node = node.parent ) && node !== null ) {
do {
node = node.parent;
if ( node instanceof ve.dm.MWReferencesListNode ) {
return false;
}
}
} while ( node );
return true;
} );