wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-09-25 03:08:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ve.ui.MWReferencesListDialog: Disable 'Apply' button until changes are made"

Browse source
This commit is contained in:
jenkins-bot 2018-11-20 15:54:57 +00:00 committed by Gerrit Code Review
parent 7d7a38ad8f fd19cd76c1
commit fd956ab507
1 changed files with 51 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
modules/ve-cite/ve.ui.MWReferencesListDialog.js
View file

@ -95,13 +95,46 @@ ve.ui.MWReferencesListDialog.prototype.initialize = function () {
this.$body.append( this.panels.$element );
};
/**
* Handle change event.
*/
ve.ui.MWReferencesListDialog.prototype.onChange = function () {
this.updateActions();
};
/**
* Update the 'apply' action according to whether there are changes
*/
ve.ui.MWReferencesListDialog.prototype.updateActions = function () {
this.actions.setAbilities( { apply: this.isModified() } );
};
/**
* @return {boolean}
*/
ve.ui.MWReferencesListDialog.prototype.isModified = function () {
var refGroup, listGroup, oldListGroup, isResponsive, oldResponsive;
if ( !this.selectedNode ) {
return true;
}
refGroup = this.groupInput.getValue();
listGroup = 'mwReference/' + refGroup;
isResponsive = this.responsiveCheckbox.isSelected();
oldListGroup = this.selectedNode.getAttribute( 'listGroup' );
oldResponsive = this.selectedNode.getAttribute( 'isResponsive' );
return listGroup !== oldListGroup || isResponsive !== oldResponsive;
};
/**
* @inheritdoc
*/
ve.ui.MWReferencesListDialog.prototype.getActionProcess = function ( action ) {
if ( action === 'apply' ) {
return new OO.ui.Process( function () {
var refGroup, listGroup, oldListGroup, isResponsive, oldResponsive, mwData, attrChanges, doc,
var refGroup, listGroup, isResponsive, mwData, attrChanges, doc,
surfaceModel = this.getFragment().getSurface();
// Save changes
@ -112,10 +145,8 @@ ve.ui.MWReferencesListDialog.prototype.getActionProcess = function ( action ) {
if ( this.selectedNode ) {
// Edit existing model
doc = surfaceModel.getDocument();
oldListGroup = this.selectedNode.getAttribute( 'listGroup' );
oldResponsive = this.selectedNode.getAttribute( 'isResponsive' );
if ( listGroup !== oldListGroup || isResponsive !== oldResponsive ) {
if ( this.isModified() ) {
// newFromAttributeChanges doesn't do the smart-replacing
// for nested attributes, so make a copy of the mw
// attribute so we can disable autoGenerated now we've
@ -160,6 +191,22 @@ ve.ui.MWReferencesListDialog.prototype.getSetupProcess = function ( data ) {
this.groupInput.populateMenu( this.getFragment().getDocument().getInternalList() );
this.responsiveCheckbox.setSelected( this.selectedNode.getAttribute( 'isResponsive' ) );
this.groupInput.connect( this, { change: 'onChange' } );
this.responsiveCheckbox.connect( this, { change: 'onChange' } );
this.updateActions();
}, this );
};
/**
* @inheritdoc
*/
ve.ui.MWReferencesListDialog.prototype.getTeardownProcess = function ( data ) {
return ve.ui.MWReferencesListDialog.super.prototype.getTeardownProcess.call( this, data )
.next( function () {
this.groupInput.disconnect( this );
this.responsiveCheckbox.disconnect( this );
}, this );
};