Two small changes per comments on
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1036766:
* remove both night mode classes in a single function call
* slightly rework alterDisableLink logic to account for the possibility
that the message is empty when we check it
Bug: T365083
Change-Id: I1633df85e768b7da2f1f542fb793089f34bcc6b7
Satisfy typescripts needs
Literals are evaluated faster and what we use more consistently.
With typescript, since keys and values can be any value, we need
to declare explictly the expected types of the values via a
@type command.
Note Object is also a constructor, if you use `new Object()` you
would get the same typescript error.
Follow up to I9583ee7ebf8c810ddd504193d568034c954d28f2
Bug: T365083
Change-Id: Ibfda8ea1bcf2ecb6b280302197af33e4c4065d95
While our implementation of night mode is in beta, we want to respect
the existing night mode gadget and disable night mode in favor of the
gadget, providing a notice with an option to disable the gadget and
reload the page
Additionally, raise the max bundle size to account for the additional
code added
Note: the tests still aren't exactly where I'd like them to be, but
hopefully they raise confidence a little bit with reviewing this patch
Additional changes:
* Upgrade to latest version of TypeScript types and remove several
@ts-ignore statements
Bug: T365083
Change-Id: I9583ee7ebf8c810ddd504193d568034c954d28f2
Fixes 9 warnings generated by https://validator.w3.org/nu/
- The navigation role is unnecessary for element nav.
- The main role is unnecessary for element main.
- The contentinfo role is unnecessary for element footer.
Bug: T365938
Change-Id: Ibdbe70900f9a85d904252ad8ac26e4bb6e813a1c
The Menu/MenuItem files got slightly larger due to new
config options related to the MenuButton component.
Change-Id: I04c1250aef3afbff43c11a012194263ec6b0f533
Replacing Vector specific variable with standard token that is meant
for exactly the applied use cases.
Note, I've left `border-color-subtle-transparent` because of that
extra engineering leg. I assume it was meant for animating the property,
which is not there. It seems better to me to replace this variable too
with `border-color-transparent`.
Change-Id: If264e04e576f044b98ec0d61b085f65af0110b6d
Should only have one HTML ID per page. I've decided to remove
the first of the two duplicate IDs and to replace it with
#vector-variants-dropdown, to match the code style of the similar
#vector-user-links-dropdown
Bug: T343730
Change-Id: I6abdc293c1dbb18faf9751b4633a572a019593ab
* Remove stray @package comments. They appear to be auto-generated
as they just repeat the namespace name (but the wrong one).
* Remove redundant test that effectively doesn't do anything other
than testing if the constructor doesn't fail. This is already
covered by other tests.
Change-Id: Icb1136b7018a88310a37a3989d18a678e6cb9ddf
There is a missing span tag in the table of contents where text is placed directly into a div, breaking convention.
Change-Id: I12280e2c6a6e688b36a906d5b5a5c5deba42c977
This reverts commit ff5a61e9c6.
Reason for revert: The behaviour introduced in this patch needs some more consideration.
Bug: T364015
Change-Id: Ieab4ca4084df4f1b5c942fe81c7fb99b058e0623
Updates `CSSCustomProperties.less` to include `.oo-ui-popupWidget-popup` in
`@OOUIOverrideSelectors` for inverted color inheritance.
Bug: T364798
Change-Id: I6c3ac79d24f6af71a9171153e346494fb97acd3f
Allocate specific space for each installed extension based on
whether it is installed. This should reduce false positives (assuming
we have accounted for every installed extension)
If we haven't we'll follow up with additional budgets as we learn
about them.
Bug: T365480
Change-Id: Ie487fc56eb199f94e0b72f59d5c54f623570773a
I accidentally enabled this on tablet breakpoint.
Follow up to e3d2ab5031
The Pixel UI report should only surface changes on mobile - all
of these are improvements as it means the whole UI is visible in
the viewport.
Bug: T361573
Change-Id: I8aa5699a8fe959c1595d74c03f19c14856f6470f
It is unclear why this is needed, but
I9be50b3749500160e918ff3f2d2e1646ba7dc1a6 (which only touches en.json
and qqq.json files) fails on this test in CI. The cause must still be
investigated separately.
Bug: T365480
Change-Id: I889561b5b669d992c1f152d4bd203a71e2aff9ba
Styles removed in 1d17b46 were being utilised for Echo without
us knowing. Rather than revert that patch (which seems risky
so late in the day) I think it's preferable to restore these styles
for the Echo icons inside the skinStyle
Bug: T365409
Change-Id: Ibb967343f9c97c5fbe87d29b40e871f0f336f957
