wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-23 23:33:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing span tag on ToC items

Browse source 
There is a missing span tag in the table of contents where text is placed directly into a div, breaking convention.

Change-Id: I12280e2c6a6e688b36a906d5b5a5c5deba42c977
This commit is contained in:
weebney 2024-02-20 06:56:32 +00:00 committed by Jon Robson
parent a4af4b12f8
commit 6dcb40447d
2 changed files with 66 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/templates/TableOfContents__line.mustache
View file

@ -2,7 +2,9 @@
class="vector-toc-list-item vector-toc-level-{{toclevel}}{{#is-top-level-section}}{{^vector-is-collapse-sections-enabled}} vector-toc-list-item-expanded{{/vector-is-collapse-sections-enabled}}{{/is-top-level-section}}">
<a class="vector-toc-link" href="#{{linkAnchor}}">
<div class="vector-toc-text">
<span class="vector-toc-numb">{{number}}</span>{{{line}}}</div>
<span class="vector-toc-numb">{{number}}</span>
<span>{{{line}}}</span>
</div>
</a>
{{#extensionData.DiscussionTools-html-summary}}
{{{.}}}

84
tests/jest/__snapshots__/tableOfContents.test.js.snap
View file

@ -16,7 +16,9 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-foo\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#foo\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">1</span>foo</div>
<span class=\\"vector-toc-numb\\">1</span>
<span>foo</span>
</div>
</a>
<ul id=\\"toc-foo-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -24,7 +26,9 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-bar\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#bar\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2</span>bar</div>
<span class=\\"vector-toc-numb\\">2</span>
<span>bar</span>
</div>
</a>
<button aria-controls=\\"toc-bar-sublist\\" class=\\"cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle\\" aria-expanded=\\"true\\">
<span class=\\"vector-icon mw-ui-icon-wikimedia-expand\\"></span>
@ -34,13 +38,17 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-baz\\" class=\\"vector-toc-list-item vector-toc-level-2\\">
<a class=\\"vector-toc-link\\" href=\\"#baz\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2.1</span>baz</div>
<span class=\\"vector-toc-numb\\">2.1</span>
<span>baz</span>
</div>
</a>
<ul id=\\"toc-baz-sublist\\" class=\\"vector-toc-list\\">
<li id=\\"toc-qux\\" class=\\"vector-toc-list-item vector-toc-level-3\\">
<a class=\\"vector-toc-link\\" href=\\"#qux\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2.1.1</span>qux</div>
<span class=\\"vector-toc-numb\\">2.1.1</span>
<span>qux</span>
</div>
</a>
<ul id=\\"toc-qux-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -52,7 +60,9 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-quux\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#quux\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">3</span>quux</div>
<span class=\\"vector-toc-numb\\">3</span>
<span>quux</span>
</div>
</a>
<ul id=\\"toc-quux-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -84,7 +94,9 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-foo\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#foo\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">1</span>foo</div>
<span class=\\"vector-toc-numb\\">1</span>
<span>foo</span>
</div>
</a>
<ul id=\\"toc-foo-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -92,7 +104,9 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-bar\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#bar\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2</span>bar</div>
<span class=\\"vector-toc-numb\\">2</span>
<span>bar</span>
</div>
</a>
<button aria-controls=\\"toc-bar-sublist\\" class=\\"cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle\\" aria-expanded=\\"true\\">
<span class=\\"vector-icon mw-ui-icon-wikimedia-expand\\"></span>
@ -102,13 +116,17 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-baz\\" class=\\"vector-toc-list-item vector-toc-level-2\\">
<a class=\\"vector-toc-link\\" href=\\"#baz\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2.1</span>baz</div>
<span class=\\"vector-toc-numb\\">2.1</span>
<span>baz</span>
</div>
</a>
<ul id=\\"toc-baz-sublist\\" class=\\"vector-toc-list\\">
<li id=\\"toc-qux\\" class=\\"vector-toc-list-item vector-toc-level-3\\">
<a class=\\"vector-toc-link\\" href=\\"#qux\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2.1.1</span>qux</div>
<span class=\\"vector-toc-numb\\">2.1.1</span>
<span>qux</span>
</div>
</a>
<ul id=\\"toc-qux-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -120,7 +138,9 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-quux\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#quux\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">3</span>quux</div>
<span class=\\"vector-toc-numb\\">3</span>
<span>quux</span>
</div>
</a>
<ul id=\\"toc-quux-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -128,7 +148,9 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<li id=\\"toc-bat\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#bat\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">4</span>bat</div>
<span class=\\"vector-toc-numb\\">4</span>
<span>bat</span>
</div>
</a>
<ul id=\\"toc-bat-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -156,7 +178,9 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<li id=\\"toc-foo\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#foo\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">1</span>foo</div>
<span class=\\"vector-toc-numb\\">1</span>
<span>foo</span>
</div>
</a>
<ul id=\\"toc-foo-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -164,7 +188,9 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<li id=\\"toc-bar\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#bar\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2</span>bar</div>
<span class=\\"vector-toc-numb\\">2</span>
<span>bar</span>
</div>
</a>
<button aria-controls=\\"toc-bar-sublist\\" class=\\"cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle\\" aria-expanded=\\"true\\">
<span class=\\"vector-icon mw-ui-icon-wikimedia-expand\\"></span>
@ -174,13 +200,17 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<li id=\\"toc-baz\\" class=\\"vector-toc-list-item vector-toc-level-2\\">
<a class=\\"vector-toc-link\\" href=\\"#baz\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2.1</span>baz</div>
<span class=\\"vector-toc-numb\\">2.1</span>
<span>baz</span>
</div>
</a>
<ul id=\\"toc-baz-sublist\\" class=\\"vector-toc-list\\">
<li id=\\"toc-qux\\" class=\\"vector-toc-list-item vector-toc-level-3\\">
<a class=\\"vector-toc-link\\" href=\\"#qux\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2.1.1</span>qux</div>
<span class=\\"vector-toc-numb\\">2.1.1</span>
<span>qux</span>
</div>
</a>
<ul id=\\"toc-qux-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -192,7 +222,9 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<li id=\\"toc-quux\\" class=\\"vector-toc-list-item vector-toc-level-1 vector-toc-list-item-expanded\\">
<a class=\\"vector-toc-link\\" href=\\"#quux\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">3</span>quux</div>
<span class=\\"vector-toc-numb\\">3</span>
<span>quux</span>
</div>
</a>
<ul id=\\"toc-quux-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -218,7 +250,9 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<li id=\\"toc-foo\\" class=\\"vector-toc-list-item vector-toc-level-1\\">
<a class=\\"vector-toc-link\\" href=\\"#foo\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">1</span>foo</div>
<span class=\\"vector-toc-numb\\">1</span>
<span>foo</span>
</div>
</a>
<ul id=\\"toc-foo-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -226,7 +260,9 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<li id=\\"toc-bar\\" class=\\"vector-toc-list-item vector-toc-level-1\\">
<a class=\\"vector-toc-link\\" href=\\"#bar\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2</span>bar</div>
<span class=\\"vector-toc-numb\\">2</span>
<span>bar</span>
</div>
</a>
<button aria-controls=\\"toc-bar-sublist\\" class=\\"cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle\\" aria-expanded=\\"false\\">
<span class=\\"vector-icon mw-ui-icon-wikimedia-expand\\"></span>
@ -236,13 +272,17 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<li id=\\"toc-baz\\" class=\\"vector-toc-list-item vector-toc-level-2\\">
<a class=\\"vector-toc-link\\" href=\\"#baz\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2.1</span>baz</div>
<span class=\\"vector-toc-numb\\">2.1</span>
<span>baz</span>
</div>
</a>
<ul id=\\"toc-baz-sublist\\" class=\\"vector-toc-list\\">
<li id=\\"toc-qux\\" class=\\"vector-toc-list-item vector-toc-level-3\\">
<a class=\\"vector-toc-link\\" href=\\"#qux\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">2.1.1</span>qux</div>
<span class=\\"vector-toc-numb\\">2.1.1</span>
<span>qux</span>
</div>
</a>
<ul id=\\"toc-qux-sublist\\" class=\\"vector-toc-list\\">
</ul>
@ -254,7 +294,9 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<li id=\\"toc-quux\\" class=\\"vector-toc-list-item vector-toc-level-1\\">
<a class=\\"vector-toc-link\\" href=\\"#quux\\">
<div class=\\"vector-toc-text\\">
<span class=\\"vector-toc-numb\\">3</span>quux</div>
<span class=\\"vector-toc-numb\\">3</span>
<span>quux</span>
</div>
</a>
<ul id=\\"toc-quux-sublist\\" class=\\"vector-toc-list\\">
</ul>