Should only have one HTML ID per page. I've decided to remove
the first of the two duplicate IDs and to replace it with
#vector-variants-dropdown, to match the code style of the similar
#vector-user-links-dropdown
Bug: T343730
Change-Id: I6abdc293c1dbb18faf9751b4633a572a019593ab
* Remove stray @package comments. They appear to be auto-generated
as they just repeat the namespace name (but the wrong one).
* Remove redundant test that effectively doesn't do anything other
than testing if the constructor doesn't fail. This is already
covered by other tests.
Change-Id: Icb1136b7018a88310a37a3989d18a678e6cb9ddf
There is a missing span tag in the table of contents where text is placed directly into a div, breaking convention.
Change-Id: I12280e2c6a6e688b36a906d5b5a5c5deba42c977
This reverts commit ff5a61e9c6.
Reason for revert: The behaviour introduced in this patch needs some more consideration.
Bug: T364015
Change-Id: Ieab4ca4084df4f1b5c942fe81c7fb99b058e0623
Updates `CSSCustomProperties.less` to include `.oo-ui-popupWidget-popup` in
`@OOUIOverrideSelectors` for inverted color inheritance.
Bug: T364798
Change-Id: I6c3ac79d24f6af71a9171153e346494fb97acd3f
Allocate specific space for each installed extension based on
whether it is installed. This should reduce false positives (assuming
we have accounted for every installed extension)
If we haven't we'll follow up with additional budgets as we learn
about them.
Bug: T365480
Change-Id: Ie487fc56eb199f94e0b72f59d5c54f623570773a
I accidentally enabled this on tablet breakpoint.
Follow up to e3d2ab5031
The Pixel UI report should only surface changes on mobile - all
of these are improvements as it means the whole UI is visible in
the viewport.
Bug: T361573
Change-Id: I8aa5699a8fe959c1595d74c03f19c14856f6470f
It is unclear why this is needed, but
I9be50b3749500160e918ff3f2d2e1646ba7dc1a6 (which only touches en.json
and qqq.json files) fails on this test in CI. The cause must still be
investigated separately.
Bug: T365480
Change-Id: I889561b5b669d992c1f152d4bd203a71e2aff9ba
Styles removed in 1d17b46 were being utilised for Echo without
us knowing. Rather than revert that patch (which seems risky
so late in the day) I think it's preferable to restore these styles
for the Echo icons inside the skinStyle
Bug: T365409
Change-Id: Ibb967343f9c97c5fbe87d29b40e871f0f336f957
* Use !== instead of !=
* Avoid else after return
* Use falsey check for object is null
* Use consistently spaces inside of brackets
Change-Id: I2928664acbab315ab3eae38c74f87b019d46cf29
Follow up to 0109218ab where we renamed ClientPreferences to
Appearance
Also update wgVectorResponsive for consistency with other
documentation.
Change-Id: I7198e7742a50caa16a061904f05388b6837f251e
The values have slightly changed:
- Tablet breakpoint is decreased by 80px,
pushing lesser devices into a mobile only experience but
should make barely a difference to vast majority of our users.
- Biggest difference is in `min-width-breakpoint-desktop`,
which is increased by 120px in comparison to
`@width-breakpoint-desktop: 1000px`
Bug: T349793
Depends-On: I3afba8c51f60de9271054499bfa3ffbcc1a9d779
Change-Id: I56b93d5241d6a029dcb6814de02d18ac9f38ee5d
In preparation for enabling responsive Vector on Wikifunctions,
we lower the support threshold to 320px for Vector.
Minor adjustments are made to the header to make it use two
lines at lower resolutions.
Fixes to tables to make them responsive will be made shortly as
part of T330527 which will complete the responsive behaviour.
Bug: T361573
Change-Id: Idbac393ab6ee60100ba0fd6df4b224cc45949bfd
- Adds the notice "This page is always wide" and disables
the inputs for the "width" options in the Appearance menu
when pages are excluded via configuration ( `$wgVectorMaxWidthOptions`).
- Changes layout behaviour so that pages in the
$wgVectorMaxWidthOptions['exlcude'] configuration
stretch the entire viewport width.
- Stops the width settings in the Appearance menu from
being hidden on smaller resolutions.
Bug: T364015
Change-Id: Idee294adf3b309e03834276ea75e4ae43b0cffcb
WikimediaMessages is deployed on all wikis. It provides important
fixes for night mode.
The work to make tables more responsive in T330527 will also
increase the bundle size.
Note:
Some of this budget will be reclaimed later as we roll out the
appearance menu to all users.
This is needed to unblock
I3ce5fe61f58592a9e6bf982745f9d4cf22d8aeb3
Change-Id: I276e1a3c3fb1603d72c4e8c34abd002e5cd27eba
1) Icon optimizations
* Load styles for expand icon in
JavaScript since it relates to table of contents and that is only
enabled with JavaScript
* Drop vector-icon--x-small class since it only applies to this icon
* Remove some FIXMEs to an issue that has already been fixed
upstream
2) Move styles that do not need to be render blocking to skins.vector.js
* Move sticky header to skins.vector.js since it doesn't work without
JavaScript
* Move popupNotification to skins.vector.js since this is never server
side rendered.
Change-Id: I98e6c0826b514aaefcf88f66275bba37125129b1
