wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-09-23 10:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Optimize styles"

Browse source
This commit is contained in:
jenkins-bot 2024-05-17 18:30:33 +00:00 committed by Gerrit Code Review
parent ff5a61e9c6 1d17b4624f
commit c570ec099d
10 changed files with 31 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bundlesize.config.json
View file

@ -24,11 +24,11 @@
},
{
"resourceModule": "skins.vector.styles",
"maxSize": "11.8 kB"
"maxSize": "11.3 kB"
},
{
"resourceModule": "skins.vector.js",
"maxSize": "15.5 kB"
"maxSize": "16.4 kB"
},
{
"resourceModule": "skins.vector.legacy.js",
@ -40,7 +40,7 @@
},
{
"resourceModule": "skins.vector.icons",
"maxSize": "1 kB"
"maxSize": "0.7 kB"
}
]
}

2
includes/templates/TableOfContents__line.mustache
View file

@ -9,7 +9,7 @@
{{/extensionData.DiscussionTools-html-summary}}
{{#is-top-level-section}}{{#is-parent-section}}
<button aria-controls="toc-{{anchor}}-sublist" class="cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle">
<span class="vector-icon vector-icon--x-small mw-ui-icon-wikimedia-expand"></span>
<span class="vector-icon mw-ui-icon-wikimedia-expand"></span>
<span>{{{vector-button-label}}}</span>
</button>
{{/is-parent-section}}{{/is-top-level-section}}

3
resources/skins.vector.js/index.less Normal file
View file

@ -0,0 +1,3 @@
@import 'tableOfContents.less';
@import 'popupNotification.less';
@import 'stickyHeader.less';

0
resources/skins.vector.styles/components/PopupNotification.less → resources/skins.vector.js/popupNotification.less
View file

1
resources/skins.vector.styles/components/StickyHeader.less → resources/skins.vector.js/stickyHeader.less
View file

@ -1,5 +1,6 @@
@spacing-search-title-divider: 30px;
@font-size-sticky-header-links: unit( 14 / @font-size-browser, em ); // Equals `0.875em`.
@import '../skins.vector.styles/variables.less';
.vector-sticky-header-container {
position: fixed;

10
resources/skins.vector.js/tableOfContents.less Normal file
View file

@ -0,0 +1,10 @@
@import 'mediawiki.skin.variables.less';
.mw-ui-icon-wikimedia-expand {
.cdx-mixin-css-icon( @cdx-icon-expand );
// Temporary generic small icon class
// FIXME: Replace with proper Codex CSS icon usage in T338403
.cdx-mixin-css-icon-background( @size-icon-x-small );
.cdx-mixin-css-icon-size( @size-icon-x-small );
.cdx-mixin-css-icon-alignment( );
}

16
resources/skins.vector.styles/components/Icon.less
View file

@ -3,22 +3,6 @@
.cdx-mixin-css-icon-size( );
.cdx-mixin-css-icon-alignment( );
font-size: 14px;
// Temporary fix for https://phabricator.wikimedia.org/T356540
background-position: center;
background-repeat: no-repeat;
background-size: ~'calc( max( @{size-icon-medium}, @{min-size-icon-medium} ) )';
}
// Temporary generic small icon class
// FIXME: Replace with proper Codex CSS icon usage in T338403
.vector-icon--x-small {
.cdx-mixin-css-icon-background( @size-icon-x-small );
.cdx-mixin-css-icon-size( @size-icon-x-small );
.cdx-mixin-css-icon-alignment( );
// Temporary fix for https://phabricator.wikimedia.org/T356540
background-size: ~'calc( max( @{size-icon-x-small}, @{min-size-icon-x-small} ) )';
}
// FIXME: T363920 Remove when all icons are migrated from ResourceLoader to Codex

8
resources/skins.vector.styles/skin.less
View file

@ -20,7 +20,6 @@
@import './components/PinnableElement.less';
@import './components/PinnableHeader.less';
@import './components/PageTools.less';
@import './components/StickyHeader.less';
@import './components/TableOfContents.less';
@import './components/Button.less';
@import './components/Appearance.less';
@ -34,11 +33,16 @@
@import './components/MenuTabs.less';
@import './components/PageTitlebar.less';
@import './components/PageToolbar.less';
@import './components/PopupNotification.less';
@import './components/SearchBox.less';
@import './components/SiteNotice.less';
@import './components/Watchstar.less';
@import './components/BottomDock.less';
// JS only features. These should be hidden by default but will
// be displayed by skins.vector.js when loaded.
.vector-sticky-header-container {
display: none;
}
}
@media all {

4
skin.json
View file

@ -370,7 +370,6 @@
"logOut",
"imageGallery",
"userGroup",
"expand",
"listBullet",
"close"
]
@ -409,6 +408,9 @@
"features": [
"interface-message-box"
],
"styles": [
"resources/skins.vector.js/index.less"
],
"packageFiles": [
"resources/skins.vector.js/skin.js",
"resources/skins.vector.js/legacyMessageBoxStyles.js",

8
tests/jest/__snapshots__/tableOfContents.test.js.snap
View file

@ -27,7 +27,7 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<span class=\\"vector-toc-numb\\">2</span>bar</div>
</a>
<button aria-controls=\\"toc-bar-sublist\\" class=\\"cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle\\" aria-expanded=\\"true\\">
<span class=\\"vector-icon vector-icon--x-small mw-ui-icon-wikimedia-expand\\"></span>
<span class=\\"vector-icon mw-ui-icon-wikimedia-expand\\"></span>
<span>Toggle bar subsection</span>
</button>
<ul id=\\"toc-bar-sublist\\" class=\\"vector-toc-list\\">
@ -95,7 +95,7 @@ exports[`Table of contents reloadTableOfContents re-renders toc when wikipage.ta
<span class=\\"vector-toc-numb\\">2</span>bar</div>
</a>
<button aria-controls=\\"toc-bar-sublist\\" class=\\"cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle\\" aria-expanded=\\"true\\">
<span class=\\"vector-icon vector-icon--x-small mw-ui-icon-wikimedia-expand\\"></span>
<span class=\\"vector-icon mw-ui-icon-wikimedia-expand\\"></span>
<span>Toggle bar subsection</span>
</button>
<ul id=\\"toc-bar-sublist\\" class=\\"vector-toc-list\\">
@ -167,7 +167,7 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<span class=\\"vector-toc-numb\\">2</span>bar</div>
</a>
<button aria-controls=\\"toc-bar-sublist\\" class=\\"cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle\\" aria-expanded=\\"true\\">
<span class=\\"vector-icon vector-icon--x-small mw-ui-icon-wikimedia-expand\\"></span>
<span class=\\"vector-icon mw-ui-icon-wikimedia-expand\\"></span>
<span>Toggle bar subsection</span>
</button>
<ul id=\\"toc-bar-sublist\\" class=\\"vector-toc-list\\">
@ -229,7 +229,7 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
<span class=\\"vector-toc-numb\\">2</span>bar</div>
</a>
<button aria-controls=\\"toc-bar-sublist\\" class=\\"cdx-button cdx-button--weight-quiet cdx-button--icon-only vector-toc-toggle\\" aria-expanded=\\"false\\">
<span class=\\"vector-icon vector-icon--x-small mw-ui-icon-wikimedia-expand\\"></span>
<span class=\\"vector-icon mw-ui-icon-wikimedia-expand\\"></span>
<span>Toggle bar subsection</span>
</button>
<ul id=\\"toc-bar-sublist\\" class=\\"vector-toc-list\\">