Commit graph

5196 commits

Author SHA1 Message Date
jenkins-bot 5340f59b61 Merge "fix 3 empty HTML ID attributes" 2024-05-28 22:59:49 +00:00
jenkins-bot 042bf26957 Merge "fix double id="p-variants"" 2024-05-28 22:57:14 +00:00
Volker E 783d67e077 Replace border-color-portal-heading with Codex border-color-subtle
Replacing Vector specific variable with standard token that is meant
for exactly the applied use cases.
Note, I've left `border-color-subtle-transparent` because of that
extra engineering leg. I assume it was meant for animating the property,
which is not there. It seems better to me to replace this variable too
with `border-color-transparent`.

Change-Id: If264e04e576f044b98ec0d61b085f65af0110b6d
2024-05-28 14:29:20 -05:00
jenkins-bot 3ebd429f16 Merge "Remove redundant test cases and comments from tests" 2024-05-28 17:23:23 +00:00
Novem Linguae 3f5dd3c066 fix 3 empty HTML ID attributes
HTML validator says these are errors.

Before: `<button id="" class="foo">`

After: `<button class="foo">`

Bug: T365938
Change-Id: I9450eaaaa79c5aaf8f54b34effff04fba80cd450
2024-05-28 09:03:52 -07:00
Novem Linguae 4f609e6ba1 fix double id="p-variants"
Should only have one HTML ID per page. I've decided to remove
the first of the two duplicate IDs and to replace it with
#vector-variants-dropdown, to match the code style of the similar
#vector-user-links-dropdown

Bug: T343730
Change-Id: I6abdc293c1dbb18faf9751b4633a572a019593ab
2024-05-28 15:19:18 +00:00
Translation updater bot 4664ecf49a Localisation updates from https://translatewiki.net.
Change-Id: I12faf96b6557be29934c259350c11c3c2bb4f597
2024-05-28 09:33:26 +02:00
Translation updater bot 49152c98a4 Localisation updates from https://translatewiki.net.
Change-Id: I5b0fd05cb7686d9884a2af76d778a97040e48900
2024-05-27 09:32:29 +02:00
thiemowmde 79dae4ad7a Remove redundant test cases and comments from tests
* Remove stray @package comments. They appear to be auto-generated
  as they just repeat the namespace name (but the wrong one).
* Remove redundant test that effectively doesn't do anything other
  than testing if the constructor doesn't fail. This is already
  covered by other tests.

Change-Id: Icb1136b7018a88310a37a3989d18a678e6cb9ddf
2024-05-27 09:18:05 +02:00
jenkins-bot 4235ff0efd Merge "Wrap tables with JS" 2024-05-24 22:46:24 +00:00
bwang e42b235669 Wrap tables with JS
Depends-on: Ia271a57776e6f38384c5855727ab82fd7af83241
Bug: T330527
Change-Id: I756f8e1bcd86867bee52962a0d1c2dbb34ca75eb
2024-05-24 15:49:54 -05:00
Jon Robson 48b0eeac2f Icons should not repeat at larger font sizes
Bug: T365731
Change-Id: I539f906e06bb2dc133885092dbacb851fd774c23
2024-05-24 20:32:46 +00:00
jenkins-bot 4665273b40 Merge "Fix missing span tag on ToC items" 2024-05-24 19:43:07 +00:00
weebney 6dcb40447d Fix missing span tag on ToC items
There is a missing span tag in the table of contents where text is placed directly into a div, breaking convention.

Change-Id: I12280e2c6a6e688b36a906d5b5a5c5deba42c977
2024-05-24 11:29:06 -07:00
ksarabia 17a71f3c82 Adds invert exception for dropdown
* Adds a filter invert rule for toggle

Bug: T365035
Change-Id: Id04e3937ff1ef3982563003346fda07348ae26ea
2024-05-24 11:55:20 -05:00
Translation updater bot a4af4b12f8 Localisation updates from https://translatewiki.net.
Change-Id: I19719bf05d58e7f62954608a6c55785646eacc81
2024-05-24 09:47:15 +02:00
Jdrewniak 607e6b39c5 Revert "Add exclusion behaviour for "width" option in Appearance menu"
This reverts commit ff5a61e9c6.

Reason for revert: The behaviour introduced in this patch needs some more consideration.

Bug: T364015
Change-Id: Ieab4ca4084df4f1b5c942fe81c7fb99b058e0623
2024-05-23 23:51:46 +00:00
jenkins-bot f075bb0823 Merge "fix(vector): Set popup notification color to inverted" 2024-05-23 17:07:28 +00:00
Translation updater bot 7b08449c0c Localisation updates from https://translatewiki.net.
Change-Id: Ieca3832ba8642e86d41366260e60aa5676099b15
2024-05-23 09:30:45 +02:00
James D. Forrester ac3c525420 PerformanceBudgetTest: Add WikiLambda dependencies to unbreak merge
Rough numbers for now.

Change-Id: Ie487fc56eb199f94e0b72f59d5c54f623570773b
2024-05-22 13:25:01 -04:00
Moh'd Khier Abualruz 4d97e0a4fb fix(vector): Set popup notification color to inverted
Updates `CSSCustomProperties.less` to include `.oo-ui-popupWidget-popup` in
`@OOUIOverrideSelectors` for inverted color inheritance.

Bug: T364798
Change-Id: I6c3ac79d24f6af71a9171153e346494fb97acd3f
2024-05-22 16:53:26 +02:00
Jon Robson f797b8760d Adapt bundlesize based on installed extensions
Allocate specific space for each installed extension based on
whether it is installed. This should reduce false positives (assuming
we have accounted for every installed extension)

If we haven't we'll follow up with additional budgets as we learn
about them.

Bug: T365480
Change-Id: Ie487fc56eb199f94e0b72f59d5c54f623570773a
2024-05-22 05:37:28 +00:00
Jon Robson 70fbd6f0c2 Small font size is not applying to excluded pages
Bug: T364887
Change-Id: Ib24beb3a383599dcc3ad64e01992ead908e3bef3
2024-05-21 23:41:35 +00:00
Jon Robson f4befc068d [Visual change] Limits two row header to mobile devices
I accidentally enabled this on tablet breakpoint.

Follow up to e3d2ab5031
The Pixel UI report should only surface changes on mobile - all
of these are improvements as it means the whole UI is visible in
the viewport.

Bug: T361573
Change-Id: I8aa5699a8fe959c1595d74c03f19c14856f6470f
2024-05-21 11:52:10 -07:00
Jon Robson ca9b2274dc Fixes OOUI widget visibility within VE surface
Bug: T365050
Change-Id: I1bc59fcd20174cabe39cab0d5319ddb40a2105e3
2024-05-21 17:24:19 +00:00
jenkins-bot 0ee96091b9 Merge "Bump performance budget to unbreak l10n change" 2024-05-21 15:26:30 +00:00
jenkins-bot 0f9ad1ba67 Merge "Support Vector 2022 at > 320px" 2024-05-21 14:23:09 +00:00
Michael Große 167f6d32d5 Bump performance budget to unbreak l10n change
It is unclear why this is needed, but
I9be50b3749500160e918ff3f2d2e1646ba7dc1a6 (which only touches en.json
and qqq.json files) fails on this test in CI. The cause must still be
investigated separately.

Bug: T365480
Change-Id: I889561b5b669d992c1f152d4bd203a71e2aff9ba
2024-05-21 16:21:05 +02:00
Translation updater bot 0f52e1e85a Localisation updates from https://translatewiki.net.
Change-Id: I827c90d995958bc0456f94f5e15d77b1aa688705
2024-05-21 09:30:35 +02:00
jenkins-bot 6c535ac9f7 Merge "Fixes: Echo icon display when clicked" 2024-05-21 00:40:32 +00:00
Jon Robson 376b607d97 Fixes: Echo icon display when clicked
Styles removed in 1d17b46 were being utilised for Echo without
us knowing. Rather than revert that patch (which seems risky
so late in the day) I think it's preferable to restore these styles
for the Echo icons inside the skinStyle

Bug: T365409
Change-Id: Ibb967343f9c97c5fbe87d29b40e871f0f336f957
2024-05-20 17:16:34 -07:00
jenkins-bot 685a02f8a6 Merge "watchstar: use mw.util.isInfinity() instead of comparing to 'infinity'" 2024-05-20 23:48:09 +00:00
MusikAnimal c06d62a531 watchstar: use mw.util.isInfinity() instead of comparing to 'infinity'
Bug: T353389
Bug: T353483
Change-Id: I580deb0ba47e4c13643524ddd4d57f1a8e0a35ae
2024-05-20 16:27:42 -07:00
Ed Sanders 54b750af14 vector-popup-notification: Use 14px font size instead of 16px
Vector still uses 14px almost everywhere, so use it here
as well.

Bug: T360335
Change-Id: Icf4891375a62480ffbb4808a357935aa6d6fdc58
2024-05-20 13:59:31 -07:00
jenkins-bot 2702cf106c Merge "Simplify PHP code" 2024-05-20 20:18:10 +00:00
jenkins-bot ad03ea0eb3 Merge "configuration.md: Remove mention of out-of-date wmf config values" 2024-05-20 18:57:33 +00:00
jenkins-bot 1a2036b79c Merge "configuration.md: Remove unncessary double-bolding in headings" 2024-05-20 18:57:32 +00:00
Ed Sanders 91e44426f8 configuration.md: Remove mention of out-of-date wmf config values
Change-Id: I40da59927589ad073233fa41fdc378ced86c277e
2024-05-20 18:33:31 +00:00
Ed Sanders 568501f383 configuration.md: Remove unncessary double-bolding in headings
Change-Id: Ia82766e86c5e0c6ee0a10d232f35c3c20282aff9
2024-05-20 18:33:13 +00:00
Fomafix 94d1bee402 Simplify PHP code
* Use !== instead of !=
* Avoid else after return
* Use falsey check for object is null
* Use consistently spaces inside of brackets

Change-Id: I2928664acbab315ab3eae38c74f87b019d46cf29
2024-05-20 18:23:48 +00:00
Jon Robson ee05f8f5bd Update documentation for config flags
Follow up to 0109218ab where we renamed ClientPreferences to
Appearance

Also update wgVectorResponsive for consistency with other
documentation.

Change-Id: I7198e7742a50caa16a061904f05388b6837f251e
2024-05-20 11:15:40 -07:00
Translation updater bot 57873592ff Localisation updates from https://translatewiki.net.
Change-Id: Ib4274eb3401ee93383b7c64404a6c7352b4e6ca7
2024-05-20 09:28:44 +02:00
libraryupgrader bbef8b3bcd build: Updating grunt-banana-checker to 0.13.0
Change-Id: Ia3dfc349bbb6b2c2542884ed08b9f74d038ca250
2024-05-19 10:33:49 +00:00
Volker E dd5b98515d styles: Replace deprecated breakpoints
The values have slightly changed:
- Tablet breakpoint is decreased by 80px,
  pushing lesser devices into a mobile only experience but
  should make barely a difference to vast majority of our users.
- Biggest difference is in `min-width-breakpoint-desktop`,
  which is increased by 120px in comparison to
  `@width-breakpoint-desktop: 1000px`

Bug: T349793
Depends-On: I3afba8c51f60de9271054499bfa3ffbcc1a9d779
Change-Id: I56b93d5241d6a029dcb6814de02d18ac9f38ee5d
2024-05-18 02:28:18 +00:00
Jon Robson e3d2ab5031 Support Vector 2022 at > 320px
In preparation for enabling responsive Vector on Wikifunctions,
we lower the support threshold to 320px for Vector.

Minor adjustments are made to the header to make it use two
lines at lower resolutions.

Fixes to tables to make them responsive will be made shortly as
part of T330527 which will complete the responsive behaviour.

Bug: T361573
Change-Id: Idbac393ab6ee60100ba0fd6df4b224cc45949bfd
2024-05-17 23:31:37 +00:00
jenkins-bot b33513e20b Merge "Override default sublist styles" 2024-05-17 21:08:51 +00:00
jenkins-bot 2852b2b9f9 Merge "Increase bundlesize to accomodate Extension:WikimediaMessages and responsiveness" 2024-05-17 19:11:16 +00:00
jenkins-bot c570ec099d Merge "Optimize styles" 2024-05-17 18:30:33 +00:00
Jan Drewniak ff5a61e9c6 Add exclusion behaviour for "width" option in Appearance menu
- Adds the notice "This page is always wide" and disables
  the inputs for the "width" options in the Appearance menu
  when pages are excluded via configuration ( `$wgVectorMaxWidthOptions`).
- Changes layout behaviour so that pages in the
  $wgVectorMaxWidthOptions['exlcude'] configuration
  stretch the entire viewport width.
- Stops the width settings in the Appearance menu from
  being hidden on smaller resolutions.

Bug: T364015
Change-Id: Idee294adf3b309e03834276ea75e4ae43b0cffcb
2024-05-17 17:58:19 +00:00
Jon Robson 08bc5c53b4 Increase bundlesize to accomodate Extension:WikimediaMessages and responsiveness
WikimediaMessages is deployed on all wikis. It provides important
fixes for night mode.

The work to make tables more responsive in T330527 will also
increase the bundle size.

Note:
Some of this budget will be reclaimed later as we roll out the
appearance menu to all users.

This is needed to unblock
I3ce5fe61f58592a9e6bf982745f9d4cf22d8aeb3

Change-Id: I276e1a3c3fb1603d72c4e8c34abd002e5cd27eba
2024-05-17 10:06:52 -07:00