Commit graph

3749 commits

Author SHA1 Message Date
Umherirrender dd5753c023 Replace empty() with falsy check
empty() should only be used to suppress errors
When the type of the variable is array,
a falsy check is the same (checks for null, false and empty array)
Found by a new phan plugin (T234237)

Change-Id: If24015795219f6ff4f155c0d667472dc52a04d43
2023-10-21 20:29:41 +02:00
Ed Sanders a8aecda711 Udate jsdoc and use jsdoc-wmf-theme
Depends-On: Ic3861870c10f64d7f5414669a9d25b8ffb4c79a4
Change-Id: I6750e9bb6d5409e497b5605e3a4660734f5677ab
2023-10-20 13:42:19 +00:00
Translation updater bot 162aed289a Localisation updates from https://translatewiki.net.
Change-Id: If04a2b942ab0a7919c00ba7ce63e139206615eef
2023-10-19 08:46:32 +02:00
Translation updater bot 6fe0eb4c8b Localisation updates from https://translatewiki.net.
Change-Id: I69b2f1a2f1f48d7e1e75dc448fa2de442160cd73
2023-10-16 09:18:29 +02:00
Translation updater bot 17ec3a7b6c Localisation updates from https://translatewiki.net.
Change-Id: I85d60acce3e4be9d14513d80de4ab0951d5e6e7f
2023-10-13 09:00:04 +02:00
jenkins-bot 8e14b94635 Merge "Revert "icons: Register 'flag' in the wikimedia icons group"" 2023-10-10 22:56:41 +00:00
Jdlrobson a90cc7ba4c Revert "icons: Register 'flag' in the wikimedia icons group"
This reverts commit 2696ced732.

Reason for revert: Icons should be defined by the extension
providing them. The icon is already incorrectly defined in
that extension but can easily be corrected.

Depends-On: Iff3aa23604442011062a67a8e165fc4a1b5b2d47
Change-Id: I22a114d41e2cadb97d46c299709496cd04299cf6
2023-10-10 16:17:26 +00:00
jenkins-bot 7d5f700442 Merge "icons: Register 'flag' in the wikimedia icons group" 2023-10-10 11:09:20 +00:00
Translation updater bot 8c66507f25 Localisation updates from https://translatewiki.net.
Change-Id: I235dca316e692bc4aac2a01110791374f631cd50
2023-10-10 08:54:37 +02:00
jenkins-bot 57a61c82c9 Merge "Selenium tests: broaden the definition of the article page edit link" 2023-10-09 15:34:49 +00:00
Kosta Harlan 2696ced732
icons: Register 'flag' in the wikimedia icons group
Why:

- The recently-introduced "Report" menu item in Extension:ReportIncident
  needs a flag icon

What:

- Register the "flag" icon in the wikimedia icons group

Bug: T348455
Change-Id: I4caa3a84583349a19603a2ad86471d79671f4b6a
2023-10-09 17:19:39 +02:00
Translation updater bot d81009c1ec Localisation updates from https://translatewiki.net.
Change-Id: I3ea112150ef78f12466a95a419b360103441f41d
2023-10-09 09:00:13 +02:00
David Lynch dfccc816af Selenium tests: broaden the definition of the article page edit link
Bug: T348353
Change-Id: I92f7c2c5f4691bd511219432c53379ddd928eae2
2023-10-06 16:27:49 -05:00
Jon Robson 7d59aa1843 Restore watchstar for anonymous users
Minerva shows a watchstar for anonymous users.

Follow up to
I3c9d59f49f1b939981a7b2b450448db6736d5958

Bug: T348336
Change-Id: I36afb86f0c89c30dcb7695e1409f7c20d3dc31d1
2023-10-06 18:05:08 +00:00
Translation updater bot 93bccd3342 Localisation updates from https://translatewiki.net.
Change-Id: Ia5642af8be418baa8f219b4b82b5ea945c5a7c78
2023-10-05 09:14:22 +02:00
jenkins-bot 50563c1b23 Merge "Support extension of page actions via hook and addPortletLink" 2023-10-05 00:23:01 +00:00
Jon Robson 05231bb254 Support extension of page actions via hook and addPortletLink
This adds support for:
mw.util.addPortletLink('p-views', '#', 'text', 'fooz',null,
  null,'#page-actions-overflow' )

and adding multiple edit icons via hooks.

Depends-On: I655097769620301143140ded1cde4c7a16879ef4
Depends-On: I401805224c0f387ac85b52b50c1f298b83c03a91
Bug: T346944
Change-Id: I3c9d59f49f1b939981a7b2b450448db6736d5958
2023-10-04 22:15:47 +00:00
Translation updater bot 7c1761cb9f Localisation updates from https://translatewiki.net.
Change-Id: I21dddcd6f628611f67a97935958c346dba60035d
2023-10-04 09:12:06 +02:00
MusikAnimal 907e40d5c9 ToggleListItem: correct {{class}} to {{classes}}
This fixes the integration added with Ice909aab7f.

Bug: T242467
Change-Id: I8920e0878f676885a795fca8bfd2dc63ec1140cb
2023-10-03 16:42:29 -04:00
Translation updater bot a5f1c79678 Localisation updates from https://translatewiki.net.
Change-Id: I0e426d97ab27b6a073abaa67ed0ee4453843ddd2
2023-10-02 11:01:03 +02:00
Sergio Gimeno 2a9680f2a4 Apply content styles to mw teleport target
Bug: T347199
Follow-up: Ibd5d8c7cc7880678fae498a451cfd417f1f8e1b8
Change-Id: I50274180b62dec902fd7b9030313d4bcf13bd494
2023-09-28 11:29:30 +02:00
Translation updater bot f33ffcf850 Localisation updates from https://translatewiki.net.
Change-Id: I3f9991a3a2a34061e81422aa626ec86e370fb258
2023-09-27 09:25:14 +02:00
Translation updater bot ad2b7c0e9e Localisation updates from https://translatewiki.net.
Change-Id: Ib51f2e84fad86be73290b8ceac617e31f8000105
2023-09-26 08:46:45 +02:00
Jon Robson b51c6511ef Fixes history icon in green last modified bar
Currently the last modified bar icon appears black rather than
white. This is because the last modified icon shares icon CSS
with the page actions in AMC.

Untie these by giving the icon in this context a different selector,
taking care to support cached HTML.

Change-Id: I98443b0dcb88911a5314092216809387b4fb80dc
2023-09-25 20:40:55 +00:00
jenkins-bot a5ea9e2107 Merge "Remove Minerva bundle size check" 2023-09-25 17:43:04 +00:00
Translation updater bot d6f61786f3 Localisation updates from https://translatewiki.net.
Change-Id: Id01a0bad6e18f4fd3bfe0ffb62c24096301bbc8a
2023-09-22 08:49:46 +02:00
Translation updater bot 74744928dd Localisation updates from https://translatewiki.net.
Change-Id: Iaa4a3b290b890a807b0b97811f4f93371d4e1eef
2023-09-20 08:58:23 +02:00
Jon Robson 23da7a1fb5 Remove Minerva bundle size check
The mediawiki.ui.icon module is not loaded in this skin.

Change-Id: I2956933226687fe0881b0099c6de68af70a4364e
2023-09-19 16:03:46 +00:00
Jon Robson c53f69f36a Fixes notification overlay: Change URL using location
Partial revert of I192c6d4235c57f69cf48dcd67aa6c4810df62dfa
The deprecation notice seems incomplete. The two functions are not
equivalent and we have various usages elsewhere in the codebase.

Bug: T346685
Change-Id: I063daa217708c3bebac97af7be9eedab01f5217b
2023-09-18 14:15:12 -07:00
Translation updater bot 397b726f99 Localisation updates from https://translatewiki.net.
Change-Id: Iffd71241367bd501120a68eea73fe46fff779306
2023-09-18 08:47:38 +02:00
Translation updater bot a108d5d2fc Localisation updates from https://translatewiki.net.
Change-Id: I1d2dc0775ba0a16e882df5e7209f38b058aa701e
2023-09-14 09:32:29 +02:00
jenkins-bot 18451d4f94 Merge "Fixes console warnings" 2023-09-13 23:37:11 +00:00
Jon Robson d407d1054c Remove or document remaining mw-ui-icon usages
Most of these are captured in other bugs
The anon talk message style doesn't do anything.

Bug: T344022
Change-Id: Iba1fce98ea05931fe07b2b20f07c62d198039d1b
2023-09-13 00:03:38 +00:00
bwang 47b2744609 Clean up icon selectors from cached HTML
Bug: T344022
Change-Id: I170d86b52345b94a81e74f03b82aef7b522bbb39
2023-09-12 08:45:58 -07:00
Translation updater bot a76d5ede1e Localisation updates from https://translatewiki.net.
Change-Id: Ifa2d0c4de2fc74132c1eba32a323f5d10da38bdc
2023-09-12 08:28:48 +02:00
jenkins-bot d676f6e910 Merge "Ensure header edit icons are the same size" 2023-09-12 00:09:12 +00:00
bwang 9e9c1292e4 Ensure header edit icons are the same size
Bug: T345969
Change-Id: Ica191284df74610c958ad8808dcd1c03839b1a5d
2023-09-11 18:37:31 -05:00
jenkins-bot 757dfc078e Merge "Add figure and picture elements to the reset." 2023-09-11 22:02:40 +00:00
Jon Robson dc51175986 Remove wmf-a11y from daily job
It's throwing an error disrupting the build

Change-Id: Icc31316010f57813513ddd4449c74735ca7b63ae
2023-09-11 15:10:51 -05:00
Jon Robson 658f1c3439 Fix Echo badges on desktop Minerva, remove module
Bug: T345785
Change-Id: I2913c60d609a11fa74d90e858bf112627553aa13
2023-09-11 14:35:40 -05:00
Translation updater bot eecf2ccf53 Localisation updates from https://translatewiki.net.
Change-Id: Ibed181af4f0b947e62ba05057c5ed818a0395af8
2023-09-11 09:08:10 +02:00
Derk-Jan Hartman 2728752633 Add figure and picture elements to the reset.
These are newer elements but they have similar user agent defaults to
img/video/audio etc.

This should fix the usage of imagemaps, which use frameless figures
and currently have excessive margin in minerva

Change-Id: If9f995401b771baffe221e474991cf1e3fbc7f76
2023-09-09 13:53:06 +02:00
jenkins-bot 5a6016b708 Merge "Remove old :before icon selectors and update selectors to not use minerva and wikimedia prefixes" 2023-09-07 18:46:41 +00:00
Jon Robson 52de5fd597 Fixes console warnings
Fixes "[1.40] Use of PageGateway is a NOOP and deprecated. Please remove this call."
Fixes Use of "navigate" is deprecated. use navigateTo instead

Change-Id: I192c6d4235c57f69cf48dcd67aa6c4810df62dfa
2023-09-07 11:22:49 -07:00
bwang e09c41b011 Restore mw-ui-button styles to history page buttons
Bug: T345306
Change-Id: I331373de54fe4f4975d3e162efb6daf3258dcd67
2023-09-07 11:56:25 -05:00
jenkins-bot 724dbe43c4 Merge "build: Update MediaWiki requirement to 1.41" 2023-09-06 23:22:25 +00:00
James D. Forrester 44e6f875c5 build: Update MediaWiki requirement to 1.41
All skins in the MediaWiki tarball are expected to track MediaWiki's release directly.

Change-Id: I320ccbc07409ab9c2858fd1410ec91cda797b464
2023-09-06 22:46:16 +00:00
bwang 269bd5bdaf Remove old :before icon selectors and update selectors to not use minerva and wikimedia prefixes
Bug: T344022
Change-Id: I573d7b36513cd0b74f62621cc246f719bcb94256
2023-09-06 13:53:22 -05:00
Translation updater bot c07ad24444 Localisation updates from https://translatewiki.net.
Change-Id: Icfe5f48aff0cefae4ea26f6e5ec159d17fcb4247
2023-09-06 08:45:31 +02:00
bwang e7b908cd5a Fix unseen notifications icon
Bug: T345483
Change-Id: I4e0b2ce146dc9ac65e6f8e3532fc825c3bd8ce18
2023-09-05 19:09:53 +00:00