wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-23 22:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove or document remaining mw-ui-icon usages

Browse source 
Most of these are captured in other bugs
The anon talk message style doesn't do anything.

Bug: T344022
Change-Id: Iba1fce98ea05931fe07b2b20f07c62d198039d1b
This commit is contained in:
Jon Robson 2023-09-12 14:22:20 -07:00 committed by Jdlrobson
parent 47b2744609
commit d407d1054c
5 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/skins.minerva.base.styles/anonTalkMessage.less
View file

@ -3,10 +3,6 @@ div.minerva-anon-talk-message {
margin-top: 16px;
margin-bottom: 0;
.mw-ui-icon {
color: #fc3;
}
.usermessage {
display: inline;
margin-left: 8px;

5
resources/skins.minerva.scripts/addPortletLink.js
View file

@ -47,7 +47,10 @@ function insertIcon( $link, id ) {
var icon = document.createElement( 'span' ),
classes = 'minerva-icon';
if ( id ) {
classes += ' mw-ui-icon-portletlink-' + id;
classes += ` minerva-icon-portletlink-${id}`;
// FIXME: Please remove when following URL returns zero results:
// https://global-search.toolforge.org/?q=mw-ui-icon-portletlink&regex=1&namespaces=&title=
classes += ` mw-ui-icon-portletlink-${id}`;
}
icon.setAttribute( 'class', classes );
$link.prepend( icon );

3
tests/qunit/skins.minerva.scripts/page-issues/index.test.js
View file

@ -30,7 +30,8 @@
} );
QUnit.test( 'insertBannersOrNotice() should add an icon', function ( assert ) {
assert.true( /mw-ui-icon/.test( processedAmbox.html() ) );
// FIXME: Remove mw-ui-icon when T346184 and/or T346162 has been resolved.
assert.true( /(mw-ui-icon|mf-icon)/.test( processedAmbox.html() ) );
} );
QUnit.test( 'clicking on the product of insertBannersOrNotice() should trigger a URL change', function ( assert ) {
processedAmbox.click();

2
tests/selenium/features/support/pages/article_page.js
View file

@ -20,7 +20,7 @@ class ArticlePage extends MinervaPage {
get talk_tab_element() { return $( '.minerva__tab-container a[rel="discussion"]' ); }
get mask_element() { return $( '.mw-mf-page-center__mask' ); }
get drawer_mask_element() { return $( '.drawer-container__mask--visible' ); }
get watched_element() { return $( '.minerva-icon--unStar-progressive, .mw-ui-icon-mf-watched' ); }
get watched_element() { return $( '.minerva-icon--unStar-progressive' ); }
get menu_button_element() { return $( '#mw-mf-main-menu-button' ); }
get search_icon_element() { return $( '#searchIcon' ); }
get menu_element() { return $( 'nav' ); }

4
tests/selenium/pageobjects/edit.page.js
View file

@ -6,7 +6,9 @@ class EditPage extends Page {
get content() { return $( '#wikitext-editor' ); }
get displayedContent() { return $( '#mw-content-text .mw-parser-output' ); }
get heading() { return $( 'h1.mw-first-heading' ); }
get next() { return $( '.mw-ui-icon-mf-next-invert' ); }
// Sync with src/mobile.editor.overlay/EditorOverlayBase.js in MobileFrontend
// FIXME: T346184
get next() { return $( '.mw-ui-icon-mf-next-invert, .mf-icon-next-invert' ); }
get save() { return $( 'button.cdx-button' ); }
openForEditing( title ) {