Noticed this today.
Apparently was reported a long time ago so let's disable this for
now.
Bug: T334634
Change-Id: Id46a8a7d4b9a22ed5d1bd5df5d5f9b03df1f72b0
TestUser's are created for real in the test database, but this test
doesn't need that, especially because it's not in the Database group.
Change-Id: I8261b7e8130f0698df4f1684da767f312504c307
Move away from User, and use Authority instead. The only exception is
isBlockedFrom, which still requires a User object, so inject a
UserFactory for that.
Simplify the test accordingly, and also remove implicit assumptions as
to what certain user groups are or aren't allowed to do (e.g., watch
pages).
Also avoid using TestUser as it needs a DB connection.
Change-Id: Idfff8fd00f7b01df1dc6ec509dfc0cbd10ce7ce0
WebdriverIO has dropped support of sync mode, hence changed to async.
Update npm packages: @wdio/*, wdio-mediawiki
because async mode needs at least @wdio v7.9.
Remove npm packages: @wdio/dot-reporter and @wdio/sync.
Bug: T293084
Change-Id: I5babbdadf21e9f951f69de93bfca5213a50965aa
Use a UserFactory instead of getting an id and the user objects on
second request
Also replace another deprecated User class and use the injected factory
Bug: T325687
Change-Id: Id610ee39e0ef865b97f7ae8506188eea04a86ac5
"Wikitext Editor (Makes actual saves).Broken redirects" is constantly
breaking CI in core.
I have enabled it in
b9a92ef717
but it isn't as stable as I thought.
Bug: T280652
Change-Id: I667f65a27fd420a3a70f39fb5e1606907e465897
'Broken redirects' was disabled in 69a100cb45
'should be creatable' was disabled in 5e0dd88af0
'should be creatable' is failing so it is deleted.
'Broken redirects' is passing so it is enabled.
To be sure that the passing test is not flaky, the CI has ran it 100
times, it never failed.
Bug: T280652
Change-Id: I34a863dcbd126c2da8a98624e6ba1fa916eac0cf
The feature is being replaced by DiscussionTools. We're not ready to
remove it completely yet, but the tests are preventing us from
enabling it on additional wikis.
Bug: T317467
Change-Id: I8b8206d2810426cf4e09da37d0fcd8dec766ccb3
Use the config parameters from the core file
tests/qunit/resources/mediawiki.Title.test.js
This change allows to run the JavaScript tests on a wiki with a non
English content language.
Change-Id: Ie2b45646117b48904798f9ac64fd8a70d39e49e1
Hard deprecated the Group::insertAfter() function because it is not used in the Mediawiki codebase
Bug: T311894
Change-Id: I209d3fd492713425a2727fd48c5870f983a39f9b
* Created a buildMenuEntry function
* Replaced all Group::insert() functions with Group::insertEntry()
* Added a trackable parameter to check if a menu entry will be trackable
* Removed the MenuEntry class
* Removed the MenuEntryTest class
* Removed the Group::insert() function
* Changed tests in GroupTest to test Group::insertEntry() function
Bug: T221004
Change-Id: I39bed4e9a9b09f904cb3e5d78ccb3e6e175981a8
For now this should be a NOOP as the existing "special" page tab
is removed, put it paves the way for using tabs on special pages.
Bug: T286466
Change-Id: Ic0b52b298d598c20987b172c81c732a31e409402
* Update stylelint-config-wikimedia to 0.13.0
* Ensure eslintrc.js and root files are linted
with server config
Change-Id: I59c49fedd5b0c4c5620f960b78e4f781a6bc5abb
* Declare variables inline, as per the current code conventions.
* Use built-in assert.true() and assert.false() in a few places.
* Use built-in QUnit.test.each() to remove need for ad-hoc loops and
inline composing of assertion messages with common prefixes. This
also creates clearer and more detailed test reports, and more granular
ability to re-run specific test cases.
* Remove unneeded use of `QUnit.newMwEnvironment()`.
* Simplify restoring of mw.Uri by storing the original reference
once outside the test, and then re-using that each time.
* Use mw.config.set() for improved familiarity and rely on natural
restoration instead of the extra 'config' key abstraction which is
another thing to learn and understand.
Change-Id: I796e034854203d2e0e78e510458f4b34603e9901
These are never run. We are not running them manually, so we should
remove them from the codebase.
Change-Id: If54b45dfc72f32c2631a4338096b568aae5d404a
beforeEach failures do not have videos associated. We'd like to see
what's going wrong with these tests.
Change-Id: I1b723bcd7d00f15907647d5c7a4aa1f57578468c
This reverts commit 422e3a3b09.
Reason for revert: The Ruby tests don't run. This change should be in
the Node tests.
Change-Id: If59753569b1eb24ffaf2486242ea49e794d388b5
The mobile editor can load in two modes - visual editor or wikitext
editor. On the beta cluster depending on user preferences, the
VisualEditor may be loaded.
Since this test is just a smoke test that checks it renders, it's
okay to look for both.
Bug: T301575
Change-Id: I8192fc6e71e064278f62fc41e80652860f319e37
* Prefer Title::makeTitle in unit tests where the title is known,
this avoids title parsing and can improve the test performance.
* Use Title::makeTitle for the user page like done in User::getUserPage
Change-Id: I3901a6ed208a5ff90b216d01d3c4962cdcb48db1
'Redirects' was disabled by Edward Tadros in fbd373b (2021-01-15).
'A newly created topic appears in the list of topics' was disabled by
Jon Robson in d4828b2 (2020-09-24).
Bug: T280652
Change-Id: I63fb62c0c2871ff2713643285cd6e5d878684f83
Avoid time outs
Error in "Opening and closing the reference drawer.Opening a nested
reference"
Error: waitUntil condition timed out after 5000ms
at Browser.<anonymous>
(/workspace/src/skins/MinervaNeue/node_modules/@wdio/utils/build/shim.js:270:24)
at iShouldSeeDrawerWithText
(/workspace/src/skins/MinervaNeue/tests/selenium/features/step_definitions/reference_steps.js:25:10)
at Context.<anonymous>
(/workspace/src/skins/MinervaNeue/tests/selenium/specs/references.js:44:3)
FAILED in chrome - /tests/selenium/specs/references.js
Change-Id: Ia5d493fba4995c1122721b76ae98d6ba60399238
Wikimedia CI now serves MediaWiki over Apache (T285649) which mean we
can do concurrent requests!
Bug: T226869
Change-Id: Ifb155b7a14f5dd7b037578c83c9590f7901feacf
This makes the tests a little easier to read, I would argue.
any() is the default anyway. It doesn't add new information to the
test.
Change-Id: If4655ddea494f1054538a760802b583e17c0108e
