wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-24 06:13:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use PHPUnit shortcuts where possible

Browse source 
This makes the tests a little easier to read, I would argue.
any() is the default anyway. It doesn't add new information to the
test.

Change-Id: If4655ddea494f1054538a760802b583e17c0108e
This commit is contained in:
Thiemo Kreuz 2021-12-17 11:29:48 +01:00
parent 1cf3de024f
commit bb31754073
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tests/phpunit/permissions/MinervaPagePermissionsTest.php
View file

@ -32,8 +32,7 @@ class MinervaPagePermissionsTest extends MediaWikiIntegrationTestCase {
$isSuperUser = false
) {
$languageHelper = $this->createMock( LanguagesHelper::class );
$languageHelper->expects( $this->any() )
->method( 'doesTitleHasLanguagesOrVariants' )
$languageHelper->method( 'doesTitleHasLanguagesOrVariants' )
->willReturn( $hasOtherLanguagesOrVariants );
$user = $user ?? $this->getTestUser()->getUser();
@ -148,10 +147,10 @@ class MinervaPagePermissionsTest extends MediaWikiIntegrationTestCase {
->getMock();
$contentHandler->method( 'supportsDirectEditing' )
->will( $this->returnValue( $supportsDirectEditing ) );
->willReturn( $supportsDirectEditing );
$contentHandler->method( 'supportsDirectApiEditing' )
->will( $this->returnValue( $supportsDirectApiEditing ) );
->willReturn( $supportsDirectApiEditing );
$perms = $this->buildPermissionsObject( Title::newFromText( 'test' ), null, [],
$contentHandler );

2
tests/phpunit/skins/SkinMinervaTest.php
View file

@ -60,7 +60,7 @@ class SkinMinervaTest extends MediaWikiIntegrationTestCase {
->getMock();
$outputPage->expects( $this->once() )
->method( 'getCategoryLinks' )
->will( $this->returnValue( $categoryLinks ) );
->willReturn( $categoryLinks );
$this->overrideSkinOptions( [ SkinOptions::CATEGORIES => true ] );