wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-23 22:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid accessing the database in SkinUserPageHelperTest

Browse source 
TestUser's are created for real in the test database, but this test
doesn't need that, especially because it's not in the Database group.

Change-Id: I8261b7e8130f0698df4f1684da767f312504c307
This commit is contained in:
Daimona Eaytoy 2023-07-17 19:40:07 +02:00
parent e9e3095a10
commit 731c0b5703
1 changed files with 31 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
tests/phpunit/skins/SkinUserPageHelperTest.php
View file

@ -3,8 +3,10 @@
namespace MediaWiki\Minerva;
use MediaWiki\Minerva\Skins\SkinUserPageHelper;
use MediaWiki\User\UserFactory;
use MediaWikiIntegrationTestCase;
use Title;
use User;
/**
* @group MinervaNeue
@ -145,16 +147,23 @@ class SkinUserPageHelperTest extends MediaWikiIntegrationTestCase {
* @covers ::isUserPage
*/
public function testGetPageUserWhenOnUserPage() {
$testUser = $this->getTestUser()->getUser();
$title = $testUser->getUserPage();
$user = $this->createMock( User::class );
$user->method( 'getId' )->willReturn( 42 );
$user->method( 'getName' )->willReturn( __METHOD__ );
$user->method( 'isRegistered' )->willReturn( true );
$title = Title::makeTitle( NS_USER, $user->getName() );
$userFactory = $this->createMock( UserFactory::class );
$userFactory->method( 'newFromName' )
->with( $user->getName() )
->willReturn( $user );
$helper = new SkinUserPageHelper(
$this->getServiceContainer()->getUserNameUtils(),
$this->getServiceContainer()->getUserFactory(),
$userFactory,
$title
);
$this->assertTrue( $helper->isUserPage() );
$this->assertEquals( $testUser->getId(), $helper->getPageUser()->getId() );
$this->assertEquals( $user->getId(), $helper->getPageUser()->getId() );
}
/**
@ -163,20 +172,30 @@ class SkinUserPageHelperTest extends MediaWikiIntegrationTestCase {
* @covers ::isUserPage
*/
public function testGetPageUserWhenOnUserPageReturnsCorrectUser() {
$testUser = $this->getTestUser()->getUser();
$testUserTitle = $testUser->getUserPage();
$user = $this->createMock( User::class );
$user->method( 'getId' )->willReturn( 42 );
$user->method( 'getName' )->willReturn( __METHOD__ );
$user->method( 'isRegistered' )->willReturn( true );
$userTitle = Title::makeTitle( NS_USER, $user->getName() );
$secondTestUser = $this->getTestSysop()->getUser();
$secondTestUserTitle = $secondTestUser->getUserPage();
$secondUser = $this->createMock( User::class );
$secondUser->method( 'getId' )->willReturn( $user->getId() + 1 );
$secondUser->method( 'getName' )->willReturn( $user->getName() . 'other' );
$secondUser->method( 'isRegistered' )->willReturn( true );
$secondUserTitle = Title::makeTitle( NS_USER, $secondUser->getName() );
$userFactory = $this->createMock( UserFactory::class );
$userFactory->method( 'newFromName' )
->with( $secondUser->getName() )
->willReturn( $secondUser );
$helper = new SkinUserPageHelper(
$this->getServiceContainer()->getUserNameUtils(),
$this->getServiceContainer()->getUserFactory(),
$secondTestUserTitle
$userFactory,
$secondUserTitle
);
$this->assertTrue( $helper->isUserPage() );
$this->assertNotEquals( $testUser->getId(), $helper->getPageUser()->getId() );
$this->assertNotEquals( $helper->getPageUser()->getUserPage(), $testUserTitle );
$this->assertNotEquals( $user->getId(), $helper->getPageUser()->getId() );
$this->assertNotEquals( $helper->getPageUser()->getUserPage(), $userTitle );
}
}