wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-12-21 01:52:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
3857 commits 16 branches 12 tags 68 MiB
Commit graph

11 commits

Author SHA1 Message Date
Steph Toyofuku 2b41416c0d Allow addPortletLink to target tabs/associated pages 
Currently `mw.util.addPortletLink` cannot properly add a portlet link to
the associated pages tabs, as there is no `p-associated-pages` id on
mobile.  This change pulls the id from the page data, and adds the
necessary class for the tab to be styled correctly - since tabs do not
have corresponding icons while most portlet links do, we also branch on
this class (effectively on whether we are in the tab container) to
ensure an icon is not inserted

Finally, I added a few comments and spacing in the sections of code that
I touched to make them more readable and resolve some of the linter
warnings, but happy to hear if these are not helpful!

Bug: T340728
Change-Id: I33fc12611a6238552a3eb47f6ca37f087903a92a
 2023-12-21 16:37:28 -08:00
Ed Sanders a8aecda711 Udate jsdoc and use jsdoc-wmf-theme 
Depends-On: Ic3861870c10f64d7f5414669a9d25b8ffb4c79a4
Change-Id: I6750e9bb6d5409e497b5605e3a4660734f5677ab
 2023-10-20 13:42:19 +00:00
Jon Robson d407d1054c Remove or document remaining mw-ui-icon usages 
Most of these are captured in other bugs
The anon talk message style doesn't do anything.

Bug: T344022
Change-Id: Iba1fce98ea05931fe07b2b20f07c62d198039d1b
 2023-09-13 00:03:38 +00:00
bwang 0e391a87e0 Update addPortletLink for Codex 
For testing make sure to check the 3 variants:
```
mw.util.addPortletLink('page-actions', '#', 'text' );
mw.util.addPortletLink('p-interaction', '#', 'text' );
mw.util.addPortletLink('p-personal', '#', 'text' );
```

Bug: T344006
Change-Id: Iad3a8d5ed1237c1438d170f07c9c3fe3784182fe
 2023-08-29 19:27:56 +00:00
bwang b66ac786d1 Prepare addPortletLink handler for Codex switchover 
Change-Id: I33e541ab7b816640a63541ce719e094bb8f5d78e
 2023-08-24 12:07:28 -05:00
BrandonXLF eae59a8c86 Fix spacing between icon + text in toggle menu and JS 
This fix was already applied to the main menu in change
Idc603ccaeeb42f60899059ebb51226e8a20a969d

Bug: T301056
Change-Id: Id31fa76f40aab44672efc51fb981d481c27f1ff8
 2022-02-05 20:28:59 -05:00
BrandonXLF 9fe8cf7cc0 Add icon to portlet links without IDs 
If the portlet link does not have an ID, don't add the
mw-ui-icon-portletlink-ID class.

Bug: T301014
Change-Id: Ibcc7cbe131ac989247d25dd6498baed778daee7e
 2022-02-04 17:06:53 -05:00
jdlrobson e9e336a679 Enhance icons of previously added items 
If addPortletLink is called prior to setup.js only the last
link will be enhanced. To avoid this problem, check existing links
when registering the hook.

Bug: T240910
Change-Id: Ifd46b26401b8eb20686882577edf404a15eaf155
 2021-09-27 21:52:08 +00:00
jdlrobson f49eefbf84 Improve support in Minerva for addPortletLink 
* Use skin registration and set skin options as and when needed
* Set link text-wrapper
* Simplify addPortletLink hook
* Update modifications to apply to items added prior to the hook

Bug: T240910
Change-Id: Ic806adf3de6490ba9da11e8968a61b3d0acd93bc
 2021-09-23 22:05:36 +00:00
jdlrobson fb36687fc3 setAttribute takes a string not an array 
Since we are dealing with arrays here with the value of classes
but using native DOMElement we need to convert the array to a string

Follow up to  I331912a1cd6cd4293c22a1a48bb32cdec48bd37d

Change-Id: If08d68af8cebecaea02cc29bf779d25d58c0c6c3
 2020-03-02 12:05:42 -08:00
jdlrobson 6b6c6b8d6e Menu items added via addPortletLinks should look like other menu items 
Requires `I4c477c88ce48484960e40609cd243e63639175bc` to function.

Bug: T236711
Change-Id: I331912a1cd6cd4293c22a1a48bb32cdec48bd37d
 2020-02-29 00:11:28 +00:00