wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-09-23 18:28:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add icon to portlet links without IDs

Browse source 
If the portlet link does not have an ID, don't add the
mw-ui-icon-portletlink-ID class.

Bug: T301014
Change-Id: Ibcc7cbe131ac989247d25dd6498baed778daee7e
This commit is contained in:
BrandonXLF 2022-02-04 17:06:53 -05:00
parent 9074976583
commit 9fe8cf7cc0
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/skins.minerva.scripts/addPortletLink.js
View file

@ -37,11 +37,15 @@ function getClassesForItem( $item ) {
* Insert icon into the portlet link.
*
* @param {jQuery.Object} $link
* @param {string} id for icon
* @param {string|undefined} id for icon
*/
function insertIcon( $link, id ) {
var icon = document.createElement( 'span' );
icon.setAttribute( 'class', 'mw-ui-icon mw-ui-icon-portletlink-' + id );
var icon = document.createElement( 'span' ),
classes = 'mw-ui-icon';
if ( id ) {
classes += ' mw-ui-icon-portletlink-' + id;
}
icon.setAttribute( 'class', classes );
$link.prepend( ' ' );
$link.prepend( icon );
}
@ -62,7 +66,7 @@ function hookHandler( listItem, data ) {
$a.addClass( classes.a );
$item.find( 'a > span' ).addClass( classes.span );
listItem.dataset.minervaPortlet = true;
if ( id && classes.span.indexOf( 'mw-ui-icon' ) === -1 ) {
if ( classes.span.indexOf( 'mw-ui-icon' ) === -1 ) {
insertIcon( $a, id );
}
}