This reverts commit 548e94da98.
Reason for revert: The patch was causing the following error on pageload
Error: Cannot require undefined file includes/Skins/ToggleList/ToggleList.js
require startup.js:1006
Bug: T373482
Change-Id: I22751109c124795af7d2e0ad6c4104745b2d6632
Added to MediaWiki core last year with I9fca9fdf9b7623b1.
This fixes a confusing assertion in page-issues/index.test.js,
where for "insertBannersOrNotice()" it was asserting that the HTML
contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character
indicates the message is not found (i.e. an error).
The test had to be written this way in order to pass, because
the skins.minerva.scripts module was not actually loaded, and thus
its templates and messages are not present either. This lack was
filled in by index.js for mw.templates, but not mw.messages.
By adopting private require(), these workarounds can all be removed.
== Motivation ==
In change I3a4024ccf90e505581, I'm working on improving the testrunner
config to enforce uselang=qqx on all tests. This is passing except
for GrowthExperiments and Minerva, both of which have the above
workarounds in place that caused a message to be undefined, and then
kept in the assertion expectation. When using uselang=qqx, values are
returned as (key) instead of ⧼key⧽, which exposes these message
existence errors.
By removing this workaround, the test will simply import the module
in the test as normal, thus the messages will exist, and thus it
will expect (key), and thus it will continue to pass even after
enforcing uselang=qqx.
Change-Id: Ib68f45d93a7054ed8bd35fc5644e2852f2f90248
Prevents dark-mode styles from affecting print media
by adding `@media screen` to dark-mode related styles.
Bug: T371331
Change-Id: Ieeca30d086d8b8705aba96441a576e3d8e127838
* eslint-config-wikimedia: 0.27.0 → 0.28.2
The following rules are failing and were disabled:
* tests/selenium:
* implicit-arrow-linebreak
* no-mixed-spaces-and-tabs
* grunt-banana-checker: 0.11.1 → 0.13.0
* stylelint-config-wikimedia: 0.16.1 → 0.17.2
The following rules no longer exist and were removed:
* stylistic/selector-list-comma-newline-after
* braces: 3.0.2 → 3.0.3
* https://github.com/advisories/GHSA-grv7-fg5c-xmjg
Change-Id: Ia94454c1da778f241085714e1601a0233d547570
The message box is changed from warning to
notice for the following messages:
- mobile-frontend-generic-login-new
- mobile-frontend-watchlist-purpose
- mobile-frontend-watchlist-signup-action
Bug: T366127
Depends-On: I358ee59a1a0b7a5bb94e66bca9a2437517f40141
Change-Id: Ifa4418cbecda38011a6ee4d09c03db3ded7a9eb9
It keeps fallback definitions which will work for most of the
cases in older browser as the transformations provided by
CSS Janus.
Bug: T371265
Change-Id: I0df37ca675533cf72c5636747cd40bbb4fb7497a
This is akin to I404710209d59241991716bb7180bcaabcafffcec which
was for the most of desktop skins but since Minerva doesn't have
any dependency to `elements` and `i18n-all-lists-margins` it
should have it's own implementation of the change.
Bug: T371082
Change-Id: I1b98ced874a1caf049e7e09dbb678105d4d9e4d4
Updates the styles for the author note shown at the bottom of the screen
on the diff page on narrow displays to use Codex design tokens so that
it will use dark colors when dark mode is enabled.
The color for the edit count is changed from #72777d (color-placeholder
/ color-disabled) to a darker color #54595d to use a more appropriate
token (color-subtle).
Bug: T370003
Change-Id: I3340e8794036a1c7cd8aa4cfebd2ecfb50d2cbcf
- Include date and bug ID in skipped test comments
- Helps track and identify unfixed tests
Bug: T280652
Change-Id: I2e78385e3ed5f0cb073677d4b4d0bcb74454c66f
